From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D24C369C2 for ; Sun, 20 Apr 2025 23:59:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 289116B0005; Sun, 20 Apr 2025 19:59:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 211C56B0006; Sun, 20 Apr 2025 19:59:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B28D6B0007; Sun, 20 Apr 2025 19:59:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DE6326B0005 for ; Sun, 20 Apr 2025 19:59:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B7AD9120BD0 for ; Sun, 20 Apr 2025 23:59:10 +0000 (UTC) X-FDA: 83356090860.30.5657EF3 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf21.hostedemail.com (Postfix) with ESMTP id D5D331C000A for ; Sun, 20 Apr 2025 23:59:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=iJy75O3Z; dmarc=none; spf=pass (imf21.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.182 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745193549; a=rsa-sha256; cv=none; b=m2aQ+FLBI3BB9G90dejN6zRQICtmRTbepmBenSwyj7ahUOoaE5K6tfiSiU/Ks1q1XA+6N2 +xhozOMdeLVpMrfW3+3WHhfWAl6/UJudQaFcrc34r9jieDDpfZZTvIRhBqXKx4ruQqrEIK OOqjwG3DfVp4FVUzoJ39Tcf0OIQSHok= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=iJy75O3Z; dmarc=none; spf=pass (imf21.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.182 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745193549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0mQesHxfKtuc73XSj9cqVrV4U7M1K9OzNneDiyDjZ40=; b=sHwkHUGR/MGBN4Vqz27oycDm8oSWYZvdKFMYTW07D6xQjasRhIA9iGC+n2BG7c31oUK8Wb 49wMSPBq5nd9OrsWsIhVqidvYVIhJnhKwpgRybw+IPBcjdPRlsaWLbIOgOm451e5LOScQm ELDU7egzuoXQSDZtkyup/T2DlpDG55I= Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7c5a88b34a6so330778785a.3 for ; Sun, 20 Apr 2025 16:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1745193548; x=1745798348; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0mQesHxfKtuc73XSj9cqVrV4U7M1K9OzNneDiyDjZ40=; b=iJy75O3Z8hFb0564huAGQ38j9VUAyjCpYIxYySmz43YltOIMbH60Cu223e7xVaQbS5 NyBgrnxtckYEUzdFzB6zAUrtViQioT4YgDdDCOkwwTD3Ua3NWyOtNdcGriGn/38kYtgs IKJMCInluznCrlQgDLzLoN9e3GNtHCwNMfK4Vmb9F3d6VvYQxbKLk9F+noonp8jk5NXS yIxrBW5VDEkSdB5ttoKg1pw8w2+xP84VgA+8Cvd5+HKJzJ1jVQdyO0gD4uvnEqbvRLWa mTzRlr0VvLlPXPB4N0LCWwRml89uEYdqJylO0a5VKB5QHrS78s982rgx7+LEw9uwhWIb egWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745193548; x=1745798348; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0mQesHxfKtuc73XSj9cqVrV4U7M1K9OzNneDiyDjZ40=; b=DjKeNtbSluPnup4C65wbj7OrUlWJJLY/Bftp2iwSKxzSifnJHIMaTSBmbVFkrqz5GN UNx1xd9nTziZqKwaDrI1uBpv8fLBRTNz+xKbZY8pmTCg17wMdNkX460aaXNdxRHLUv4C NaXBATxJlagE5zLvae1DJm3/z0+xPzGf7xTpaZNByRt2gYx7GGcjQFjSGBXjGs1h++Cg Zql2ukywmhPMvd65Q67ieYTQSbcXyN66Pq8C+mZNKVxX2pA251EsmYeuSIE3PYK4fdd0 4MYOjutdg5me0xM46gEjjjy2ldRjncz4byU8nPpSMNXZrTe6MoZUduqdgXovrA1h25ku oHsw== X-Gm-Message-State: AOJu0YzMFxjUc0kwMxNOjdeIImLDaeQHkwyUWxkN6IHFrztMm9C5IGu/ LhwjGUhHv9qkjnBjLFcppBL+U1nzo+mjQJS0B2LAUPVgMcgQA9Em5vN13ZFQm40sQN21fIn1v7F i X-Gm-Gg: ASbGnctRQ37OjJiupuCK1C50p0rWs2+hISIdzqVSQlz/SU3ifeKEc3T1XrbR1AQHZiG 52ZIyfSGh3grz52q+N1hg0Td0tkMqUW9nPiduswprPy8f4PXjognqKqr8W0IzB2jp0UQbNL+xQd mxKydkoQ+TYQmr6RtOqI2mQ7wOILw1/hdM2K7eENtDUH/dV7ayddDe4zV9Xmq/ZVBE6IpT8sNyj ktR5jy2o1/bTH4fxWEjVuQkInJQHqHYUgeBDspGD2Gu+NsQvGWvs7p8TkiQArP0eCUbrYz8q4rb bZGSmS+WtSk1UYhg3OzsQFN3Bp68ACI5qYG86y9drcDSbXmlgDJOo2jKZUmux4hZwFDYBtQT9Ph zAMJxprFoOwx/taAZs7qetqIYac1vOINtfw== X-Google-Smtp-Source: AGHT+IFhH1nWHcHOiEwOCjwti40tQB4MIiy3rrP4y16J3QXDbzb5k/8Z8Mai0D7KL4gpGcXFnHhTVw== X-Received: by 2002:a05:6214:2483:b0:6e6:65a6:79a4 with SMTP id 6a1803df08f44-6f2c468812dmr184751696d6.44.1745193547812; Sun, 20 Apr 2025 16:59:07 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f2c2b3274csm37135666d6.58.2025.04.20.16.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Apr 2025 16:59:07 -0700 (PDT) Date: Sun, 20 Apr 2025 19:59:04 -0400 From: Gregory Price To: Waiman Long Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com, akpm@linux-foundation.org Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim Message-ID: References: <20250419053824.1601470-1-gourry@gourry.net> <20250419053824.1601470-3-gourry@gourry.net> <532fe761-4907-4f4b-b98d-566453301399@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <532fe761-4907-4f4b-b98d-566453301399@redhat.com> X-Rspamd-Queue-Id: D5D331C000A X-Stat-Signature: rf17t68zha44ehwu1e58gz3mgz1wq8b1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745193548-610299 X-HE-Meta: U2FsdGVkX18GZI7xJ0iJvm1IbNvZAMDyxlH/6E6r44udagKhka3rl65Vr3jDlOGhjHRO+9bEqyt8E9lkEKyRwt5GlScNNRNUVGOHcCHavJaTmIzwO0EF2MlLoMGjnjII0ah7VYCPAEuLc4p/ZF9HgLOMzvJ/2pZwjqN9PRl9GxeORxgLSaGE9qZ9meb/Os1uZBKBZagEJP19XryR1ynGHAhG6g/unHvSqxcoqdW+affrRHm788N7vhPSYWTRfjFm/JdLkQ8+LYdVmAxnSg6I18d1AQ2lyoi7sWz4acKhNBriERbI4wTbyJJFBGXi/ckK/rtsWbwuTKq8e9UO/j4flbpJshDcIWGHAw2u4riYEaimpG2luUVLCwUB3zNxAxCHvIJW0GaigQIAOGQcV+N6LtKLpUyLjGRFcQ3RaFRF9yxWERZ7mAyMVHznKfSzcvBAdokAS5BxXPQYCvY/tE8EKZ5c5KuqktUSTAZCyZNtBz4obWKPipW5u1uQd2EPFmUdGI21V804Kh/JvEoa548IaRd8GWMjyH212XJ79N6u5u7vCC5bDGL4nmnCFKPF1mIMaDDbclXeKSz1+lQ0Nkz7VWIXTkOCGY6+wj5c0EuKR1md077g0N/134T9YC8EsK/lgkAXi14f9gVvchwbSfhSBijVoS9YI1uQmspv+KYNXNnvgHke86CRr3ncq5u+DQXSts4bpl7meghGkq/tLxgsD9I6meLH7j6Uf8dNNrXajcWi0NFHwBIcT7XiYYQcaqTs7E1uzyRm6vfJxHNi1ik1ZqdocvdweniPapjN8x0E44kRA0IWIE19bCNX4+hfIwXYi0y+tArapRmPEBb9Loi/GiPKdvPWq3bgziZ9FxLThHb46Z3K/cssKPeUuLL6q1atoPzXRncyBvIiFfejBrBw6mlKMWTV+5WcCt9vpvMKIePqXAqInPtm0UzDpXYPgap0dwxYzTCgFhYwCf1cTaI Tyx+l1El tPu/KIo3N0tJF11aI4LXxBVCfUIRb03zwNAYRb4n6qWhsUew+YgCLl6iMr59wEaDbFZ1lRQFNwsdLfeE5gV/4iDXmSzqM5h0nhcop2Uio0P2lprQn2VWMmg4KeuVH9BNrldia9ckKSohP27JWF2NOkK5JcrQ3FYUjegVmH2fPSdT9P9nXXt/Q57RQ8m9oR2DXD3btecgRll0JIezFuIsfq++cSxMrLxxY4oBoV2SUmmRGc08mZ23/2GKC98wsuExENwMBcmhQT4fnOnbaiZnxGEVgRDRokpF8PLjXS5HyfeSX6WstZQ6VYfra/3AsFbuhojGd5X/6VA1SQSlzHD+vvy1Su4p3/S9fkzupZtH1xf71I45/7tEjjZRxx0jE6JfqVqSW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 19, 2025 at 08:31:41PM -0400, Waiman Long wrote: > On 4/19/25 1:38 AM, Gregory Price wrote: > > diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h > > index 893a4c340d48..c64b4a174456 100644 > > --- a/include/linux/cpuset.h > > +++ b/include/linux/cpuset.h > > @@ -171,6 +171,7 @@ static inline void set_mems_allowed(nodemask_t nodemask) > > task_unlock(current); > > } > > +extern bool cpuset_node_allowed(struct cgroup *cgroup, int nid); > > #else /* !CONFIG_CPUSETS */ > > static inline bool cpusets_enabled(void) { return false; } > > @@ -282,6 +283,10 @@ static inline bool read_mems_allowed_retry(unsigned int seq) > > return false; > > } > > +static inline bool cpuset_node_allowed(struct cgroup *cgroup, int nid) > > +{ > > + return false; > > +} > > #endif /* !CONFIG_CPUSETS */ > > I suppose we should return true in the !CONFIG_CPUSETS case. > > Other than that, the patch looks good to me. > Woop, quite right, thanks. I'll v4 and hopefully get some -mm feedback ~Gregory