From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92EC0C369CA for ; Sat, 19 Apr 2025 17:21:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 290836B0093; Sat, 19 Apr 2025 13:21:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 215CA6B0095; Sat, 19 Apr 2025 13:21:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B9AC6B0096; Sat, 19 Apr 2025 13:21:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DF2126B0093 for ; Sat, 19 Apr 2025 13:21:48 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 39C66142A1C for ; Sat, 19 Apr 2025 17:21:49 +0000 (UTC) X-FDA: 83351460738.13.A06E127 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf25.hostedemail.com (Postfix) with ESMTP id 9F269A0002 for ; Sat, 19 Apr 2025 17:21:47 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FAzLxzIL; spf=pass (imf25.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745083307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z+JpPE1w8UlZDFqhO4Z/5uT+YRZBhUJgErZbXyP6cA0=; b=1DBRgV8aocMBEofb1krP0IfXxEoo7BM+hSQXfByyH69Y4fzel5y7EHvBdDCOt8S2voVDER Zt+T5knyaNJbkgQ2peFCHRz1z0xkZwCoq2cAY1avJ5bGKdzaeazaOaHbiwxA8/vPbzKiYc FkjcyTTHWKMm1QgSWa7+ltRqpFnS2pc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FAzLxzIL; spf=pass (imf25.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745083307; a=rsa-sha256; cv=none; b=6aOxF9jHB9UW3SA2gb9J/qxRjVkLEx/mJsIWrEI0ac/K8sM2lIvmPJ0t6i8+4BztCo7Zeh Au/HWV+hmCV4LOa/RMDJKbO8KOQHnNadoiviFvfde0UPNDkcEYwlr40sy4GVyqj2DT1CBA eDEQb090xmuCFXJRkYeuGKFmo9tS4Ls= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 489A261141; Sat, 19 Apr 2025 17:21:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8952BC4CEE7; Sat, 19 Apr 2025 17:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745083306; bh=gubOaCJu4/S9c8n4ojxqS9QUB7mqxeUWCfhq6ikB6Ag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FAzLxzIL0cN4CKUMGyC00dPYO8XLzx3KMT4LQBrZ1CcXJ5+AS0ek2N3/crkQGZvWO lKsWVFqbnEmRX1gvK4iaM4suPI4Uj7DNtnwiy0CSbm//UZ9TFLxRbfKgFVj0fgHvbd sevTIKYNz0wSBRlTXb6eJdt/qPthSAwqV5cb8A8u/akmTz+DLcYKWI1vUynkkxon65 s3fyhiEbL7MwgMF61rviujP7hUlYt9aNYgwDvTMCvWjHv0Tne9B0Gl3iWEzAxsflG1 LwldbvwEFEnY1V56swq/SfoKLxu5nU21BeMEyAjru4cvUhyDlIM4RTuI5qJlZQQX0O mag0OmhItlaWQ== Date: Sat, 19 Apr 2025 07:21:45 -1000 From: Tejun Heo To: Gregory Price Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, longman@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, mkoutny@suse.com, akpm@linux-foundation.org Subject: Re: [PATCH v3 0/2] vmscan: enforce mems_effective during demotion Message-ID: References: <20250419053824.1601470-1-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250419053824.1601470-1-gourry@gourry.net> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9F269A0002 X-Stat-Signature: wn4ae7uxxku9946x46pgtpxuthjs3smd X-HE-Tag: 1745083307-162582 X-HE-Meta: U2FsdGVkX1+vzRSj1FLQyJw/Ak7C7mEIcyNopovqjec0TLeviKg+erqf/Uy2ovCOpHKjaWGHe//xJlXJOiSHGL9iDVeo9PlKVr677se4ULmRUMRcz8D0GeyhIm1Jw1Lv5vOhC7YynS24Hst7pgdD2NoLWJN80NzM3RjR2vHucwJLtRqBIunUbuti4yzSxe+7isdR6BQ2+cM8nQeRPeb9gq3QuKqfKyu2VjFqP58KOA4oinyaPYdVmlEzibL4vDpAp/Ik8YZwg/TShcdndiKL4VHFSGwdqXs0an8E5fFLYrnk9jfYq6O2PR7mewPX6d+tff+f/bTSMZD/LBydBX2S/lHHnpboeerdNSY8JLKxKidMcm6NtTYVpqQ35ZSXM8ljCCrLjRYhm3e4KmP71VuVIeUA3RVdX3vLMgHUOAtkPCkFQnqM9gNdC6lwBLuoJPDvHc3PLzspFBdc66rL40+oCGXThPKj8Za4ftxyhDK6g/hbZ6avzbxtA5OomIC/UjXteUF9QWLDckjxUZzGK7se13AJanNZVFKsFt3IDhQnhTSynnySMt0wSLhcwPWF3QxA1VrCr6hxRyu1+b83oW76aZLAt9Qn6z4Ebg0wov4p/VunC+NNHnu7dPGImiFrdP5jFDVhmuc7EK5fZTsQyCMswHDxLdULguFciBnWr00xzYFciQlNsIIIPGnii7QFQVbJBH19FEvS7eDJwS94E4YerMNdLPwAFe16SDHnH21wu2frVJKNnalX/ryIWepsT9HzVxCjNYAnQ7/b0awAm+9h/Dgs5Ykz9eD/wo12f/PzBXmifVimqd3snkLMadcm5MLg2Op848NxbIKXPGTu0eQl2O8Tt8g6KJRoT2ggfmn0n7U0oQJsD7habUMsdM4aF78ZRJSfR85FEZ9+MU+cLwPSa0VCO7ducmsgyp1qmo+2uAgDP6ugwrECcu1BVByC2xrT5VuWo/3ghmzg2s5Ti6d meZ6MB4J OIyPk3SIn2HtVXJiF1Dfehn+Hnb2uqEwIr4GV6lt0PSdyOaWZ41m3/0qDblDhYOGnNMW1rp0sBX/ZTdPtarACCaOWY7cfWPGSdgMvHGztFIrE1y50OZa4Dd0cqOOG1WI98PkV8BzndpKeSiVQI5Ph1Uj78WXvLfHRXqZ2PUaPlDLQbNDMwJzaA2a6pXJS7yZGUqeq8+sb1eYfizHjNUAAKB5g6WJYmeTiuOqWPbqexTsO0vOSJrKFqqc9QVWZEZyocnn+hFo97cwfSSluecxq+kLv++7HosuBtq7M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 19, 2025 at 01:38:22AM -0400, Gregory Price wrote: > Change reclaim to respect cpuset.mems_effective during demotion when > possible. Presently, reclaim explicitly ignores cpuset.mems_effective > when demoting, which may cause the cpuset settings to violated. > > Implement cpuset_node_allowed() to check the cpuset.mems_effective > associated wih the mem_cgroup of the lruvec being scanned. > > This requires renaming the existing cpuset_node_allowed() to be > cpuset_current_now_allowed() - which is more descriptive anyway - to > implement the new cpuset_node_allowed() which takes a target cgroup. > > v3: > - remove cgroup indirection, call cpuset directly from memcontrol > - put mem_cgroup_node_allowed in memcontrol.c to reduce cpuset.h > include scope > - return true if mems_effective is empty, and don't walk the parents > as recommended by Waiman Long. > > Gregory Price (2): > cpuset: rename cpuset_node_allowed to cpuset_current_node_allowed > vmscan,cgroup: apply mems_effective to reclaim >From cgroup POV: Acked-by: Tejun Heo Given that the operative changes are mostly in mm, it'd probably be best to route through -mm, but please let me know if you wanna go through the cgroup tree. Thanks. -- tejun