From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B467C369BD for ; Sat, 19 Apr 2025 03:47:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 065C46B0005; Fri, 18 Apr 2025 23:47:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F095E6B0007; Fri, 18 Apr 2025 23:47:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D82E66B0008; Fri, 18 Apr 2025 23:47:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B75776B0005 for ; Fri, 18 Apr 2025 23:47:37 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4A97CC169E for ; Sat, 19 Apr 2025 03:47:38 +0000 (UTC) X-FDA: 83349408996.15.DB2B5FB Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf01.hostedemail.com (Postfix) with ESMTP id 6CCB940003 for ; Sat, 19 Apr 2025 03:47:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="ZK/A0Vky"; dmarc=none; spf=pass (imf01.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.175 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745034456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oGkr4hYBihWGh7JmZ8GOd7BMmZ2Z6d/IyfdB5vi5hx4=; b=WqMCRPUtl2RQmbr0DrW2dAzkKA6dfOnAupQH9vfmlbS0WctTpF3i1Y7dWeLDV+7oimauVw 7yNupBYfRiyg8pSQD0Mnw8KrOcYpL/Av8ddNQLyZrSkEksNXL56XVGd2jLpt7jjFGuqVMt tT7EhD7t6WVAVoE0f80E5Ziq9p/OrXI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="ZK/A0Vky"; dmarc=none; spf=pass (imf01.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.175 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745034456; a=rsa-sha256; cv=none; b=HIls7QTRgYyKsUZkgkIC8ZWtOlJ+2+tFj+vS1GUHDZVDDylCOC4S9bm+hZ0pXjdsc58Gvs DhPfvt9W90NH8w1QVnkyyVmS1Xce8bnGTeXJrYHofDHvw0pVIfnh7frhQCn059xd3QDFsW ipf2Q9SsPyfgGKgVekV+xctnBjAAwLQ= Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7c07cd527e4so230596385a.3 for ; Fri, 18 Apr 2025 20:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1745034455; x=1745639255; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oGkr4hYBihWGh7JmZ8GOd7BMmZ2Z6d/IyfdB5vi5hx4=; b=ZK/A0VkympCx8xcI4p5ijvSiJxEe87Hy4r+7Jr6ZoqR4GuYZPlKDz4QmuJfYkvlpwr yBZNQsmFc2lb2sh0FyJjON4TBAn+TwTe3CT+nqj8+c0hOv2slsFpucRWDbvqHj9MEj7c DyukG1DX0SeOCvmURmpckZO8PYtgrH06Ig0Krw3eLJNIsQ1CS4fuOFwpnJ2Pbydw2Som f1RS76r6+SuNmBbj2XFnoGqwkj2JqmNvPqKLYXxisyQswIEQaUdN3+pHnI4DGYVylqz8 NebMNXRvPHBx86kYPA5VU7/Vp31O/RCKwYF8iSj0CYP19xUU83GX1IfhzJVUG0YjavC5 A9aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745034455; x=1745639255; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oGkr4hYBihWGh7JmZ8GOd7BMmZ2Z6d/IyfdB5vi5hx4=; b=wR11Y8SOyI5aZL864qSa4xGNoZ1HgHEj8JorgQdD5Kqm0uAVsoSucoH39hu71hAS2K 7o0fyogSBZC67pcK/OakS9E+s0tZ7pN56wWM8y277FresmKm2E+eV37t/3weK+h6CuEM 478IQK6A+4D3cdAOh4f7/mq4n9CbuyuFA4eHyUpOg+071GyanNWCe0MbQpM99dzGKjiT zrAE5saiuGJks5vbqoR9dx6ETFUgMDz072dkeevclEGrnGqRqBaiOGUhbEOFsP2VxRoF 6QlESllW8LoSa0OmmdH9RkfNnmLRomW4rdUMv9F2SWC59TsB09E2N+SUTlySZaeloWFb G9zQ== X-Forwarded-Encrypted: i=1; AJvYcCVZPfZvMjFe9JQPFAobwA1iEK5R2pkqSMcWR4Wg20ryq6HYMFWztkscqUy9Z2N5G3n/0Om71JuOsg==@kvack.org X-Gm-Message-State: AOJu0Yy0gX4Li/VYEzbJzXfPP1cfVd2gYxJPS98BL/PTTxz0KO/SdcSF v5/IADjTXfbDFFqmHBlS0oBM5L9u838R5DfqA+eCl/hOwpNShU9j1ZKx+3pkVEA= X-Gm-Gg: ASbGncsAsC6o7IWus/1fEcueaaVEJJqvsCUOc+j14TNOYqTN3A5JjfQfAh2BrF1CPRH kDFqGTQ7F7cWQ2oJoBMoXR4gJonf35lQNo/FLnmOk9p7gb3ynw9J+yzeyYdaD45iHkbtwmiH6EQ 3au4O040FEGvWVUKedv5kOISOTZnXmmHS6OC7mF4l86dSbSOisj2y+dzGzNH9UMV8DHOHltkXDG MKCO0L+LheCd5od0FWi4vqPPAKid8krdvBHU0NUoX1moWPfTuG4kOFK/R/ngnEr9NO8gD4Vy+Up a4vdG3kl++oC3+ji6jxL+ZsAbaa1VvtYlRPdG3a9n8PkzzOodr8qWspDOL3U62s3qkR3dHg7RDd Y8HBstOZyMgMR6a+UikPO4Mg= X-Google-Smtp-Source: AGHT+IHLpDeJmAWC8vn48omh/WZzD3TF09eoVh++JIk/Dh5S1v8tWk78RgXlZgP26pjlrMn9VABJOg== X-Received: by 2002:a05:620a:4413:b0:7c0:be39:1a34 with SMTP id af79cd13be357-7c928038eb8mr806824685a.43.1745034455556; Fri, 18 Apr 2025 20:47:35 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c925a6ee74sm177409985a.1.2025.04.18.20.47.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 20:47:32 -0700 (PDT) Date: Fri, 18 Apr 2025 23:47:30 -0400 From: Gregory Price To: Waiman Long Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, tj@kernel.org, hannes@cmpxchg.org, mkoutny@suse.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org Subject: Re: [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim Message-ID: References: <20250418031352.1277966-1-gourry@gourry.net> <20250418031352.1277966-2-gourry@gourry.net> <162f1ae4-2adf-4133-8de4-20f240e5469e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162f1ae4-2adf-4133-8de4-20f240e5469e@redhat.com> X-Stat-Signature: cegoag63ukno8nmcze4gmk5edz3re5ab X-Rspamd-Queue-Id: 6CCB940003 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745034456-885314 X-HE-Meta: U2FsdGVkX19txcolL9pitzmicTrkkzv6ING/Th6S3F0OAjeR5tphyixEpn7hY33CidT8Ke2bUynN2yWQXu/ZNEdfa1QpMcG8hItTTVWtEE3q9yr+GqepxrFnO9kgVXy7/5eTeqbQkmbFE0NbNEwhRnWy4hVqIuj/s35IZvGXf+nnw8GoZCvK7HgInPVhbAhb6ShUGXZQ56UhMuDF+W+bIycmU/iPrUmmAa5P4MbZsDFheJ2lhBeE/6bAe/5PP5wdbgdvpfB7zqTV6sVhikiVdGzzzqyBZC5s677IKr1qvrf0wDXsnOudltXRC+r9Z7GsjOQgUeBaErEb8hhMAi/eM7mLHZaiLcjjBbtl4nzgXiuBhvO2xJViGiH1NdhfSymSyrKorkubqsvPJx5K1nHKDqn+DLeFoXAaTqIG1JVu3gi5B24YNOxN+QCba87pRHbOqmJNWLGC4dvlYKPVd4Axqsmo3T8sc+F0Gphv8sNDRM78+pf5WMeIKEo8RPefp3hK+Z+n0K76elRnc1PT6maDnHWtQzOosy4seOhj1uONzVicvGbD2c2RuWDMbHVup6trWaOSXccPbW0V6Zn1KriKiTkSM6lp7aPziCGKB9U11vEUteAFVwfukPicaHDPrvgtzkj+2RN/4nxmDfWcBe/mP9q5Av6IBPWvo8p6BHBQOe4wJnDNjs0n2P6H0iNBI5W/N8b1Ioc/gZcZJSpQZQoQaGXk2u7ePT60zIDS/9dPkW7G+SDiaiofZKN139EF4Oy9/+oSLaaKqRDq65ezA+FCiu6xGjZS9a3MwqK0PUHdKyyDAOGbkFLomoYKrfK10O/OUSAHJE2egZ5cYMYc3z+vJ3TaZ8Yx7PTkp0JWVtR2lHAqauOOqotHr7hIyX9f+z2/YznJ7fsoU6WiqEiBiq8el3o+I+H5nhZKZJtIzqd3b60mm3ul4YD4zGET3YKKoAy372+TPWMybJmj4MnkTlI k1/+aEYF mGYmNJzW49z9s9s4DIii+5mNQH0qJFCbOohJwkoip5gg/jPs+jp8w9AxeoI3uCI7pBu0CTJjXvyDky6UaeO+NwqtUJC15leWrcdaQQaZdcSxGIGgjwO6uO0NvnoWfNvZrtjBQVlZCbFwEAq590FDlB41dGJJuodlAsrX9ApCds2EueTgufn3OpTfg289sAL0T731xYCJujiAQqvr47sz6dgSnH/Z09Fx/AyBAcVzWpL0erWn7QYp4HttcU39RPQLCzSlHJDKZcs3G6k/sLnvgWnhQDnP1kzcMaCTIHRQhrrL6k3w+AmnyxdFyihhBvTwRXlN/LzcOrNMsHq/xsG3sPrSmdvgPizooIrKRRrx/9vnIAdNcewWlQOGcyIMxg48c6Fk6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 18, 2025 at 10:06:40PM -0400, Waiman Long wrote: > > +bool cpuset_node_allowed(struct cgroup *cgroup, int nid) > > +{ > > + struct cgroup_subsys_state *css; > > + unsigned long flags; > > + struct cpuset *cs; > > + bool allowed; > > + > > + css = cgroup_get_e_css(cgroup, &cpuset_cgrp_subsys); > > + if (!css) > > + return true; > > + > > + cs = container_of(css, struct cpuset, css); > > + spin_lock_irqsave(&callback_lock, flags); > > + /* At least one parent must have a valid node list */ > > + while (nodes_empty(cs->effective_mems)) > > + cs = parent_cs(cs); > > For cgroup v2, effective_mems should always be set and walking up the tree > isn't necessary. For v1, it can be empty, but memory cgroup and cpuset are > unlikely in the same hierarchy. > Hm, do i need different paths here for v1 vs v2 then? Or is it sufficient to simply return true if effective_mems is empty (which implies v1)? Thanks, ~Gregory