From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 089A0C369AB for ; Sat, 19 Apr 2025 03:41:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D01E36B0005; Fri, 18 Apr 2025 23:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB0B06B0007; Fri, 18 Apr 2025 23:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B77AF6B0008; Fri, 18 Apr 2025 23:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9AB316B0005 for ; Fri, 18 Apr 2025 23:41:08 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5A8D5C03DB for ; Sat, 19 Apr 2025 03:41:08 +0000 (UTC) X-FDA: 83349392616.24.DFF702F Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf26.hostedemail.com (Postfix) with ESMTP id 785EF140003 for ; Sat, 19 Apr 2025 03:41:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=APS+mPhw; dmarc=none; spf=pass (imf26.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.176 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745034066; a=rsa-sha256; cv=none; b=QrGPwN7Ic4u5U7Ma5VBxcWNyx6a+wKtWOxvgKiUjREjQN6Y9RRCbo7+rCyLA2zZqyZGfOu 5XvT4sbg6mqnGOpY4cbsSASzqW+5fFi2oddTyiPnk/RDkSaSDPQ2KRhyzNsgnhH8H9gJMp tUe4AIdh1Aypi/xiAg1YcPOKqNd8M+s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745034066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vf/SdZzWZ/97U55NJCW7xj0E3zqMD/eAiVLqyHOwDFs=; b=8LRx3zXw4eWA4osV5SJ5jlvQyz/4j9RJufDvPU7TSZMONnSCysfJA5W2MyP5evmObvH8Cu rZRvw6yYxz9M+GLIG3uLLXyoNu3ASOkL6nUk3OgiXn/WWOvbtziD6clpeyfQUlGimpiQUq 4c5nx7tvZTplEqYbD1TKrnUdUapgCNY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=APS+mPhw; dmarc=none; spf=pass (imf26.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.176 as permitted sender) smtp.mailfrom=gourry@gourry.net Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7c560c55bc1so241291985a.1 for ; Fri, 18 Apr 2025 20:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1745034065; x=1745638865; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vf/SdZzWZ/97U55NJCW7xj0E3zqMD/eAiVLqyHOwDFs=; b=APS+mPhwirqrXG6QwSC3wOH8DDJXqBMw5oifNMkrwcrycwHKHKXCL3X4gmcxwFDTZC 1bVuYY1hNKjqGCk6y8S7/oAzCeBg4OO731Okree8GBsei+sbbl3s0PPQp9ItOXHUbfAG YS57hyasitA2FPxv1axl49AfXOa1YiCko65xUFNCHNvX5wPYjTuAQsyQigb0gI+OAC2F 5tLqkJ1d3rfqNt6Nlh6n8JM5qlBMs2n83leY2Pp5CuLXDZ79wUeNIlmqCVxcnnU9pq8W iIVOjl8AGVYFtP7eIltMZS8jQ9dExUDs2sksMS2nNJvJehtkcTS5yjbMOrygSShcw2p0 Rgew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745034065; x=1745638865; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vf/SdZzWZ/97U55NJCW7xj0E3zqMD/eAiVLqyHOwDFs=; b=xMECrI6WM5aoGdSuipRlJuJd6vJ29ywUT940jx2tuWYKnuVbBSuNQEMe1l14H47vdD vyvqjYWCJRMDXEIjJSYikNjikdpo63hD9tQymgtmWAUCT630/EB8nKNQKHI+bFIsmkW0 kCHfu9MCjTmONKcO9DnTlxhYySr9a+YfZwSy3x8sMOrGLjsCSCRrfiZwy4uu4EJpD4A/ pVXVYmuAMvgmjqXrQPAm1aPcmkUXuYGzHZ2lF6s8uuTKol+oFpKk9TksbU09WI5df+AY KIebo5K9zdJrGL72pgvEl+bSDr/doYqngzdPextD0Ts6ufj4G7LXYF0cvlc/uZ8yj4HE tMqw== X-Forwarded-Encrypted: i=1; AJvYcCWpatTyXFVciPt/jMoEfZgP5hFDIXp9FJojoJS7G4dd3I7VGL8R0e3QZ0XiJqWYF+qZNLa9CO+oeQ==@kvack.org X-Gm-Message-State: AOJu0Yy5VduzjCQ+g00SGZ1cEQlBCOii37AjNG7idGaOgxv192CEDFpv nL2YCL2GBxFo6P9Se/8ny02J7uJC90W89EaFFIuKQRoLuD+IzJZAAOKTcrg7gsMlcGgKwAsRyso e X-Gm-Gg: ASbGncsJg5rnFkYVbiv/WZA04wlIJMAmCT7X68ehWaTFNxj0nFeFInooBqrJ3DqGq4t M/VcBmQH3uNvpgvmx4HHD8ItcpnJY/AnSB6q+K0+cnJRRQn+Cxuk3LMszQDNyMXi3JYGv+BqSr5 Hs5c5toi6d1VSVczZgqEcswGn23JBAAhagEJvo885AVmfdMJ9m6+bA4WDBUpaPHGtKIoOgM2p/w hXBGPg3OVM4d7X18+HX5kkHZBtyvUbr6RTokbI2MfsQbNCtH7NVlguyMn9QzvjdGaWFDOzDdPDN hMr3u6kZ57ikaDdb8e/MFuifHxwCLnBpUOOzFgyTn4/oHhc0Y6Y+VJ+dHmk/SvnPrKPlPJrS8OW wrlrNrhjYNFYc5FAm2mfFW8Y= X-Google-Smtp-Source: AGHT+IHBuLN56lYhOyNk3hQZI/IKMdqmk7y+jZIExTVI9cAFyXEhsXltOxcEYmpfFoMh81jIo2Y7oQ== X-Received: by 2002:a05:620a:260e:b0:7c5:94b2:99da with SMTP id af79cd13be357-7c927fb51f8mr786359885a.28.1745034065642; Fri, 18 Apr 2025 20:41:05 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c9280de4adsm152367485a.114.2025.04.18.20.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 20:41:05 -0700 (PDT) Date: Fri, 18 Apr 2025 23:41:03 -0400 From: Gregory Price To: Tejun Heo Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mkoutny@suse.com, longman@redhat.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org Subject: Re: [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim Message-ID: References: <20250418031352.1277966-1-gourry@gourry.net> <20250418031352.1277966-2-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 785EF140003 X-Stat-Signature: 9mbpn8nj3f3sxq9npqpctwf5wm8nf7h5 X-Rspam-User: X-HE-Tag: 1745034066-515765 X-HE-Meta: U2FsdGVkX1+L0cFrbTOpghVIw65XLt5VJTjYFqJ6LE2y0eI5ewm+6ctVNdiJT5uG+xZOxNjfCYDuXm9AOOo9W15G+bbK9vg/KGXdqzKScHtNJXeivQ3tUX66r+OOI9PgqfioYDvOohZWYCVW1Y+8NaRcvOeaAMmDpLfhP6zeFor36eCw5ITsMgEvBLIZVZ2/T/zjk8V5dtv5iDGOtaaEAyv/0uC74IhAkXyWlVErTCB4xkBbVPsp2zK2v1v0jxzXhe93P48dhQNFMnZBt13A26saeHBrbW/tP2DnM19Z2BEyRmT+Btyfx8YKDr0pQghVf8LsQ2sz3nLXkzoq6EgYEHz7CDSy1YFSoj4tMVwIylsXwep64LWtrqbk/5cbqWl6pI1Lg3sbWg8pmXH0AotCoXXYNb3Sroz2a1yXz+VA/IfJnaI1Cr71JEL9VUdr7dne5dajBt+S4MqZtVL5lin6sXcxKaQuOZrXGvMZec8F7WT486dXyYMR2JsHOAfbKP0BxOpnf7xuScYRqEJl8f9u4e1aXeuLXptvoYZvUOlqT4xKjtIoIVIne9aIsAXoeFjO4K5r00JpvWgU4PNEuCMoOD8wzobll/MlmeEgnMkRdri6x7IuhytGlQlhO53GhLL9g+rKGqKjI7446b0EeOfLEWbqRbTMYtB5HN/Qoblld4NeSohYFxGAP68C8uTw6s3TEpC0E+yBWxV4ohOjgDbCqyPhsTEHK0NtU/bIShJrBP/sQZeOeGcsJW6BlcBePH4F1VOrEChTXBe26eR0UD1t+lfiIrci3KcO8cLMwknP/UElAFU44XZkEAb1QRqF6KlBlGtjz8I5N5PyiVnxEQ2f6j8DupUeIY981EsCs4GzFbahmxFkt3ESu1FVsyjBUAEK/ITP05xQS99e7OILfQgJsznLSYvl5ZxTSyf0GmQudZxaBWN4Z9EkDDGnBsbYZV/LUnRJ+ba9QEPUEFmcJaB XD1npRXt WokhvcVvPejPFRa1fq0wD1o4w9lgO764+oNCtagTQZqsfRmUofsOjXW/uV+j5GPf/uyCLc7NlYg+4hLSiqMQfvzm6yv/VABjywoBWvft0Dkb7uAhW+4Z9b2M7jZuR4FeK4Q6ffUkay509PGG+jsKIv92/zjnBv9NiakIdmzaPL3dxo3tzFmMfcTWypnQ2B/UJ3uZM5Tysi3aHpwX40OGhTnbCKsu2kjpwh11Ze7+HSKVxEeBzfPGj4nWtWqS6jPipTzB5tv7rvabCDhYIk1VeHFE0d8zRgDWOl6cpNQ20paBYGmBVBBbBrknNEJ2YCDv1ZewoamQiGMPR0H2xyl3b5SRgLpVU6lh0oAIW3Yda9ED/ppHHpk1GaM57TA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 18, 2025 at 11:27:55PM -0400, Gregory Price wrote: > On Fri, Apr 18, 2025 at 05:06:20PM -1000, Tejun Heo wrote: > > Hello, > > > > On Thu, Apr 17, 2025 at 11:13:52PM -0400, Gregory Price wrote: > > ... > > > +static inline bool mem_cgroup_node_allowed(struct mem_cgroup *memcg, int nid) > > > +{ > > > + return memcg ? cgroup_node_allowed(memcg->css.cgroup, nid) : true; > > > +} > > > + > > ... > > > +bool cgroup_node_allowed(struct cgroup *cgroup, int nid) > > > +{ > > > + return cpuset_node_allowed(cgroup, nid); > > > +} > > ... > > > +bool cpuset_node_allowed(struct cgroup *cgroup, int nid) > > > +{ > > > > What does the indirection through cgroup_node_allowed() add? Why not just > > call cpuset directly? > > > > This is an artifact of me trying to figure out how to get this to build > with allconfig (matrix of CPUSET and MEM_CGROUP). > ... snip ... Looking back through the include graph again The reason was lack of inclusion of cpuset.h in memcontrol.c while chasing the allconfig solution. I was trying to following the current includes rather than making the graph more complex - it wasn't clear to me whether going directly to cpuset.h from memcontrol.c made sense - since memcontrol can be built without cpuset. The graph here is a head scratcher. I'll still try a build with cpuset.h included in memcontrol.c. ~Gregory