From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B31DC369AB for ; Sat, 19 Apr 2025 03:28:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BDE46B0005; Fri, 18 Apr 2025 23:28:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86A866B0007; Fri, 18 Apr 2025 23:28:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 731DB6B0008; Fri, 18 Apr 2025 23:28:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 570636B0005 for ; Fri, 18 Apr 2025 23:28:00 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B13FE5FC89 for ; Sat, 19 Apr 2025 03:28:00 +0000 (UTC) X-FDA: 83349359520.03.F5299F0 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf06.hostedemail.com (Postfix) with ESMTP id BE854180007 for ; Sat, 19 Apr 2025 03:27:58 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="lj9ep/aC"; spf=pass (imf06.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745033278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yeXMXSSzOYM79gde1X46jJHnJZxA7c7jB0TbcbsMRB4=; b=sEFGVcx0yGR4h3jooPbokdTDplmqbXCGTikmxnpquv3IR2kZZ4Quzs7Er1Xin19jkuBJ1D JDCZfyYuCe159ksDeBNO1t4G3Qi267HMWKZXdI3SKlcMmkt7HABJMIFZZJYDe203UERjWT VsuCdhIcV1QHUdRjkhu7jsmvookNP0U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="lj9ep/aC"; spf=pass (imf06.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745033278; a=rsa-sha256; cv=none; b=XOWMRW4nT6pqUZnxtQV4uGSj8C7hxiR1uPy6ZrDFX5AHNc+0kfDiI3DO85fxmosGPgGkcx CD/CyNG0BZTiPxrM53voJyJt+c6gXPVt1oPcb99rKO9cxnYuyLuHguXRXNpM/BWa1NytGp Ei+csXCC9UvoOQ3GHtjkP5vr/Ra4DlU= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7c5675dec99so217446385a.0 for ; Fri, 18 Apr 2025 20:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1745033278; x=1745638078; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yeXMXSSzOYM79gde1X46jJHnJZxA7c7jB0TbcbsMRB4=; b=lj9ep/aCOXrzu67cU7bZFYcQMxHEqzsLyNtpuf6rYWJd5grxjgCTpBjdvRovlSUdcX 2j6VuMP+KzEngpygl5ZSs7I5XiMY31ZguRfv94z4Hc5T9Qd5Uisz3pFxZ816uiGUTrfs X+0lwFnQw3XGtiSW/No09K28bJ0ZJXwg+zeRKyQx9EksQwOQHvJGYfEqTboViIWxY6Vg 9+HkiWJgGMNkp8tH6pAohv5FMjESwyvilEs1Y0QWYOfWr3ssYkB8IGwxP2DwPn8HAEjH wQtrpFweMqdUuq01CKJ+/XUHx4oQeNlHI3oI3DC0HR+M7tHg4/y1UJD0OeKgd8EqeSOG I5dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745033278; x=1745638078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yeXMXSSzOYM79gde1X46jJHnJZxA7c7jB0TbcbsMRB4=; b=NXOhWnCup8bA1R9gnAhsEllBgxu+Uloz25xw7uKCoXV1rcFQtJSmCe2QTb0HFQ5WRA xtBplp5FgsUVnNlz8UYem6uTkKtGqQ8O00cQRKLfJ14wFptozoaXBqgeeIwHCxKSowQ8 mV+AzHmFaVS0bmjj5IGlIqk1o4+8I+8lGfa1b/amSbV/UXHaDUvJEyI8SOoHxPiTyjhS vnCQFXv/tY9ChhtSX6H2a4abKdyL0to7SKITmOAqArlNeDt8K0aKNEQ8zW2DIUOAqpOa BXxLuoZkMVZwRkOxj1Crq9edOSWpHQuJC2utyCmDGxAZwQIAS3pjnVp5MnTcNmB54+W2 YVsg== X-Forwarded-Encrypted: i=1; AJvYcCUr2tNQUIRgynwq5WiWJX77UVURqHXsNq1+n2VxpLmxMLZO7LEZ4A/RjFv4iIzRTGe186Bccdc4fg==@kvack.org X-Gm-Message-State: AOJu0YyDjpiGY00NJvtmUPCYo9vH6z0I4M4yPoqh6xpvQW8b0hQq9K9V E67TqmTeYrLlZ6+JqzN+ZUHjmaKKTpW+FvDBkEX9DG1DcfuLS3X3rRRszzSDuZE= X-Gm-Gg: ASbGncsjg6JIyCYivoPl4CMLnGtADOgwPYiV5EQTJmgbyLlkTI7mSwt6pN8TM6bB15a 1kExxSwIPcRnYOFAZttGekOUG0/WikTqD8q49hdWyhqnZnAlrvsErgVaBOyx4yT9k/yg/6fGYJm TlR49vbGcBuKqRmHQEbt1G2h2wYJ5eop9AEOXUVpJju25CQ4Umm7uPaQfs060YCJq574QoGcboz 4O9q01BwP/hUfs6y2UYVhJivLFdlV6P5i91OnyPxuHF2Luz2lhGlpwf2U6Haec+np/amTIdhNYB 2g+RjEKqPRs4LTVicqdYwhFnZd/bCNUfPmdOV+x6wzsQkLnf/ervjp8yxmDOCq+z3b8a34WruQO GSNWyoozlh3vehx18Z7PK0hw= X-Google-Smtp-Source: AGHT+IFI0fqsWNRil4RH53+meP9hxUVCCEQa8S74bFAShz56Lmc8QxXWWOZOtWwNV00SncAzpszxHg== X-Received: by 2002:a05:620a:199e:b0:7c5:3ca5:58fb with SMTP id af79cd13be357-7c927f6fedfmr857572785a.4.1745033277742; Fri, 18 Apr 2025 20:27:57 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c925a8f6d0sm174315185a.40.2025.04.18.20.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 20:27:57 -0700 (PDT) Date: Fri, 18 Apr 2025 23:27:55 -0400 From: Gregory Price To: Tejun Heo Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mkoutny@suse.com, longman@redhat.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org Subject: Re: [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim Message-ID: References: <20250418031352.1277966-1-gourry@gourry.net> <20250418031352.1277966-2-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: ru9en9mt6xc6ssfpkfgrms6tsqzojzea X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BE854180007 X-Rspam-User: X-HE-Tag: 1745033278-2818 X-HE-Meta: U2FsdGVkX1/JiDY5UDuI6itjx4uhWR9PAci7y5xVkSlu20rQ39q/5VpDxsXZaNo6b+u19g1Y5yP0kiUiMLFCYVfpuvwvdtx1zSQ/E/Eot3ttoCrq3IFHpPrsp85k/2f/2asFJo35XXP5B3ALeBCj8OIi7EhzlJOJw+qbAAtxq6dyE/vyI717w8rUq5ntJJsuAJn1UNQYzZbC4SbA5pZ9CJIkKyaNfpf4uYBV/5umT9iJNubEnHiTigzNT1vSN/lLk1nret82hixu4JYaYFGXvLjPMoYb039MABwAfKmWpw4ak+CbIwCFopWjCTPfvOYsIescmGCZjMTmuXMyGXAMHIlbBiBQrxTe7lQVSjXWXJHNmdqOsOIal2fI+aC2Clk3U8wsIOzcPYLmwsdN2nINsVWV3HvI+1bYElwAW72AwhjSe7SD45sNlCQBvIGBYd9jXRH3Q6rAH+PEpzfIZ+FZcxepBJhZMWkxxhXkQn/U0hgbRCoNOMUL37SHjbf0cXEf/j2W/GkHhm2oPKWtIKCep+JcAObAA6as2Lk3sC3vWmjxQ8Ym7sBC9UsjcLJONqPxo4DFxt1c02JlQzMrK98uEdNQRu7o5t3Evy72LRS0IvzQ/l9v63tER/6czkfJQ9NZdzPhGSLQuMA/o4WjNaTC2TITWKK2OywTQKHLdyW2ZIypUkQgG+rzTIk4AyHpNmYiJa2OgXvIusUR5aX2Yfvetf4NF+qrlAmujo3wjAgv/knJM/riMCZ7kuprlP0aEt9SUFcXJ+hbXXazuCfAErGF3GcVntuuNgW4BHkZ48QoixK3kRDTCdIAg4R3g/Wmjy680qGSKdj/feedcr4cpyV3L4VkVJ8roF4CUA2HLVhby/fj/rt7YUhnTH9rzSYCNiA9kzy/77x2U5onVGryEZbS8TBeIyUzIhgFkw0EMSFcCVZ8ObMZfu1uUej5mXmvV3BKA7MIKTQ/NaEWI280icl qzZ5VjJT koaM0q/RKk3tQpiFakGTDPProgxJlgHbRdn40kebILd46DUZ6TrpeL5f+6UC4aOvq2zIY+f+/yd6kOKHokftGPvQB3EAHDgO6mBe52odY4SZXKpOZHTzFi160xvRkqeKYz18aVF9a3B/nZsK0o/IrT6zupUrbJIFrEbZ+U6Ervyqik/kwFIeQoocTZzS3BUWK6x2ylBRtxYaFEbrO0+CfWodeFNljUmkBF3Y5ov66dDGm6S2HV+le/LdPubyVUyBK8M4ECv/KHRvSWbUnBzCUMuBAHSu42xr1ET/qMCI/GaRrQQbZRqOF+UY3LaLfadfpVySU8TaJ1OAfFRc8rHpLOCHj3ukboo3RxRoJYP/fhZJcCsXg/IPEm1Pm8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 18, 2025 at 05:06:20PM -1000, Tejun Heo wrote: > Hello, > > On Thu, Apr 17, 2025 at 11:13:52PM -0400, Gregory Price wrote: > ... > > +static inline bool mem_cgroup_node_allowed(struct mem_cgroup *memcg, int nid) > > +{ > > + return memcg ? cgroup_node_allowed(memcg->css.cgroup, nid) : true; > > +} > > + > ... > > +bool cgroup_node_allowed(struct cgroup *cgroup, int nid) > > +{ > > + return cpuset_node_allowed(cgroup, nid); > > +} > ... > > +bool cpuset_node_allowed(struct cgroup *cgroup, int nid) > > +{ > > What does the indirection through cgroup_node_allowed() add? Why not just > call cpuset directly? > This is an artifact of me trying to figure out how to get this to build with allconfig (matrix of CPUSET and MEM_CGROUP). I think you're right, I can probably drop it. I was trying to write : bool cpuset_node_allowed(struct cpuset *cs, int nid); and just couldn't do it, so eventually landed on passing the cgroup into the cpuset function, which means I think I can drop the indirection now. Will push it and see if allconfig builds. Thanks ~Gregory