From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E97C369AB for ; Sat, 19 Apr 2025 03:06:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0C5F6B0005; Fri, 18 Apr 2025 23:06:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 994F06B0007; Fri, 18 Apr 2025 23:06:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85E3A6B0008; Fri, 18 Apr 2025 23:06:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6B25E6B0005 for ; Fri, 18 Apr 2025 23:06:25 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0779D16151C for ; Sat, 19 Apr 2025 03:06:25 +0000 (UTC) X-FDA: 83349305130.19.A872649 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf27.hostedemail.com (Postfix) with ESMTP id 550C640007 for ; Sat, 19 Apr 2025 03:06:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="IO/uXds7"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of tj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745031983; a=rsa-sha256; cv=none; b=todom98x7rx0N2Db9sZmWKRFBDw8Cg1owVNkS80k6hEG9DXyztRQlYnsJFwjpebLaXfesO 3oNmCzba9VnPYqttBiPGss1WYRilHjopawr4FXyN26UO/KLKmIEcKKudWT9XFMuFKsnqWF rdJbwwIWrpBLJIlhQzwhWpJz60B4oxQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="IO/uXds7"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of tj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745031983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i/jkDc2rgRNgf1iTxCCFXduPlksHrXwwzUTBMysH/I8=; b=oL2u8QvhHAdUbgWK9cbDg6dEC3wbwf4th4JAvn8brQjeeT7Sj22cVQvYUnx1EHhNn2EETO AWLXjvN8oSS2B7jImhp0Mo+HmpeAbApbgWP4zGFNuYs7LQ2KGnZyvm9CI02nXG6/uXX/aB KjhBnlW6bzDvAJo1hVRe/WPI7Gt8JKc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 9A62744615; Sat, 19 Apr 2025 03:06:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98197C4CEE2; Sat, 19 Apr 2025 03:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745031981; bh=M1+LRyvWE1k+yZk6eS0NB7H7ludbBSzUMV6n2DD1EOE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IO/uXds7p/Cj04S1GA3k/BYjFn4fdOOOQhCfDdH1QbQPUrexRBRRi+SV+wkHwRfHL GNGG6sJxqyM0LM9YVG8k+pepr0vrL8TRRlfM8lPLwhJ7bfTBAIBl0x348nGeSt/hrZ ldvUMSHi/kLxW8dSLpsn5/foWY8+svb81i3fE5nkdtwYmBemrH1bsvmjwPpP4Y/rhW lPwEYobl73jQgawkbMESh3ppiVFHtwcgDtaAbb0+x50s6Q0f9pIAUdWNK8wPNLy4Lv fLEO9a1R6xmNCUYoHloxM5PXoI3GC1ZgiyKU04J+bWLK1Jbq/Ud9fqWha1ttPPOQvA 4w4Jmz+U4eNTA== Date: Fri, 18 Apr 2025 17:06:20 -1000 From: Tejun Heo To: Gregory Price Cc: cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mkoutny@suse.com, longman@redhat.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org Subject: Re: [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim Message-ID: References: <20250418031352.1277966-1-gourry@gourry.net> <20250418031352.1277966-2-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250418031352.1277966-2-gourry@gourry.net> X-Rspamd-Queue-Id: 550C640007 X-Stat-Signature: ru6sogthamm11f9zctmgbr9goz37iwiz X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745031983-765493 X-HE-Meta: U2FsdGVkX1/h1ghmW8GTxX8ErTHtxvFgQmJlRY6cmDqelHitMcf9DwbQudBrcZmBteManKC4mplNUjmIXvDse54ZMyI3lebDZPyOzgrlnnn4Wl5R343VBF9fkE/W1knASxmho0Io0fWSaZMUrVoPHWDorNwuIHi5GA4EmWnLQ40oTLoR2D3B7NfDtQwHWBxSC5QqQxaBB+0GGtgyC2TYe2AbTz5IAkcZtTJxcQsdFyGBdpBw5sloOOHZWnTwdNEWFNCqWiKyoNjSYJdudywPVrVh0POJEfWqRxTlHpIRcLVcp3G4az1JvP8z4tPeZ81qlPcdTlJO/0P3wJw/TL4421Uvsc7jpWNQWad5jsyPF7HY3HuqZZHYztSbzQiR8/MbLquhxGFPopgpqHJyy4kYGUtDpLHnhzSpe6JmY3N3AE23fmlVHSjZ06OV2fX305jjspvJC5xoYcgYxR5mk4VJsRjoiRptapu50yGKNlrcbCP8zAAIuesri0jr3UOKTYkFdBNew1xgkD/0DDA7wHWqzShScuEIZzU6CjRYwX0qWR+rNaV17BimMrc15h0+cs6Gu6MsuLvBZ0O5eXecOf+6Kim9x0tmjSurUvcgS1egcqqWShd99ttXUijPME++nerjY3furpM1MDFISF3WtUlOW/TInERuATePlQHeRjTffOPVDJ5E5ZH96H+1lKWnTA4Gk2zTCxxR795ThzVy2SCQ/KSOaiqkI2sf5yyCq/sJlG/krgJEnWg19uy30OvLS8UloKruMiDNo9yGRVkpKucFXrCtcygi/W9nA3PcnxXuoIrf67v7Ieu7mwIEBBeO+KXFBkk0HIHEn7+jmLRT3kyE9g/bojojFb2tdeAXUMM4ESdf/gqRdl7m+A+iDeguQad52j2YQZPz9o5pT5EX4yI0o1xqo5NpeTVHEpMUuSJ3BPRWA6+a+YjihPUx0XhCnsCFKs8oq4CGxvRNswAMm/X wfiv2nZn FeeWBOwxj4Y/WP2qJCTe8/JLpT6dtkH91NaS2iErJbM7YNYi3XGgP7b9EoRN0bJ+rVkNoLOSdxBzZc4JLbf4pA/N7mu0ola0V4dTZNh6GbqYLKqPM2AxV3GvSH21brUciu9p2ZIddr4+W7myeaJT3fTQXiU3S0t5Mk/DaMEg3LTE9GV1YuqOE0ZHo9GGfdpK6D2Tr6D9gDYxvY5oYyWNjdUNLaFtc49Pby15BwFI340rPZn11MrLTgyTSnUWVbbjSoB7mlINFpCzB/A4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Thu, Apr 17, 2025 at 11:13:52PM -0400, Gregory Price wrote: ... > +static inline bool mem_cgroup_node_allowed(struct mem_cgroup *memcg, int nid) > +{ > + return memcg ? cgroup_node_allowed(memcg->css.cgroup, nid) : true; > +} > + ... > +bool cgroup_node_allowed(struct cgroup *cgroup, int nid) > +{ > + return cpuset_node_allowed(cgroup, nid); > +} ... > +bool cpuset_node_allowed(struct cgroup *cgroup, int nid) > +{ What does the indirection through cgroup_node_allowed() add? Why not just call cpuset directly? Thanks. -- tejun