From: Tejun Heo <tj@kernel.org>
To: Gregory Price <gourry@gourry.net>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
hannes@cmpxchg.org, mkoutny@suse.com, longman@redhat.com,
mhocko@kernel.org, roman.gushchin@linux.dev,
shakeel.butt@linux.dev, muchun.song@linux.dev,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim
Date: Fri, 18 Apr 2025 17:06:20 -1000 [thread overview]
Message-ID: <aAMTLKolO0GWCoMN@slm.duckdns.org> (raw)
In-Reply-To: <20250418031352.1277966-2-gourry@gourry.net>
Hello,
On Thu, Apr 17, 2025 at 11:13:52PM -0400, Gregory Price wrote:
...
> +static inline bool mem_cgroup_node_allowed(struct mem_cgroup *memcg, int nid)
> +{
> + return memcg ? cgroup_node_allowed(memcg->css.cgroup, nid) : true;
> +}
> +
...
> +bool cgroup_node_allowed(struct cgroup *cgroup, int nid)
> +{
> + return cpuset_node_allowed(cgroup, nid);
> +}
...
> +bool cpuset_node_allowed(struct cgroup *cgroup, int nid)
> +{
What does the indirection through cgroup_node_allowed() add? Why not just
call cpuset directly?
Thanks.
--
tejun
next prev parent reply other threads:[~2025-04-19 3:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 3:13 [PATCH 1/2] cpuset: rename cpuset_node_allowed to cpuset_current_node_allowed Gregory Price
2025-04-18 3:13 ` [PATCH v2 2/2] vmscan,cgroup: apply mems_effective to reclaim Gregory Price
2025-04-19 2:06 ` Waiman Long
2025-04-19 3:47 ` Gregory Price
2025-04-19 3:53 ` Waiman Long
2025-04-19 3:06 ` Tejun Heo [this message]
2025-04-19 3:27 ` Gregory Price
2025-04-19 3:41 ` Gregory Price
2025-04-19 3:47 ` Waiman Long
2025-04-19 1:59 ` [PATCH 1/2] cpuset: rename cpuset_node_allowed to cpuset_current_node_allowed Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAMTLKolO0GWCoMN@slm.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox