From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 968ECC369AB for ; Fri, 18 Apr 2025 22:42:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCED86B000C; Fri, 18 Apr 2025 18:42:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C55E66B000D; Fri, 18 Apr 2025 18:42:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF6D26B000E; Fri, 18 Apr 2025 18:42:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8EE196B000C for ; Fri, 18 Apr 2025 18:42:51 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 76A7E1CD16A for ; Fri, 18 Apr 2025 22:42:51 +0000 (UTC) X-FDA: 83348640942.17.0028150 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf12.hostedemail.com (Postfix) with ESMTP id 8A0EE40002 for ; Fri, 18 Apr 2025 22:42:49 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aQnPxjaK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745016169; a=rsa-sha256; cv=none; b=h/zBZb+JqAgkJljwIgixQKGiF+o8+AvRUhFQnKzRUCgZVL/70fuob/TlHvCqmIVNQOTOWe uAE7Ai+V0twRXsnG6+HDMTUI9dqVwcrFb+gPuAKD1OpePG3fpppkreD7tFJB74DOln9eMW 0Zgsp1Jag7iqpSpB8e2HGtNeARvvgNM= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aQnPxjaK; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745016169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kgmTL9oN5DIMe3Fsp6gnWf0VH3wcE7YG+W1w6XJGAF8=; b=U5HZurnQfYxG5Sv+IaIaO1AIPAoB0ZW+2bMDslNOC6mKknkdPCfTKsAOlU5KiRquC6Abp8 PDznluLxWBGpHjH9Z5GE6p38mN3NQOrskidJ0vT1md6xYXhVUyR5SHsMjAT1pu0ppZOoyd BgNBVf51cb7/vQKnyHaBhMVPXsmyIMg= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-736b0c68092so1928082b3a.0 for ; Fri, 18 Apr 2025 15:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745016168; x=1745620968; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=kgmTL9oN5DIMe3Fsp6gnWf0VH3wcE7YG+W1w6XJGAF8=; b=aQnPxjaK8AD2KTuWTQmbIyJAyi/45Ju5QDl4uMLBSs3O8tGntsivTExuVx8gwjNqVp RcGTvxZZoeZkBu8jql8tv7a/02/UP+dK4Zq+suGhH2VlSCerJUUrlndYBwkzCeCY4TGk Kne3+k9jQzuBMKqZRIvE6D0NuPL037CvEnIxSqhphQ43RAmG6O+Am5ljBDxfWXLDoMyy IkertAOk+vWZH115rpDLY9QWs4EBX8RQKt8tsZ89bKdN6Qv+oldqYFoCcANDNlxHvddR ZUrY4AM7VQDCMY/4WH7g5ufTH9ltbr9Qvm4D+/inJelp5Ix2Tqv7UvBFNFGmb8pJ1SdT pRgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745016168; x=1745620968; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kgmTL9oN5DIMe3Fsp6gnWf0VH3wcE7YG+W1w6XJGAF8=; b=RiG/jny2yNvi4iCYe57V+K96utRnhqWDnKSV7nSvEeI/ttWm+tD5VzJdRhveayQ1ET 1TjL1tafV0+HJjxBlfM1WdrjeB7CTIwYK/0+LOkneN2RTRk34Bz+j3i4p3tEvZBPy93v jZqUx+mztCi1iA2iWTkzAH+MnVM0dYldPadGIZYzMWrP/uYfJ7CkAGgxNEl9D/F1Xhbo cFUtOQl+m2LHCPB8PI6aPfjc4yRN/F8Q5Tm7ncz1JU55eN4bNKa5Y4fRcXp+Y4KoXo/S 5TbZUjXTtkaFAMUiI1F2q1KTgxo7aiS6EClOOIku4GTyqLTeBosKzFRW/aHghFQco31Q glFQ== X-Forwarded-Encrypted: i=1; AJvYcCW8DUVjk+NZvbHNtoGAkCOHBuShP92pQ3iJVvpybSBu0/DFAYbeqUgB4MZHcxM4joc/FLd9jaNfrg==@kvack.org X-Gm-Message-State: AOJu0YwitPP2etUP2yF5PZoe0ft3x8AKV/EA30cPMdAhpoXekMi/+uRb 8E9u4kLyKBUELMVZRmXrU7TnDuQ+S6vaBvL9y0U/MVqjvicls2Dv X-Gm-Gg: ASbGncsrYYQrJXfBkYXRJnRR7nczgSfjwEKkoi2N+1OeAhIjENDyrItmsKPezXPHE/x PPSdNWluV02QyepABKcuPYz9CBVf0OUX79LLN+zkaZCHfzNrLglSS/yiU6HkwgODPa+0OzoyWWt fZk56AY2opuNJWPcomqs5w/LVLkHsessUwps9j6ndsgwAnYxy8Dp/fcbVZi/cYiUWAlFnS+RsTq nBvRiH4mOQHDwrukrODSFmhTKfPPMbtyVQC37VVhuu23K4CtsZH2yexNAqjmJCOcNeY1c/Xugqe XWRViS9QwrV6qsXqDGINnhqkKHzUjHHGWOK6 X-Google-Smtp-Source: AGHT+IGgefdlO0e//1jWeM5CqboYo60WpnvHsKtXus2GnvC33Rp2p8SbJVkWXMYbmcIKQvXFijMZOg== X-Received: by 2002:a05:6a00:4c17:b0:736:57cb:f2aa with SMTP id d2e1a72fcca58-73dc14d34f3mr5438974b3a.13.1745016168262; Fri, 18 Apr 2025 15:42:48 -0700 (PDT) Received: from debian ([2601:646:8f03:9fee:5e33:e006:dcd5:852d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73dbf90dc88sm2126398b3a.83.2025.04.18.15.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Apr 2025 15:42:47 -0700 (PDT) From: Fan Ni X-Google-Original-From: Fan Ni Date: Fri, 18 Apr 2025 15:42:45 -0700 To: Matthew Wilcox Cc: nifan.cxl@gmail.com, muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: Convert &folio->page to folio_page(folio, 0) Message-ID: References: <20250409004937.634713-1-nifan.cxl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8A0EE40002 X-Stat-Signature: 4stkxy7uput7685kzep7fhbgf8pwriac X-Rspam-User: X-HE-Tag: 1745016169-395037 X-HE-Meta: U2FsdGVkX1+rkgV0rOluXBRbWOpC6/fQAqfWrN/on460BdmtbwFJpMS1FzBK7vTm71vJdPrAptlIEluTM5Z9nWuvSESRnR278hVh12Ss9QVO//HL6zCb/xBwdF/EBUDbmv6Bd3yzSNp80GV+D0dE7MiLd5kR6whFJRIAm2RQsJlg/5plu3NafF7wQCiCyq5QdNQlIZcjzfcjPyvNLQ/2v8vGA8yXiO4HChIvWxa0p2S/3FCDf+Eqm0OLN7EPmJrA1mrlyXo1GlrzIRYT8IvOK3DjXB7aNjgdMruzVrG5nDA5dk7vyaCbAnB3IMFn4QkZNSawBMPol4G9uoBuMtO4WC98cwkJC1WTGH2L7z6JJU79niNyKanfvBAasaZTyrBYLdE6IcdfwNtRP7lRG4jHop9INHEf+coBv5C2VOXDTqZICfaoQEgAMdX1uDDxy0gj1OrNpzqZGfZGGKLd8lRO0UJxfQMUz5wXJVbYojBavqGMFaZexdY4N2EDY04S5fsaDXlQegYgFmaSsOhTU1ENrEoPyPdg0BjJIcB3XLA0BvGu6qX9wcUhO2E9LoAERZQwzxH0QBA4eQSZDvpWU4VSSiyiz2mie9OytLeJVJv9F9OuGlZxpgMC8NUHFp2ydC3urF/OIZH9u1e0o+OmCMRETjODnjmvz8jtbWcSXtae9GkjXrT+Z9KD32qy37r2F2aPoPupq2ghuAMVSCRBBnCMzNRiVVf2CPV9LQ/RzYmUOeziin/0lBj5cLvdx8d0BmUR6Tm/DboIX8S6lZJ2Jct7MNc7njcl8oCo5bimcQD9r7+RHERyMqrcnJkvyE95D0DaMk21PpAzsURCDsG0fJvaxhmA9BpS8aYdBoJElkqFWgj0XQurDSDctMzO2gTsWu//BBKBC4225mXBT5C/FJ+489eh8sBEMxSsr3doW0ngqGhont4KFF/Zuzl6GNMV4nUEjWtXsnL+NB2KR/B9qJq 9rjUcNzJ azG/mJNsR1g98E87JJnV6tdjiBsqcG4BH4XW7BUxnC81cib6u/z/MO1m0Ea63JP0gRAUP/JyTUseQzPGSQhSgzgpFMFqvg56GUHq/LTkBnyE0wKyT7F7UlVxfpauHzMOgp+bjQeix31YfOCARF6FSVn1oPkFF8pOdqW9CGpK/c8akO8f0FAsV7kloPYjZj1+6sn5ut/iOnxeAvzWV46e7+Hfz9n/jHw6/oFzn5j86jnHDhxbKBt43+Ruvp8cis73SL8nEIYgZOURHl1BIbWHWL1NU18DnW6/kWAwlJAA0xjzPenX/WRnHtLnePM5Je2KynRT9Ece8Z+MEQiqx9Ccr50F2c7+BdsuzC7idV/0C7vUL0559+T8ErZwZtIOhGH2tvFRfXC1T9buLWek7waufdQpIKl42jbMpv7a8W5VDL5x34cz+sEG+iKn9V+4C/+lgpIHiQum4LCuL91ZBGQIjLxO0wmm1JEi6ktuFATnOPsfJ7Bnk1AUdYa72NikiydSaesX2mrRb3H9JiKkM3Aw+0+nB2pL35V0cNL2myh74UXiGe6JoupwMDl8e7ZXOVaA4zT8nebA8tmjTRYNx8a5/Lik8K8tj2HWNcJJ+GMexcbqqqiHL1O3OLFUEKmt0cUZTyFnx2JH01AQ6/cg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000188, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 09, 2025 at 04:15:30AM +0100, Matthew Wilcox wrote: > On Tue, Apr 08, 2025 at 05:49:10PM -0700, nifan.cxl@gmail.com wrote: > > From: Fan Ni > > > > Convert the use of &folio->page to folio_page(folio, 0) where struct > > filio fits in. This is part of the efforts to move some fields out of > > struct page to reduce its size. > > Thanks for sending the patch. You've mixed together quite a few things; > I'd suggest focusing on one API at a time. > ... > > out: > > - trace_mm_khugepaged_scan_pmd(mm, &folio->page, writable, referenced, > > - none_or_zero, result, unmapped); > > + trace_mm_khugepaged_scan_pmd(mm, folio_page(folio, 0), writable, > > + referenced, none_or_zero, result, > > + unmapped); > > return result; > > ditto, > > > result = install_pmd > > - ? set_huge_pmd(vma, haddr, pmd, &folio->page) > > + ? set_huge_pmd(vma, haddr, pmd, folio_page(folio, 0)) > > : SCAN_SUCCEED; > > I feel that set_huge_pmd() should take a folio. There is a patch on the mailing list for it, https://lore.kernel.org/linux-mm/20240817095122.2460977-5-wangkefeng.wang@huawei.com/ If the above patch is needed, do_set_pmd() should be converted to use folio. Fan