From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D5ADC369C7 for ; Wed, 16 Apr 2025 21:49:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFB5E6B00BC; Wed, 16 Apr 2025 17:49:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA8C76B00BD; Wed, 16 Apr 2025 17:49:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A96E06B00BE; Wed, 16 Apr 2025 17:49:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8B8C86B00BC for ; Wed, 16 Apr 2025 17:49:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A8C65C76E for ; Wed, 16 Apr 2025 21:49:30 +0000 (UTC) X-FDA: 83341248900.18.C5F4D3C Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf09.hostedemail.com (Postfix) with ESMTP id F1553140005 for ; Wed, 16 Apr 2025 21:49:27 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KLIJM9JJ; spf=pass (imf09.hostedemail.com: domain of salvatore.bonaccorso@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=salvatore.bonaccorso@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744840168; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kuAsoSRWs3XXMkPQiT04hZEE3IG6isgmWWPjEa55rjo=; b=rXarsib9ntGhoxdw0AUu+dXIAD+yIKZnB+awGFdnts349O7lsoAGWlZnok8MMWPZyrm9TO Hl78FJ7dpjufJIwPTTc9LRSS4U+8XIyfmmD2XfEajGLoEHKJ3B5ad+jBHVYPDfLniCZWcB r2BrkATXrqotwzjvWF2oghrPXp+BbRA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KLIJM9JJ; spf=pass (imf09.hostedemail.com: domain of salvatore.bonaccorso@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=salvatore.bonaccorso@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744840168; a=rsa-sha256; cv=none; b=IhTx4AnGF/zjyOcolTUnt1oCSfeGEfJaW8z1Z8dTkt0OpZYM/YKB2AZ7XHqlwHn/BbCFsC CTB0kkcQFMxeAPMWrlw8Snspa5IPSCpfVT/rAkv8+gB2yN49Pz6ZyYBAbBufupKUhb2II2 UEQhziH4ZS5LdF4n76uVA4uHK/tL3r0= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5e677f59438so175513a12.2 for ; Wed, 16 Apr 2025 14:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744840166; x=1745444966; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=kuAsoSRWs3XXMkPQiT04hZEE3IG6isgmWWPjEa55rjo=; b=KLIJM9JJhHxNW8Ffwbw5fmAhxO5NpPKfmNWDaJ8IaUMeplZwKuQ2dO96HhgZwStGmc tvq58MqK3Z8j7QpWkCSu7EZagxoWWixzPLHwD5eqm5wqMLX2iypGfur/p/H4L62B3Q/L ZlJgQ80iBvW7Dwr/WgNs5LBdjnkDmA8x7GkrhoV8ECkhnJLAZN7SBsvarRBatD1a+xnS eiRDKyQtapndsVDUtLLOtUw6Bfu3eok57j8FLO+opxvS6QVIszZlpGQpc0QDs5AzDP5T 7mQFDgku7cWtSBImSf/TyL+aB9xS0p8liGX8pDbd98PtRDt2HasO5oRnW7+IyjmYPqXB QD8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744840166; x=1745444966; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kuAsoSRWs3XXMkPQiT04hZEE3IG6isgmWWPjEa55rjo=; b=XygPRydTtU9yI0Fsw++Deoi9Gm7F7wVfsV7aXsdnppPyk2msuYLPlhNhZea6Y4kmQi jRif78aLPPhJkLqSqd6OO6yqJdx2v5+2mDZ2gkqGQmVOzaPSbyXwLuCiHRUtejUVvItx mcsVNKj4A4jtoQybVmbBVX5/I3Ls2jPcPtuqpNL/gCV+hgr0FhJsSQOpDwzJ/XIi1/If AqVTpqB3UE/2zBIVn9b717n3Mprwh1Vj809QmCqB/gQGjLz0vy1CvIpwnNZ/h+lZR7UF wLBD09+b+Ubqj6z0loUCa5zX3ZiD94mkDtPhWo9MlLC+abVl1V3Bnvlf6oq+lfJVjVtj JH2w== X-Forwarded-Encrypted: i=1; AJvYcCVamEmf621nBHRJBua2mIJzscePkcpeXFpEGTDnC7hPdCnxED3CrVSfeek9pBAvG7zZ5TJBJ2zsXw==@kvack.org X-Gm-Message-State: AOJu0YwKivFJHPtfWzO4COGxEFLoXuNQ0Iwk0y/NxrDbrKoQ40rWzy8V kzB6S4gTlrrj8fBZtws0wUT7e70O1GGjHHsNCufAwHT+B4WUu39m X-Gm-Gg: ASbGncvzLm/m6vLmOyy/xoNOduygTnAbr4n0elzyZb5bmG2O1pbCQy9HTChxzKZ4Sa9 g8sxrXoNnr0SVjztdVPQADjmUcTtRPelqiZi0m+6lOF8xV0lLPnsggR5MDDxnQIb1Fbh2lcC9kY QyQ6We8UAscDfaIMkVShqbsQXqjo1Rk0omdaXttg7kf6hlnP0DGFKG74voEXSyp+2HCIyJtaCco IObGKhV3EwwFWAVtny+rkcVPQzJmzunYIUz0iPeckfLbxO8i1ViiBiNbr8Srxu2DzXwfOckZD/P Ke4KeyfXuvza+4Rsy1/n7DDYOjPnLBJ0JKTvJHxgCG7U0aTwPVDIwYfkaIcDPhSLPBjHDtEwNw= = X-Google-Smtp-Source: AGHT+IG2kUiL7yGVIL+oa4rcD7PDtuEb9dFfWdovybmt7T7ov7aU4NDkdAzlU2k3yGIoxsTNHQ4Z7Q== X-Received: by 2002:a17:907:9712:b0:aca:d27b:b20a with SMTP id a640c23a62f3a-acb4288cf2bmr327108466b.7.1744840166091; Wed, 16 Apr 2025 14:49:26 -0700 (PDT) Received: from eldamar.lan (c-82-192-244-13.customer.ggaweb.ch. [82.192.244.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb3d128118sm191120066b.122.2025.04.16.14.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Apr 2025 14:49:24 -0700 (PDT) Received: by eldamar.lan (Postfix, from userid 1000) id 20E59BE2DE0; Wed, 16 Apr 2025 23:49:24 +0200 (CEST) Date: Wed, 16 Apr 2025 23:49:24 +0200 From: Salvatore Bonaccorso To: Alex Williamson Cc: Milan Broz , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sasha Levin Subject: Re: [PATCH stable 6.1] mm: Fix is_zero_page() usage in try_grab_page() Message-ID: References: <20250416202441.3911142-1-alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250416202441.3911142-1-alex.williamson@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F1553140005 X-Stat-Signature: kgezcib7419o44bscifjjie619pu8iek X-HE-Tag: 1744840167-747824 X-HE-Meta: U2FsdGVkX1+DF3HhkShZlbx/5m/hX1bRNCbpbqI9jd6yBpI5LaylptSjVCEFyfVIrWuGUnKO/765asWdEWSQXb5GyLtfNRQqFv1Yyx+Ef8vGHqqfgjuZtmHtHiuGYIZgt5TaD0V6BiJPH2Nf603HHQIM5ZIradsWUuru+NxmmTFBcKEA/cneWZ4EvNoAxGSGOgveZo5+vyaETkvDARcTBRyewHQ/CECpJsbuYapyxWG5JhxaeDIa7AWrTJS8HWKNahRjL6saF6nbBcFRS7JSK5H6SK6rbrxkUn1fxPbp6cJrPVssjvLlPJLTjHH40FfAou/I4Y5evgM7eb/aeMoQ/mYv0CnQohE80SGK7XoXdkj5fjzEMr/+XV+DZRQTldO/nt1UZ8r00/Vbb/6qBGg/bwctXVF8S4n8nyEzDiI/8UfQQsNFRtzRPQFQPfTVriFTMevr3sM1Q8q0dtoo/7Og9cLHZ8ZcKZ4qbMfFC/Bs3SVDMemEoIceygiG7G/g4VttG+J4UhLXU97z6Jc0foF7Pz3DndwT0lrcVk/Jfwv1ZA7xi4C8aV9yiovlbTcHLQ1fJzRfZDrhA9hKAdEnWiWwUzuJE/Sesl8fwjZnK4w+w7ciV9hnE2YVE5PSERCtGAMDWN6h646dQ9a6p1opwkio/DDkniNOrJtsXSMN1y3D/WERHm0aYVpRm/hXhfe34hthUrFvO5xvgp1O50hrYEnO8Nw5pToX90QhtHxCWt3BkU3PBKHjvxEY4NaKuubM1a3tF9V5Dd8vpim2maW1170zg46N556Z3HWWq5w6f6EbRClELJG1ryhyLDXRFmCtTPMkLLunvwEYuWrpDYVnRE1IGPOjEAgDOp5/5YL1rKnunEN3YXF7aJAM2T//PA6PbsXDdnHfOFglEOujakL3hKw5+24NFFCff8FLpaOnHXPRDmLu/TNWqcntRDO3yhDaydMBzDvhHzzF+CTxLhM0B3x C3PUwPze 8Wxh9oR8qAfrM1YUeGnu9RknXGDQ17wK9mFQMiHGtPgvJpEHyE2fTdAcs31ghIyU629p4vYNUzNAt84lXo1Kg0qZiewKQqgailDdvBCePmc7krk1aoCY9eY+U2XJYPkDIcOFezfpsyGJakFVdEU6G/G8VRhmyxvp8vVPBO58GAKz6OVjkkH9vUVEhGttWCnZlY17x90Hv+HpKRXvFGRErPewzj0X+vmo2WosZaqSsLZP9TYqmuqqeG00aw8QKvnACwcyBfmJiXzsTjdINr4Gzb2aaeRgopl/aY5NX4PoAEDcdATckXy+balivy8dZRn2CyKczm6Kz5Bhpt79+KviQCG2yKI9Q1WMzpaJy/6tOXtcNygzKIwJmxoQtljyLjeomzfKBFykXm5iHD9E/Vzkz6IZlM+sFVGkWX9G5ZHe7ekt3uXbH+4kgwYtA6pTJ3Y65Z/mVIbBA5kSAKSNqIpkav3kV3J//Bp9l2vqQfyUBlJ7F3HPVAZ4EtAf0PybIH0dqgWlyGpqtt/G5XnLqMdhz7bSC+SvcQ5vQDQxMlma0/VppRZp+f/GQI6u3iSm7wweANTQAbLw5Pqrbq1HHvekG8FeHwvGnmBhJqyC4wSbE/sGoKOMOZ0yInF+memQp6Kz6v+NiahLNS3WaUZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alex, On Wed, Apr 16, 2025 at 02:24:39PM -0600, Alex Williamson wrote: > The backport of upstream commit c8070b787519 ("mm: Don't pin ZERO_PAGE > in pin_user_pages()") into v6.1.130 noted below in Fixes does not > account for commit 0f0892356fa1 ("mm: allow multiple error returns in > try_grab_page()"), which changed the return value of try_grab_page() > from bool to int. Therefore returning 0, success in the upstream > version, becomes an error here. Fix the return value. > > Fixes: 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") > Link: https://lore.kernel.org/all/Z_6uhLQjJ7SSzI13@eldamar.lan > Reported-by: Salvatore Bonaccorso > Reported-by: Milan Broz > Cc: stable@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: Sasha Levin > Signed-off-by: Alex Williamson > --- > mm/gup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/gup.c b/mm/gup.c > index b1daaa9d89aa..76a2b0943e2d 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -232,7 +232,7 @@ bool __must_check try_grab_page(struct page *page, unsigned int flags) > * and it is used in a *lot* of places. > */ > if (is_zero_page(page)) > - return 0; > + return true; > > /* > * Similar to try_grab_folio(): be sure to *also* > -- > 2.48.1 Thank you, with your patch applied one test VM with a PCI passhtrough configuration start again. Tested-by: Salvatore Bonaccorso Regards, Salvatore