From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3B94C369C5 for ; Wed, 16 Apr 2025 19:34:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F5F16B02C1; Wed, 16 Apr 2025 15:34:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A46B6B02C2; Wed, 16 Apr 2025 15:34:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED6146B02C3; Wed, 16 Apr 2025 15:34:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CF7E86B02C1 for ; Wed, 16 Apr 2025 15:34:21 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 71946BAE02 for ; Wed, 16 Apr 2025 19:34:22 +0000 (UTC) X-FDA: 83340908364.20.8A2EA39 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf02.hostedemail.com (Postfix) with ESMTP id E35D680005 for ; Wed, 16 Apr 2025 19:34:20 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T+A0oHTS; spf=pass (imf02.hostedemail.com: domain of jarkko@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744832060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e5jX5vAkCjmrrtYmKuR4FVu2jjvQlpbRk2vPXmMuN0U=; b=UI3TQQFgoNQRRgOjf3J7ti5PTmMfxNTVpcUUuQiEQfMZgR4tPfLJYBxYYYiVKkYNnWsonR /d0JHwDhxZVoO99O337lWkR9jhrpP/AMLAOt3xqboprr4lskg07CRx/i3IdQw03kwxtmUP TPkpBYOg8HtVaiXxYu/Y4/+sK68Iq1M= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T+A0oHTS; spf=pass (imf02.hostedemail.com: domain of jarkko@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=jarkko@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744832060; a=rsa-sha256; cv=none; b=ymOYmAS07JA694MHoWhmRNTDfwtmxsw91FIY9oz8X1jR9xCdM7n9lIlHUdv7UNi5v0W/MQ 7gOikBToBz+MpOIH47xCdvAUF0tALDI1CIMjmUfJnPg29AdcysGeI68ZZ4N/fMJ1zsoSzj lLL03q4F7+5wOG2M/KVoovtgeV9BqgU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C0BBEA4A52B; Wed, 16 Apr 2025 19:28:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E34AC4CEE2; Wed, 16 Apr 2025 19:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744832059; bh=geLExcJtOAjXjEY3nYZsjfpMc2TX5ES0OBy8m9gKC/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T+A0oHTSymTtL9IlRxP2X49sZVIM+qKZykeUc2U1jckOh7Fab2nVwAlbNWbp/XYXH 72yCmdRJgMazizkaUaoxG0Wn7KFWs6aHcG6OfFWYy+IW8oFbj4GScY3vpMq0460m83 znneUQQNp70DChBAFipuLJMTCbl0QPbJuB9t45gg34S2XEtV2Xy7YIWXsmuR4MnGoB ONm30k/EW8IhlQTZhxZ/RMNIYfZyo3oG6WmJH2ox1m2hZrI+VEcIhKMAYk9WTZNjB/ RizhkamT1QOnRjMZK46AjXuFi1Hwlokh2lbPLIBWcjDTJ5LJe25/TXY4xyWLb6lIOf LWfCobji2UGcQ== Date: Wed, 16 Apr 2025 22:34:16 +0300 From: Jarkko Sakkinen To: chenlinxuan@uniontech.com Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Peter Huewe , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-integrity@vger.kernel.org, linux-kbuild@vger.kernel.org, llvm@lists.linux.dev, Winston Wen , Changbin Du Subject: Re: [PATCH RFC v2 4/5] tpm: add __always_inline for tpm_is_hwrng_enabled Message-ID: References: <20250416-noautoinline-v2-0-e69a2717530f@uniontech.com> <20250416-noautoinline-v2-4-e69a2717530f@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250416-noautoinline-v2-4-e69a2717530f@uniontech.com> X-Stat-Signature: 1mziam6iboo8rht547ungq4hp5pjfdpo X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E35D680005 X-Rspam-User: X-HE-Tag: 1744832060-219681 X-HE-Meta: U2FsdGVkX1/mh92FvGPY6/f4mKd+mCga0TBtuOr4R3mRmE7TaRkzPlEXLB9J8BOpj8qenUeDSgrh+cXTt4vO3YDHgErdiSvADWNtbXOgYFVyso8lgGcj0ba3Sswqt0K4Fp0LgVOrrqrPXbfip+2FIjt/mg1hJjRBB15t+YE/xv+YpJhiRqddfQrc/cedszRaNUug5TBVlNGJPrdH2VfumbV7fAn670/YbAHk+8IrNlUes8IBPTAzDnHDGIXCLfammaBMwomcMDDV1RrxisYd6kMEQbpJPl9EwyqfmxSOCAOgLwLGgjFBJFxMuIe1zHR9p6U4jWBatsNc1Z7KhxSM2qzm2BeRZqUtsN1Q2LM8QxRXW01pvmdAW2HTwUqMf5u5tW/UOe0L8NFC0I273WNfrvpT9FQYyodJYAo9sBsGgEMHAMX7o9I8GeoFyLb78jBSrvp2hMxo1wL1py4CKffZIaDeq2XX9DZMLYwxfsPZMjUyw4Z6A9PQu21XWw8vY5hUiwFIw1EYTAk5AuOZnksDoYuAvW2VQ0P0D6c2axacKKwxICwDkhptgK2/PNPmM0ip8vEe8m+J443jy9VLZWOwHNkjLIAJnP+iwTPKowg5UexTYXlpCP/pip24utKAwYB/MDvuQbb9bMCtW7pmUkY7n1Xk6w98llrUDzO2zzgJ9KG58/c+nbjMDJFPYiPABara3MI8RBCXzijaM8FaWGdy3TdjqO/g18zDNFR+bcIAtDaAwUPJLGUm8GHE3kjuJjBU2vppO9H/xZJUbvhTXwee7uJUiIGGLDadw3ykfprrXZUnd+J9Pzc4zg7pb5AC/hiSbEDZcaopAjg1zUh2EjnZXbQeLb9HN2TTe1cXLqFEkOmLopEF8o+Gl6jAoeXTAheM5eMoE6hY1/OglYX/tawyMLbsAo5GwiRjMqgc5/++PJ11i9bQPI/diHKjAkkjCpHJ4MkMKe+O7NrBVND02yM 3vt+AyD3 E4/OKgSk0RHG/aPezSt3Y6s4xRx1KHGXEvRmC5xlRVe5w9ZzWVNZ6QXVosMBQaSW+uUb/Ass0Xqk0jWH/7w9758lth9WZW/RqMKGMklCYiJtxixMWUljtkY2v4oSgvotIpszlLjk/71XbgRgr1YBdONND8KZtYhseTcYBQl/01PjBeKTN+KKNwzbN0OZljAfR6g9vEtMNhdewKDd74nOdodZBQyGrT95eusGDjCbroOMJZsQZxu2s8UezFWTa5i/P6s0ePtSFN03Mj19cvUXVnFBu9nGMCelMx9r0bjOrZjMoNLB01WzoIx4mnUSXDSfJ1Quy48524frbq9X4sKY4ylEyCe/46j2W9HmJ6zZmEOeKguwreppn2GDINLm5bLLsDucJl3dC3yorHyoJfNrTgUwOW6wiRQIcnK4JrLY3YPhzvJ7cpbn+rNI64eYvjHBHi54O/4QQR6UEiALjbrg9aTN2kA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 16, 2025 at 05:44:50PM +0800, Chen Linxuan via B4 Relay wrote: > From: Winston Wen > > Presume that kernel is compiled for x86_64 with gcc version 13.3.0: > > make defconfig > ./scripts/kconfig/merge_config.sh .config <( > echo CONFIG_TCG_TPM=y > echo CONFIG_HW_RANDOM=m > ) > make KCFLAGS="-fno-inline-small-functions -fno-inline-functions-called-once" > > This results a link error: > > ld: vmlinux.o: in function `tpm_add_hwrng': > tpm-chip.c:(.text+0x6c5924): undefined reference to `hwrng_register' > ld: vmlinux.o: in function `tpm_chip_unregister': > (.text+0x6c5bc9): undefined reference to `hwrng_unregister' > ld: vmlinux.o: in function `tpm_chip_register': > (.text+0x6c5c9b): undefined reference to `hwrng_unregister' > > With `CONFIG_TCG_TPM=y` and `CONFIG_HW_RANDOM=m`, > the functions `tpm_add_hwrng`, `tpm_chip_unregister`, and > `tpm_chip_register` are compiled into `vmlinux.o` > and reference the symbols `hwrng_register` and `hwrng_unregister`. > These symbols, however, are compiled into `rng-core.ko`, which results > in the linking error. > > I am not sure but I think this weird linking error only arises when > auto inlining is disabled because of some dead code elimination. > > `CONFIG_TCG_TPM=y` and `CONFIG_HW_RANDOM=m` set `CONFIG_HW_RANDOM_TPM=n`. > This causes the function `tpm_is_hwrng_enabled` to always return > `false`, as shown below: > > static bool tpm_is_hwrng_enabled(struct tpm_chip *chip) > { > if (!IS_ENABLED(CONFIG_HW_RANDOM_TPM)) > return false; > if (tpm_is_firmware_upgrade(chip)) > return false; > if (chip->flags & TPM_CHIP_FLAG_HWRNG_DISABLED) > return false; > return true; > } > > When `tpm_is_hwrng_enabled` is inlined, dead code elimination > optimizations are applied and the reference to the `hwrng_*` functions > will been removed. > For instance, in the `tpm_chip_unregister` function: > > void tpm_chip_unregister(struct tpm_chip *chip) > { > #ifdef CONFIG_TCG_TPM2_HMAC > int rc; > > rc = tpm_try_get_ops(chip); > if (!rc) { > tpm2_end_auth_session(chip); > tpm_put_ops(chip); > } > #endif > > tpm_del_legacy_sysfs(chip); > if (tpm_is_hwrng_enabled(chip)) > hwrng_unregister(&chip->hwrng); > tpm_bios_log_teardown(chip); > if (chip->flags & TPM_CHIP_FLAG_TPM2 && !tpm_is_firmware_upgrade(chip)) > tpm_devs_remove(chip); > tpm_del_char_device(chip); > } > > When `tpm_is_hwrng_enabled` is inlined and always returns `false`, > the call to `hwrng_unregister` is effectively part of a `if (false)` > block, which I guess that will be then optimized out. > > However, when the `-fno-inline-small-functions` and > `-fno-inline-functions-called-once` flags are used, > tpm_is_hwrng_enabled is not inline. > > And this optimization some how cannot occur, > leading to the undefined reference errors during linking. > > Adding the `__always_inline` attribute ensures that > `tpm_is_hwrng_enabled` is inlined regardless of the compiler flags. > This allows the dead code elimination to proceed as expected, > resolving the linking issue. > > Co-developed-by: Chen Linxuan > Signed-off-by: Chen Linxuan > Signed-off-by: Winston Wen > --- > drivers/char/tpm/tpm-chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c > index e25daf2396d37bcaeae8a96267764df0861ad1be..48cc74d84247e258a39f2118e03aa10d0cbb066a 100644 > --- a/drivers/char/tpm/tpm-chip.c > +++ b/drivers/char/tpm/tpm-chip.c > @@ -534,7 +534,7 @@ static int tpm_hwrng_read(struct hwrng *rng, void *data, size_t max, bool wait) > return tpm_get_random(chip, data, max); > } > > -static bool tpm_is_hwrng_enabled(struct tpm_chip *chip) > +static __always_inline bool tpm_is_hwrng_enabled(struct tpm_chip *chip) > { > if (!IS_ENABLED(CONFIG_HW_RANDOM_TPM)) > return false; > > -- > 2.48.1 > > > Thank you. Reviewed-by: Jarkko Sakkinen BR, Jarkko