From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8058C369D1 for ; Mon, 28 Apr 2025 00:41:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F4AA6B0005; Sun, 27 Apr 2025 20:41:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A2A36B0006; Sun, 27 Apr 2025 20:41:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26A396B0007; Sun, 27 Apr 2025 20:41:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 057BE6B0005 for ; Sun, 27 Apr 2025 20:41:44 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 51433C05F5 for ; Mon, 28 Apr 2025 00:41:45 +0000 (UTC) X-FDA: 83381599770.08.C073D34 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id ADC70100009 for ; Mon, 28 Apr 2025 00:41:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Mo3kSFvf; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745800903; a=rsa-sha256; cv=none; b=Vb5IHESlRPGTsMO+l3Nva0dFxFAswN/dOVzip+5BuOGeeI4dz8kj6jnBTqnUWSfylRCkWE v61nAKMlIbPZiTkS0oo88yGjiJKbJVx3TiSWLtivEDMrhwVRKmM2cbosmgQffVFeYutCt6 C2gt7iQFhVtIjuexMZlzbntpDfbdKrY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Mo3kSFvf; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745800903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=253L+dW9y0+QF5H9qTod08othC3elXAsaDjNWZPWCTA=; b=WcmFcI3XiV5yN1yB4sGIOOhlDHrubiiqW31LZdwVB0rRLvnN2gmdQaYrbwstbc+X5jHNnh C8ZqbTYZBe3LbbLLwrWqihw2ivIdMDUztwN4njzq2nviPp8E6mrcvqOlnOxah0Tan9VR2t /giMvy0U8FYRZDg6mIb233spSZpYsyM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=253L+dW9y0+QF5H9qTod08othC3elXAsaDjNWZPWCTA=; b=Mo3kSFvffHgcBoR6oiqGDtF0P5 w+d9253RXguB+P2thF+PBLBSLNsf3EkfjJrT3Am+iaMktxc9xCfS5Y+mFc2iJR4Q1bVoBMBYySPoE 2R5U8HtEtmrCRbvRYzoOMp1H05FKBx1FvZB+9dafCjPzvllYUbvkOh98r5/qc5XwHsbkM0kmg7+y2 DzTUWZbuliI3fXbJ8isBd9fxtxCQ9R+ZsFY+M8WB7k/9Y4Q5R4dURLgtKHrA5Bd7c72xc4A4e9PeD SjQauGX6woHk6tz+TEN5Q8UCyWIaP4FnURJCGDSHKQnNCK/V+k7C+ZkSADMkmZ9zIvuryMQM9g0X4 z4cJXfNw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9CYq-00000004j3f-3Jrm; Mon, 28 Apr 2025 00:41:28 +0000 Date: Mon, 28 Apr 2025 01:41:28 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 3/6] f2fs: drop usage of folio_index Message-ID: References: <20250427185908.90450-1-ryncsn@gmail.com> <20250427185908.90450-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250427185908.90450-4-ryncsn@gmail.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: ADC70100009 X-Stat-Signature: 9h77z9gpof1cnjawkshq4rdn6wzuxr3j X-Rspam-User: X-HE-Tag: 1745800902-657450 X-HE-Meta: U2FsdGVkX1+Ot8wbqw1Ebm/qK1w0Zw+Ahus3MhDV4tQDAqtQ4LksLviRjh/hGugUqILWL5CpO7NFuIMxw/p0Od0oVejoSU44uPE8M4V1UQwXCrVSorxylAGFVn9EPZOi9tNe2LiY6mo8eNr76SoBzEMJGDiuHKc43fnpStFd9dzKSUu3SyU3+yEPt6xQC9dfnELJE1U7IeGWwLQIzmV0EMKgAfD0RTQH/yRp2+p0TidPG6jGj0Kz5Xe7VMsS23yFYEIzeXWnboLCVRI+sX+iryemker+SKjDydOGMFBVl1eAqFE8LDATLx/Sb3Z2sUPEPyP16bqeFZqDDBVVIzDmXywRyBF7j0xKMVNZ434j7Pd1flEZnMnDXylQr4n5CsldGDHQHOhX9csPqoLk7ZNfRQb9nLDzi8BQjUsXqJ4gfH2ndVnPHAMTp3gTmrlmZ+y1f2YshDgtvHj70BJ2l+7NsekC2lq22n2ZrQ0HNy+uhBREnW7Lgnibuv1SAyjULerlPXN0jXQgjvJcn6ZwlFGZaTlMG2vpQM/TnAgp+UKpnSRYrMERoBQbDYleFPCcPcj91+KHEF93waInRFlpj7V8tBzCn2yB78s1DuuvinF9ibuozu2gpXuZYy7S0yGhHjisULzfjVXlt57w1GmDKLMen48CxlkkjeayqQuNXumiyFlO9e690d6/h0O7JzRpoiKipGo63vb4WlW2JKKuo/b9VXKgBN25JkJd5x3kHZoXO9Gbc80viFCpyLjVslQ4Lsi3DizMk7YXo93QPw0Mm5qglkVBIiGqIIJpTVxA7BORkMz42gl/Mw2iTXrd0n3RFFvF0JxVJ/MBlUaECWF+eFyOF7MQXEvm2QGCVBDXW6isns+gOLIEh6N0QxNC/LoZ7ckosI2d4rPCn/cOmnWhV3egWNyd4lI1AxBRhrMjhNAwVOklIvbANrjdeNqlkRQP8yJIM7uk+JD20oi6mc+NZ8v 3VT4Ci+/ 1vUe+HEYlZAgGhMHAxvJuq4uDoHL+cy5KZ6e6V6PVYctzSzjdOOgSsjHw/S2/ZaLdRsuU3cxm5gEPDCC9qKbV6SHXsveIdFmjnJn1ajYhL2GMsz1QNnD6DnUyZ6a1hWPqIEPwPFOMit1dY2IckkJbSXVEEZP5ebnVv8i1yc4pVAwJkVhcTqDI18m+jjOXHUlr3UXcej75ad3SAibwHEC6qSJvoH9cnYUje5IZk+E8TvixtPNOHgjwMZGAVkDPJ+tjUwnTPfBNhYkdCQHirqDa4xzjVnbes6TJmQrO04VW1Zd9Lf8wPbme2z/qMgnLGzyGhzbBta4UijXUUAtv24z8TGoz1BTGIuVhguLVMinR0Rc9uL66blH2cizaLDVcSbiLl0DMe81/o5Eyfluk7lls6CUliA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 02:59:05AM +0800, Kairui Song wrote: > folio_index is only needed for mixed usage of page cache and swap > cache, for pure page cache usage, the caller can just use > folio->index instead. > > It can't be a swap cache folio here. Swap mapping may only call into fs > through `swap_rw` and that is not supported for f2fs. So just drop it > and use folio->index instead. > > Signed-off-by: Kairui Song > Cc: Jaegeuk Kim (maintainer:F2FS FILE SYSTEM) > Cc: Chao Yu (maintainer:F2FS FILE SYSTEM) > Cc: linux-f2fs-devel@lists.sourceforge.net (open list:F2FS FILE SYSTEM) > Signed-off-by: Kairui Song Reviewed-by: Matthew Wilcox (Oracle) > @@ -130,7 +130,7 @@ int f2fs_read_inline_data(struct inode *inode, struct folio *folio) > return -EAGAIN; > } > > - if (folio_index(folio)) > + if (folio->index) > folio_zero_segment(folio, 0, folio_size(folio)); > else > f2fs_do_read_inline_data(folio, ipage); This hunk is going to conflict with a pair of patches I sent to f2fs-devel a few weeks ago. I don't think there's any escaping it, just a heads-up.