From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA0DC369D1 for ; Mon, 28 Apr 2025 00:38:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E40CE6B0005; Sun, 27 Apr 2025 20:38:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF21A6B0006; Sun, 27 Apr 2025 20:38:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDFE76B0007; Sun, 27 Apr 2025 20:38:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AF4AC6B0005 for ; Sun, 27 Apr 2025 20:38:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 849A41CCA22 for ; Mon, 28 Apr 2025 00:38:49 +0000 (UTC) X-FDA: 83381592378.15.C705AAA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 1814080007 for ; Mon, 28 Apr 2025 00:38:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WDvuS+po; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745800728; a=rsa-sha256; cv=none; b=VVsdmuv6wFfL8OI6IVE57tPknHvcyp/8FlK2n74Sfe3aKcq3Zx0Es+ncMT1dqjwZt6oM8F 7UckNBdSjHFwxcC+x5vZ7iNYfMJo20LPteAxKp0aLFuIq00WZUn1UFFI343YD7maIc8nZy SLsB0bf35PHnxVFi+K84Mj8BlfDMExI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WDvuS+po; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745800728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5rLvH8pJhYps2+lWBXdf1cfAWXXjRrV8V0mx0pzJnLY=; b=sgU8WtQfKpxc9fziLeT1AyKFYw8P7m4d9dQaz4jwzAIpIliv2jPS2kfI3C0lri3zGwt5NY 9kRmdTa7rQpZ8YF9egiMOMf3K/VOmLxf3jGDmL0qdJpJV2seN/y+16qRkD5wobLW+tYmS6 Ee5yF+YgqRKwhI30HDWUG5J2OV5Pp58= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5rLvH8pJhYps2+lWBXdf1cfAWXXjRrV8V0mx0pzJnLY=; b=WDvuS+poskjYdA+emKUrqk9RL7 JlB20k2foudKEG3kZdUh6hvRd9nIQtr6bV6GH13uqVPYtBNAd07hzjP465l6Y6xqaPUUZs0t0go9K xzERm9xzIraqI/nw3B968Tcek/l6jGnvR5e5k9vY68FIZWPOVrylndIOddHRFKmlS7DCE185FYUar FULkaZuctOHJIroy7avOZiS74255Zd28t6OyAhIqUZXlgRmj4PjlF6xzAn/IQk5CwOx89PHATf7kY 1m+gkpPvzip8leAoi7zETgJ9gzUyzrwdBCpweOV1lkuRwrayH5vl1hkBnb6Ty1uFFcHnDV6ldbylL i9fbwYZQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9CW4-00000004fvu-0YyB; Mon, 28 Apr 2025 00:38:36 +0000 Date: Mon, 28 Apr 2025 01:38:35 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 2/6] btrfs: drop usage of folio_index Message-ID: References: <20250427185908.90450-1-ryncsn@gmail.com> <20250427185908.90450-3-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250427185908.90450-3-ryncsn@gmail.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1814080007 X-Stat-Signature: gwaatd7f7d1e93wb4hyfp6icujeey99x X-Rspam-User: X-HE-Tag: 1745800726-389562 X-HE-Meta: U2FsdGVkX18Qks3J9+8DsZ+CYmMvcCZoHyA4JZkvPMYpW9/wTljTVNY7nf9eaUi72VghyRAg/vBgBPLgu/wxxFKrvHbvL+4C6aRzjRpwfiaVDEwzx3p6oxHS42w0olN2CJItEZphdoVmEbFFFrUmrRgceA126evqOoTj9tQmaMY8apMJqshsIkHf4BlR9NiJmR2NG0t1Fb3ygaL+Apn44eTZwX8WLDTOKkxtnxTb2dbrDBhrrWZ49o5YKj7cp7QREB4slVwftPoq2YvryxhMVVWor7ITPWv3rlsqCs1A/QQvdoK6bsunZ+GJPau2EmaHQ6VPXwzBOn67D+fUdF5v2Nw9ZSdgYcUoFoyL/5jBHMzL20TkqJJUydl1o0yU0SneiyddkkjiskxjWtwHrln11evxdXx5S73RXxDBfQ1sE4Kqk1KP92Rtb4eg/v9aylUBoYV+omuuXQ4SWvQv/AnpjeLqCqizDClCw4vjhi60xXRDjPSgdopA0zKIbMOWhbpsvl8Zi7xGOkkvLQjUCYaY41oLr94b0JYeNoZh9O3bgl83TOUyLF2c9LFR7u2Dvet9CqG1YpKD5/49+zimdrrLHGlpizGAovTUNeHQrkyac/dQzkKX9pysQ8F7ulTHgaLKcs9FAoFP4JpI1Gs6f2yB2IujaVnA3Qt9g8Mn3ilM6maU/DTSnuFVUO13DCC5pYBkb6ZZsqSpnBOKJ9PPsV7QyGQatVUi9c5rVNTwoWtMAZ+tN65OS86BhK9qwoAldywX1kn53f3H83xs+SRzg7QH2/Ragm+BbqkraMyxWHzcRjvvqABpUOHpyHJbECSzzKxqup+zYf0LaEwQuWx9MMHd0rmbHOPCams/cbO/TUL1ixanxfNaw/JCCj27wyuK6HSWMOMv9fZDpHPOj9eIQ+Ef9+InSOUlyNvxzKjfKBx+og0134AcKfBZF5jt+FG8FLcuLh6ExkSFcoMaTUVPlf7 mzhdAEAI xeVN42V7p07VoEf5/XCzu+nO/5Sujp/tmzh2ZLuSLxhlANt9Qhnb7t0p25RGTlLzPidonEpHsA8Kj0QjP3iyCIlmRpAPhh4pEwbYJReypzA7IEWHAByQc8+PaueSLQQaTzoZs/Qj9BToyvSrfy00vnTmzq7NKEEZ1Sx1RTdf4FoRycsx57nSdEqAQqA3o8HEvE11tsEiGWNGyCMh2UV4iV059zI8oQidlpjZ7+eOb6BhYacWyzfQF2HZ46pU1k/5XElIiy7YWk5UtO3Bx2EdMho0eMipA+c7rrA6XPjezKKFr8fzcW0SuSRXMsBDObONN9sH1nVyRI1GQx1PWWJyu0CE8HeFx9fAwl8uBUxvA9kbIaucyVPuYcSjU5w88L+3TPIqaBdpz71G4rW6mWvsU6eTf7wur2y/8QShlpaO+Xs0j+F9rDt9CwmMEDww0b9EV4sNBofHYO1BN7Y0cUUg7WZqtxdsZgulAje1uuWFTf36zGHzK84T4fjUmlR9pJ59R/nkfFpJNeMDnIyAKWWACm1+z9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 02:59:04AM +0800, Kairui Song wrote: > From: Kairui Song > > folio_index is only needed for mixed usage of page cache and swap > cache, for pure page cache usage, the caller can just use > folio->index instead. > > It can't be a swap cache folio here. Swap mapping may only call into fs > through `swap_rw` and that is not supported for btrfs. So just drop it > and use folio->index instead. > > Signed-off-by: Kairui Song > Cc: Chris Mason (maintainer:BTRFS FILE SYSTEM) > Cc: Josef Bacik (maintainer:BTRFS FILE SYSTEM) > Cc: David Sterba (maintainer:BTRFS FILE SYSTEM) > Cc: linux-btrfs@vger.kernel.org (open list:BTRFS FILE SYSTEM) > Signed-off-by: Kairui Song Reviewed-by: Matthew Wilcox (Oracle)