From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6549C369D1 for ; Mon, 28 Apr 2025 00:38:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 712DC6B0005; Sun, 27 Apr 2025 20:38:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C20B6B0006; Sun, 27 Apr 2025 20:38:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B02D6B0007; Sun, 27 Apr 2025 20:38:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3ABB56B0005 for ; Sun, 27 Apr 2025 20:38:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DEEC5588EB for ; Mon, 28 Apr 2025 00:38:01 +0000 (UTC) X-FDA: 83381590362.13.E91AAB5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 3726040009 for ; Mon, 28 Apr 2025 00:37:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T98fcr7o; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745800680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WwuY/6ttiqKGxuiZxXTw1pq5GZbsJP4t0dCyVGoDwXg=; b=2Q/0GlhmIsyTUgoBZGSn5b2/yN20h2PvFeec9CFQucumfAOJwfiv7t89rA0OoibDMlKZKC RKgVypDhwZEpA7w90B80HM8dk4wdDz+NWgE1k3bu6VC7d/74x+Bn7Ofes6MQumjLs5b0Fa FZPGmEk1G1hPydtyD2Cq6dbfBHn9+2U= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T98fcr7o; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745800680; a=rsa-sha256; cv=none; b=e1YZuCrCmoxWtvVBIy21+4om0/4lDJfQeEKbGrnVIF9X0q0mU+C4FtBeM2mqXJXrX1j6my J2Mzgvd0AQGlxYRDyz8FSIw0QvMeRXGiHu4LcPdXV7pcVpayJEktqLm1Gdatib+srCY2Nr pxC20fFkExSApWCsWJ3Yz3rZzVsUwSg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WwuY/6ttiqKGxuiZxXTw1pq5GZbsJP4t0dCyVGoDwXg=; b=T98fcr7okBkuiBWbdzq0KStxgu umKA8nfSz3IUntLKD9imBZ9mgjMydQgtVoRWFQa98SrZltEw4jaWcTDdSEC68GcEkGi2IalBR8f3V eGWyQ9kwIvYWbaI3Qegv4BgikQaEaFmT10qJxtH704B0V69FdqofAku90hZCFn3KFvBh4V/WkS0ra 1feaPdT1TkFkrSYxBGuGYXxoc2MpVxS8eqBKBY4K3iWZMR5sqcCcGNXFljbPl0X1w2pfov9IkPBiM dPEsfuAGULpUBPOIQpgvsp6RVdCPjmBrwDhcSQo8m00+jv8hmnS4xLUyvQUWGW7Oi2hoB6NkmTjRh xEZcWOwg==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9CVC-00000004ewq-0kBu; Mon, 28 Apr 2025 00:37:42 +0000 Date: Mon, 28 Apr 2025 01:37:42 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org, Miklos Szeredi , Joanne Koong , Josef Bacik , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/6] fuse: drop usage of folio_index Message-ID: References: <20250427185908.90450-1-ryncsn@gmail.com> <20250427185908.90450-2-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250427185908.90450-2-ryncsn@gmail.com> X-Stat-Signature: zeb96tjahy3gkme7jreqj5ycesnxh3e7 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3726040009 X-Rspam-User: X-HE-Tag: 1745800679-755159 X-HE-Meta: U2FsdGVkX18wb3l54xeR6e2ZK2V21EeprQergmRxJ1t+3EnsPnDo5I7+SWeCVVMpP28N6cRY/Hwceu7IwlCHwmCcsVY3HPowM53xWwdppgKfEfx8nlUDRL2FjaMCPB/XHlqYt9yFZ2NibzStnNUTMmGCjJxIfktOtN2BttKScbLvbxqsyn8VMiShM9LOT3C0NCjWkBkQUY5xFb8eqY9qQweFH1IRRozwiBx/EPnlrTxiry1BItFqHv/iuQovJKLShGxnzT+LMc+Y1zmTIiYknymY1SXWpV75CEmMrWT2WcnPOEUC+GN77l6xhiQj4P3B5aZN7fzWN7yR0AL+31cA9Cc1XAo6Tfa9a3+NeH4uyVXfu5ozBPmcZgjIpW8SyE0Ey8MmNgvQAdFD4Ia9dBR363XFKhwMlG1NylBulUL+1LWgeGzHbvHCyP7uj1k4qrF4qSVH70vvxL5orv/fv3y7dtNYMPQ4/JumGHTv21U1FFwH66WfthGHgfYaPtXrQkVG+1y0CaFZWsVLtFoIpA7YXixXDrLBvSoU/zzsC8wTn7SNe6svZ9D3N6a8WpngSpFCq9CjjznlkjMmmmh9+6eoky88qBY9bmbsowG3Lwubb9LWFtFsOTE2xalcmcbTsNd0L8Q8g8CkiL3fExQlOd14/4QdvR5finXHdpPqLo1Brm4of49Sr7UaL9cQWV4vTzB/ZFDtCLiq9YD/Rz8S11c76KUbMKv1yLZgf4a20eEyQeQM3eO/kRg8W+7+YhMQscvvPqPb3eEY31+TPfTkKB/H2Zk/SOIhC0Fddf5/EX0QXriVZ9Oz0xBK5ztk3VLOYVAa/LZFADrayPXqnhF7pSKQozWK4q/YKhSg73J4JNOAOA4ngF0RLsfKGKqiCJOksZlogbph3gtRK9/DtPJwYmccDe9OqV4NLavefyvfSIGdC6WgoYDI8K0ZZ1mmDM5z/WUQmq4N+Lv95A/SnW/9OEB /Ra/Qr1i RzL6VLL1La4ayENB1SIS/v0qpe40Qnkrx1HSNPuaAxxqiCECdZiJJqQKdn+jpyCrslpLU7y83rfVaTnv+HEiLzoB8PiLRV+We/rTVW1y9EqRbMXo5+cc+CDYguNLYyf8jQNHwEBAW7/Nfa0PAPu8ZRLPgXKWEd2IsWj/Hy2zUYSmQ3I4be6/1JKCSNcWoCnt31YbI1WNoqgYMcoZnimKrH4GufOFLA25y25cJW9uC3PyOjWRXv1r9LgM/B694yBXZT9nSQaGHcfbm3ZXp7qJ0nKNKTP9SCQJ4llYkxShbutL3+Fux47qDEcopIKJfuu+q4H5dzwTEYbWsK8abwNKUEfFqwtHZAiPS06GEfBZLxXfFyyPgbXKFDJq22waqq07IcncWmzGxkyfT9vO9E15IIe5IwCgxZcSYRtj4iHxwHumI7ScFEuS1uENNq/rNu2MJmrq59D/QZg5VgKFanRY+l5KPG1jI1K3/TUkPb7n+MIyN11lryRn5FsL5VENwcNMo6c9I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 02:59:03AM +0800, Kairui Song wrote: > folio_index is only needed for mixed usage of page cache and swap > cache, for pure page cache usage, the caller can just use > folio->index instead. > > It can't be a swap cache folio here. Swap mapping may only call into fs > through `swap_rw` and that is not supported for fuse. So just drop it > and use folio->index instead. > > uigned-off-by: Kairui Song > Cc: Miklos Szeredi > Cc: Joanne Koong > Cc: Josef Bacik > Cc: linux-fsdevel@vger.kernel.org > Signed-off-by: Kairui Song Reviewed-by: Matthew Wilcox (Oracle) > @@ -2349,7 +2349,7 @@ static bool fuse_writepage_need_send(struct fuse_conn *fc, struct folio *folio, > return true; > > /* Discontinuity */ > - if (data->orig_folios[ap->num_folios - 1]->index + 1 != folio_index(folio)) > + if (data->orig_folios[ap->num_folios - 1]->index + 1 != folio->index) > return true; This looks like a pre-existing bug. - if (data->orig_folios[ap->num_folios - 1]->index + 1 != folio_index(folio)) + prev_folio = data->orig_folios[ap->num_folios - 1]; + if (prev_folio->index + folio_nr_pages(prev_folio) != folio->index) return true;