From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6971CC369D1 for ; Sun, 27 Apr 2025 23:58:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 734FB6B0005; Sun, 27 Apr 2025 19:58:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E4C66B0006; Sun, 27 Apr 2025 19:58:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AB716B0007; Sun, 27 Apr 2025 19:58:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3A6E76B0005 for ; Sun, 27 Apr 2025 19:58:36 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D9F781A03E1 for ; Sun, 27 Apr 2025 23:58:36 +0000 (UTC) X-FDA: 83381491032.04.266441F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 61736C000E for ; Sun, 27 Apr 2025 23:58:33 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SeJTc5l7; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745798315; a=rsa-sha256; cv=none; b=l2mVr194B2KKueNM54ilNn/brKAltKP6bKL9Zs1V9LJGy7rZv6wpKp4csyzuv95v+aK7U5 F5DwqirvLg1IcYePbbg/5GgD4nSI6Hv2yL4pjUMWFAigROxOMGgiE8aU2wJRfgx9eWmdbY h3EUCDkecqNNV3EB6qmqOmmS2tcGKis= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SeJTc5l7; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745798315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=swz0BgbuDu4+wXmTCpilGtd8NOgXT2LX9GnpWe/lepA=; b=78IqMp2gmsj+Ubkd7aMUWI+GDV5XqpwnX3JX+qEIyI1FQksXI/rFJWCtVcjSw1HwpiJPuB QH0ECKix6STF2oLUeztzixSR0YN0aKf9bQaJ8MMnEvjzqGWF3+btWbl4K3aViwS1cg2Zg0 VJ0WJaY5siqnpFeJzu1rlOHn7bj34rE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=swz0BgbuDu4+wXmTCpilGtd8NOgXT2LX9GnpWe/lepA=; b=SeJTc5l7eLz+MUbIWk1wyL+Lw3 K7RCK1b9iME8GnXNRxgtXeq+GWnSmsi3UzwanBRwt6dcl8/2J0X67XxFBsoN82kHaeaFUpSRPW5E4 YpUyUbg5lHJpiu3TjwH+oMm9fr0c5PHOloL5HFpdZxM7YKvUwnTfCDmg0F9r5psYILxSbyd1KC1Bd Bc1pagRfmRl0DvSSZwUEpDW97mo38lghnZeNkFtTr/5gj7QEddiJB/txqNr4L4IyEmUgr4ENiK8eZ QPMQ294UKqLpmnxiwIqSwpwoKkE87u1KE0IIrVIRJ4V6v/tnPkCEpElEGA0l+xrwQOJi687PSp+zV EJACHAAw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1u9Bsy-00000003xkv-3djZ; Sun, 27 Apr 2025 23:58:12 +0000 Date: Mon, 28 Apr 2025 00:58:12 +0100 From: Matthew Wilcox To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , David Hildenbrand , Hugh Dickins , Chris Li , Yosry Ahmed , "Huang, Ying" , Nhat Pham , Johannes Weiner , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] mm: move folio_index to mm/swap.h and remove no longer needed helper Message-ID: References: <20250427185908.90450-1-ryncsn@gmail.com> <20250427185908.90450-6-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250427185908.90450-6-ryncsn@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 61736C000E X-Stat-Signature: sxyicyq7k6ghx6eo3k1q3jwxeahgk8pp X-Rspam-User: X-HE-Tag: 1745798313-198375 X-HE-Meta: U2FsdGVkX18sR5gQmIGqVsuuvADTcSXvNz3LONzMxIMe6nGZ46B7BQH6fnZyKVlru4AnJ327QYYysPrnRw7PSEoceHKULQlScfwq88SFsLDy0Pae16mWeZHtY5Eg4SU9KHPWHup1dHBqf84B0QtcO0IuLfD+woP4UCh10WSC50TXpoEReJVs1qh+PXVSafkxbW9QuGbXBxspmf0VwFoLIwB8naXTi+pCDkScdepkXDnJyQsAqgYcXwJwHyackmT9/5owCEaTbpwybF2f53g2tMV0BV6JnOenki3a3cg/pgSj/zkJtItG51eM5/34vV3JQz2HBpPNILt6k9dY+FHV4mEyZQLVJCdp+cxeEV5p+bRQdyKUmlAouboSHlMrXozdfchHZ43klPAGiDFSK2b7tgqR8J4QU8tiotkF9NjR/1LS0zWPNgIiBVB5Zu7xRTay0apviOzJFtIGSdCT15Qhdo2GmM+wbS4YPo5FoTC8u9NnbCCO7LSycvDg6ZWQGIXHeFdeOFwwlVssuZixlXLBmEdVxi1EeA6rVTQL07Ucj7WqNu0J/z5fjP7TtLf0R5TNFH/Ns+huL4aOKtbopiMFe7Z0ENdCkerqRFqCU3fhfcyScBPKRjvcgMW+PK8bYSiOhmVDbgZGbGTQYT05s8SCE35Y8Bb2fTFDck8q2r3KLz6L5ACF9L6FycsDFtU/NBJeJhu+47hb7nWI7E1doAqP+HejxnZctsHBSSRHWT0V9E9bsSA0KMEYrmBtSB5WUjlP89WIP/fwjbO2V4jAh9itLnd+hFsPsbgu91ClKVQUyflopko9tMQdbGB0XJhGjY62McWxvfGqzeoQ1nAn/9CZNxY16KgNNP4yNRddlSa7wsni6MO4vhSdj33GW8E9tPhjL4Z1cUalSuAjCLcFViWrpIVSc9dWiNlO9R2rnQWy+OCMWm9ugH42OR/nAxqxhTasWyL2TV7mpAXoUvpO2TM FC8BfD7i mL4T5aBsEtN91RlKeXbX2UUJiEKxo0X6ZCddul7CEZoZZUIJkX5ibsm3fGGfxFM6L24EG1IKV0zNwvXwpAYSIBpSk8f3ve7rA6AOJ8xqXPpANq00IDXTTJLni7URtXG1hLE+tULVZsUBihxWG7PzazFQv6zxZ5WTE0o6uH49Y5toSH1Y2SjWfoi+xJ2dyncA+2mLB4XH8/yWOavyNSuXQDJ5HggxWkRx9XN2HNRV4rGadD8T1NFS30mojAFf9KQAdDW21zHDARuF6FvKd7PoVimyDww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 02:59:07AM +0800, Kairui Song wrote: > +++ b/mm/swap.h > @@ -50,6 +50,24 @@ static inline pgoff_t swap_cache_index(swp_entry_t entry) > return swp_offset(entry) & SWAP_ADDRESS_SPACE_MASK; > } > > +/** > + * folio_index - File index of a folio. > + * @folio: The folio. > + * > + * For a folio which is either in the page cache or the swap cache, > + * return its index within the address_space it belongs to. If you know > + * the page is definitely in the page cache, you can look at the folio's > + * index directly. > + * > + * Return: The index (offset in units of pages) of a folio in its file. > + */ > +static inline pgoff_t folio_index(struct folio *folio) > +{ > + if (unlikely(folio_test_swapcache(folio))) > + return swap_cache_index(folio->swap); > + return folio->index; > +} I think the build warning can be cured by moving this outside CONFIG_SWAP