From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7910CC369D5 for ; Mon, 28 Apr 2025 15:01:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4635C6B0025; Mon, 28 Apr 2025 11:01:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40FC86B0027; Mon, 28 Apr 2025 11:01:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FEB26B008C; Mon, 28 Apr 2025 11:01:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 126236B0025 for ; Mon, 28 Apr 2025 11:01:39 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E1C981A08C3 for ; Mon, 28 Apr 2025 15:01:36 +0000 (UTC) X-FDA: 83383766592.03.8620DB5 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf16.hostedemail.com (Postfix) with ESMTP id 321E5180004 for ; Mon, 28 Apr 2025 15:01:35 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jKomr+IC; spf=pass (imf16.hostedemail.com: domain of kbusch@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745852495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cuAXcpbNwTgS2iDlnDZv3PoErAWbPS8J39IupsxBu+g=; b=DrWl9Sk2RzlNQYt/eo05N0bPxy3S39thq6Zxap/rH4BKQCSXBkYsNItbT+ZZO5iJsKC0Dk df3NqmlquX/qPY4EHxpZk1pSqUsGDRUH4SEJ/t540SGUR3aLbsaphxKwaNhmRddkFWOBJw UhjMYpD8Dhzq1bQfrbIrQRwL6cUQEtc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jKomr+IC; spf=pass (imf16.hostedemail.com: domain of kbusch@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745852495; a=rsa-sha256; cv=none; b=M4po4YKqndHcUbVXA5jK4KZ6hFOR9K/i+sQIhA6JF6Ucg60ssYoKj/R2E0FdTw0ZqECS5e PQzEawtxR00u82ggtTjUfRf6yvly+3CdT8MweWWf8bR4zG3C4TLRbyb3vpNl+fETImAt+R E7g/wMydiiIFIr8jqhCW5itLyWNVsec= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6547A61160; Mon, 28 Apr 2025 15:01:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CD34C4CEE4; Mon, 28 Apr 2025 15:01:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745852494; bh=L6ftK1YtwSLWu98J7GlkvJulgQ+u3Pn+RMrpNruh2uE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jKomr+ICxOawI2rdS0SCrvtRMfjWOcjyj8hcN9Uofmfmil44KIDpcxgbY8A2d+7L6 rRe/4m3GpyptKvl8EXKhKcuHo2ixiN6BruOJ4eII5btvDX05tka4qMe7SOiJgJhabY JBg4ACLLwa84UreJSXs98zBiqUo6CoNGYq+pMdJ0hmmpXq3B/a0WU21ZHvvzMH4Nmz RfRnyNK3uM892O8OIenalsk9zLHcpv4B/7UdBOGT5UoYLT8qWvhWkTsJ9rJwwvkXYh PmyQRnOt1o16VtOr/Nx0GqRwXCsn3Fru7pXFiCnaOnxnWfkcRnnan4zXdebn4KJD+d mMPrCSOViY5MA== Date: Mon, 28 Apr 2025 09:01:31 -0600 From: Keith Busch To: John Garry Cc: Caleb Sander Mateos , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Andrew Morton , Kanchan Joshi , linux-nvme@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/3] dmapool: add NUMA affinity support Message-ID: References: <20250426020636.34355-1-csander@purestorage.com> <20250426020636.34355-2-csander@purestorage.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: gyhqp1qicunf9z7a9scygeb7n4cfjiex X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 321E5180004 X-Rspam-User: X-HE-Tag: 1745852495-102774 X-HE-Meta: U2FsdGVkX18cv8mJ4XmEQay5Rs/z+LXul7kYwtr0KtBH0rU9DqROVfVrEU8MYwNXnpZVdHd0ScrhPkDQYoUVSfEnqnDhh49+NaVITmCk+G4k6u8ufbIupNp9wS8RtcipRhCi5l2pTCXwcwK5fIbkWyXQ8ql3/eNe60VC9SktOlz+8wRvOHpYwQoiQPaXUJidiYHKzwgBxCoWWeSxtB/LOvW50TwPceDdWfeIbjuA3n4UF7V4UB/U7KvzcaB1CKczytweICXoSGmZ3c83gzHE0gY1rYyVDsMEZGrgT8CsWu58Mb959Cs0Dw6AfGeTFXYuCtwjZ5sBVu0xcAeybsWKI6eBzNn/PL+D+O1SQHGDdqk1QfSGEOQYoHFiy3yXfgb6J36jImpwTrltu+ueeiwZKBEZblD7/cNLYrZs6bq81+OixEDku+X7kQNA0uJabLk0C8YpvbfF0IViGfLROc0GdS/fok5+fCO9aVMoWn+V8z+TDcSb4HpL0ig23yANHtuTPjMdEzQ8QM8za7IRxQQGxsr5keH7dPyNVNUQ+QHrQrGSmjuJ4nRRN7r/qAYfFQ7emjH+OSsOSjE6RMYwSXAes1479fsRoLG+9YLVrG7xyG2nNZTYn48gdbzPiL+yJSDh+sPvgEjyvBzQWwDnh0BhdgRmF8Dv+y3wZIcEKn2mu9DCFHvJ5kqzGxtTnLFKaSqTRPVNXMk/RYG2Y1FK70aeKeScfwOAgq6Fj3ASZifhpDiIed7PShOxbzmBAxFKeKpJX3K/hYE+FLCgilh/OT9sncII7YKP3+minYM+Idl7HbFrKXfM7wV7LSMqBYIWpC42d8hkrbrWXv3gtg/9Q2sHzQZPPuNo9tmNXB5eN6BTJEWpGmsEe66EBlwdC1XPIO2ljhRQDeoUsix9jhSGxGBcBgjo7D7dk8Ga2SpH9RGNOC48FG8jRvxNPtJJfSwQjrtBy03leel9EgvB5blF5FP WB4Pj4cH PoxsIzERDFsWk3OEfdapC1LmFtlUD90Tke44QufwSd0aegfn1EN6FssRd4Cv8yRlhNVkwLuX2I/rNDNsibuXMt8lBvqfkJIrUKd/T9PqdqO3VJw61O0HZ5jExpupE0R4YKkpWKGWD5OUxtSH/euTg2H6n+LWI1IdT0wVQm7v0ILhCOyK2oT2k9xLUH1LBNdv+2aBKcq4AK35jjuSpE53ZLAY6CQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 11:35:12AM +0100, John Garry wrote: > > static struct dma_page *pool_alloc_page(struct dma_pool *pool, gfp_t mem_flags) > > { > > struct dma_page *page; > > - page = kmalloc(sizeof(*page), mem_flags); > > + page = kmalloc_node(sizeof(*page), mem_flags, pool->node); > > if (!page) > > return NULL; > > For pool->node != NUMA_NO_NODE, pool->node == numa_node_id(), right? I > mean, aren't we on a CPU in pool->node here? Not necessarily. blk-mq hctx's could span numa nodes. We just want to register the dma pool with whichever one is the first node.