From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28CF5C3DA49 for ; Fri, 26 Jul 2024 09:48:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B99076B00A5; Fri, 26 Jul 2024 05:48:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B22EC6B00A6; Fri, 26 Jul 2024 05:48:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E446B00A7; Fri, 26 Jul 2024 05:48:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 73F376B00A5 for ; Fri, 26 Jul 2024 05:48:47 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 169E08171E for ; Fri, 26 Jul 2024 09:48:47 +0000 (UTC) X-FDA: 82381429494.28.AB4F80D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 970CDC0007 for ; Fri, 26 Jul 2024 09:48:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T88c7emF; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721987275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tNXBpdpHaAPRiQP5BGBw3jwgw234lu9ivUFxmuDcIpY=; b=Tx6CuppOZQ67Ie+ICVd5hX0Ktaf6OcME7EEXCr+Hw9ZcQxdAsfwFlmMNq33cJ94NGT4MfR fGjm25tsFQiycTt3Gx+DH1oSvvWDzfHAY/oQ8eAQEPQvokecCr8q4gpEybLoxsxnKqC7bm Y7HULV/pz08ngrje8wSFH/GnLRIaSIM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721987275; a=rsa-sha256; cv=none; b=fVrCKDSSKfNSefCO0OHrDT8EThkK/NnLPmZ1zGKB3U3U7dYTKcmXlWGzIlbLiX7/AayGQ7 UaJDUTxvkrt/7SlaAyn4h9YYm8LXWkMNNSTJCoPkWR6wI7xcQuTm6gjsDNx5tycaJc+NJm 9mwgq7H+7F1oFWxOzh2Y60TIIcCVfPw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T88c7emF; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721987323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tNXBpdpHaAPRiQP5BGBw3jwgw234lu9ivUFxmuDcIpY=; b=T88c7emFRuxgZtObrqzUv1w2Pnk8dJT0DXOnKDUEcZVxY0GmMSF0OFsjv13vbMQZe4HgR9 Isdd5F9GNmLMntsYo3M3b7CLQ0hOyVROpfFBPR4Z1VDJDBXGQMN7I/iNak6wC2ajIjlejp esoHA819BTdkzNWosAuw4ukHcKd3bZM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-fGyL-wTtPTm2jDaAo_otpQ-1; Fri, 26 Jul 2024 05:48:38 -0400 X-MC-Unique: fGyL-wTtPTm2jDaAo_otpQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-36873ed688dso1033662f8f.1 for ; Fri, 26 Jul 2024 02:48:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721987317; x=1722592117; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tNXBpdpHaAPRiQP5BGBw3jwgw234lu9ivUFxmuDcIpY=; b=poQx6KTn6s9x6B47RcLaFu1TVO6TTyqCuzNRXpw7JGBVbt8vr8VcOC56GSB5LlhW1k 4IsQg/69B+QtJYoBcCTHhD39Y/0Y40zgrlHV+J2Zrp+Nfp1t6FQZlVOnLZLIrCtAM/Dr lhkMbh7ytecjNMFUrXnqqs/C0YPaGynmzmdWsACajiACjkUvLx3ypCoylkQYzf15iIvC wnptquFOIaYaALO4SyLn2MaHbMgNI5+ZzlUAo1owpmcmXghi+ePrXL4wDrZFD94wn1QC jBTDloMi4rUQgn+ZpX5/4/bpXzN2qbuuRDSB8ftR/M2aUhKOKKAAs2Uea9Jm7su/vxoa mfjg== X-Forwarded-Encrypted: i=1; AJvYcCXQ4opB4i4XcOH9/2QeZdEt9OKr/5AhTdNik4D8wEnSqkbTfcq6gOKC0YxvQxAyL0cKiLCzblocgKABSmKNA7bJ8uo= X-Gm-Message-State: AOJu0YzrmKmfNi3/x9oTSe7IGt4pQoc/xjihK/iYElC1+swVZbs2zot4 p0f4aoovih6nmpBiyw84Ips8mr+n6eMgSEs71M/4Qaj/AwP7qxt+Sjq7XbLlocq+MeCE3ZyZAsz tZlTQ6pVexdagN4xggHvbON508ROVKkeVa45PTLHPYkZqE5Al X-Received: by 2002:a5d:5ccd:0:b0:368:3198:5ac4 with SMTP id ffacd0b85a97d-36b31a79a8amr3216734f8f.39.1721987317159; Fri, 26 Jul 2024 02:48:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEf+6AQWobcjTJD4b55K/yMNVCqoqBhvySVo9+0bRHYOPuwH6uLpu43Cdct1Qgx3zpmXAJAZw== X-Received: by 2002:a5d:5ccd:0:b0:368:3198:5ac4 with SMTP id ffacd0b85a97d-36b31a79a8amr3216722f8f.39.1721987316707; Fri, 26 Jul 2024 02:48:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:a600:7ca0:23b3:d48a:97c7? (p200300cbc713a6007ca023b3d48a97c7.dip0.t-ipconnect.de. [2003:cb:c713:a600:7ca0:23b3:d48a:97c7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367fc6adsm4562039f8f.51.2024.07.26.02.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 02:48:36 -0700 (PDT) Message-ID: Date: Fri, 26 Jul 2024 11:48:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: huge_memory: don't start_stop_khugepaged for non-PMD THP To: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , Lance Yang , Baolin Wang , Yang Shi , Zi Yan References: <20240726082818.260008-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 970CDC0007 X-Stat-Signature: oxwgxpkqmmgygai4shbh1rk6zu76knge X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1721987324-904270 X-HE-Meta: U2FsdGVkX1+4yxkP5Gl7WB2vtV1uFp41yaCywchVgEbH3vIG6whNqXRGDvNs0FaTUzZ51qeRgAbdr3prPH0RznFZhg8/6AkDJL/lVArbIpD1DxEad1OmuUyfj3smINPqdVpCx74urXolxBnAnrCN1rg6p8YDYj7NpQ2sXaSCwpDKwdLueBg+Z3eKdFLGKU6YaMKj1QCKFjhQLlmL2zs2MnKXp9Op33r2EiPe5xasR0JdbhZWOmxcX5Y00Ba+4FEVaJtMSYijG1iCTrfFDRFp0nEZtO2/ouGa12BJU35PJYV1H9rspwm3oMN7BcLOUIpWNqiP79Oqx1xM654kqm42t53BsqkQPVepzyzLnVBgzdn/uuhF1imX8LPu+man4c/Z6WTe2pM9qcawsb4q4i8XGYIYOt33k1ae93i96aDTOt3Xsdcxq3/9KRR29CjF6qUGEix3MZor/B4DvEtkuu8vE0aU/t6bKCHkCqA+flq1/YNaLglLnrYYI8eSgtrxszstydTwQKUFdcIOj/M/TpOJeoBE/nycg8JmXifFmWxgZznBFNqs6L5672vtXQK9iqg2UvBIvDTCbiQxAotjZhPhONcZr9ZxW4ZHjoU+sBUZCP8z0qOoi5mL4RA+aiaZJpx/Z5Y25oz+Mvsxd5KEGN3upCE6/Mf3rh1Ujj79keHMaLzngyx6NgoclPQf4Z/SfpTyg96LW8JdjymBStMNrul2Bj2SULdYaMJi9OGrIqsP7pYNrKQrNsFli8PHmpp1TlwXkdioOrkNAFme6WZnRxpcnYSsvqQuTBB3UEEx7vcW/IOrUTzLBEFLzq+4Ox1sjNtNhBMPZw16KtY6CaCf+gyaCdJ7ds8QMiZk9xBpQ3Jqb5/WXyeVruplAp/pXjJp9yH8Xrnrfc6FxKwam4p3GOtiviUhtBgfHGeX7uxS6YL7GjEOuNdikBDT/jJpfW1ZpmgBt6A7EVjZNxLE45lvEXE PsmrJutY /qjUi+AUlTvAwlZxA87yyMjwYCfYPQRIH89icbkmXWPbwzvlec02Z7ehaRDRC/TQyvrvGJqbcA5tlmk/GzViUv+CMX6vNKvgV8dLMnf0uPIAM/UfTwkufodD1gaZo9uLt9g0GJUhEhuL8rv/jy3t7PA3z417DYcPe7OWr1ntg+/1F85LXDEqjpS4gm5OCjckBTTFusYI6Ls19UGSEcUBJj205DXgAE5N7jK+q4r7LlG4ajML4yFBiSb4gpKu0KQy3Myb8nFH91rk3hClIU0fguV2kjc1PlnIN4NyxosP6MWvdINox57L9dhjxTusRnjtrZ7eXOhxKTIPSKEbuvrOnifA8qwC5PPos70nxsgTKkHrEyVDJ0yxCZBKJgPgq2Gq8ruPJSK/I7KjHhhRrxwp0Sz5sn47GFtCnduR+S3KNjLJn8OkOoGnDCjPu3+RcrVc/hAk4hSGk9g4AIqM66jl8TW+ULaBnRon+DauIeWOjKcQJpo92LiCR75BoI8rGoP986vJphzFh2Ef5a1pE49SzxRRIbuOAHjHI81Q6OrMi10/X5cKtUJTSbnTLEcst0g0nZJpc4pEYZRwM9dqwP1rgnILQrc4iwvNa++hKxKXMmY7EZUp0pGXSs/6dITUt9USB9Isg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.07.24 11:43, Ryan Roberts wrote: > On 26/07/2024 09:28, Barry Song wrote: >> From: Barry Song >> >> khugepaged will be automatically started when PMD-sized THP is enabled >> (either of the per-size anon control or the top-level control are set >> to "always" or "madvise"), and it'll be automatically shutdown when >> PMD-sized THP is disabled (when both the per-size anon control and the >> top-level control are "never"). >> >> It seems unnecessary to call start_stop_khugepaged() for non-PMD THP, >> as it would only waste CPU time. >> >> Cc: Lance Yang >> Cc: Ryan Roberts >> Cc: Baolin Wang >> Cc: David Hildenbrand >> Cc: Yang Shi >> Cc: Zi Yan >> Signed-off-by: Barry Song >> --- >> mm/huge_memory.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 41460847988c..bd365e35acf7 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -514,7 +514,7 @@ static ssize_t thpsize_enabled_store(struct kobject *kobj, >> } else >> ret = -EINVAL; >> >> - if (ret > 0) { >> + if (ret > 0 && order == HPAGE_PMD_ORDER) { >> int err; >> >> err = start_stop_khugepaged(); > > Personally I see this as a bit of a layering violation; its > start_stop_khugepaged() that should decide the policy for when to start and stop > the daemon. thpsize_enabled_store() should just be calling > start_stop_khugepaged() to notify that something potentially pertinent to the a > policy decision has changed. Agreed, skimming the subject I was under the impression that we would be fixing something here. -- Cheers, David / dhildenb