From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34429C77B7F for ; Mon, 23 Jun 2025 13:55:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2E566B00BF; Mon, 23 Jun 2025 09:55:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B05686B00C0; Mon, 23 Jun 2025 09:55:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1CA56B00C1; Mon, 23 Jun 2025 09:55:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8FBED6B00BF for ; Mon, 23 Jun 2025 09:55:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 221B2160591 for ; Mon, 23 Jun 2025 13:55:02 +0000 (UTC) X-FDA: 83586811644.13.69C5EDB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 9F7C1120006 for ; Mon, 23 Jun 2025 13:54:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ECzXMHK5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750686899; a=rsa-sha256; cv=none; b=pzM6prkDIwbUfZxpEQ8p7rYGjtme96KvLLDZAoHkX8EBmnMq3TcC2rJforvdqVNRLxf0L7 aDxG8VfOC1EJ/5d/1Jnwc4MKjPlaAsXOTm6kxtnjaoO99XNlwRwDYSTHBX0QGdz+2vx13D J3y8KE93z1BEHW5g7TfOXajTT4TG6PQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ECzXMHK5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750686899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=70+J/gMbz8ZCZvAl7Ey9hO5guUgLriRi75o2bOYatgc=; b=ilsYg9BcxRXRGwlGvxfhaX+JIC0JrBVC2SzauxVKRKut88X6pdj/OukoLKXUVeaGL6wUgZ TBAAZjhCxUYs8kxz31Dqe1hRW4CypR9UcJTdXvhnSFvITpznSa7ogVctiYTXS0sLuKkkzI FNF8ihGtzgG/GyT+bmx6c+vVn3ae6aE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750686899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=70+J/gMbz8ZCZvAl7Ey9hO5guUgLriRi75o2bOYatgc=; b=ECzXMHK5SGYzcFBc1oIJf6TjLrr10kbGKqPzWsvLkrnMh0qSXwqka4oeo5gjcxoHw4zHIP hf5TG53jjJBbiyDf8waIrJXyr0UQ48lS4JKDrQW5ufMRnAFsrX5HKBrvMwRDfO4qWiteLY JpAzV8oJ5t6nZ70vp/Y3/fMW8lcxcZQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-DAz-xpd9PtWiPmggOY9wyg-1; Mon, 23 Jun 2025 09:54:57 -0400 X-MC-Unique: DAz-xpd9PtWiPmggOY9wyg-1 X-Mimecast-MFC-AGG-ID: DAz-xpd9PtWiPmggOY9wyg_1750686897 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450d50eacafso25545915e9.3 for ; Mon, 23 Jun 2025 06:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750686896; x=1751291696; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=70+J/gMbz8ZCZvAl7Ey9hO5guUgLriRi75o2bOYatgc=; b=pLiTLvkQRLlcwB6lLd2EeK4xnJbLExPuEZ2Mo6cvaPRoN3lz+ONqP8GRT8B3CF/Jod IQHFbf76OqV+eXC2QDleLg+q9QgcPwYJU/qevqCFHjpPDj+MqlscbtcgZK05HTevjt2F Gms0ADjYwO9LUtd4/1aMqxGcKlbR/I1EfYWkYWwoEAHjFoa2Zw2hL1K1m5b3xdIolOEm ommNAuG3xptkuu1RsYKS5NQ2np1SCJuFC8fl1Iup/sUUJgtc5gITLgosxKH8diPR3ujv RuJvzth/HOIy7R8+QbC9ivmDst3GUDf9eVe2vT1T8l3Q/UBV/uJNy0je6jEd+/1gjc9/ pmYw== X-Forwarded-Encrypted: i=1; AJvYcCWIJjSDZNX0KqeGULbnkP3J5RK9a5rWKePLVoodUrOUHSe3eBscOv62dmRmxvj03itGxTxhS3wcPg==@kvack.org X-Gm-Message-State: AOJu0YzN4jU5IyVWPh8u0yO5b30t2wUl2PT0Kzqc+9Z3xCv+VJ+j0EoP oajVr7IfdUfT379Pez09P1BbKYQifEs7+kNDmjkkQc2YNFpuTtbHsX5/wzSE/eM9Iac5/bafMw+ DstBIhLNd+lnyMP/8hvsAv2XGA0guOaXBo+adesP229COVGsxzotY X-Gm-Gg: ASbGncvKJboRJsKChx2ZpFhE01guBmHlOVulYIuw9E/n7Gqs1pl5g5XtAUlOfP9bCXI sLO69RIaBwJYvBDcz/KopTWVrQ15JvkWTd996vUxCMZnkthRlCzykFvy21qiFsnlzJcOf67yUza Niqm63W2+/miXYsYhPJsSEZsZ91HUwwlFqsNMSJooamMtI9MBcjbn5AhTHtGEeHPwBxX7jPnitK 4f+6K3xMvfww3XO34M1uUDzkDQAoPwf4dzjEbywniRNCKGIZUwyfMQ1NlRkFPX698rZnZA+44Dc V3eYy4UCx9oeZPvHvBpPMQGth11dwWPEtM3reCGr/j3BvS8P2yppnoL575BwSXgfxHC6qb1vmQE nUkAqzmJVzJCQ8iz2Cbssyfja2C1RXejGPjW9QxKl4wr0C3DQeQ== X-Received: by 2002:a05:600c:5026:b0:450:b240:aaab with SMTP id 5b1f17b1804b1-453654cb3d9mr113371585e9.8.1750686896485; Mon, 23 Jun 2025 06:54:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEoDrVvSmhOk8zkB/mwB+LCVJOjk4JiZvBSsPfG/6DKJqAC923crnrLYg1vUkWqpKe0DiLBHQ== X-Received: by 2002:a05:600c:5026:b0:450:b240:aaab with SMTP id 5b1f17b1804b1-453654cb3d9mr113371395e9.8.1750686896142; Mon, 23 Jun 2025 06:54:56 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159? (p200300d82f4efd008e13e3b590c81159.dip0.t-ipconnect.de. [2003:d8:2f4e:fd00:8e13:e3b5:90c8:1159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535ebcecb5sm146348905e9.37.2025.06.23.06.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 06:54:55 -0700 (PDT) Message-ID: Date: Mon, 23 Jun 2025 15:54:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm: huge_memory: disallow hugepages if the system-wide THP sysfs settings are disabled To: Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: ziy@nvidia.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XaX8eIn8q6Cu8I7X0WtI0cESZwBmeRWBrjfLLMoIhGg_1750686897 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 9F7C1120006 X-Rspamd-Server: rspam10 X-Stat-Signature: td1pemramp91855qzpk3h4xjd5psnxgk X-HE-Tag: 1750686899-8901 X-HE-Meta: U2FsdGVkX19WmXCBODO0Uzq2NofHHpzWRWJ9Hn+o7EKH+vc2PcLGQxsqIMgO/P2piDYUO5DVM9Y2NxNN5et4gpJpHo+xgXUZYuaKUHt87CRs2JpHuTww4ACSlVshuDnh7ZB5duzb4gcHXPnOwMRf9EeI2vXaJZLC++4JgSsz40ykLLcdBdArka4YtpusLpRklYxbrZBd+P/vn7J/1hGppkqIKHAUl/oFQtbeyTGBp10dyR6Hg9dKCAWsEk9R6LzG6+ud5UMY2XWo5YSdLe/YgxiUWhFKZ9rdMvsX2GVqMSAz2nDDTxbk2sJ9vjY9q3cMuvsDGGuSF1KBEnqeK/4MBZQF0U4hq8zj0i3z+ct3zj/rDfhIWme1sL3ITuc753C9+yZE+LrNB6c6i1cqC3Xd7MF7msPMZ2zzkXpoimdYcPSQF8+8eDR3EVbU85/triroGCo2+y4OY9rPlUiO+5SutHzk/UsdIlAK9bIqJMqoin0MDGm/KM7RYYXaI8ZsS1N7sfU1rDiyUFuA6w7ndMVH8BlIJxAm55aPUMxjsfeFaU1TEq4MlSWsDmAkgWEzOX0JqD6oeYorytxq/dSfF79s7AavaQR33NvIegKfAU2EuQ/CCBVPcNVOQvRFxHnhgfc7MK4D9fHx8PJKSiwvqjUdfHBb3d+0Lo4EqqUVDiFRjNAzM6CaqxTUvYIo0552IIbokVqb9WbSgppNam09bS+1A4ZgbI2Nr8P80TyOzX9vc9LmOdlCAFfIPGS9+DuA+0Z5EArlLHv64bQvbHenG18FWtzUiYE6WZYO71AYrQrjAwQv5Z1mkQSNLA2hSGzIyQUcCMBP8WnoWHlf8yrafSKASmzwEJopxVr3EVipiPF9LXGYumVzcgUt/IQcsPndysDFQaZgu2q8HWNQlHX3Q42cCSQ7oSr5FhCxBtN2weB94NsBw0Von66+HkSPLev57itAkwBZggw2debAO7w+gNP K6637ARb DfGdbUco8xVbzIWnm8cl+LcRHbAwgT+H3YC+c2Z6A37rz8CEOx833e/j0p2uhZg7DrlD0QmlRnk6wRJqHhaAi6ixhCXQbcxyS5fxyEHODbISrHrx3+aKq80JnVHXOiH1Iy6pw2F18GI7IBfZj5LtJMSqnhPgCBaZtN1FQ1ASLrnUNANGqf6Vv+1lmVCMcIgX/f3cC1d8mPBI8knl4LgHzli3AwxGdAJnxsn+BYg+piBuiXefxc5thA7i2UchoctDYj3usZlEeKT4czQkGpxM5MbYOw/ChogVT0OSgF0sQaf0eucFJvcCAhMBl7UIvgiw9iWSfCevzHExB7IRpogo85QAzDslXNHepzfqoaUyHri0PJLqrfinfBRT8L/1UUQZYIMJSFHk8aWJjezsWYfIWZ2D5faF7ufLqvRSwFT3xTfBGBEoxa50EXBfbWRKtcEGxj+/RckwLHbNlq/I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > diff --git a/tools/testing/selftests/mm/khugepaged.c b/tools/testing/selftests/mm/khugepaged.c > index 4341ce6b3b38..85bfff53dba6 100644 > --- a/tools/testing/selftests/mm/khugepaged.c > +++ b/tools/testing/selftests/mm/khugepaged.c > @@ -501,11 +501,7 @@ static void __madvise_collapse(const char *msg, char *p, int nr_hpages, > > printf("%s...", msg); > > - /* > - * Prevent khugepaged interference and tests that MADV_COLLAPSE > - * ignores /sys/kernel/mm/transparent_hugepage/enabled > - */ > - settings.thp_enabled = THP_NEVER; > + settings.thp_enabled = THP_ALWAYS; Would MADVISE mode also work here? If we don't set MADV_HUGEPAGE, then khugepaged should be excluded, correct? -- Cheers, David / dhildenb