From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 476E7C48BF6 for ; Mon, 26 Feb 2024 16:58:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3EDD440183; Mon, 26 Feb 2024 11:58:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AED7944017F; Mon, 26 Feb 2024 11:58:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9195E440183; Mon, 26 Feb 2024 11:58:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7F99B44017F for ; Mon, 26 Feb 2024 11:58:45 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4CF961A08FA for ; Mon, 26 Feb 2024 16:58:45 +0000 (UTC) X-FDA: 81834564210.09.CEE7BFC Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id EB3F980010 for ; Mon, 26 Feb 2024 16:58:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jcYeMA68; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Q/Xv00rl"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jcYeMA68; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Q/Xv00rl"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708966723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l0KFPjXNqVsEqy2ySF8st8aX9aaAa1NXHzLxm/9qX7E=; b=KBFIuEl1e3niyiaxRZxf8HqXA5VVcIsHm/Bu4FaSqtlik+cthEbLelB2w5teXF+VQ3zsoP wXyrIgBN1dMT66TyKDYh1M1g29cqMoNsfkxiFe9iAv+a+sudn5nTRa4mxqvQc5Mhf3wdu4 0SJcLdvCXvhCrHyaf1gzmzLSJxAfZFQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jcYeMA68; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Q/Xv00rl"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jcYeMA68; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="Q/Xv00rl"; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708966723; a=rsa-sha256; cv=none; b=E1y8mhoBRpX2W+GkpBJX3jab9uQiZX1yLazZaZSWtiGVDZa7baBGXYbN86E/bxsbuY/YsB dPXl8E8dmx3CLPM8tNJMhxxdaFsXZjUa5wF5fvrJ9j2NYCbvqrW4wum+F5XlKO9a6wriba fogkTUGwr5VSraoWohvMcKKyzqkWYMs= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1B335225F5; Mon, 26 Feb 2024 16:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708966721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l0KFPjXNqVsEqy2ySF8st8aX9aaAa1NXHzLxm/9qX7E=; b=jcYeMA68fIDBke9G63XYDHgm8r7rC8tM+xa/Jd9ZUVyLmCWWjabOr3q1eQCqkPp8AXYygU B6gQn18Om2KAhCXe4PdV8gb9C03jZeMWnTF7c8/KmoT48mw5r5Fs8oh4z7Va22fcqWQo2R 5nb3sre7bhuJCoZed92SVCBqLCLRheE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708966721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l0KFPjXNqVsEqy2ySF8st8aX9aaAa1NXHzLxm/9qX7E=; b=Q/Xv00rlXZFJgefrppCuzXJpBCyRFGwXI/qhd56LD39Ty5Lx3SkyuS3agI9PXyjpcd844V kHbrGV8fBOAd1zCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708966721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l0KFPjXNqVsEqy2ySF8st8aX9aaAa1NXHzLxm/9qX7E=; b=jcYeMA68fIDBke9G63XYDHgm8r7rC8tM+xa/Jd9ZUVyLmCWWjabOr3q1eQCqkPp8AXYygU B6gQn18Om2KAhCXe4PdV8gb9C03jZeMWnTF7c8/KmoT48mw5r5Fs8oh4z7Va22fcqWQo2R 5nb3sre7bhuJCoZed92SVCBqLCLRheE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708966721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l0KFPjXNqVsEqy2ySF8st8aX9aaAa1NXHzLxm/9qX7E=; b=Q/Xv00rlXZFJgefrppCuzXJpBCyRFGwXI/qhd56LD39Ty5Lx3SkyuS3agI9PXyjpcd844V kHbrGV8fBOAd1zCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6763713A58; Mon, 26 Feb 2024 16:58:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5Hq7GEDD3GUxGAAAD6G6ig (envelope-from ); Mon, 26 Feb 2024 16:58:40 +0000 Message-ID: Date: Mon, 26 Feb 2024 17:58:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/36] lib: prevent module unloading if memory is not freed Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-14-surenb@google.com> From: Vlastimil Babka In-Reply-To: <20240221194052.927623-14-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: / X-Rspam-User: X-Stat-Signature: izqwsw5hukzat1rrx3dctpzj7akj6wyb X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EB3F980010 X-HE-Tag: 1708966722-760029 X-HE-Meta: U2FsdGVkX19c+mwIgVjXj6ME9ZAWStMjs+zpoSUp3JONks+LEhMYoakAneiSMkaTvBH2lLP8pYE5dm0pIduVcpjK82WNR7SeOvWIgfPEQMHSn0jnLpyafKnPwOsZPEk1vXfadukL9SgWgvXMmEjc5xg3xtrmyHpJaBtlujt9Fmu3BuQwmWbD5wIHoXQ01vS3d0voNhaWdZm8VuMEZRhzLD+6WMHVNM7TeUDREexFpGzQP0gfikREnVU8AtjyN8eqZeUOFNObd3pTb4YTUtcXD1A3f6vQbg490GbiV4VNJ0TVSS2cAzTcX7CCSK0C0GJzXqVyNz598a7snF2m8iwhRttORdk0Dl7BEANzYYs+YJ1xxjqHDOQJmxP9FqM9cep1DiZpO22em2BAYyJvpDAUaeevra+VkMYeDeKwAoFM6nenOjzwA1ziIfCHl/2aHHp0zGhggGwAPay3jW/IeU0xVXqYwgEUf3NftZZ9UIyj9MMjmeerzXDFwEGkWJR5otRJfqWbNPuEntrR22egY1/6FMhyl0GEbcYq244y1jFKmOba6B8pltyfdjCDqnih1KIJK+yt5GDrKijwVlkUfe7t+4ylN2il0VP547qAXOj53lPVIDGKJ9SI29aB5Dbe4o1vKtXZ47WjRThDUjitG5/HnmAjqTzu+g6J2Fb3ZuJAGwFPNJpTIkv8RZUp3H+MdImygE3s3O80OzlHtXm9Q7zzXPYEeD1xjQbxtuUMwyqlNxPkIFM29lJo5di9uAFjBWNabGsODx2/YoC6Gs0CcWxU5+5t2luHZcchZjDX0rjrgKNFcudJ/JM0W3y4Qk7BHTS5cii1GuIjmuBEONiCMY0ggizkHR+F3cJyZtwJf5KIBRMHEZeuoVMh935emvoIJoHQuIsNN/IfhPsgDz4o1cgdbyQgXF2PqM6XjrfwliCX8WZpkHgBKEdFS52l3DxzA5T9kQ9DzlujFlwSgsm80Tk nVak2sj6 oj1d+aU+/SN7gdYjaSRg/1CNzGJKyf4c4WWom X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/21/24 20:40, Suren Baghdasaryan wrote: > Skip freeing module's data section if there are non-zero allocation tags > because otherwise, once these allocations are freed, the access to their > code tag would cause UAF. > > Signed-off-by: Suren Baghdasaryan I know that module unloading was never considered really supported etc. But should we printk something so the admin knows why it didn't unload, and can go check those outstanding allocations?