From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6428C282C5 for ; Mon, 3 Mar 2025 08:52:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56A05280024; Mon, 3 Mar 2025 03:52:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 519C5280020; Mon, 3 Mar 2025 03:52:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39447280024; Mon, 3 Mar 2025 03:52:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 17B76280020 for ; Mon, 3 Mar 2025 03:52:59 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9C7C9160500 for ; Mon, 3 Mar 2025 08:52:58 +0000 (UTC) X-FDA: 83179624836.08.3934C3A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 36D914000A for ; Mon, 3 Mar 2025 08:52:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JmBURwUz; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740991976; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L2Teo9Rbchbz42+Q6lAs3ttlkWMO9/zXQmWUHGDFFeQ=; b=tr0JfPO1dyIBikIqMN2kebAhNss057Ofg14yMDJpMPPqJRC9A+uloWookSxT4NoBkKjEW8 vzam6en1MdclH3OMLkdzZlXX4HrROmj1YDNha2fH4TkHHDYmdQVWgSEtOeIzWJtps/v8Bv DgrAhuyzIC9ZgIMF2uxFCZmdAk9e6b0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JmBURwUz; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740991976; a=rsa-sha256; cv=none; b=ogVcb2fSkz6aSR7efh8+LdfL0hEFpvT+tG8UWVIYw8PRuJNoWIpxhTCEkpej81w7+h5n21 in96kiX1QJDz98+j2A8yB1FWGHOMyaeilX8tJKtT0vwBGPEFQ1+aEixtKFQLiRO6+NdIv7 z19MlMDegvmHUK5vaaMiY+PQmrrDGJc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740991975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L2Teo9Rbchbz42+Q6lAs3ttlkWMO9/zXQmWUHGDFFeQ=; b=JmBURwUzwfixrmPoET4XYy+6LM1GDy89illrXgEIsGOI+CA8AhhXV9SWZ7RhQpcQ2TIaJC HEdiaC2cpduv3C768NcDGW8fz/KGXPJH/FzAn+EHYil4A/D8VGMNuRwr8ibakyvz/Yu42D RHg1qw7/voyfUDno1eNicD/QThpMzpI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-9pR4KGONMf-PRLxR5EyomA-1; Mon, 03 Mar 2025 03:52:52 -0500 X-MC-Unique: 9pR4KGONMf-PRLxR5EyomA-1 X-Mimecast-MFC-AGG-ID: 9pR4KGONMf-PRLxR5EyomA_1740991971 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4399c32efb4so21769935e9.1 for ; Mon, 03 Mar 2025 00:52:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740991971; x=1741596771; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L2Teo9Rbchbz42+Q6lAs3ttlkWMO9/zXQmWUHGDFFeQ=; b=cA8xS9EDAYU6W6Hz8FpZgaz2RHjLnOonJW9Ypt6SHsPrFaR4x6SZZWTsoGJ1wLC7Qa +ppolY+ROR6bSt+NIW3FVQRxV6QPV5g6rQFbeZsBAhpQG8u0L4/Tw+jyDtV+BRxyY31V Zlt9PgP8bOEnFD349bc8tahKdEpOS6Wz6XlPm/4oytClzrFKnW9vbycdlEhxVmdDlzjf hbMYJ+bG7cXOjSfGC0E41FdFU5sl1zCCCVIB2GvysLDER+p+P0idPlMfdVvwFw7TlrCV phEckPe3IVBFY4yt6r+AblQq2KJE4K/cp15mCPeWdihYKyscNLsfbs6FPy0BvGV+lPQo Wldw== X-Gm-Message-State: AOJu0YzE0Djj0h1yrD+s3aAeoVs/NCSqbDLE1VjeI48KKhAiu3iVoMYS /zJLdMRfBkULWAhT0khHYD7MbXSPKY/vk6FjI5sXYxaXNkwjzxaIIp5EQRE/6Xi5t3gW+froqYE rWK3ty2Of3567B95cLy/lEmI++zgWDu/IcRIpwu0vYuWc7ZlI X-Gm-Gg: ASbGncsie1n91jyLpFn0iJkm6OCSPdshhcOvrmD5oUWG1KU6ULxrP5kXI69HFvaRPpZ fhBG78b5ct0kw7qdJClhAgc8Uaf0wYvLS44JOalCSanJg4lqaxjb1oR/Opa6BZGsdtkuvT4TwQ3 eGKYJnm2RJ1+Btg9NASugPGzocYakANvzggqsi2WilFPbzn/Mj5woX4ztOb2P3pd8Up5kOcSSzY nkEbkjziErL+NV0NS33lQiSXQ6cauxU0ZuI/UwlEjrmM3ozupzWr1/gCQjczEqa6tMrNWsgv9+q +hlI3x66hRcIOckW2P+CJQiTtMZKUCE7VmMfDQ81apWCN2j2GiM4CnoxaQDacFsfqBW0YpZlAZv XtvyPmyNHM9vAsSAjmAKEvPar9r14t79zfl6yS24zytU= X-Received: by 2002:a05:600c:1c9f:b0:434:9e17:190c with SMTP id 5b1f17b1804b1-43ba6188e94mr94869065e9.0.1740991971265; Mon, 03 Mar 2025 00:52:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlTwiOKza9n0r0V0jJ5URyFDI8eh36wv7IjAnT7iFLb3kZ3OtN1WSRH/ph1nyV3LFOLXmlUQ== X-Received: by 2002:a05:600c:1c9f:b0:434:9e17:190c with SMTP id 5b1f17b1804b1-43ba6188e94mr94868805e9.0.1740991970936; Mon, 03 Mar 2025 00:52:50 -0800 (PST) Received: from ?IPV6:2003:cb:c734:9600:af27:4326:a216:2bfb? (p200300cbc7349600af274326a2162bfb.dip0.t-ipconnect.de. [2003:cb:c734:9600:af27:4326:a216:2bfb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43b8d6bc3fcsm122643735e9.0.2025.03.03.00.52.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 00:52:50 -0800 (PST) Message-ID: Date: Mon, 3 Mar 2025 09:52:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] mm: Fix lazy mmu docs and usage From: David Hildenbrand To: Ryan Roberts , Andrew Morton , "David S. Miller" , Andreas Larsson , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Matthew Wilcox (Oracle)" , Catalin Marinas Cc: linux-mm@kvack.org, sparclinux@vger.kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <20250302145555.3236789-1-ryan.roberts@arm.com> <20250302145555.3236789-2-ryan.roberts@arm.com> <5418a661-dbd0-46e9-8ef7-b1c5a34acce3@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5418a661-dbd0-46e9-8ef7-b1c5a34acce3@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: attZ0yWVDR4LTc487RzxGcHZeaqk0uWUNG2MNFuS1us_1740991971 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 36D914000A X-Stat-Signature: 1b77po4igtmzqzpbhdxn9xdtn1cognq9 X-HE-Tag: 1740991975-324645 X-HE-Meta: U2FsdGVkX19zfcJboiQz+hA3joJK4Y+pfMj5GBm/huuQBFqSoaFnxMYvlWLXZY3Pl5M/TboXx5oWIpdVFGTd6DZ4rn2VTPKjpy+QeL3UK7UruJ5ZXlzINlwVpf3DrE5GHKgQ+qHCpPPsb+/xyvgE2lXGmUQnnp7+uqDOh/G7OJIJ90vRIM9xHw1cPxFbNsaSJzCBjoBw6bs0g02Dqp+TTjGlA05e+R97bS07MdR+vCZGnrhCS+QTaFYbRkdESitKew5wRG1scvnGCjboGIN2Jpw/Ym05fBJKi9WfV3BhxsZKYZRLUXQAdz+Cm4hHVrqM0QaKQpJ9ATAJyJv2gmLU/xP8D2+ruJAtuJZEDbhR7A1Et82j+AlNXddBNbEtuUoMXV4mnkHABRNZORZD6OTjmab4rN7zqo5Xpb8gmp4xJ2JPkwQm+pPzZaUaNtqOtgkK2VEqh8dbIM8Wq949vGmkgKkv7lc9W3z4qTIHSWjKxhuJJBns8KTqihTWillduXfdGBcptvmlCvHSwOvFSgG55I/82aQK+ph6cCZx/ROmBhl7X7cTzfUU/urKiSSTsSNvN6Xv+O+VymsAVYpTY1dSewBHzYzcsLrnxsqP2jKmNmU7MRZy/v50MJ/P3RI5DInzAvKclNjLvmcdgZ/zWYYOj7b3LnL2AMME78lI8XLv5WuYCRudy72qxttWypWnNpjzbOrH6rs/v0ozQ9/rm6Lyi72VckmsgZMxQ4S7g/L54O0Fgm4MUHakxbOceSyrCA1kSaDiDrd6Ps6j6ZEL2aQmIeVdDLW86ZbB/5Rg43fjMxWnhcVVIcrkkcsHPIoFuY3rEUZLYJCFQpemoluyAWYWWviWi2qPg4POpy4AbOOAFc7QZ3Edd4Tyl4bHp8oykynWPeUHd5J23xvaPzhRmFgb7GC9hegSEilpem8uOrPKYQvzu7kqm2kuaSv4baIGU0urSHuuRpIghNYx0ojKKxf M/9Y6fPJ Mbdm7eKrp7Tf9YLKaadHCohfDijwq61HyFZAi6A0Tbf33MIqAAWBFG7Q0Q5xolXVpWxAaC81+nYKUmYSH4dABIhrR+vhMzPnCWncNMVqVdxLBgG2Sj92WIDVd0MtssnT8Xfe/CZhc/fiLsSNvEdQq2F9ikQU19kqmsFjQvWyn3wi32tOUHYkRvEOor/FTjtnLBfb3//aWnrM5u2Ke57Tp8H9cWfP8wrawvU8C/tmBhxGMSDMyboL12SYhtdAbj+X+5j2d8R8BA0/Qe2xriFXFH0v9O/KLSX6A4NCYWQ2zF3sbdiDmK5P7Fw0NeO1Tp8nkRUx0EEuOGGVlisYTVRnBtUU4P+Zm/TnbBj32kOrO5gIHPt7mnGPghFzO58ahiAOStLihZbMd9PlBpKAvWBAbcD8o6FO71+TW1nDq+VBiCRuLjFo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.03.25 09:49, David Hildenbrand wrote: > On 02.03.25 15:55, Ryan Roberts wrote: >> The docs, implementations and use of arch_[enter|leave]_lazy_mmu_mode() >> is a bit of a mess (to put it politely). There are a number of issues >> related to nesting of lazy mmu regions and confusion over whether the >> task, when in a lazy mmu region, is preemptible or not. Fix all the >> issues relating to the core-mm. Follow up commits will fix the >> arch-specific implementations. 3 arches implement lazy mmu; powerpc, >> sparc and x86. >> >> When arch_[enter|leave]_lazy_mmu_mode() was first introduced by commit >> 6606c3e0da53 ("[PATCH] paravirt: lazy mmu mode hooks.patch"), it was >> expected that lazy mmu regions would never nest and that the appropriate >> page table lock(s) would be held while in the region, thus ensuring the >> region is non-preemptible. Additionally lazy mmu regions were only used >> during manipulation of user mappings. >> >> Commit 38e0edb15bd0 ("mm/apply_to_range: call pte function with lazy >> updates") started invoking the lazy mmu mode in apply_to_pte_range(), >> which is used for both user and kernel mappings. For kernel mappings the >> region is no longer protected by any lock so there is no longer any >> guarantee about non-preemptibility. Additionally, for RT configs, the >> holding the PTL only implies no CPU migration, it doesn't prevent >> preemption. >> >> Commit bcc6cc832573 ("mm: add default definition of set_ptes()") added >> arch_[enter|leave]_lazy_mmu_mode() to the default implementation of >> set_ptes(), used by x86. So after this commit, lazy mmu regions can be >> nested. Additionally commit 1a10a44dfc1d ("sparc64: implement the new >> page table range API") and commit 9fee28baa601 ("powerpc: implement the >> new page table range API") did the same for the sparc and powerpc >> set_ptes() overrides. >> >> powerpc couldn't deal with preemption so avoids it in commit >> b9ef323ea168 ("powerpc/64s: Disable preemption in hash lazy mmu mode"), >> which explicitly disables preemption for the whole region in its >> implementation. x86 can support preemption (or at least it could until >> it tried to add support nesting; more on this below). Sparc looks to be >> totally broken in the face of preemption, as far as I can tell. >> >> powewrpc can't deal with nesting, so avoids it in commit 47b8def9358c >> ("powerpc/mm: Avoid calling arch_enter/leave_lazy_mmu() in set_ptes"), >> which removes the lazy mmu calls from its implementation of set_ptes(). >> x86 attempted to support nesting in commit 49147beb0ccb ("x86/xen: allow >> nesting of same lazy mode") but as far as I can tell, this breaks its >> support for preemption. >> >> In short, it's all a mess; the semantics for >> arch_[enter|leave]_lazy_mmu_mode() are not clearly defined and as a >> result the implementations all have different expectations, sticking >> plasters and bugs. >> >> arm64 is aiming to start using these hooks, so let's clean everything up >> before adding an arm64 implementation. Update the documentation to state >> that lazy mmu regions can never be nested, must not be called in >> interrupt context and preemption may or may not be enabled for the >> duration of the region. >> >> Additionally, update the way arch_[enter|leave]_lazy_mmu_mode() is >> called in pagemap_scan_pmd_entry() to follow the normal pattern of >> holding the ptl for user space mappings. As a result the scope is >> reduced to only the pte table, but that's where most of the performance >> win is. While I believe there wasn't technically a bug here, the >> original scope made it easier to accidentally nest or, worse, >> accidentally call something like kmap() which would expect an immediate >> mode pte modification but it would end up deferred. >> >> arch-specific fixes to conform to the new spec will proceed this one. >> >> These issues were spotted by code review and I have no evidence of >> issues being reported in the wild. >> > > All looking good to me! > > Acked-by: David Hildenbrand > ... but I do wonder if the set_ptes change should be split from the pagemap change. -- Cheers, David / dhildenb