From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB0C8C25B0E for ; Wed, 17 Aug 2022 02:39:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C15A8D0002; Tue, 16 Aug 2022 22:39:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 470A78D0001; Tue, 16 Aug 2022 22:39:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35FF58D0002; Tue, 16 Aug 2022 22:39:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 270BF8D0001 for ; Tue, 16 Aug 2022 22:39:52 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E20C01206F2 for ; Wed, 17 Aug 2022 02:39:51 +0000 (UTC) X-FDA: 79807529382.18.CD532EB Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf15.hostedemail.com (Postfix) with ESMTP id 02A95A0068 for ; Wed, 17 Aug 2022 02:39:50 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4M6sbH0kpzzkWM9; Wed, 17 Aug 2022 10:36:27 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 10:39:47 +0800 Subject: Re: [PATCH 2/6] mm/hugetlb: fix WARN_ON(!kobj) in sysfs_create_group() To: Muchun Song CC: Andrew Morton , , Muchun Song , , References: <20220816130553.31406-1-linmiaohe@huawei.com> <20220816130553.31406-3-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Wed, 17 Aug 2022 10:39:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660703991; a=rsa-sha256; cv=none; b=8eDpEDylR6OgBQ8Y0hcrA97eBFkWGysWuNkv03ZiW64kBx+E3gp+kNlGjF793aygBddG/q 9cdxCkLOK4GGNGLRGHOqO7lArRglBZ/xiGj8ZTFzxzrG4suultpqn1zts7fuQ9k7JcNEOa ULia7gCI7Y4x9b55em9z18A4IACJleY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660703991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TAFBYd1pmYGmQ9xT9jBk8gSmaLGCtqNWZK0hWJwLedk=; b=YpC0XVADxbQW8ph/wa74jDxx1cGYqFbMlYqJ8nL88RWxtKCLGagIYUtik1LtafQcUN6QG5 tElBudrjhY6i1YTg5hQ8NOTOjaRxWV4E9jTghSPVrrtcievVK10117ECCxGcPWz/jVtsFo 21Aq0ki3+LD39mrsQ8Cmd2ZGa7ENS9U= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 02A95A0068 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: h148tuan7s6xzujkhtwo3bn14e469zpd X-HE-Tag: 1660703990-545404 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/17 10:31, Muchun Song wrote: > > >> On Aug 16, 2022, at 21:05, Miaohe Lin wrote: >> >> If sysfs_create_group() fails with hstate_attr_group, hstate_kobjs[hi] >> will be set to NULL. Then it will be passed to sysfs_create_group() if >> h->demote_order != 0 thus triggering WARN_ON(!kobj) check. Fix this by >> making sure hstate_kobjs[hi] != NULL when calling sysfs_create_group. >> >> Signed-off-by: Miaohe Lin > > It’s better to add a Fixes tag here. Will add it in next version. Thanks for your review and comment. Thanks, Miaohe Lin > > Reviewed-by: Muchun Song > > Thanks. > > . >