From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD8CEED616 for ; Thu, 12 Sep 2024 15:44:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BE836B009D; Thu, 12 Sep 2024 11:44:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8478A6B00A0; Thu, 12 Sep 2024 11:44:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EABA6B00A3; Thu, 12 Sep 2024 11:44:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5047E6B009D for ; Thu, 12 Sep 2024 11:44:24 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 115B3160E50 for ; Thu, 12 Sep 2024 15:44:24 +0000 (UTC) X-FDA: 82556508048.07.DE4398B Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf04.hostedemail.com (Postfix) with ESMTP id 1AD3140020 for ; Thu, 12 Sep 2024 15:44:19 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=AZSFFWL5; spf=pass (imf04.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.53 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726155806; a=rsa-sha256; cv=none; b=i3z1V/t+tvvrobw/WC8U5kXTQwaYYXukI94yq6rTVXdXwmNqr0B2K/3LrFl1DlGCyNhh+5 Dvs4gyBVnKI51CsRVVKnRa0TqK6gQY0DcbL9vL4J+1XWu8i4G9Ms3WLI8BznfE+IzVFs0B C+SL8VeXr03nWvinXg0dq4H13VALUaU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=AZSFFWL5; spf=pass (imf04.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.53 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726155806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/xzJmJZir7SNhkzAEWBQK9iRI0VrPUIlmQ6Tc4M2oLs=; b=a3VrNtU1NPrIY3i9kYNJS956RxYpIlV+AfPbhXgnbHS7Dy59G/VTrgFpnnu5qEc5WcK9yk oBMDoxtsJgX7+9lHEChhoRkS3p3t67yms8FIa47BcfER73eMvrMfarTjwpGFOTG4+Xrctu S7Pa76CkKOHfjfG7sVYWFrjgz0rKCtM= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-82cdb749598so54838439f.1 for ; Thu, 12 Sep 2024 08:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1726155859; x=1726760659; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/xzJmJZir7SNhkzAEWBQK9iRI0VrPUIlmQ6Tc4M2oLs=; b=AZSFFWL50k7NrFSefh+/1d4Qm1Uu4tV++bcqdWb7MBA19W6gpATE1rM84jvJ5kHRoD EoHvHmFMrGfcpk9yg7xlzbISQGBRAl28gE2VbWcIYDR3dHzbnPRfIwajuCxEJx7d/afX PHjwDXPNeOFKGGouWwQvsC6aqwzLsW3NqHb+0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726155859; x=1726760659; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/xzJmJZir7SNhkzAEWBQK9iRI0VrPUIlmQ6Tc4M2oLs=; b=FTHPFgkSHmy9t731SCCqMtPiLQzriSLSgw+0kswQhhJIBlK6v7o+qqgCtlZx/RiZNf L8oiYrpQD/W08fQ0TTCpVyRlCiGPe3OAugbZD5KorS6IQGGWfBYNUzMdWHf5NKALnGds zBMyju1SRj6uryPQHRKRorMSstDClbJnvJ5s6L96ebtEa5LPxaJ8nrt+d+Jlo5OgzXjj +hC0Ys68Ebb10yQe2nluuNvdp6/FyaaobeLpzTCBCWFbJKR0oSK1wYKZE6GG5LyBHCqt yvoPTJG6hE4ImHumbroaLmgwUvKWc4f7lKcf21FfVtquRW2o9qXBJtZHAzjUk0HqWhnv oZ/g== X-Forwarded-Encrypted: i=1; AJvYcCWW5Vonfhzbc+TOioxm3KClQEQRZtT5VrT/RDzVEBEtoI0nH48ckprDDlkhyvcrAie8TQrNwJW0Vg==@kvack.org X-Gm-Message-State: AOJu0YwQc6YHW/tzAjneWK6ggv6moATx1DvdPHjgQn50QiM8MTsarFUO P2VV/o3Ds//u/yuZVQ/OD8A+k0tbu9ANySIpsytbrX8Bn20OudFa/4IxTozT8YM= X-Google-Smtp-Source: AGHT+IG6esSlE2W6kArjZrA67ckcdnIzOt6LyndGjqyPFo8xbm61PKfZ5ht422I2fxHXzRSn5KH60g== X-Received: by 2002:a05:6602:2d93:b0:82c:bdec:1c0e with SMTP id ca18e2360f4ac-82d1f8b3d81mr497735339f.2.1726155858844; Thu, 12 Sep 2024 08:44:18 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d35f8ed815sm654814173.142.2024.09.12.08.44.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 08:44:18 -0700 (PDT) Message-ID: Date: Thu, 12 Sep 2024 09:44:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] kselftests: mm: Fix wrong __NR_userfaultfd value To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan , John Hubbard , David Hildenbrand Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240912103151.1520254-1-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240912103151.1520254-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ohc395ty7ey7uzcrqpezwirg6hmqf1u1 X-Rspamd-Queue-Id: 1AD3140020 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1726155859-154553 X-HE-Meta: U2FsdGVkX19arFnq0MxDPVpFtbBk33iVRALuiBJ72YNhBIbkHYOZPt/Ub/xmgp/lw9Hf0Qz+xHE3uMgS3xwZSM6JdBM6pAU5NsNTEE/EJVIUj+qvMhR8Sm5JU9df2LC9UWRtDmP890ybtXegnBSpReqRYv+ubTTZ53a9hePuMDuF5x9yoLbPwTV6sj1praUzTOUB7r2g5sbmFdhTMkx0KA4ohalSN2cVCmjoHXxgZzU93Eu8Vq4MsjPCX8Muwnzfn6zM8bnWcKC/V9k2ySaW9cUyT+wg68Vo3ps8KRSrGt207Pihsf3bVrdEm53rH1YKInye526ILQbfWhxKyPqVcIDRFfRX6siH0ZTeOkf6a8y8fhzbhES3pHaNJG98BAHs5kOC5TFZWIUGdCZcR8xA2fGg6TfbUK15dJLT+QNTGI3gSkJILWmmppQDl1HnaEfkT9zMzQONjmwoeAMmqqrkLMcBd83M/lNHxOCsyFKezuIToJMn3zKtBNzkb57O2gFRucz092/6xhiFqQYR7m+BsBPlCsnc2MEQRtqCNH/fDUKpxaPTojNyzoqYRwUP38bZWiMHjNpDeVeqDiHZZXlkIfurbO9sIeze16L4+qxWWWIoI24wKQxLfgJu4orZ4zua2+FLlbi+3D1dtljRirSTG/+OwFqlUXWxqxCvpgjoC0g18Hdc4TK7ZaxpEzQylTiBqRk8goNQaUE5TuPCmpAFvj8rk0jP/2gZCexrnMFMns0msrIPFqdGfnpkAA2z0XExPmqLASF9DQnO6Hvw9U/1rYADYm52FhtIY4LYRJZDrGoEX3TXE8K1QbY5kuJ0Ddzs8TZdKnyDlY6on1kcTGJ29ZAnZzykIuFcBEnyM8F3MaZmHV6W7ELBBUh9z2IFXk07lAcRiQsb3vLUFI36t7E8eGju66nYskojlCZPMnupnFo2R13Qmr5uX2+Gn/UY5NfZl5DMnRQcR786ME6IQqr n13gpS1r wXAMTt6ULdPWHcIDIEm3A/RPcB74mPuqtR5Ahq5519FVLXTq7S3u4rc3tBvTTf59LM5FWXH8wy0dHbPbUdBIYQwcYEo7tvUc8Xc4m3Bln+nRGnf5TNtV45ZVBfcO9WOiBS8bUfHcQUFCop964HQkKkZxcdqmgO4IekSiWcMSz0vEzlEhH4shpT+B8/79XCvxiuUK2hjPF8n62OEhGIdUTCLJbz3fjSPV+wRkSiEKN2J35LXhHpPU5FgbXo0FnN208EcwXqgct/msvR4xDp4QfjlNYyIJPMjXwyedXrTEXOS1kM9HPDP2Axue/VObjl9V4yZiRxVtiFbECNg2YfcS0CDqn2VrO/wB6xs4QrkRxV9QmHwiTy5ORvo79vySiy/RjOUpgarzrW8HFbtItMAPFP/HUrG0NpFkqz2efRLHSZZcmMKbBlZe9xNOwR/AVenx8ywuL6h596/PM0ta71TREsRySUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000220, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 04:31, Muhammad Usama Anjum wrote: > The value of __NR_userfaultfd was changed to 282 when > asm-generic/unistd.h was included. It makes the test to fail every time > as the correct number of this syscall on x86_64 is 323. Fix the header > to asm/unistd.h. > "please elaborate every time" - I just built on my x86_64 and built just fine. I am not saying this isn't a problem, it is good to understand why and how it is failing before making the change. > Fixes: a5c6bc590094 ("selftests/mm: remove local __NR_* definitions") > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/pagemap_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c > index fc90af2a97b80..bcc73b4e805c6 100644 > --- a/tools/testing/selftests/mm/pagemap_ioctl.c > +++ b/tools/testing/selftests/mm/pagemap_ioctl.c > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include Also please generate a series with these two patches with cover-letter. thanks, -- Shuah