From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F75C4167D for ; Thu, 2 Nov 2023 11:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DDF68D0089; Thu, 2 Nov 2023 07:49:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58F0F8D000F; Thu, 2 Nov 2023 07:49:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 455B98D0089; Thu, 2 Nov 2023 07:49:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 376348D000F for ; Thu, 2 Nov 2023 07:49:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EA88580747 for ; Thu, 2 Nov 2023 11:49:54 +0000 (UTC) X-FDA: 81412845108.03.7ACAFBB Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 08361C0007 for ; Thu, 2 Nov 2023 11:49:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=SKVfTG98; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf22.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698925793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=baE1NJC2GfKa3jymwVwu7JViQnSuC/OsG7D/SDjGWtY=; b=0VdgknXM0HkXdGbz/HEC0SXechcuhJ/3QZNfrDOjRmJwNc0VyUhQz0b+DjCfi8PDe9eP1V R6K6o9O4YYuY/01CkqO9i/SkIv6eyKwn6R6+oYyS0D8su0K9fvAx8lFfJ0KICfk9lQWij7 QXBhtpxoKzZl/SX2bYbq7lUbJVGcsBs= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=SKVfTG98; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf22.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698925793; a=rsa-sha256; cv=none; b=nlNbDB23C3VNc9yYbXUpVAhl07gDNIjHQsX7fQS25PzM6tlPQQ+9V/d4xP5addApJfC65K QLypCozI2DEZJXZrOuV9ELhGm9BljHq5AaigTLUt+EfZyrhpGPtv3HZQNFEW6wmRH01Ktl z3bJtT09LMmCyfViuf04JcXIz3AL2BQ= Received: from [100.98.85.67] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 35E696603102; Thu, 2 Nov 2023 11:49:44 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698925791; bh=DnwHAYWfAm3XZipZksuQGXF6sjFyFFaQUCgEARzx934=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=SKVfTG98EttX7MvGf7/J9/7o9DENZJm5T53wD2AxQHucm9rfKzRBoLdUq3eaY6Tyr nnW2hbmTZGZOE+Ob2DHwLFU1t6+jthHUubGWxwLZqGB4y6PDX2m50UVt0zGGV5pvl5 yZT6Il+zrTYuFrtEV90z5JjqR1TyVyR0dj4QAzohaVpY6Av92xVj+0X4KeGTJkoNs5 G/cYlPaAliy5FnwOTM2qFGRkckMwrSJHdpuB7HJb96c6ac4vobTiT22EEtPT0vvb/e s7OGvqe11DzO6W0Ru0v87mDXSHdbEUCQd4Cjeknr2FndxH67JxejfM/xMbbrjLDx7e /wm3YpqUoO4yw== Message-ID: Date: Thu, 2 Nov 2023 16:49:41 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com, Cyrill Gorcunov , Mike Rapoport , Nadav Amit , David Hildenbrand Subject: Re: [PATCH v33 6/6] selftests: mm: add pagemap ioctl tests Content-Language: en-US To: Ryan Roberts , Peter Xu , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WC?= =?UTF-8?Q?aw?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman References: <20230821141518.870589-1-usama.anjum@collabora.com> <20230821141518.870589-7-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 08361C0007 X-Stat-Signature: 156ff8n7omjy1zjne3n9d7z8ss185idr X-HE-Tag: 1698925792-564843 X-HE-Meta: U2FsdGVkX1+IBw1T2lFA8K1DzNwQ8+r4N67FhY2PkbML7il5ossRJ0CYfLEnsV41cmySPO54p2xVzbUtbACazL3Yu3bgdXtF/FEbzSm1WkeE5R1RV2pSwbtB7ifKBhMVpJ1njYNsDqgrXLGQp2wH05Z+zcrtnePOzBP+KWCU+nXqbX39vSKWOrAmGjngBWH//r4IgLECr1rq0OXy8WMd2L/0ed/Zb5XncGl5Aajd/eXzkRomFOpKHFS7xKxUQDsRuAMYBDmaTbTLt9EMI6t/dDisyB5qsRlrggweRJys+X5lU0ZGfkYlOcqCObcQnRgdSDqxVuwYGVx5GNuX6FjVJqQM4A9NnMk1up8uOVdrhufO7KTCpMobzESvm6g0LEGehbpbwE8Y5q6eqokolgEgAA4c4F+IFEWO7dUBV5G9kmIZFpAIkK3WvBO+RTuTTwoT9JFJ3q89yi3JWMDEeEkB7IEx/NMcoC/QH+FJWMVhl4NCKaMORGL018Jwgmnnanp1n6retXXYG2ldDdU2aJmBWBv4GcQeJ0lrwNP/ZzLa4F6qLX+s8PMUEqLKnZH1Ltwzy0PUvsDcvbU3dFOtS6ZseGTWWiYTS6PNo2f6oRHP48tf5VTMZzePu3vfGCN85AdYGYAsd4BSvVhckvw0OWbWyfk89tvVsREzfG3KIyDxhNUKLhRXU82/rMRbOnyA76LCvai2Z6FsycJMoPjNemUVyG6P7bQ1GXvzKih135lWRPaBoc93s5LK45DWhyVOlXkxZAIW5Jf9AJYnI+SAUZZutHKUkrTqoBnQ4Bs55I26LatNFwQlm+4+hFRDMI2vZtsqXfWLrWOSkY0E+R0wznfTgzgNtVgvf4QUicysj42XE29L1sE8xe+BwACM3biLIZPlmHHfSMXilTO5cjtQcnTyx4WM3qyKRggMNSCoe7lKdgaHORqhLjbx5tBoGJG69JUJf8ayi4qOIvtGzyLcyu2 XiC9FYos u9ruDiYRuXeuXyE5QU4hMO8HXdTR5e9eCXn2OVRSM8lk1kYMWo7YoAZhBVXWHXdUpWv9qlACtcGvLgpPFDwdYm/yOvbvetHy69psVcLY/cf8dDr4VaoLxuIEt6rnKG1IgNRaoxWfg1iAVnl384ozhKIhwRzjMHoz+/noefSuhPd5wKSq7C69BbQLYGEA8GGJ8IkVsA8ArUG5dv+hRNOjKEll+vCIyP2525xAMTkJlz7z1VWqoYdOnB1j5Jw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/2/23 4:45 PM, Ryan Roberts wrote: > On 21/08/2023 15:15, Muhammad Usama Anjum wrote: > > [...] > >> + >> + >> +int init_uffd(void) >> +{ >> + struct uffdio_api uffdio_api; >> + >> + uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY); >> + if (uffd == -1) >> + ksft_exit_fail_msg("uffd syscall failed\n"); >> + >> + uffdio_api.api = UFFD_API; >> + uffdio_api.features = UFFD_FEATURE_WP_UNPOPULATED | UFFD_FEATURE_WP_ASYNC | >> + UFFD_FEATURE_WP_HUGETLBFS_SHMEM; >> + if (ioctl(uffd, UFFDIO_API, &uffdio_api)) >> + ksft_exit_fail_msg("UFFDIO_API\n"); >> + >> + if (!(uffdio_api.api & UFFDIO_REGISTER_MODE_WP) || >> + !(uffdio_api.features & UFFD_FEATURE_WP_UNPOPULATED) || >> + !(uffdio_api.features & UFFD_FEATURE_WP_ASYNC) || >> + !(uffdio_api.features & UFFD_FEATURE_WP_HUGETLBFS_SHMEM)) >> + ksft_exit_fail_msg("UFFDIO_API error %llu\n", uffdio_api.api); > > Hi, > > I've just noticed that this fails on arm64 because the required features are not > available. It's common practice to skip instead of fail for this sort of > condition (and that's how all the other uffd tests work). The current fail > approach creates noise in our CI. > > I see this is already in mm-stable so perhaps we can add a patch to fix on top? Yeah, we can add a patch to skip all the tests instead of failing here. Let me send a patch this week. > > Thanks, > Ryan > > -- BR, Muhammad Usama Anjum