From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D04F0C6FD1F for ; Wed, 20 Mar 2024 14:21:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A97F6B0088; Wed, 20 Mar 2024 10:21:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 233196B0089; Wed, 20 Mar 2024 10:21:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FCBE6B008A; Wed, 20 Mar 2024 10:21:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EE6F96B0088 for ; Wed, 20 Mar 2024 10:21:42 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C2787A0591 for ; Wed, 20 Mar 2024 14:21:42 +0000 (UTC) X-FDA: 81917630844.22.97EC87C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 8308640015 for ; Wed, 20 Mar 2024 14:21:38 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710944498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sS6ZcYxNWvp78s1cP9mGaiOSeT6AChxv2PewOuoBVKg=; b=dwO8QlPBX9vhOEq4Y7R3Tu9Sju+Ef9sm/7n8SpEksvW5GgAPJVcHKtE1sbxyje7/qdnonV u+hDcIr8LQE13XuzFmYEkn1tY+2XphB0xiDw03+I6PvSsIZy/2+WuK19A1W6bgPmQPlkxV UMov+UU41drIV/EvMeqZYAhi5mOkyng= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710944498; a=rsa-sha256; cv=none; b=0iYiofFIZvZwQrJgdH7FDbSefWsylUwJ/0IKwmlO8EwjnfYH226uqLEmoD3UGJPmwYbeDV 3zblGaxC3V7fRZNMvkaVer0XdRBwgt2xtnd90ka7SN7XG+jCiV1UXnTrebRiT5hY4AbuuU 1Cj/pPaNz9fjlF8XdnJmwierGW7C730= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D9401007; Wed, 20 Mar 2024 07:22:12 -0700 (PDT) Received: from [10.57.72.78] (unknown [10.57.72.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8029F3F64C; Wed, 20 Mar 2024 07:21:35 -0700 (PDT) Message-ID: Date: Wed, 20 Mar 2024 14:21:33 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] mm: swap: free_swap_and_cache_nr() as batched free_swap_and_cache() Content-Language: en-GB To: David Hildenbrand , Andrew Morton , Matthew Wilcox , Huang Ying , Gao Xiang , Yu Zhao , Yang Shi , Michal Hocko , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Chris Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240311150058.1122862-1-ryan.roberts@arm.com> <20240311150058.1122862-3-ryan.roberts@arm.com> <42ae8cdf-2352-4bb9-9b22-aed92a2c9930@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8308640015 X-Stat-Signature: zuxf7c6nkyb8ebqxcfstz8naiyhwsbcb X-Rspam-User: X-HE-Tag: 1710944498-725838 X-HE-Meta: U2FsdGVkX19PBnuLqy/jCXPf5QaBZOV6Jjqh6BguSbndauuYeDfDJZQqsc/YnwPWzwUz/mS+X2KZKNzL0n9HIDPBpogGVBsYPW6YugORnFL/qK3nJjobdCi5YI/PT8yqjoBGiWMkcNKaq+eMsdPxnczORd+4NW8J3TUstiwq0B7Y0+qObB4VswKhLrZUERrRP+eGJjkXIidIIVUb6kgm3iIwLwjnw2yFYzEYhCHeNX4wcyIqWTIVrC+e6eqL5bTRgwcOudQqFY03/Q45R/xQ2YzDnTOUFvYF+eHXR7/koN0wHfUHJ80kGcbAomWER6xEj3PKuNhRyq+VGRml+5zr4i5I2W5skhjq6D6jX/LEBi7yyRanhnntbZxf4sa7ALXSqKjbC/qWqTr+/1vlgInDSOVk8Rpq4ufArYhHHMZClZQm1MWqtUvQgHh2DorXKJdEh/C7m+JAiGqiZALwVaSvoREAKwlwUFwAeGXXN7qT5YPIucsD+8VIZyHIWHdtB4To9fr+d+xUjGEdWcJh1FqF8gWsXY8N62/wNFV4aVM4KEVJXe6L0JGU4S2JS4QVlO6/cJLUWnPNjoWOSFyywP6s8PJieGjPnnDjhzKWL44qPgkqsuvzIvcMztII5Y2kYnRK0oxKYSOZoH0bbJ99gTf0tf0pAdcP7nIYM6Re20NAoUTMRfG7iV5EVUMhdENPOZqYzOtScmPdb6uHWHS4ml16/fBPcNimwRwjmi+87ejEkID7HMSp9FQ4JLGOJ2P6K/WwDxblnSE2ejwWheTIQJtP3uPBZ5JCiM9ZnqY8YMXQQC34WydS1eNMuRIp/RuU3MlK5xkSmsi+1NgOj+z03a7QZ1t2K7xEZfziz6o0PyS1MIzjGJw5CEpjeO5E8Q8UCc9IyFNsQtT5TCT4X5tKq/QUIvmJeVd6AZc+IsEMxKeSY3/zAnJRvsvX/BzRqFi/IlljnZx1CvRBsfvXPfbtM7z QaOrrEuz 5yvgWRifzmYiAYYmyiaFv+9PMMuWijg/uE3uFeKmmLrHXgU+owjIe3Piqcixyl7bhhzQe9oUwxFhOkdOKcFIr+Zguyg9ffxJsmNW1jMcJ9/7kJzLHK+Fo4sWTmSGC/FeslBXK99oSSI6xBWg/ZE/y5MSz92gvCap02u2FPMUMP8GDBIl5f4VW+ZQ6IaB+T4SgxWKz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/03/2024 14:13, David Hildenbrand wrote: > On 20.03.24 12:10, Ryan Roberts wrote: >> Hi David, > > I'm usually lazy with review during the merge window :P Ahh no worries! I'll send out the latest version next week, and can go from there. > >> >> I hate to chase, but since you provided feedback on a couple of the other >> patches in the series, I wondered if you missed this one? It's the one that does >> the batching of free_swap_and_cache(), which you suggested in order to prevent >> needlessly taking folio locks and refs. >> >> If you have any feedback, it would be appreciated, otherwise I'm planning to >> repost as-is next week (nobody else has posted comments against this patch >> either) as part of the updated series. > > On my TODO list! >