From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C53C5B549 for ; Fri, 30 May 2025 11:31:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18DE96B0098; Fri, 30 May 2025 07:31:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 117506B0108; Fri, 30 May 2025 07:31:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F21136B010F; Fri, 30 May 2025 07:31:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D3FE16B0108 for ; Fri, 30 May 2025 07:31:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4F6A4E802F for ; Fri, 30 May 2025 11:31:34 +0000 (UTC) X-FDA: 83499358908.19.783EAC5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 143E080006 for ; Fri, 30 May 2025 11:31:31 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M0J03fF5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748604692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Orz1dWpWTcwglQpXKN+jv23Chiw8dD36FoK1Cob7nM8=; b=d2bp0VR/wKM+T06aIs2L6W8zhr3p+ctu18m62ue9TPh1pcFpHD2g+oSZJR6CVSGeKO+t/+ CV7Umh4jECOdDMLJ4N6emtm/80YYckVxIRPHw4JA/5UpNaJV55q3T0NgSiCL36YJ2pKGmP jkO+cu/VSr1gLTIbdf0+edakmr2eJ7s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748604692; a=rsa-sha256; cv=none; b=x5TVXFhPqLv6jWHjTF7H3aJQzrtDA5oAemCb7BltGr5y+B+Sy9RK89+KQDHKWfwT4eIhvI o2ho70+laxzWgqe1wwDzWiP3FlI7EMX5isZOnijTNKOUbdFzJL+HkXSOhgDeqneecQuHqr qRlFbCpuxg5djjI3dv4p3CvMh9Meiss= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=M0J03fF5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748604691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Orz1dWpWTcwglQpXKN+jv23Chiw8dD36FoK1Cob7nM8=; b=M0J03fF5NaAIYbPwxFPcBSBCKKA39XKIMi3VWeKsyemAgWhKrcnZfntJW7qz1VeuyYvNN4 zCky68p+rr4S3C0rsg+eRVfC+WbreTJh3rg/qqcOV02RKzrGBaAjEvuWwaxqWw95ak7N+v iTcMDO6dLZW90bHPgXgEVfd5EDCHz6s= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-wD-S6y8BOvWC6O7ExWsJ_Q-1; Fri, 30 May 2025 07:31:30 -0400 X-MC-Unique: wD-S6y8BOvWC6O7ExWsJ_Q-1 X-Mimecast-MFC-AGG-ID: wD-S6y8BOvWC6O7ExWsJ_Q_1748604689 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4fb87fa4aso7698f8f.3 for ; Fri, 30 May 2025 04:31:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748604689; x=1749209489; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Orz1dWpWTcwglQpXKN+jv23Chiw8dD36FoK1Cob7nM8=; b=qu3fu1nuDMRaKqLX3O+zOXj6bhw7lrhUEn1qxkIar2dhp0mYlfY+Kw7H6VPlTIq6aH 2ZRFBQ5VAzilmp29+c5rFIXtQlWk7bfQBk62BWsJVthkigHzSbZeIZOVfV9aOBprFKXj Qjbx4kra2RmVRIb22lK9NXjb8xelwDmytWEUVkViT8ep6ydI2Ys3w6WtY7iZ/MKuA8iv MpEHtgayixgitUcWBLsMtoRK8H0F9mOQklbmuJuzQSd2ktkC0ap6VFv02leApLLvLbEQ PPobp+ukLgwqo6B2/wAKF9ZPaaunDU3EUsgUdoMJG+oLn0kFOefB+pah29X/FrBhhyiT 8BiQ== X-Gm-Message-State: AOJu0YyaP5FZ588xZdzRH7V0Nq2n+Z+r0/nZzlA9ZtFxbb7K72o2ClBI C1dMLYOPHmkzA0qR2h+O/F9EM2Va0ZHsRTxOK7m1Awh8AyoWKEFWdeUIG7eUlsNEgBBwvaC4E0e cuPeNespwZP0wTi52+VuEWx3OjzsNeOcOkvT+7goyWIEPkHINeYZv X-Gm-Gg: ASbGncvuxETZIdcC/CYaQqhthNviBIjBYgK1BKrQylsfZhoUz0SooYON3VyR8ttTdg/ oDovW+JmqdaafmnhSG+2Xg39MiRYXp1karDcbsvVOafy8rl0cv26OaVGTR1Iu1iZjpmFc6oGIGP pWa26Hl/+6EksCGA+cWZ+qN0h6lPr/JdwQwOEmZqWUojUxynNNL249rYf1hdz76EmiD9Ju53rMN UUSVRoiJogY2QV7J8STRG26mFeb2NrZxWvNKxTHVNbRkDo8fgTq7sSkhit/CG13AJ01h47Dt4+W xksNHIkpVRxSXf4iHjPEFFxHHHfgrDmkN7ckPyMScDlZsKu/7/ZX X-Received: by 2002:a05:6000:3103:b0:3a4:dbac:2db6 with SMTP id ffacd0b85a97d-3a4f7a7cc6bmr2273587f8f.49.1748604688811; Fri, 30 May 2025 04:31:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZDnNkUdD63iYQNSW3yhDVRuYaPmbfBT7vwGZ6v3NIFmHsNuBFtcvU5wsfPEEdUS1v6VlRYQ== X-Received: by 2002:a05:6000:3103:b0:3a4:dbac:2db6 with SMTP id ffacd0b85a97d-3a4f7a7cc6bmr2273559f8f.49.1748604688361; Fri, 30 May 2025 04:31:28 -0700 (PDT) Received: from ?IPV6:2a01:599:90b:feef:9de7:67cc:305b:deed? ([2a01:599:90b:feef:9de7:67cc:305b:deed]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450dcc18a80sm3196965e9.38.2025.05.30.04.31.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 04:31:27 -0700 (PDT) Message-ID: Date: Fri, 30 May 2025 13:31:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gup: optimize longterm pin_user_pages() for large folio To: lizhe.67@bytedance.com, akpm@linux-foundation.org, jgg@ziepe.ca, jhubbard@nvidia.com, peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, muchun.song@linux.dev References: <20250530092351.32709-1-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250530092351.32709-1-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZvT1ZahOuPmBHg-enW9PYrp3BelFy0JGRF1Mf0oPbog_1748604689 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 143E080006 X-Stat-Signature: 53c31tkfzz53j6cxk5k9j939wyxne1xm X-Rspam-User: X-HE-Tag: 1748604691-657686 X-HE-Meta: U2FsdGVkX1/D1VZ6P16bJFlMSAkPgOt6/WeZoNmBd4mQqJPd0smE0BzgfTTmOYH0ak0nPhnz3v2uYVMdfYLL4z/Pol0ISSJpZ7Dr1X70wzCvZQ3Ev5O+qVg8AEPQGwzK4e2jO6Kr9c2xsvTMaksosMkc+eRPws5EKXpV+UCDkzJuModcvYvITVjALuF+7Qx9AVP3eLjNCzwRACvzOfTnqlEP4e6M0f88jrTNhuQXtuNeZp0v16T+4Si/GKy1rMAGLflQl0Vn3XaE9xDgPdeEt/DAxNdOm5M8HzYCkJ9A+3tm6decIQTvP6vf6TSeE4RwjK+1RtDd5OJXRNE4bhb4D5vRDl6A2ufydmtivKvUhvMipucpRiWsztsexKwgS6gCgHL+75Y4xeP5RiHitDvMGikTxaEKJhNY0dSA7yxWVkFksfew07TZVOJ737cHF6Box3JkVl2MgSSrBi7D8HFi/wLU0piwLF+COSiBqZjNxeoFLET5hR9PAzfVKtszFvZjsaihF/f46FnP5j285BgZPccg6xC5VCUqsm9UK4r9lyOXCZrMUaEn/2x07CykLAHSxMPozn6wzx0M20HEx/4mHxJbj5SlP3MrWkmNUFUV9vYdVW07aUBhBwMPWyaOYNXw01VDl6fAWYv1p8P2MYHQ7T3M/Qn3xQWgRBT0wb6so0URrqRHP9AzeTqeeta5r9LR5NTuRyS2AywJnLGMYQ4n9ttcYJv17jEi0i3DPA4PRY9X1dSr+LEfM8xbjvvQAoFcbPzSUGFaGoDkTt5pR4Fk4vyBF4Z41o0yBCsbhdvZ0P1H9Th0qGDILMAVMorJ0dniZVtJadWIVsUwV1J2aAKBG+uHqXvvejEfxgdU3EU9ZmJu6XLOt3SZqPadYFtvIhXOn6I9OjruA5/ljjSdDyLMyx+y+pva28st9UwkUlENmi/cMcepN0lVu4P0OzDeyU+DFpI9t9Jzdz69EYhDT/Z 3RWlk8+b J22/vapriAbb1GvLVU1JmbM0K4mZeoTrb+6FQINnztraI059yNvjttZFtU2rR4pRtH0gqa5dBAwMVApoH4r+ZwDpL+TpNK9Cj0F6kVtd+PPCj3hUPWjHy7EE1FA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 11:23, lizhe.67@bytedance.com wrote: > From: Li Zhe > > In the current implementation of the longterm pin_user_pages() function, > we invoke the collect_longterm_unpinnable_folios() function. This function > iterates through the list to check whether each folio belongs to the > "longterm_unpinnabled" category. The folios in this list essentially > correspond to a contiguous region of user-space addresses, with each folio > representing a physical address in increments of PAGESIZE. If this > user-space address range is mapped with large folio, we can optimize the > performance of function pin_user_pages() by reducing the number of if-else > branches and the frequency of memory accesses using READ_ONCE. This patch > leverages this approach to achieve performance improvements. > > The performance test results obtained through the gup_test tool from the > kernel source tree are as follows. We achieve an improvement of over 75% > for large folio with pagesize=2M. For normal page, we have only observed > a very slight degradation in performance. > > Without this patch: > > [root@localhost ~] ./gup_test -HL -m 8192 -n 512 > TAP version 13 > 1..1 > # PIN_LONGTERM_BENCHMARK: Time: get:13623 put:10799 us# > ok 1 ioctl status 0 > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > [root@localhost ~]# ./gup_test -LT -m 8192 -n 512 > TAP version 13 > 1..1 > # PIN_LONGTERM_BENCHMARK: Time: get:129733 put:31753 us# > ok 1 ioctl status 0 > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > > With this patch: > > [root@localhost ~] ./gup_test -HL -m 8192 -n 512 > TAP version 13 > 1..1 > # PIN_LONGTERM_BENCHMARK: Time: get:3386 put:10844 us# > ok 1 ioctl status 0 > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > [root@localhost ~]# ./gup_test -LT -m 8192 -n 512 > TAP version 13 > 1..1 > # PIN_LONGTERM_BENCHMARK: Time: get:131652 put:31393 us# > ok 1 ioctl status 0 > # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > > Signed-off-by: Li Zhe > --- > mm/gup.c | 31 +++++++++++++++++++++++-------- > 1 file changed, 23 insertions(+), 8 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 84461d384ae2..8c11418036e2 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2317,6 +2317,25 @@ static void pofs_unpin(struct pages_or_folios *pofs) > unpin_user_pages(pofs->pages, pofs->nr_entries); > } > > +static struct folio *pofs_next_folio(struct folio *folio, > + struct pages_or_folios *pofs, long *index_ptr) > +{ > + long i = *index_ptr + 1; > + unsigned long nr_pages = folio_nr_pages(folio); > + > + if (!pofs->has_folios) > + while ((i < pofs->nr_entries) && > + /* Is this page part of this folio? */ > + (folio_page_idx(folio, pofs->pages[i]) < nr_pages)) passing in a page that does not belong to the folio looks shaky and not future proof. folio_page() == folio is cleaner -- Cheers, David / dhildenb