From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C047EB64DA for ; Thu, 20 Jul 2023 09:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6D602800E7; Thu, 20 Jul 2023 05:31:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEB1128004C; Thu, 20 Jul 2023 05:31:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8B6B2800E7; Thu, 20 Jul 2023 05:31:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AC16328004C for ; Thu, 20 Jul 2023 05:31:55 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7D10D14023D for ; Thu, 20 Jul 2023 09:31:55 +0000 (UTC) X-FDA: 81031473390.14.55ED866 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf07.hostedemail.com (Postfix) with ESMTP id 246D640003 for ; Thu, 20 Jul 2023 09:31:52 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689845513; a=rsa-sha256; cv=none; b=Zp/VueCEXS/hrbjpVmO+x0KoWQVlterecznOQLk8MffOchyMj/EITr4pziI4AgiGaYsRlm HLU9qXGyW/vNwDWfHRKcyCbycjEbA4VQ6F7Dq4sG4QXavlT0WRAvC15NYpAuGBvgLCbEf4 6abu230uIyYuVORto/x3Q1PglNx034g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf07.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689845513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRDvdc8e1iZo3Qo3P8Xns/x2iSwX0zvxaWcd1w9CJ9E=; b=uB6cyEuWqS2NCyk8+SnWAcBXs/IY+p5mI7+1UivryJpA7+Ck+DYdm7mZZK9PaCJAkrpkl+ bTOb/8hQLDZC1Vg+2TP156R/X7T3O0nwr+uMs/G8/j75EP7awfkCwM5PSbfBUVmpwuuIii ojZAbiIeFh/TJVf+JlzRQatSa9n5jIU= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4R66r90jwJz18LQR; Thu, 20 Jul 2023 17:31:05 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 20 Jul 2023 17:31:49 +0800 Message-ID: Date: Thu, 20 Jul 2023 17:31:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 From: "zhangpeng (AS)" Subject: Re: [PATCH v2 8/9] mm/page_io: convert count_swpout_vm_event() to take in a folio To: Matthew Wilcox CC: , , , , , References: <20230719095848.3422629-1-zhangpeng362@huawei.com> <20230719095848.3422629-9-zhangpeng362@huawei.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 246D640003 X-Stat-Signature: dkriaeagbkx4c7wq9nrbcsgusjj71i6x X-Rspam-User: X-HE-Tag: 1689845512-214063 X-HE-Meta: U2FsdGVkX1+PFFOr2olsbjh4am1dluUXQOGvNIGk6Sc/xHh6NVdybqYGhjCy7qSrYOKlnktscslE1vPKFtyC1FsPVZGRqeF0p/jlD170lYzySa1ztKtIowTaBjBvn0ojb6UHTkIOLolThJYvxRuMKf7BVT1QCHen0N5WhVf1GYEfulE02YSLNV7oyrJlAwj+LmBohoCUnCHXZIPujBzoEYIsdxM/BEYfaw0DhBE71NL0VrVmJcQ5YnaDds+Ai75JGzqdKgB+DjXdtO2S2znglpLRZoJqzSF7YnYq2sMrWa3T1IfjCFHPQRChTgZQ0kSY31YtDQMGxpNARf2c8NLmUhQJ0CUlqVFb5BPE+tejj+xNYWjd5lkm4jEUiCkM9K2mE7B6TIrcKmMn2iUhvFeu5cxHb/L286r538W2ytnyljiq7PjcwrxcoRO2XnD8V2ldBXru/izCRAecknOokIyfqdMv7jNVhoLNcHy9OVTl54M4OSth9lIi4ja53/wXje1P/LbBs9vzW0Cy1bCA06Z/BvVrYUYje31ZXfqzlbfMF0Fut8Fk4FFZlBnNVzIRvJ57i2GcdY0Fsb+qiECa952eSmzc7xqMbif78zum6iRL7rL+I6xcSwJPHljENnETa6j30p4kXNBx2MGi6nkWyUTB3EW8eibSWkyC2BVOKXL0/Pf0wi72EaA2e67dCLDD6WMSEIErcjg/Wz4569x+jMkQ2eu2E1+oZAEaexam5zF5rc7XY1fzC0dwiJhaP22a2odzErFmmCbZnLFlLyOAih5T9tKN7IUx+jYNMKEtsQ278L4kemuzFdfQtip3FDVDd3UalFHTWgD1Q0lsIn0syvuLaeYgNZ513WEugXnGpoSndeteERv1khw7OBiQLg2hwlw1wzhuH6K6GVsDDGx73EguOAt9r9Vov9qb6x94dZ2PC0V49ayAgyTHAkFQapqhRH4EkupHwDZiAUiLja5ZOwb ZpDxVX+I 8X2QjRmIF9GfN3873jFj4/+ZKRLNxeIf6Dl4Qow9Yw0YAAVn7e9p1J5UqJLqRhKmLS2pzgjhyMs2WLEL/0Tb4QPlzo6lv1XUjRod3zhYbX0qYxsLb2TB7ygaRg9Wl8tDwyfbxibPnJE+0TFqR4vSLbrtJK+jJm6+1V6kN9+6jJLIRZ1Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/19 22:24, Matthew Wilcox wrote: > On Wed, Jul 19, 2023 at 05:58:47PM +0800, Peng Zhang wrote: >> -static inline void count_swpout_vm_event(struct page *page) >> +static inline void count_swpout_vm_event(struct folio *folio) >> { >> #ifdef CONFIG_TRANSPARENT_HUGEPAGE >> - if (unlikely(PageTransHuge(page))) >> + if (unlikely(folio_test_pmd_mappable(folio))) >> count_vm_event(THP_SWPOUT); >> #endif > As I said in my earlier response, you don't need the ifdefs. Check > the definition of folio_test_pmd_mappable. Sorry I forgot to delete the ifdefs. I'll fix it in a v3. Thanks. -- Best Regards, Peng