From: "zhangpeng (AS)" <zhangpeng362@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<sidhartha.kumar@oracle.com>, <akpm@linux-foundation.org>,
<wangkefeng.wang@huawei.com>, <sunnanyong@huawei.com>
Subject: Re: [PATCH v2 8/9] mm/page_io: convert count_swpout_vm_event() to take in a folio
Date: Thu, 20 Jul 2023 17:31:48 +0800 [thread overview]
Message-ID: <a989179a-102a-d07d-aa80-0ff45d21a74a@huawei.com> (raw)
In-Reply-To: <ZLfyDvSgFxkX6Z1Z@casper.infradead.org>
On 2023/7/19 22:24, Matthew Wilcox wrote:
> On Wed, Jul 19, 2023 at 05:58:47PM +0800, Peng Zhang wrote:
>> -static inline void count_swpout_vm_event(struct page *page)
>> +static inline void count_swpout_vm_event(struct folio *folio)
>> {
>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> - if (unlikely(PageTransHuge(page)))
>> + if (unlikely(folio_test_pmd_mappable(folio)))
>> count_vm_event(THP_SWPOUT);
>> #endif
> As I said in my earlier response, you don't need the ifdefs. Check
> the definition of folio_test_pmd_mappable.
Sorry I forgot to delete the ifdefs. I'll fix it in a v3.
Thanks.
--
Best Regards,
Peng
next prev parent reply other threads:[~2023-07-20 9:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 9:58 [PATCH v2 0/9] Convert several functions in page_io.c to use " Peng Zhang
2023-07-19 9:58 ` [PATCH v2 1/9] mm/page_io: remove unneeded ClearPageUptodate() Peng Zhang
2023-07-19 9:58 ` [PATCH v2 2/9] mm/page_io: remove unneeded SetPageError() Peng Zhang
2023-07-19 9:58 ` [PATCH v2 3/9] mm/page_io: convert bio_first_page_all() to bio_first_folio_all() Peng Zhang
2023-07-19 14:17 ` Matthew Wilcox
2023-07-20 5:34 ` Christoph Hellwig
2023-07-20 9:31 ` zhangpeng (AS)
2023-07-19 9:58 ` [PATCH v2 4/9] mm/page_io: use a folio in __end_swap_bio_read() Peng Zhang
2023-07-19 9:58 ` [PATCH v2 5/9] mm/page_io: use a folio in sio_read_complete() Peng Zhang
2023-07-19 9:58 ` [PATCH v2 6/9] mm/page_io: use a folio in swap_writepage_bdev_sync() Peng Zhang
2023-07-19 9:58 ` [PATCH v2 7/9] mm/page_io: use a folio in swap_writepage_bdev_async() Peng Zhang
2023-07-19 9:58 ` [PATCH v2 8/9] mm/page_io: convert count_swpout_vm_event() to take in a folio Peng Zhang
2023-07-19 14:24 ` Matthew Wilcox
2023-07-20 9:31 ` zhangpeng (AS) [this message]
2023-07-19 9:58 ` [PATCH v2 9/9] mm/page_io: convert bio_associate_blkg_from_page() " Peng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a989179a-102a-d07d-aa80-0ff45d21a74a@huawei.com \
--to=zhangpeng362@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sidhartha.kumar@oracle.com \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox