From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC5AFC02181 for ; Fri, 24 Jan 2025 10:07:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36A9B280045; Fri, 24 Jan 2025 05:07:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31BB76B0110; Fri, 24 Jan 2025 05:07:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20915280045; Fri, 24 Jan 2025 05:07:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 035646B010F for ; Fri, 24 Jan 2025 05:07:45 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9CA88810F6 for ; Fri, 24 Jan 2025 10:07:45 +0000 (UTC) X-FDA: 83041918890.23.291EAA9 Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) by imf19.hostedemail.com (Postfix) with ESMTP id 8B4981A000F for ; Fri, 24 Jan 2025 10:07:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=jbxKjJmp; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737713263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N1cSa6vH9o3QeSLYJ5bFyY0urrbFDp3kXf3Zs30pDLg=; b=CbJpGuMpnvYryclv2da0bGUykw6DwZRyxfY7VZeaUaS5wlhb8TbSmj/6qr1Cg74Ze+1bUY 0fXgnz1SOWwvNbjnhPdtgYXHtHCuxXXEiGMjd0vTCHy2L5uKzEQAUHXhGxe4mB42PdogL1 YCbVg3s5aqbGhnVELATPH+SEqD4MK30= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737713263; a=rsa-sha256; cv=none; b=U5FV6ljniaMdnOkiIWK3gaUFr+DqcgqqTvgi/+3DkEwvutu9krJbbGEOxtF0Z7426qZxMB m88Ll2X3XNQebRFo6mlGYbWvJmZtrAQTbH5/QOFFmkRvEHPFFzHDBKaW64yLifeU6DutaY rRxDU55EnLwTfN85Ejx69MsfPFV8Smw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=jbxKjJmp; spf=pass (imf19.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.98 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1737713259; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=N1cSa6vH9o3QeSLYJ5bFyY0urrbFDp3kXf3Zs30pDLg=; b=jbxKjJmpft4gZpgTdIxxCqd9UBsWZe821M6LUiwPdG0beqNhhOPxBX/hEdrABs9CrdDolvkNU2hwdVQSIWR+wF4sfkL3KBdl277E2IFo8Yc/xw+G3h+wY/QzYnnBHXdae/DF3EF5dpgTX1ZNWGGylFd1LmlKkuOMGdtFoPA+1ho= Received: from 30.32.95.77(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WOEB2EB_1737713256 cluster:ay36) by smtp.aliyun-inc.com; Fri, 24 Jan 2025 18:07:37 +0800 Message-ID: Date: Fri, 24 Jan 2025 18:07:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/compaction: fix UBSAN shift-out-of-bounds warning To: Liu Shixin , Andrew Morton , Kefeng Wang , Kemeng Shi , Mel Gorman , David Hildenbrand , Matthew Wilcox , Nanyong Sun , Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250123021029.2826736-1-liushixin2@huawei.com> From: Baolin Wang In-Reply-To: <20250123021029.2826736-1-liushixin2@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8B4981A000F X-Stat-Signature: p74etqcn9o5iaxhuucqupai4itondjwq X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1737713262-625176 X-HE-Meta: U2FsdGVkX1+aEDpvkuQ5cEk+QtiBkKYKP4RQCM5E+jeTtKiOJ4pEUPIq0uJDXkgjpTrhed13siiGbuGyezU1NNB8CxoBHZLhubz6ti2vYlieYzWd/nfyKwNLZS+T3CdxA9v/ska7zHI6aGQZw7NHaWbP7CWnl9bAdeJlIuOf4tLjm8iaVQSw3ki2LJFqv9i9wCgB03BMpq/BM8BJKLE071jezIZak1c24PmLFJHsQeiDDCPU+r1CzxNwbmj7QT6p3weCH5TCvvV7J0B1n0rR3Ao8/4/Ldtin277xzrYL49l1B0JQHDB9DXQh0cc6Y9fGGKTa0hlQy/0qY0Q/7ToVR5n9rjkWJmlEnDHUWnPnXSZCCebstTQ3lQY8fA4O/n46C21Mylc9OXrFmB43teemFm9m0wJqI4A6bdx1HsMqk/lt1REHDqNhWEiUgUUQEK7Wdnhr03PTwpm9iUmF/yPRwv0K5WMZYn2iSMWy725OAc0Aook1Zng4VibC5+UD+SZf0Kkw2ZtUdlxaisJV28r2BUoKX4qvbqScpRz+jONnoCqkwJJhXBiPZ2Oep+18Ykerot+GrTb0hhliJ6vSydIjpMEWD+MZj4NZgEPjLZG51xf4Pnp1v1i1tYF+sDMPiGV4aRlf7stn71bc/9KDCO40Vc8T+tPJONuY2H2Yjb/broD/1LDOwnFIcrcVRS2GqkD7UBFFwL04GQckWEqocEKTS/06//BmIhuZSTS6SSHlx85blgeBWX+zvyDh/4XeQ8JnZ0N1hbBq0GOBHYMQvrtNcypqDuCrziVT6i0y/8CqbWW4TUWvQdHYAyttBLtpifuSzVpbR0q3e84N80dm58ECxDHFUbH1LeMFE3Xtf9WLKe8b9JQBZbjpi/ZNXlwQw11e/Q5dU9TNQoha6mlbgHC1fQDJpQQidLicc0F68VhN4dzmYAmstazBxQNRyE8WniEkn8GsvngQw3Cxj4/9C8+ cU3qtaTK SwfHNO6C/0gilUSWfBi3+Um5VVTwcL8PYVMp8hmQb1RFvsC5iLAIqgAmYjBhBNiXs8h+Zgxn1ozQLK9GjWCGiBq4X9Xwg3OWqDXhhhgex0a56yYR56/3re7BpCnIX4062PSA0GlxmkOSPOZ86myoQNrS3OirkjZldoVDgg46jn6tvpjPtyEPdhn4oMVcOYzLBpSZbwGFrnVh4eT6rJMCCHqHERZZVdRFXud164ozhs+36fkntCbCr9uvwy9f2jOVUC7ZQJT7qwkdz54AiYY+8SbQ2wqLt8lZsfboYigi4YL9l1C/EwLwHP8CxCvocIwQqd1cH X-Bogosity: Ham, tests=bogofilter, spamicity=0.003208, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/23 10:10, Liu Shixin wrote: > syzkaller reported a UBSAN shift-out-of-bounds warning of (1UL << order) > in isolate_freepages_block(). The bogus compound_order can be any value > because it is union with flags. Add back the MAX_PAGE_ORDER check to fix > the warning. > > Fixes: 3da0272a4c7d ("mm/compaction: correctly return failure with bogus compound_order in strict mode") > Signed-off-by: Liu Shixin > --- LGTM. And I remember Vlastimil had the same concern before[1]. Reviewed-by: Baolin Wang [1] https://lore.kernel.org/all/6b055821-ce14-4a6d-959c-25ade4a9bfd7@suse.cz/ > mm/compaction.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a2b16b08cbbff..384e4672998e5 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -630,7 +630,8 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > if (PageCompound(page)) { > const unsigned int order = compound_order(page); > > - if (blockpfn + (1UL << order) <= end_pfn) { > + if ((order <= MAX_PAGE_ORDER) && > + (blockpfn + (1UL << order) <= end_pfn)) { > blockpfn += (1UL << order) - 1; > page += (1UL << order) - 1; > nr_scanned += (1UL << order) - 1;