From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AEA7C433EF for ; Wed, 30 Mar 2022 07:39:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4E5A8D0002; Wed, 30 Mar 2022 03:39:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFE488D0001; Wed, 30 Mar 2022 03:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9F488D0002; Wed, 30 Mar 2022 03:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id B622A8D0001 for ; Wed, 30 Mar 2022 03:39:47 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5A009A5669 for ; Wed, 30 Mar 2022 07:39:47 +0000 (UTC) X-FDA: 79300253214.17.1B7D2C7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id CE59120008 for ; Wed, 30 Mar 2022 07:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648625986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bdmc0ujk/QGKxeijeYMWGwM4/XVziFQYge7M2egdNzo=; b=DZRCDSydMcU2gNHIpAjhakzxzsCN+PXkU11DJbm40QYnOUW2lGvepISd3vOB0OYvGqiuvK l0Z5846cFKIVp9OPRBtx5r/X3FnZ1crKYI1Bos9j0Kt/mlYB9xDywjmEzebxsGFIhJO0YP Z3axAgvzCdSQAjusUI5mIYtSLemtrBs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-465-7rh7AUMLO4qzmYr2ve2kxQ-1; Wed, 30 Mar 2022 03:39:44 -0400 X-MC-Unique: 7rh7AUMLO4qzmYr2ve2kxQ-1 Received: by mail-wr1-f72.google.com with SMTP id j11-20020adfb30b000000b00205a3f19489so3598132wrd.16 for ; Wed, 30 Mar 2022 00:39:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=bdmc0ujk/QGKxeijeYMWGwM4/XVziFQYge7M2egdNzo=; b=jir+gofc0LoT01VR7noMkQ9vE3Pw4QAxF0RkulXuwYEp9TyCbpIXUhKXS98fdBftB/ deIVkILRmoCQFB4BC1IuOzWMA8aQ7/VEMudnzc0BDMV6BIS1X/PqyugD5TsFRgjWdyTy mzhPo8MZM+ghX5SrhZpN7p07VW9HRTMvzqR7OjL2jj4yK7oIavOa7bMTlkRWzGIDrEXO ORHOL06W/93na0grXVqzHk+PlixWlXsJB2f/YOcuPS3NBcSxkU6OUt8fRD9JiHegXjIn sE4QTT9awWg1JVgxNi0/3vx62HXn2wwyyxQAqy3BHTwrdooHdSofoxglMtbpalkIlzt+ nCwQ== X-Gm-Message-State: AOAM5323VI8ZiQWQEZzHgl5bSdwgeePMPsDyRdaWKjGMRyEK47JMkqPD 7njM7fjbhJl0+hanO2xgC3pm010fMAdftVLl6g0X+C8JFj3xqZ+aU/K+Fm4EtdJVOh3p3lu1Rx3 bGpu73pbnWUg= X-Received: by 2002:adf:eb48:0:b0:203:f854:86cc with SMTP id u8-20020adfeb48000000b00203f85486ccmr34346338wrn.102.1648625983769; Wed, 30 Mar 2022 00:39:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxD6/4KA9nOXr+UYw0G5RCCghSOQawlwc82iZvSTIsHhrWRBJJtIxg+6ty0ZAU8K5GX9wFrWQ== X-Received: by 2002:adf:eb48:0:b0:203:f854:86cc with SMTP id u8-20020adfeb48000000b00203f85486ccmr34346324wrn.102.1648625983566; Wed, 30 Mar 2022 00:39:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:2200:178b:7244:2a1f:b5d8? (p200300cbc7052200178b72442a1fb5d8.dip0.t-ipconnect.de. [2003:cb:c705:2200:178b:7244:2a1f:b5d8]) by smtp.gmail.com with ESMTPSA id bg42-20020a05600c3caa00b00380deeaae72sm3818045wmb.1.2022.03.30.00.39.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 00:39:43 -0700 (PDT) Message-ID: Date: Wed, 30 Mar 2022 09:39:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [Patch v2 2/2] mm/vmscan: make sure wakeup_kswapd with managed zone To: Wei Yang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ying.huang@intel.com, mgorman@techsingularity.net, Miaohe Lin , Oscar Salvador References: <20220329010901.1654-1-richard.weiyang@gmail.com> <20220329010901.1654-2-richard.weiyang@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220329010901.1654-2-richard.weiyang@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DZRCDSyd; spf=none (imf03.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: w9bxm6a7bodst9y19soyg5t7egk86gix X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CE59120008 X-HE-Tag: 1648625986-667237 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.03.22 03:09, Wei Yang wrote: > wakeup_kswapd() only wake up kswapd when the zone is managed. > > For two callers of wakeup_kswapd(), they are node perspective. > > * wake_all_kswapds > * numamigrate_isolate_page > > If we picked up a !managed zone, this is not we expected. > > This patch makes sure we pick up a managed zone for wakeup_kswapd(). And > it also use managed_zone in migrate_balanced_pgdat() to get the proper > zone. > > Signed-off-by: Wei Yang > Cc: Miaohe Lin > Cc: David Hildenbrand > Cc: "Huang, Ying" > Cc: Mel Gorman > Cc: Oscar Salvador > Signed-off-by: Andrew Morton ^ I'm not so sure about that SOB, actually Andrew should add that. But maybe there is good reason for it that I'm not aware of. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb