From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7135C7EE29 for ; Tue, 23 May 2023 11:36:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D15D900003; Tue, 23 May 2023 07:36:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 181AE900002; Tue, 23 May 2023 07:36:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070E1900003; Tue, 23 May 2023 07:36:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ECF0E900002 for ; Tue, 23 May 2023 07:36:49 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 89F61A0784 for ; Tue, 23 May 2023 11:36:49 +0000 (UTC) X-FDA: 80821317738.13.61F557B Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf28.hostedemail.com (Postfix) with ESMTP id 88838C0017 for ; Tue, 23 May 2023 11:36:45 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684841807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UktGo7IXp2IWJKvdgYzyDCeDnjV+FI3ZpjViPkq4UIo=; b=5twHGW/+roDDJk1cXz46vxrjOLpcUGsFETVzX1eULTHDzTYrexFkF/YKI3heb1MPumVmra fu54ihRjN2lEMIiQBS47LXWKdK3ahiRYeYB2l7MWKwyoj2S8CFLV2NQzgsltQYwBsJcO8E ndj0aU7ptXoTwE9LGhEcKfgGzwg2bMc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684841807; a=rsa-sha256; cv=none; b=WawNoojsKg4dIcFAketfWVY6TeKQhvRL9Vz+yMvUcv9Gdebr6MzOrDQfs/RpblW7k7OIdW YPTm8YCug4o3WjTBRBaxCLtB9Htupg3jWw9EgV7Pn87W7YGNwpxiPwBUrtiDG/ft3iooG8 6Gb3xG92jGQ20u5CgteDEluQh2hDw/8= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QQXJS5Pk0zLq4g; Tue, 23 May 2023 19:33:44 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 19:36:40 +0800 Message-ID: Date: Tue, 23 May 2023 19:36:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4] memblock: Add flags and nid info in memblock debugfs Content-Language: en-US To: Yuwei Guan , , , , CC: , References: <20230519105321.333-1-ssawgyw@gmail.com> From: Kefeng Wang In-Reply-To: <20230519105321.333-1-ssawgyw@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 88838C0017 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: msgfggshyzub3kg7ak73jrnoj9g5tune X-HE-Tag: 1684841805-780523 X-HE-Meta: U2FsdGVkX1+5ToJxG+8jrsjkydeyISngWsfKHbdEQtVZNrEYt8M456Qd+Q0V8gcM/fHqMANDZlHbSykBX7oC0MAfj7Yqc3RqRBiQO7p1Ant0bNheV7FOhmFRuBpJ86PDqlyDfbW+5qEDFd9U4YDfr9T3xIwSSHIf7uW3qu1QNNZQYHbR32yBi8GTuBKjP86kGTk3WY4el3ok/6mZ8VsuXMNLyzO7vn1mmJs8vsZy9fn5nXfovv+3TsGpc9yldtRttzlCGSguTaYvpeSfLuHdJoha786EUeu2KPJo26duoLNokSIXhDvR02X5dgcSo+ueqoaVCURDmcbXhs+eXEXt8J0rDHBfyWCEN5JXniGOOCYDVEgKX4BGxkAqhcUHcXnUtmQZOJcrNGPkod6I7BXAlxoKoLfgcEaIzbGhoPqXmhBO6pZz6E60a5KYLi8U5sQkCk4q4gHU5BtO3O4JREyGiHMXl1JuinEzCumH9UP/JXAl49fgwHrTJSM553SxAl9efTTs23DO4Am2mdNiNVdvaItM+gZT9yJ4cmBHQOiMecJocXMcHgi1MnX5wNaFiD4cfwHX0Bh/CaPN/8A2O6NVh5qREv0zZkX+pD0ifvR6+oma9aRn4dxYdguTVWqgEtleK/QBxeWJ+TlhVcdmKoHLKKGd2Xtjos4HntpmYbM8cwr7caZINDEAxprFELN/3rbRE8gklGE9RYg4F7FfrIM/9UYepZZ+25xd9cA0oOHRN9sPsN6IELVSdM0X+NEcqHlYGHDwK1p4kZTNthEjrK7BvX9xcfCQP194heJG93koM3YDUKUzYKfzf0TIBy53M6pUImJ8g56ym8YkrHW/vwnddOC/JbD7sVtaBOwKtNpg1d76iBv1NG2CVaBWq4ArufmCQ47mfygSyvV9Pe384DdwUkjK6lHxpGNyxcXitKMV2AN6kCwbfr1+XArLd5KmRb7r5Q6hGC6rJGJw9ng+8dj lIb/cwnE DMPemCE/vmaOj5ItzfjcarD7ztO79ZqbltUnEVk32ffj09uWovGiHikLBeZAeSp6Hzap/9qiTaCyXUGzjN0fvxwIO0vP2z6mbY4DUapGllWmN+7evdfLKNYEIcvOsiL56YHMaOlyD+DgerKvK4eVgJihE79k7gmzGvUHMu19l88++Z+TPL/kdkKdd8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/19 18:53, Yuwei Guan wrote: > Currently, the memblock debugfs can display the count of memblock_type and > the base and end of the reg. However, when memblock_mark_*() or > memblock_set_node() is executed on some range, the information in the > existing debugfs cannot make it clear why the address is not consecutive. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff > 1: 0x0000000090200000..0x00000000905fffff > 2: 0x0000000090600000..0x0000000092ffffff > 3: 0x0000000093000000..0x00000000973fffff > 4: 0x0000000097400000..0x00000000b71fffff > 5: 0x00000000c0000000..0x00000000dfffffff > 6: 0x00000000e2500000..0x00000000f87fffff > 7: 0x00000000f8800000..0x00000000fa7fffff > 8: 0x00000000fa800000..0x00000000fd3effff > 9: 0x00000000fd3f0000..0x00000000fd3fefff > 10: 0x00000000fd3ff000..0x00000000fd7fffff > 11: 0x00000000fd800000..0x00000000fd901fff > 12: 0x00000000fd902000..0x00000000fd909fff > 13: 0x00000000fd90a000..0x00000000fd90bfff > 14: 0x00000000fd90c000..0x00000000ffffffff > 15: 0x0000000880000000..0x0000000affffffff > > So we can add flags and nid to this debugfs. > > For example, > cat /sys/kernel/debug/memblock/memory > 0: 0x0000000080000000..0x00000000901fffff 0 NONE > 1: 0x0000000090200000..0x00000000905fffff 0 NOMAP > 2: 0x0000000090600000..0x0000000092ffffff 0 NONE > 3: 0x0000000093000000..0x00000000973fffff 0 NOMAP > 4: 0x0000000097400000..0x00000000b71fffff 0 NONE > 5: 0x00000000c0000000..0x00000000dfffffff 0 NONE > 6: 0x00000000e2500000..0x00000000f87fffff 0 NONE > 7: 0x00000000f8800000..0x00000000fa7fffff 0 NOMAP > 8: 0x00000000fa800000..0x00000000fd3effff 0 NONE > 9: 0x00000000fd3f0000..0x00000000fd3fefff 0 NOMAP > 10: 0x00000000fd3ff000..0x00000000fd7fffff 0 NONE > 11: 0x00000000fd800000..0x00000000fd901fff 0 NOMAP > 12: 0x00000000fd902000..0x00000000fd909fff 0 NONE > 13: 0x00000000fd90a000..0x00000000fd90bfff 0 NOMAP > 14: 0x00000000fd90c000..0x00000000ffffffff 0 NONE > 15: 0x0000000880000000..0x0000000affffffff 0 NONE It's useful for debug memblock, thanks, Reviewed-by: Kefeng Wang I also found memblock reserved type's node is always wrong, from memblock=debug, and read /sys/kernel/debug/memblock/reserved return bad node info, I will send a patch. > > Signed-off-by: Yuwei Guan > --- > v4: > - show string value for each memblock flag > --- > mm/memblock.c | 24 ++++++++++++++++++++++-- > 1 file changed, 22 insertions(+), 2 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 511d4783dcf1..10d0ddbeebc1 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2136,12 +2136,19 @@ void __init memblock_free_all(void) > } > > #if defined(CONFIG_DEBUG_FS) && defined(CONFIG_ARCH_KEEP_MEMBLOCK) > +static const char * const flagname[] = { > + [ilog2(MEMBLOCK_HOTPLUG)] = "HOTPLUG", > + [ilog2(MEMBLOCK_MIRROR)] = "MIRROR", > + [ilog2(MEMBLOCK_NOMAP)] = "NOMAP", > + [ilog2(MEMBLOCK_DRIVER_MANAGED)] = "DRV_MNG", > +}; > > static int memblock_debug_show(struct seq_file *m, void *private) > { > struct memblock_type *type = m->private; > struct memblock_region *reg; > - int i; > + int i, j; > + unsigned int count = ARRAY_SIZE(flagname); > phys_addr_t end; > > for (i = 0; i < type->cnt; i++) { > @@ -2149,7 +2156,20 @@ static int memblock_debug_show(struct seq_file *m, void *private) > end = reg->base + reg->size - 1; > > seq_printf(m, "%4d: ", i); > - seq_printf(m, "%pa..%pa\n", ®->base, &end); > + seq_printf(m, "%pa..%pa ", ®->base, &end); > + seq_printf(m, "%4d ", memblock_get_region_node(reg)); > + if (reg->flags) { > + for (j = 0; j < count; j++) { > + if (reg->flags & (1U << j)) { > + seq_printf(m, "%s\n", flagname[j]); > + break; > + } > + } > + if (j == count) > + seq_printf(m, "%s\n", "UNKNOWN"); > + } else { > + seq_printf(m, "%s\n", "NONE"); > + } > } > return 0; > }