From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBE9E77188 for ; Sat, 11 Jan 2025 02:07:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC3B86B00A5; Fri, 10 Jan 2025 21:07:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E73AA8D0001; Fri, 10 Jan 2025 21:07:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D3ACA6B00A7; Fri, 10 Jan 2025 21:07:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B6A366B00A5 for ; Fri, 10 Jan 2025 21:07:40 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 221291210E3 for ; Sat, 11 Jan 2025 02:07:40 +0000 (UTC) X-FDA: 82993534680.17.BFD012C Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf28.hostedemail.com (Postfix) with ESMTP id 2DDA7C000E for ; Sat, 11 Jan 2025 02:07:37 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eNt0kCjR; spf=pass (imf28.hostedemail.com: domain of zhijianli88.lz@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhijianli88.lz@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736561258; a=rsa-sha256; cv=none; b=6oQTI7g6LjtLKnWBEKPDkvjC6T1x9uJVjnltlLdAjNnKc4ttPS0N1HmvI0/SOUbVGU5RnH RVDfqjCZvd5TTzhpNV6HOX67Pnah8QkrOnxpwqPDyATn6jc0PGp2d4d5inL++QF1rIU2hS Kr9PhJtvnJbvlAgGfzFfahRr439hLrA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eNt0kCjR; spf=pass (imf28.hostedemail.com: domain of zhijianli88.lz@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=zhijianli88.lz@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736561258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=seLrvPT9JjZWz6saRH0pd2cljURptYB7TR64wdQqsW4=; b=5JFqt7N3832oFdSLrp2pWLwgtLSF7J5JJPFAFgkwBx3WBKn88SEUELBzNNGXOuCjI62g8p BzUCVaQtntXGqfIHJdlqSbDyQDJfwmKobCXFMEZHZ4PazqeMS60b+Um8H82YHpIpey7asa 6xeLswn65wHYpDmtpVgiSq4O45g2rCk= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2163dc5155fso48430115ad.0 for ; Fri, 10 Jan 2025 18:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736561257; x=1737166057; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:subject:references:cc:to :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=seLrvPT9JjZWz6saRH0pd2cljURptYB7TR64wdQqsW4=; b=eNt0kCjRQTmYRKAUkbkna/5T8KtGcccUmIwddSaGDzmsgkGIG8q5MH3YT9KnKZ/9A8 r8+LvDZhKqNTlSnZvb7DkXc5J5FXJNubUBk7v5NkpDuF44at9p0SZ5rHIvRy564yRGHu Hx+hXRvkwTa25y/8Lb9ba9ievnIz5qK01Mmq3dmmVi2H+VBGUOG9sCZD0Dm6F0UApKah ax3H8Sg9Qb+FcZJqQACN9RXe3oh7uqpBo5WlciEqTdvx73PuvFx+/jsr+yU9vbGY0a69 pDx8npPua+5deM70zHR8QcIfBIuF8SXRddsTma4e50zbVw6NczBLRHXiBxmv0Vh5OLrb CMRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736561257; x=1737166057; h=content-transfer-encoding:in-reply-to:from:subject:references:cc:to :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=seLrvPT9JjZWz6saRH0pd2cljURptYB7TR64wdQqsW4=; b=onw3ejABt4Quh3fwBS5S+wyo5ZhWoLFp3ySejvCCc540FjYxJOQK8tGujuF98SH624 dWQHZEWt0AmM/yYc1qgKCB318iZhR5xOQcpXhZGjtLb/Oi3i+EP7K3TKS3F+BtTxe+Iu aSMPzQ2DTyEvM3A+KJ4IC9dZ0xZ12OFG8haWM05xI4r3DDv+OBcWB4N0eMk9wJdOdxuW 5U0nyeV3jZg8aFxpniCyNJt30mGMAkUTj+yOXTHVImi/kfAIItlWEk48Ob7lTM63zwv6 GOIkzskRLghku916iT6B9Y2zfvb7THvIlHyevo4Zti2HI8/L0XKiW6qYYAwNuiTqR9Za 700Q== X-Forwarded-Encrypted: i=1; AJvYcCXr+hBp9diTIADfUJ6yE4MtWCpSCGdYDagOZzNd0R09m96GZB2321NgyS5jdk76zqS+HBcgWMoEtA==@kvack.org X-Gm-Message-State: AOJu0YzzwWuUalX5VHUf4IHIQYKiYTe+rcU3nNESlQRFXPgIxConTydH PmHg8RSwcnXS3htNSC+kKGHDKaZ/oUVw21F3tgyHuznuetx2RYSb X-Gm-Gg: ASbGncv1hwVI83V7DFnQQD6E8n3IpxI3AMD3GvPDJLrByEE8Wr4BOt3c+gbJt7IHxLm TkN/ZhRdf1wM81h7jbWtWv+sRwy+eWAFNGitqDmdo6Wu3xvBF/lSP8Ewzv+pvnq63RwgT8JcNtO tkjloLXNs0pY5gM4nqkUxBRW6VVbHRZYaZ84B6AL2XG+2mxsPv/QuICvgdwcGx66syE1BS47Z6V itehbZqIG9r2CgsipIjajIO/VSdTi+p5xRq6e5aDb74+dUNxejKaMjTK+Z/pYMEPIIkVsneeXcA 6vkkRJijibVFgZ+CFdbbiD9X9NgX/6hLzIE= X-Google-Smtp-Source: AGHT+IHNq+4sDdblZNYnqKgN4AGeXVDzSpn75fbz1b5s79akmRXh5f+QvTq/EY/dvZ9s4N6QlCj0mg== X-Received: by 2002:a05:6a21:3996:b0:1db:d738:f2ff with SMTP id adf61e73a8af0-1e88cf7f75dmr21941550637.2.1736561256749; Fri, 10 Jan 2025 18:07:36 -0800 (PST) Received: from ?IPV6:240e:3af:e05:c460:74c2:d24d:3e6:13f6? ([240e:3af:e05:c460:74c2:d24d:3e6:13f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d40658fcfsm2100208b3a.111.2025.01.10.18.07.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 18:07:36 -0800 (PST) Message-ID: Date: Sat, 11 Jan 2025 10:07:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 To: donettom@linux.ibm.com Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, hannes@cmpxchg.org, kaiyang2@cs.cmu.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, rientjes@google.com, ritesh.list@gmail.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, weixugc@google.com, yuzhao@google.com References: <20250109060540.451261-1-donettom@linux.ibm.com> Subject: Re: [PATCH] mm: vmscan : pgdemote vmstat is not getting updated when MGLRU is enabled. From: Li Zhijian In-Reply-To: <20250109060540.451261-1-donettom@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2DDA7C000E X-Stat-Signature: z8x18hgoqc6dy7nkghbj8i47esjswpir X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1736561257-433890 X-HE-Meta: U2FsdGVkX1+eL+3Vat7tb01G7BXehBFj2u4CSQdriWOgHGAyD8wPvt5kNXZVSAKj5Co32MpJHREGY1Y71pKXe0I+hNbNKmHTUsbux0R1je3hQZ6CFszDqL4+k92HoiUKZJ3CR/vS1k2J8dYevkQ4C8+aHb/twS181S7VznLdXCg5u+t3jv5xQZgNQ7Xr/FEKMOJCikIDfXvXdvoPhnw9ePq2KiKrl/dtKHVD2H4SiQ3i1p+M2XEwQ781tRmWdqpK0eNTSUvCQzS2Q3hYUuzm6kC2Dn0hJqNqo60sV9ldj6qRuOVUZ/Sxa/3mDLxxMawQNYUFehJXJmDArfhTa+IqNKGHu0RHVxi1qS7NlDPHWJM22U0B8YEQEFmWC0/HkTtXXrBcG66shCWttDEK6mLvYSePWVXaBf/eVVoQ9cPnCA6DvhKwMMmNPChgYVT7yejK9+9bn5DqpXzUsiRiDkBw38OsH2YX3mKvYxbaoDJdwQlzHOHYifIzHQOEGE+s+yKhHWVAZ3NxUJQ/Ulb4nc4gzAnPnOgmEBrH4Na/A0zlFYIR6ZYCyaat7rZ2E78fqeNkyi8TNkIBTEY5TiX8YuH62xLdA7/u229cwTZXfbmMFvbQw1rUoCtw5t2k7f5sNsA7UezUWaUNoCzOAobcehAvPQuwH4uqafkMvmYqUijyBdmdrH30F2C9Z1SAKhVFPQAGRFFJTX8gl7dYzeDYkxrbT3UhY1veIPZXI+mm47NvXBL3oHx3lMlFHaWKpbabxUEykcd0NlJoosABfQFoPoLSwUSJyudaEEOQ7qwM0EvCvfx0E9v1B/2VQz1gJSo7GKsr8VbNab0obxtXdRqhXqEXFaV8Ou3655tBEA02sHR7PR5o/yz9HKX7MODXUnslXUltW4jusz3pYayWqTSTUT7mDfOcJP28uNQBsDe5d3+Hibsq/mNWucCXXif0UXbdScu5IC20ZFcFfxxrC3gWN55 59I1hJAP /JdRfXbmocYCtf9IbQ0IHFBhPz4dieUqqyxE3EmPV31ws847bn5hPDHq2g2cjD+2WMx1onuKOB9qKlPrRdnNyOFb1lq7pSsXvD8rDb4FMDfFUm3gI1OmNP4rSH0Tq3QErixd83Mc0cA1Vz9MjzUvCrf5gdiS6ecns5FtsyjtxZB6oEkSgLGOA0k4mr0iYkcgY7+S/U3eteYnuqfxodonnrq0hdd51AYSN+xTrqIJpB3yjAa5y5ZRrQF60jILF+veHswDPW+QCmq+IR+RRp2kreEDbmO3xzIQ51kbZ6/nfQJNbk8XqNgWOwcqxFcz5FIgqWbD0kDpkbocOsccPKbmTPgG7wZlEwYN9TsTBvaV+O9OO/ngFxJ8QPWxZof8UqUa9z1f8dvdxxW4ml881CjeVlA5bt4ZgB060z5BqM8B2w/vSRmUH/tJFCtB2oGjZ7tO0DLxntZyO0bNRJPPKjKHPWPVuJ3cojeWa1tg8YSFAP9kKNEYxggQBXQu6+hiB3rLEvUex25KWh44gnQhIy57nzLl5QP+ac6vTOjTx X-Bogosity: Ham, tests=bogofilter, spamicity=0.002368, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > When MGLRU is enabled, the pgdemote_kswapd, pgdemote_direct, and > pgdemote_khugepaged stats in vmstat are not being updated. > > 'Commit f77f0c751478 ("mm,memcg: provide per-cgroup counters for > NUMA balancing operations")' moved the pgdemote vmstat update > from demote_folio_list() to shrink_inactive_list(), which is in > the normal LRU path. As a result, the pgdemote stats are updated > correctly for the normal LRU but not for MGLRU. > > To address this, we have added the pgdemote stat update in the > evict_folios() function, which is in the MGLRU path. With this > patch, the pgdemote stats will now be updated correctly when MGLRU > is enabled. > > Without this patch vmstat output when MGLRU is enabled > ====================================================== > pgdemote_kswapd 0 > pgdemote_direct 0 > pgdemote_khugepaged 0 > > With this patch vmstat output when MGLRU is enabled > =================================================== > pgdemote_kswapd 43234 > pgdemote_direct 4691 > pgdemote_khugepaged 0 > > Fixes: f77f0c751478 ("mm,memcg: provide per-cgroup counters for NUMA balancing operations") > Signed-off-by: Donet Tom Great minds think alike, It's excatly same with mine[0] :) There is another bug[1] as well. [0] https://lore.kernel.org/linux-mm/20250110122133.423481-2-lizhijian@fujitsu.com/ [1] https://lore.kernel.org/linux-mm/20250110122133.423481-1-lizhijian@fujitsu.com/ Feel free to add vvv if your patch is accepted at last. Tested-by: Li Zhijian Reviewed-by: Li Zhijian > --- > mm/vmscan.c | 3 +++ > 1 filechanged , 3 insertions(+) > > diff > > --git a/mm/vmscan.c b/mm/vmscan.c index 9a859b7d18d7..b1ec5ece067e > 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -4642,6 +4642,9 @@ > static int evict_folios(struct lruvec *lruvec, struct scan_control > *sc, int swap reset_batch_size(walk); > } > > + __mod_lruvec_state(lruvec, PGDEMOTE_KSWAPD + reclaimer_offset(), + > stat.nr_demoted); + item = PGSTEAL_KSWAPD + reclaimer_offset(); > if (!cgroup_reclaim(sc)) > __count_vm_events(item, reclaimed); > --