From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D3DC7EE33 for ; Thu, 26 Jun 2025 21:43:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A64CA6B00A4; Thu, 26 Jun 2025 17:43:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A14596B00A6; Thu, 26 Jun 2025 17:43:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DC5B6B00AA; Thu, 26 Jun 2025 17:43:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 775266B00A4 for ; Thu, 26 Jun 2025 17:43:01 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3B249C03F6 for ; Thu, 26 Jun 2025 21:43:01 +0000 (UTC) X-FDA: 83598877362.29.C5BCBC6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id C66CD40005 for ; Thu, 26 Jun 2025 21:42:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ckDBn1b1; spf=pass (imf11.hostedemail.com: domain of luizcap@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=luizcap@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750974179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=75dl3DeypNDiAtmR3WWaBq44pb5bGGxuHo+PqUY4Jz0=; b=IvUb8tViX1ytbMLWd8KoLTKyT4HdbZCNyL0is0L8TM2FIAhLb1SPsBT7Gdw7Sz8EgdaFtQ 64LkPhmGos4TzZAKjHCW3zAqAW93Yocx4wpNqegg7oIZHNN8RY1cJvRBF1bIj4M/IQfW7Z 3xZsTW0hvQnw6d9UZbjIV6kX3BNvoZA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750974179; a=rsa-sha256; cv=none; b=cdgA3/f/IZJV/uWoBiegNfIeTVIKU7DSS2B8uLJTKpYkjVvTd39PEiFh4ztXQa3t1BcKWV cZVZS8K3Hh17oBVbUQ19eGsYbi1nzF3KL1StfdXDuUv6TBBob6sf4xdxhhQuvFbcIwO5kc pmC9E9ySf313J2/O6iIOloDYI3kkrWE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ckDBn1b1; spf=pass (imf11.hostedemail.com: domain of luizcap@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=luizcap@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750974178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=75dl3DeypNDiAtmR3WWaBq44pb5bGGxuHo+PqUY4Jz0=; b=ckDBn1b1R/VEWxxwyWVfi/er4NnsNhQ6TKsRKJihjpD4WFJKr8izJdfBZPIgj5ltBp0AEx 6Wep3HOJ3ixeAgzZ68kBZBSWBRNB3DkJ4U471wQL7Sgz8Tj0GOSe0vOdhUtsn4X5D1zmZK DidslOumQKIMagK2wIiXUJSNzCYZFK4= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-55Dxrk4XOOyqWTnYhtVMzg-1; Thu, 26 Jun 2025 17:42:55 -0400 X-MC-Unique: 55Dxrk4XOOyqWTnYhtVMzg-1 X-Mimecast-MFC-AGG-ID: 55Dxrk4XOOyqWTnYhtVMzg_1750974175 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7c5e2872e57so219051185a.0 for ; Thu, 26 Jun 2025 14:42:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750974175; x=1751578975; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=75dl3DeypNDiAtmR3WWaBq44pb5bGGxuHo+PqUY4Jz0=; b=WbvotwyunsIOuimXDxL8giI/7l9mQ0/Xr6Klo3+QWvc0dd9pyYL+qHw2Wp9jECFpnL S9vj3lkzOlpyHikF43Y/I3fvHZIdadEwX9A/PbGuLxBoM1Ul4p4tzIf8sKT9PZ2A4coy AhSVe/evi/u24wlZzP4D0DR+go2n45q6VbkLhevPA33DyERNtl4IsjBnTKt72VkgLsZF n+juydM68M8R/NDqi9fvnqUO3m7lbzqCxdY/vF9NyZ8AYi6BweWxormqhDtNN/HPzOrf MfPivQJR37QNO1RrGZ8pPsFiFH+9hGFHqhSve5nYeN83KIOwiQJdQAM14+4WIdMl5Xfq h9Jw== X-Forwarded-Encrypted: i=1; AJvYcCUjudMfJX2xnskNpqq+/+nFtBIHGzp9DSuMwR64jd5GeQ+w6qsjtMITmSCkh7W33OVtdTzfMDMr/w==@kvack.org X-Gm-Message-State: AOJu0Yxy351ZcSKKDKN+irhKcOtT6hTw5isyDvyhg3hU0i65UvqeaAlV q/+1+v2YWU6h4i2ivgnzNFf5dk3lBvnv4CwIKoBkfTW4ytKuPGHTYRu+O96l9lWi8Alv1C8zY14 t2BbMRvKWxuFqoF+sQdOfrm80lCH95qFDeLfk3s1VbAzCXzwxO9d6 X-Gm-Gg: ASbGncueZf4r/hjVQJX5atdeWDUjuhATWfiDGJKuEbUXSoegJQoh9YjcExXaO2I/kmd PKX1jeufUUM7Rvi8rVw1jYXp4U8CIEY8mptbpRGMfnyc8hZqOYe0yzNH7EFcYZ+sRdNOF6xPdhD NRB8mU42kr8nAn+EimHIQxTtdyiF6idBQ35AmnFnhQQt0JoT4gfaiLAnd89N2VXHTfaWCqUlc47 7p+//6z6lUDPn8Syu3uy6pf0usXKNZAmIzhJZxUitYgafXefZekawwq5xCTAjdkLbtKWq6PG5Qq y9AFzUFLumqBW4KJA+OSGu6A3xWc1uvA/4h/dVVfisrBeEraE4FLa2/Amhh6BKaZv3qlIVKdyo9 iPMrIaSq/NHvC X-Received: by 2002:a05:620a:468e:b0:7d3:8d2e:1f69 with SMTP id af79cd13be357-7d443947fbamr183756285a.17.1750974174925; Thu, 26 Jun 2025 14:42:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUieCka+aOZrUbXnLnmpVlLncLoLoEijYEGoYBPSFatbcBvDkiAfQTVyy0D8U8ztRdJluPVg== X-Received: by 2002:a05:620a:468e:b0:7d3:8d2e:1f69 with SMTP id af79cd13be357-7d443947fbamr183753785a.17.1750974174559; Thu, 26 Jun 2025 14:42:54 -0700 (PDT) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-65-69-156-206-24.dsl.bell.ca. [69.156.206.24]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d44320265asm46963085a.66.2025.06.26.14.42.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 14:42:54 -0700 (PDT) Message-ID: Date: Thu, 26 Jun 2025 17:42:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] mm: introduce snapshot_page() To: Andrew Morton Cc: david@redhat.com, willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lcapitulino@gmail.com, shivankg@amd.com References: <4a9745dd2989f7d5bf5bc69c37fc3e3cfda37e87.1750961812.git.luizcap@redhat.com> <20250626143929.a7f2bcbb8e90290f23af452e@linux-foundation.org> From: Luiz Capitulino In-Reply-To: <20250626143929.a7f2bcbb8e90290f23af452e@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8oMzf_oIv6MkMUE84qUeRGSBvvOzISLwAQ-tceXTexg_1750974175 X-Mimecast-Originator: redhat.com Content-Language: en-US, en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C66CD40005 X-Stat-Signature: qfxj7awbngbrfbw5mctmz6rd38yx5o49 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750974178-575004 X-HE-Meta: U2FsdGVkX1/bRWMa1nqxfmroFemR8NWlD0MPqexBliXWcuWKHul6q9D3X5DuZsD4pC3G34dplkH2XCSW1uQiDLONFPBeNzi1ONmw81vO95WSTSgM6B9DwDangk3jtUa+wju/L57m8YLKtdNrbokGHzejMdGAokHtjSosph/qlqR77ZUrL05tZRsmLXulsOnYVYVFcXRMs6L7L+ybpYf85V9T5AbqURrtrgdqH5N/hHIhg1x0/2IgHhy+0MOomszaXSphAQpfP3wdicHVWk7yhz3BXLmXmnumEeb7SRKOn1kliyjCinHnGalP17rTvwXeIoIa41qEU92uhPj5WFRh9WNCzjRESewtMwuKJ5Nzzdwp9/vJ35qURYU0jLnHtPSI9DffVX/OA33pekxf2e67Pb0fEFAViDbz1D/Nrz+F1A3b0jvZuxm8EhrZ/iJXALbq1XMbZcC9DsB1pV290x8Uz8VTZgSYwfqXNmLhKC3LN6XjY1CSboMhmtP3WedJBpFmt7SOrVOvI/zzOo0kpkU5L5O9IKI/2ILWgiikDN9zBQLGF+sZ0YR/Vrp7YzvrgV714cAbfs1tOJNVi2IjimNHd84ntzmvk6H8AVeous0Wp7hy+Psy4rpIe8731nC73Z4bqseGxcjcOoW0h+nT0YVDFzQFBFF5le52+IjIcR7oL+7oDM/VSqkI4mBQ3anEnjYyC5D8XR42P9hTehig38EjyrCxlKth1I6OUldrZde7UNa1p99xe8PdBs/cjrr+ebJI/cP7aFRmcEUzUarav2e8S1Aie6f3y9rhLXqQYzc5HY5yOCVbQrJzq+1OQMWpkk6cfJg7GAZUlrZ8+Q905ZjU7q517E0s/Fw9nXJKkCkhMHzV8xO4TjW797LI3hLaV+T7utcO8mHvyADECOWhZebpcSbYy/28EwxwXVSFbIzEodxfjRe6eeNvpvZG3R6nfcoIwDW4PD9cw7cM0S8Ra7J gHpwjemH QijJO8DPiXTqrVSjigoqQjjtVPMFt4BOf4p3ZO0mTCAQwP59JbTteickWz8qg3Gw1Dq9k5iDnSveYBEEdB6A9N9YQKg70NBdafEKhzrHqIwcz2o2txoGWvnAwaufD5S1rg5Y3d3K1j8+VvmmcrqCOLxBvC1rmc5VQ4ihfzjGEm05a+zhjKJ2V5ilvNnwUDq4Li4kJGa32QXIe9Chv8b30gJmee1oSt2G/KW4bnVtysgOX3ALu4Z+2nuP7is342UuwT7SwwS3OcwxsLxdrKFZgX3naecYqyo0bUwXsLY36IgYD5H/inyDLrUfbdjptjZjTmfqf+jfKW1G91kTq0mCJTlWhxLNC2MCjMt5QA0lg3hPgM/6WzMqgCXjw2wge63B3baNErj3d+jQU4rg90H5VsfgmW9MhqnqqePucD6fubCiquOgOwDU3evVQ+VdMJuv89m50g3ErX53u0/sSM1v4x6AgDZ5Qti/sA6jQVAj29S0VW56kRnPL2VdEc0S6QpoKrzEvROdHSIEAjHjwTF0z0pE+Lm7K0FWFMKFg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-06-26 17:39, Andrew Morton wrote: > On Thu, 26 Jun 2025 14:16:51 -0400 Luiz Capitulino wrote: > >> This commit refactors __dump_page() into snapshot_page(). >> >> snapshot_page() tries to take a faithful snapshot of a page and its >> folio representation. The snapshot is returned in the struct >> page_snapshot parameter along with additional flags that are best >> retrieved at snapshot creation time to reduce race windows. >> >> This function is intended to be used by callers that need a stable >> representation of a struct page and struct folio so that pointers >> or page information doesn't change while working on a page. >> >> The idea and original implemenetation of snapshot_page() comes from > > tpyo! > >> Matthew Wilcox with suggestions for improvements from David Hildenbrand. >> All bugs and misconceptions are mine. >> >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -4184,4 +4184,24 @@ static inline bool page_pool_page_is_pp(struct page *page) >> } >> #endif >> >> +#define PAGE_SNAPSHOT_FAITHFUL (1 << 0) >> +#define PAGE_SNAPSHOT_PG_HUGE_ZERO (1 << 1) >> +#define PAGE_SNAPSHOT_PG_FREE (1 << 2) >> +#define PAGE_SNAPSHOT_PG_IDLE (1 << 3) >> + >> +struct page_snapshot { >> + struct folio folio_snapshot; >> + struct page page_snapshot; >> + unsigned long pfn; >> + unsigned long idx; >> + unsigned long flags; >> +}; >> + >> +static inline bool snapshot_page_is_faithful(const struct page_snapshot *ps) >> +{ >> + return ps->flags & 0x1;' > > & PAGE_SNAPSHOT_FAITHFUL? > >> +} >> + > > All looks sane to me. Small-system people (are there any left?) might > point out that all the new code could be under ifdef CONFIG_PROCFS? > > I'll skip v1, see what reviewers have to say, thanks. Yes, no rush. And I'll fix the things you pointed out for v2 (including ifdef CONFIG_PROCFS). Thanks for the super quick feedback.