From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C565C52D71 for ; Fri, 9 Aug 2024 07:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F36E86B00A9; Fri, 9 Aug 2024 03:36:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE6F56B00AA; Fri, 9 Aug 2024 03:36:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D60626B00AB; Fri, 9 Aug 2024 03:36:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B75116B00A9 for ; Fri, 9 Aug 2024 03:36:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 65CA8A0AD5 for ; Fri, 9 Aug 2024 07:36:23 +0000 (UTC) X-FDA: 82431899046.29.E3DB2DE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf10.hostedemail.com (Postfix) with ESMTP id DD7C3C0016 for ; Fri, 9 Aug 2024 07:36:20 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hopuVlLq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sViIljoY; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hopuVlLq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sViIljoY; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723188932; a=rsa-sha256; cv=none; b=SxIzlomC1+IFJxjSOzqwfEvpg6dvZbj8t9opjsIcjQAbvr/USvcpBabClAIPkosqbdijAi +Aj5/Ptv5Hv0d7Cpc2z1R/PVkcptKAIzVRmqK1+8/PGywe76rqhAnH92ZG9cIDL4y724nq u+J95uvQh6ASrXAh989AmJBYcnyLGLE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hopuVlLq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sViIljoY; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hopuVlLq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sViIljoY; dmarc=none; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723188932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UOrjEaUulZgkcInF64kZRFxXI22T1IGvp1lLOLWN5Wc=; b=2vCr1aVYeqgb1LrHji95mDTAOy33XaQF4yH9Z4A7nTLQMoAp6uO4UE6JaqhCNV9Rm1jc9H IEDssggV/mbQhZny+Fx7LUnydfHPyScb//eHore/bUpfIY4PDL+vfAxujZDdorPdU0/BwT knJ5q2T2HyqpOhN0dnQnFO0MWJnO6C0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DF03B1FF14; Fri, 9 Aug 2024 07:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1723188978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UOrjEaUulZgkcInF64kZRFxXI22T1IGvp1lLOLWN5Wc=; b=hopuVlLq004LcXnZNgc8/pdOz9SOVCUNecKWTuxH6i5weJpfLWZclvcVc5FLvDfRRaV8rH V97wujAvZFuqPiF9rj/O9FphCDBDFA7UkZvhD9n8qLN4wNkZPpcMnd2XRrNqgAORQygguF mwt3pncTOPNsZDVA+O1Cassw9sIIX8A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1723188978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UOrjEaUulZgkcInF64kZRFxXI22T1IGvp1lLOLWN5Wc=; b=sViIljoYjNV6pTjL26ZSiymuJkFsBR+ykkLyuhXC29pOkmSdjcRV9iOVFfyeRAippcLz9i jLtCCd8HLACXtQBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1723188978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UOrjEaUulZgkcInF64kZRFxXI22T1IGvp1lLOLWN5Wc=; b=hopuVlLq004LcXnZNgc8/pdOz9SOVCUNecKWTuxH6i5weJpfLWZclvcVc5FLvDfRRaV8rH V97wujAvZFuqPiF9rj/O9FphCDBDFA7UkZvhD9n8qLN4wNkZPpcMnd2XRrNqgAORQygguF mwt3pncTOPNsZDVA+O1Cassw9sIIX8A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1723188978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UOrjEaUulZgkcInF64kZRFxXI22T1IGvp1lLOLWN5Wc=; b=sViIljoYjNV6pTjL26ZSiymuJkFsBR+ykkLyuhXC29pOkmSdjcRV9iOVFfyeRAippcLz9i jLtCCd8HLACXtQBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C73C71379A; Fri, 9 Aug 2024 07:36:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id pxZKMPLGtWblFAAAD6G6ig (envelope-from ); Fri, 09 Aug 2024 07:36:18 +0000 Message-ID: Date: Fri, 9 Aug 2024 09:36:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, slub: print CPU id on slab OOM To: Axel Rasmussen , Andrew Morton , Christoph Lameter , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joonsoo Kim , Pekka Enberg , Roman Gushchin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240806232649.3258741-1-axelrasmussen@google.com> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240806232649.3258741-1-axelrasmussen@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: DD7C3C0016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oqeti48mtqwb9c9geddbuifjaigdyr1g X-HE-Tag: 1723188980-539183 X-HE-Meta: U2FsdGVkX1/Zo+mQZTOVQwvI+U2Dhy7jwEfcEhfM0q5yjY8tI2kvgQHInAQ9uP3RLaSAXOf36GiAJXcAt3pCcav20AQdVhIkAckiKOO5wP+3yukG9AdwwwrUnhIOkpR4gLCZS17p9zEDvBQyW9ojWJqEQRl6AU0JNVawd1E9iUL01k7CGV682BYNL5+PCyXWcbeoKGPnOqdG9NeQcinBnzA/VI99QhysKF+gpRgH/HHwNxwIx4d2aRhBFESiGxtScZNrRSYOBy6YDOu8z6a4BeSB8Mid9a8lMNcjzjlt3j4B/8snfNnyw9WvRysm0na/NOHolK3qZPyYJ06PZy+AZ7XKLc681KNkfg+xvUvp4/Jmyb+REQ9LapZKQy4hjXBjOGA5UowvfJDOIulkmddKChn6W1nexD331IryhAjjVOLz72QKKaiefKVwXXKVL8OIzMBr51R14DviPhQZLn7+WWqykAPC0WPHJ+AP/X9sN05dzzdLGViAuMKKy89HkQyfbYWcuESmx00YNbrB5oiUXxkv4GeUykrhmTlL7W704jGY0uo2SvMyX4Qlhke8VfWIm3aXU53DLB29Fwtd+qKxIaDXk17+1fPhOSHQWE5PJqZcbQg+6VCeCmp1pBxXGJVyB5QHTM2oRI8F/w1WcIsd+qV7oXNSb898v/VFD9Pm8DtpT84WLtzYuelZWZh+hHZtnShYlSias4bwUlGKNwyh4JtqGOuUyUHVBySB/x16pN3DNSkxWMq5yNO/VYHVd/8Wf0VJnlNvlXHsW/8I/yiqj6urmNoNRIntUGe7WqH/50LSFN73R2TSjtzCn14jicfNcfFV8nTUbkZ290duppgRHKH+RPZj3shRvf81WnLh9xz2NJhcuU3VUprMpEMluLjeTqdKerI9bFgWzqPefaVAYyBIZya/2Bb1aFaZvuLIgGeBvHvcYdHcX7t4mGWfozYZDWVgJbZ3h97iJgkqr+m p6aOczq7 IY/bu10ICI/Fq6usTNU/38p5SOjM3VCnpUXjL7/R3v6HWLbJNZVV1AXB0dVxfxFrWLZAXzRo7j5hHCvbCb+MI5B7td8WgbGNx/4m5WkLrrY5w9TYpzur9n3WV0WbqikeX/OdzBESA7vgbKeEkJY4RgzbDM2eMb3XBt9jr7i2DHKILCB2ElHzbz7MFTgJx8Q/UWfxRQMXL7499dMvtHI3yOpDeDhQkvJKZDBbvMF27pBTxt+Fv3HnvjCr4sHIBkBUhmmzn3Jw1ZY53FFUGLm3WRyRmBDQ7aUIrKp9sjNeNuNZ7VV5JkobjEKSj5Spn8RnTGGVGSZ4sDFBNexZRg6S4Nc7o0dyzjIsdGqX812Hl0RsK8oQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/7/24 01:26, Axel Rasmussen wrote: > Depending on how remote_node_defrag_ratio is configured, allocations can > end up in this path as a result of the local node being OOM, despite the > allocation overall being unconstrained (node == -1). > > When we print a warning, printing the current CPU makes that situation > more clear (i.e., you can immediately see which node's OOM status > matters for the allocation at hand). > > Signed-off-by: Axel Rasmussen Added to slab/for-next, thanks. > --- > mm/slub.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index c9d8a2497fd6..7148047998de 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3422,7 +3422,8 @@ slab_out_of_memory(struct kmem_cache *s, gfp_t gfpflags, int nid) > if ((gfpflags & __GFP_NOWARN) || !__ratelimit(&slub_oom_rs)) > return; > > - pr_warn("SLUB: Unable to allocate memory on node %d, gfp=%#x(%pGg)\n", > + pr_warn("SLUB: Unable to allocate memory for CPU %u on node %d, gfp=%#x(%pGg)\n", > + preemptible() ? raw_smp_processor_id() : smp_processor_id(), > nid, gfpflags, &gfpflags); > pr_warn(" cache: %s, object size: %u, buffer size: %u, default order: %u, min order: %u\n", > s->name, s->object_size, s->size, oo_order(s->oo),