From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 812DCC64EC4 for ; Fri, 10 Mar 2023 14:23:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD0768E0002; Fri, 10 Mar 2023 09:23:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B80A88E0001; Fri, 10 Mar 2023 09:23:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A702A8E0002; Fri, 10 Mar 2023 09:23:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 985328E0001 for ; Fri, 10 Mar 2023 09:23:45 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 69D381A11AF for ; Fri, 10 Mar 2023 14:23:45 +0000 (UTC) X-FDA: 80553207210.20.40E6730 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf26.hostedemail.com (Postfix) with ESMTP id 5FAA1140003 for ; Fri, 10 Mar 2023 14:23:40 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678458223; a=rsa-sha256; cv=none; b=MASNWYbuLpT0XLRCfY4TZvxlBF9vkSN+UqOdpJ216cu+YWq1XvqetpDyQGHakt0e3HTq9A blRW9yJA+cfTzYsexFa3l18ngpenUdAyuaqk3v6GJsKzLJCDMnWYB5JoTyB9sgJVmtPqSB qFCPoRUDgH5g5jCiZRwbIiZwbNIeFRM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678458223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b/KXcn1uhkJ58o8op9vUf7QKl18qV7M7bzCQRSv/jGU=; b=WAwH/CeCBnBB3Cfy/nDKEAiul4TxlHNryU4MORn+GxILdEF6nudV1QvrVOKItX6VRj8dG0 40chQU6Y3NHShMPRnGpJ4ZoZCzq/vAMZsv7OZ4UjV7Ew4dlI8qq/uFHpD/yTUtTZ0Mev8z xOOl1XcUSdHMJNmT+ZlAtKr8J59JXZE= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PY7X85ntKzHvKK; Fri, 10 Mar 2023 22:21:28 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 10 Mar 2023 22:23:35 +0800 Message-ID: Date: Fri, 10 Mar 2023 22:23:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] mm: hugetlb: move hugeltb sysctls to its own file Content-Language: en-US To: Luis Chamberlain , Mike Kravetz , Muchun Song CC: Andrew Morton , , , , Kees Cook , Iurii Zaikin References: <20230309122011.61969-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: <20230309122011.61969-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 5FAA1140003 X-Rspamd-Server: rspam01 X-Stat-Signature: i4d3ty67txwnhq3xph5q7tibupzfk7w9 X-HE-Tag: 1678458220-443856 X-HE-Meta: U2FsdGVkX184XnECmGBLaLQb4AZ0zITsyxBxnxm48weWvML3kZttZLrCr/mcPbZznpsT47g7D0j2ulO0XsGSreHxo+XESMKMGBOZ+lWaHGQ0thnXgK9bp0pWMj7h/+ujYwP9VWkS7saJ0nOqxmrFdpofcBkv5WfSg5gghaNUfrN2xeTSGfKqHfET23YI3J3ad7HdlpAYVSkp6LzQYVwuZsTgv/lkHr+0hNnGnR1PABN8FqXh1YaAzFYXp5bCswZxMRZM6zXi7DcFcnGzBe8ffzCaG+SQ7GuOr2U4nIS5mK9Xo1jCp9Fd1rtHwNCdbig4ihbD+1FdH/1k77HL6e6NRn21OJhyuGVwRQMIlh3tDFL46Q4VpA2ivrXDEnmEXnhlLfOEslbyEpEaL2zhU2JtpT0unfKZKHBhqpww2MZrUawMuCs9DTvDHGb5Ju5xfgtTpBd8sNtY2qOv0jCtnZdNo0KO0sWkpZxTsrfSsAIoZOfMibjMeaud9iS++dsXcgWdwO16ALiEG1nlL/0zDZkrenyYHtBMWmowY71556i+n3uAfT77SH/AMrbeOMhVWVNUd5RqXruRkS8kIPNon3my++eaPiKxbaGHeDw+0NrvDHTGN8dpZFepXralpcdCjvh2oNtlUaBzpme+KwMwaEH7LogEa368IHUSqSEQRnbodiJ/98CUE4rC33gWw8jVNrsPZ9NPKjd7+70h2Oaeq/q4Q0hbh/TI/OXrepDZ+RqLihWZxwGPudLcPYNXVVT3rXE3PZzHglCffZ4JIX+gw9IW6hTIV+Mg1aqPqwKO/NAezyajFyVzKF5QgIgb8d3YvTN6k/MfDOD/bHrVXsG3UAXIZglB8Pjl6z4zbBrA04RllBjDpzqp4x+kmTypBCWRm5L7IC5BpAcGudO87bqIW5N9fKGUVlLRN6pv16JEXpjJcD61TAW3jCGB8golcmcDPyJlUZ7dxbGZO28ObqtvicV Y0CBpOrp CkTi2IlrPXH2k0MM96OoOU5wFt0y4LzGsavZJyJLn8H/5sy8fd+fJK5rlcfqYWPa+Lbe2AaprOADUtesvs4qGCKlozicpwJywVwzYujO82sP/4yLiILhgHfZM+cQNGr/AEFUh9F92vP/+dGyfXW78o5KpyS2LyTGX6ovTZUlKsHoVhZ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/9 20:20, Kefeng Wang wrote: > This moves all hugetlb sysctls to its own file, also kill an > useless hugetlb_treat_movable_handler() defination. > > Signed-off-by: Kefeng Wang > --- > include/linux/hugetlb.h | 8 ------- > kernel/sysctl.c | 32 -------------------------- > mm/hugetlb.c | 51 ++++++++++++++++++++++++++++++++++++++--- > 3 files changed, 48 insertions(+), 43 deletions(-) > > +#ifdef CONFIG_SYSCTL > +static void hugetlb_sysctl_init(void); Hi Luis，this should add __init as it is called by hugetlb_init, could you help to change it, or I could send a new patch. > +#else > +static inline void hugetlb_sysctl_init(void) { } > +#endif > + > static int __init hugetlb_init(void) > { > int i; > @@ -4257,6 +4263,7 @@ static int __init hugetlb_init(void) > > hugetlb_sysfs_init(); > hugetlb_cgroup_file_init(); > + hugetlb_sysctl_init(); > ... > + > +static void hugetlb_sysctl_init(void) ditto, sorry for the mistake. Thanks. > +{ > + register_sysctl_init("vm", hugetlb_table); > +} > #endif /* CONFIG_SYSCTL */ > > void hugetlb_report_meminfo(struct seq_file *m)