From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B8DC7113C for ; Fri, 18 Aug 2023 14:17:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBBB6940053; Fri, 18 Aug 2023 10:17:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6BA7940012; Fri, 18 Aug 2023 10:17:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3423940053; Fri, 18 Aug 2023 10:17:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 93BB6940012 for ; Fri, 18 Aug 2023 10:17:46 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6D3A11602FB for ; Fri, 18 Aug 2023 14:17:46 +0000 (UTC) X-FDA: 81137428932.27.AC74CBB Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf17.hostedemail.com (Postfix) with ESMTP id 2C6F840026 for ; Fri, 18 Aug 2023 14:17:43 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=FVvFkFNP; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf17.hostedemail.com: domain of quic_srichara@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_srichara@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692368264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=akA0nmt89B/FV8WxkezBSxU8XfCgLyW/lSBv3lioi5g=; b=elk+FqE+ibYxDw92UC+O8n5SFqAdrx2rh2AgPSho3Q7brHSrP/MIQuco2Cxl/Bvh9RI+fn JBO/wKT7ViD10vPCLgeuoBAE5TjzLR1b2URXPY5ADL62X85A507wGzUs1IQk03IYjo/5vy QPj6crTxqzvI5jRKnA6MxPB8FaM2UtI= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=FVvFkFNP; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf17.hostedemail.com: domain of quic_srichara@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_srichara@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692368264; a=rsa-sha256; cv=none; b=sfZKXGAXcmKHmtcevPZj0+XDA9h19TLaWSg5o8f+R38nIBL/P8kvNLVy2FAq5VImV3E/ZL 4jIy4ZmLVHKoJnhvHi39INvCezujq2Sz7Ae10fL8EkJg2TpoSK5a3ds8cV9BOQsiCvE/Fn 3Feduu0Eh0LfoSLTh59b+mfG/dArZuQ= Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37ICrXmK031018; Fri, 18 Aug 2023 14:17:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=akA0nmt89B/FV8WxkezBSxU8XfCgLyW/lSBv3lioi5g=; b=FVvFkFNPd9NIkh8BG/ARak37YHT00RknMFqgy9kaDLhPjySPY0yNRSvc/PKnNYgaR30u fXQ6NJFzUeqmuYKqhKZ13caNc2rdHPrr16y7Mjc8dMnx6ES4LrL3zZv2uqkzUGrdiwEe ENwv8jyZuvFv8W8TtHkD/mT7GjMP52rJDORCHMwYTxy8/riAh0jNNt47SClx+iRZnIAQ YLW50XOV+xohMEKZmCpphUFYDfa2gzqsdJseyx7DuBq1dzKbfQYCDYTF0XO8vHUjbGhw X+pLALPxOCnSwqmxTxr4r0JbaY7NkpsB1MMpd8Vpd2ymjmkg0fg58kPpOiv/SDNtv7EA vw== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3shscrhrjs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Aug 2023 14:17:37 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 37IEHZLL032261 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Aug 2023 14:17:35 GMT Received: from [10.216.16.154] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 18 Aug 2023 07:17:33 -0700 Message-ID: Date: Fri, 18 Aug 2023 19:47:29 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [linux-next:master 1937/6910] drivers/mtd/nand/raw/qcom_nandc.c:2941 qcom_op_cmd_mapping() error: uninitialized symbol 'ret'. Content-Language: en-US To: Miquel Raynal CC: Manivannan Sadhasivam , Dan Carpenter , , Md Sadre Alam , , , Linux Memory Management List References: <7ad1160b-5f8c-47af-a1c5-51b34f656fab@kadam.mountain> <20230804184550.0cb12369@xps-13> <3604e2ed-8d30-4f7b-9e56-7af5b23b2ac5@kadam.mountain> <20230804190750.3367a044@xps-13> <20230805065510.GA18650@thinkpad> <908ee5e8-6213-5685-7094-8c4b1282015c@quicinc.com> <20230807211458.3de7c627@xps-13> <4b8607e8-4df8-3b15-693f-7d7478caedac@quicinc.com> <20230818153319.4f2ca354@xps-13> <2fd50bec-b689-738a-297c-e0f9ad3cc402@quicinc.com> <20230818160308.261088fb@xps-13> From: Sricharan Ramabadhran In-Reply-To: <20230818160308.261088fb@xps-13> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: _a_unKlBfsXKBOLt4nUefzMfTpkW_Ezj X-Proofpoint-ORIG-GUID: _a_unKlBfsXKBOLt4nUefzMfTpkW_Ezj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-18_17,2023-08-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 bulkscore=0 spamscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308180130 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2C6F840026 X-Stat-Signature: kgutrmqdr9rdxifg5oas7jfap5rqcgxs X-HE-Tag: 1692368263-633249 X-HE-Meta: U2FsdGVkX19PznAGT7EKSBARwtvq3dhx7VB9Z8TkPFr+bSFOzsYZhCrBxidKp1iy2RP3nn3214tlehh48Gw3aSUxmtg6E+zMtCJIhHNC5KkGKIF6KF2CfacHwgmcCiCxq1pI1mek708zlh7AiC3Y4cT/ODy/udx2B2qIApMzZqWnbqcSM9m+lmDdAbi4mz5A/3dIb3HQh9xYXzzlRy0ooajapdJT8Fz9hVUPbKrHChXgKNDyI7c8K/g2u/tmRE2lPm3Y/UxqbMtH88kll1ZX+aZZrUfNeaQr77lRNMj1KVMZhivDvx770G+lOh4U8Ri1CToTDfX89q/tXxaVrg2YLaf13wEui1smSBAXGQHq3WAPvEN3b66nLPxObDOfTQ6DGkfl05N5nwZe960OknfSEIM34svEZjdHFxyK6HpKIFJGshuA2TWKuLnLz6j7c9tkEBH1gdgotKrixw74XVd1uJKTLb4YNy46G1A15Zl0w6Knz7ttyUKKlaA439b6IVuR0NjilE4zjjhe3jh/vV3mA+0txnRAcedRaY2Hlw9FjX4yih3yJBL0O/E9P19trbRmF67SjApqduf7jikFSXj2uvd5oIr1ajk9EE58usCo9gMZDKxN2HBhCSAiuJCIJfZcXH3ohvfI7wFQZ6D0W3pHlrYFXHlwb4DuBRUy+kvSZ+MY02sXS5VRnWMTd5zlUpdz95LuN58TPfxg5BeagCmW9aCOvwrCTdqRgUpn2qEbdx/aJTGvdKED4Io0kW0hRGf6TfKWbNRofCCaiSxm4pQ4iUsKid4GsGMoYCQnA7OsuuwVOoCknuxlLgvlhLMX3edVui+G6fwqRDr26XHCiCPUdoKa4OLw6yLLd8zr5NrTIOuRM8IkSaQbgQCr4WUlXfFv1rR9KeUOApfYIM0Av/yC/4alcBfgu0AVRhpCQJuERM2HuyCzr3Hw49dfTyJGtiHmXtuxWIaGYwbNAoQ6Wyg pMUu2gFQ cHEGURgNCTauq026l1OSv7KjuAJekg9+Qe0QuWM3j3uAwC8nENCtv/bEgNUUexwB8bmjf6MIRZW0SVe9UGLro3cahrqzAT80tXNh0qqlH+3FyWZbV671ajgE3WJJUq+9XBVvTyVpYQ3gQ5lfSLMZsoQeFzmfzxeD5NpOUYBkM5Y1YTaINivpU10Byw2S5dhIzKjaY+KU85mvUlWMcCNe9RvIu4ma3vX7tJsBDZxrXGC5/xqrJsYbB2vh6O6LM5ca3B+Ap3vpc/GeuF5ejXxrurzO9AHzf0fudssF34EBwVc5Y06DtBn4S+Gty23bkxQTyRA9lRwiS1MV94KgCJZ7jhdg4KdVhrBk2KFCe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/18/2023 7:33 PM, Miquel Raynal wrote: > Hi Sricharan, > > quic_srichara@quicinc.com wrote on Fri, 18 Aug 2023 19:21:04 +0530: > >> Hi Miquel, >> >> On 8/18/2023 7:03 PM, Miquel Raynal wrote: >>> Hi Sricharan, >>> >>> quic_srichara@quicinc.com wrote on Tue, 8 Aug 2023 10:46:14 +0530: >>> >>>> <..> >>>> >>>>>> With this series applied on linux-next, started seeing the below >>>>>> messages flooded on console while doing mtd r/w. >>>>>> "xxx "Opcode not supported: 0" >>>>>> >>>>>> opcode '0' corresponds to NAND_CMD_READ0. This command inturn was >>>>>> invoked from qcom_nandc.c driver from below places. For read/write_page >>>>>> driver does not use the exec ops. Hence these calls just ends up >>>>>> being -ENOTSUPP and ignored. So removed their invocations. >>>>>> If this is fine, can this be added to your series ? (will send >>>>>> git-format patch to add to your cleanup series). So far, tested >>>>>> mtd raw/block read/writes and all works fine. Will do further tests >>>>>> as well. >>>>> >>>>> Unless I really don't understand the controller, this is non sense. >>>>> nand_read_page_op() is precisely what allows your NAND to perform a >>>>> read. Removing this call cannot work. >>>>> >>>>> What you need is a proper ->exec_op() implementation, and repeating >>>>> this becomes slightly annoying. >>>>> >>>>> Look at your qcom_op_cmd_mapping, you don't even have a path for reads. >>>>> I bet something along: >>>>> CMD_READ0: >>>>> ret = XXX_OPCODE_READ; >>>>> break; >>>>> will make it work. >>>>> >>>>> Please fix the driver and test with nandbiterrs -i. If this test works, >>>>> it is encouraging. Otherwise it is still broken. >>>> >>>> ok understand. Will fix this up. >>> >>> This is urgent now. The driver in -next is broken, shall I revert >>> everything or will you test the above fix quickly? >>> >> >> While we are able to reproduce the issue, add path for >> CMD_READ0/READ_START for IPQ platforms. All mtd tests including >> nandbiterrs works fine. But we are not able to get hold of a SDX >> device where we could reproduce the issue to debug. We are working >> offline with Manivannan for the SDX remote debug. Will keep you >> updated here and if we are not able to solve this on SDX in next >> couple of days, only way looks like revert and re-apply it for 6.7. > > If the READ path works on IPQ platforms it's already a huge step > forward, please send the fix on top of Mannivan series. > ok, will send. Please confirm if its all fine. There are more abstraction/common mode in the driver to be pulled out, but that will do later. > Now, what is the issue with SDX? Looks like SDX device that Mani is having is a 4K nand device. For some reason, after exec ops nand boot is broken on that board. We applied the fixes we did on top of Manivannan series. With that enumeration works, but still mount fails. But 4K nand device boot on IPQ works fine. Problem is we do not have a SDX board where we could debug that. We are trying to get a remote setup enabled for this. Regards, Sricharan