From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2824AC433E0 for ; Sat, 11 Jul 2020 01:35:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D00FA20674 for ; Sat, 11 Jul 2020 01:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="de/WgrqJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D00FA20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5CDC78D0003; Fri, 10 Jul 2020 21:35:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57E618D0001; Fri, 10 Jul 2020 21:35:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F6F18D0003; Fri, 10 Jul 2020 21:35:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 262B78D0001 for ; Fri, 10 Jul 2020 21:35:32 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A36E92476 for ; Sat, 11 Jul 2020 01:35:31 +0000 (UTC) X-FDA: 77024077662.14.ocean50_1608eb926ed3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 7A0D518229818 for ; Sat, 11 Jul 2020 01:35:31 +0000 (UTC) X-HE-Tag: ocean50_1608eb926ed3 X-Filterd-Recvd-Size: 4871 Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Jul 2020 01:35:30 +0000 (UTC) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 10 Jul 2020 18:33:40 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Fri, 10 Jul 2020 18:35:29 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Fri, 10 Jul 2020 18:35:29 -0700 Received: from [10.2.51.208] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 11 Jul 2020 01:35:29 +0000 Subject: Re: [PATCH v2 2/6] mm: Dump compound page information on a second line To: "Matthew Wilcox (Oracle)" , CC: Andrew Morton , Vlastimil Babka , "Kirill A. Shutemov" , William Kucharski , Mike Rapoport References: <20200709202117.7216-1-willy@infradead.org> <20200709202117.7216-3-willy@infradead.org> From: John Hubbard Message-ID: Date: Fri, 10 Jul 2020 18:35:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709202117.7216-3-willy@infradead.org> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594431220; bh=1R+fx9XyvYt5xJNZBE74t6qfFLlG7bXK3ZFV9J+fNt0=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=de/WgrqJi5V0m60ns8E6gO8z7as9Q0ihZrLcIEtLDKjF0k0ATqlD3IJ4yRX8MyMcz UNUjfVUrvdmOObX8g/Tyv2cB5EkW6lOrETuLvxGsWitbfn39DZVAbmwaUnkKfwtL5a wFWEyBb7mTTkFV21m9ZvHIH1vG5YGMrkuKrmFfOyrvhg+ock4et5riN9Z7BvgSkhzm 3odTin6mGGPr6ArEgdSri+b+jW0PPX5i8xCcKNwDPd7H60j3BKME/olOH6+DuUKwRK rRkF3Qc6oNiaZWSA/E9edk/38F7PnfbMv7dqx6AZmoBF/I0KRMTAJYFkxwDFaxxdQ6 XGzfgo0WJkirA== X-Rspamd-Queue-Id: 7A0D518229818 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-07-09 13:21, Matthew Wilcox (Oracle) wrote: > Simplify both the implementation and the output by splitting all the > compound page information onto a second line. > > Reported-by: John Hubbard > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/debug.c | 30 ++++++++++++------------------ > 1 file changed, 12 insertions(+), 18 deletions(-) > Yes, looks good and is working nicely for me, too. Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > diff --git a/mm/debug.c b/mm/debug.c > index e5de63406b59..f35c1ae1a7a5 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -89,27 +89,21 @@ void __dump_page(struct page *page, const char *reason) > */ > mapcount = PageSlab(head) ? 0 : page_mapcount(page); > > - if (compound) > + pr_warn("page:%px refcount:%d mapcount:%d mapping:%p index:%#lx\n", > + page, page_ref_count(head), mapcount, mapping, > + page_to_pgoff(page)); > + if (compound) { > if (hpage_pincount_available(page)) { > - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p " > - "index:%#lx head:%px order:%u " > - "compound_mapcount:%d compound_pincount:%d\n", > - page, page_ref_count(head), mapcount, > - mapping, page_to_pgoff(page), head, > - compound_order(head), compound_mapcount(page), > - compound_pincount(page)); > + pr_warn("head:%px order:%u compound_mapcount:%d compound_pincount:%d\n", > + head, compound_order(head), > + compound_mapcount(head), > + compound_pincount(head)); > } else { > - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p " > - "index:%#lx head:%px order:%u " > - "compound_mapcount:%d\n", > - page, page_ref_count(head), mapcount, > - mapping, page_to_pgoff(page), head, > - compound_order(head), compound_mapcount(page)); > + pr_warn("head:%px order:%u compound_mapcount:%d\n", > + head, compound_order(head), > + compound_mapcount(head)); > } > - else > - pr_warn("page:%px refcount:%d mapcount:%d mapping:%p index:%#lx\n", > - page, page_ref_count(page), mapcount, > - mapping, page_to_pgoff(page)); > + } > if (PageKsm(page)) > type = "ksm "; > else if (PageAnon(page)) >