* [PATCH] memory tier: Use helper function destroy_memory_type()
@ 2023-06-26 12:10 Miaohe Lin
2023-07-03 2:28 ` Huang, Ying
0 siblings, 1 reply; 5+ messages in thread
From: Miaohe Lin @ 2023-06-26 12:10 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, linmiaohe
Use helper function destroy_memory_type() to release memtype instead
of open code it to help improve code readability a bit. No functional
change intended.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memory-tiers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
index e593e56e530b..0b8b76078c12 100644
--- a/mm/memory-tiers.c
+++ b/mm/memory-tiers.c
@@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype)
*/
if (!node_memory_types[node].map_count) {
node_memory_types[node].memtype = NULL;
- kref_put(&memtype->kref, release_memtype);
+ destroy_memory_type(memtype);
}
mutex_unlock(&memory_tier_lock);
}
--
2.27.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] memory tier: Use helper function destroy_memory_type()
2023-06-26 12:10 [PATCH] memory tier: Use helper function destroy_memory_type() Miaohe Lin
@ 2023-07-03 2:28 ` Huang, Ying
2023-07-03 2:53 ` Miaohe Lin
0 siblings, 1 reply; 5+ messages in thread
From: Huang, Ying @ 2023-07-03 2:28 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, linux-mm, linux-kernel, Aneesh Kumar K.V
Miaohe Lin <linmiaohe@huawei.com> writes:
> Use helper function destroy_memory_type() to release memtype instead
> of open code it to help improve code readability a bit. No functional
> change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/memory-tiers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index e593e56e530b..0b8b76078c12 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype)
> */
> if (!node_memory_types[node].map_count) {
> node_memory_types[node].memtype = NULL;
> - kref_put(&memtype->kref, release_memtype);
> + destroy_memory_type(memtype);
Not need to be changed in this patch. It appears that
destroy_memory_type() isn't a very good name, because we usually will
not free the memory_type here. Rename it to "put_memory_type()"?
Best Regards,
Huang, Ying
> }
> mutex_unlock(&memory_tier_lock);
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] memory tier: Use helper function destroy_memory_type()
2023-07-03 2:28 ` Huang, Ying
@ 2023-07-03 2:53 ` Miaohe Lin
2023-07-03 3:07 ` Huang, Ying
0 siblings, 1 reply; 5+ messages in thread
From: Miaohe Lin @ 2023-07-03 2:53 UTC (permalink / raw)
To: Huang, Ying; +Cc: akpm, linux-mm, linux-kernel, Aneesh Kumar K.V
On 2023/7/3 10:28, Huang, Ying wrote:
> Miaohe Lin <linmiaohe@huawei.com> writes:
>
>> Use helper function destroy_memory_type() to release memtype instead
>> of open code it to help improve code readability a bit. No functional
>> change intended.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>> ---
>> mm/memory-tiers.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
>> index e593e56e530b..0b8b76078c12 100644
>> --- a/mm/memory-tiers.c
>> +++ b/mm/memory-tiers.c
>> @@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype)
>> */
>> if (!node_memory_types[node].map_count) {
>> node_memory_types[node].memtype = NULL;
>> - kref_put(&memtype->kref, release_memtype);
>> + destroy_memory_type(memtype);
>
> Not need to be changed in this patch. It appears that
> destroy_memory_type() isn't a very good name, because we usually will
> not free the memory_type here. Rename it to "put_memory_type()"?
Do you mean rename destroy_memory_type to put_memory_type in a separate patch? This sounds reasonable
to me. But destroy_memory_type is a EXPORT_SYMBOL_GPL symbol, is it fine to do the rename work?
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] memory tier: Use helper function destroy_memory_type()
2023-07-03 2:53 ` Miaohe Lin
@ 2023-07-03 3:07 ` Huang, Ying
2023-07-03 3:25 ` Miaohe Lin
0 siblings, 1 reply; 5+ messages in thread
From: Huang, Ying @ 2023-07-03 3:07 UTC (permalink / raw)
To: Miaohe Lin; +Cc: akpm, linux-mm, linux-kernel, Aneesh Kumar K.V
Miaohe Lin <linmiaohe@huawei.com> writes:
> On 2023/7/3 10:28, Huang, Ying wrote:
>> Miaohe Lin <linmiaohe@huawei.com> writes:
>>
>>> Use helper function destroy_memory_type() to release memtype instead
>>> of open code it to help improve code readability a bit. No functional
>>> change intended.
>>>
>>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>>> ---
>>> mm/memory-tiers.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
>>> index e593e56e530b..0b8b76078c12 100644
>>> --- a/mm/memory-tiers.c
>>> +++ b/mm/memory-tiers.c
>>> @@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype)
>>> */
>>> if (!node_memory_types[node].map_count) {
>>> node_memory_types[node].memtype = NULL;
>>> - kref_put(&memtype->kref, release_memtype);
>>> + destroy_memory_type(memtype);
>>
>> Not need to be changed in this patch. It appears that
>> destroy_memory_type() isn't a very good name, because we usually will
>> not free the memory_type here. Rename it to "put_memory_type()"?
>
> Do you mean rename destroy_memory_type to put_memory_type in a
> separate patch?
Yes.
> This sounds reasonable to me. But destroy_memory_type is a
> EXPORT_SYMBOL_GPL symbol, is it fine to do the rename work?
I think so. This isn't a kernel ABI. And not many people use it now.
Best Regards,
Huang, Ying
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] memory tier: Use helper function destroy_memory_type()
2023-07-03 3:07 ` Huang, Ying
@ 2023-07-03 3:25 ` Miaohe Lin
0 siblings, 0 replies; 5+ messages in thread
From: Miaohe Lin @ 2023-07-03 3:25 UTC (permalink / raw)
To: Huang, Ying; +Cc: akpm, linux-mm, linux-kernel, Aneesh Kumar K.V
On 2023/7/3 11:07, Huang, Ying wrote:
> Miaohe Lin <linmiaohe@huawei.com> writes:
>
>> On 2023/7/3 10:28, Huang, Ying wrote:
>>> Miaohe Lin <linmiaohe@huawei.com> writes:
>>>
>>>> Use helper function destroy_memory_type() to release memtype instead
>>>> of open code it to help improve code readability a bit. No functional
>>>> change intended.
>>>>
>>>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>>>> ---
>>>> mm/memory-tiers.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
>>>> index e593e56e530b..0b8b76078c12 100644
>>>> --- a/mm/memory-tiers.c
>>>> +++ b/mm/memory-tiers.c
>>>> @@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype)
>>>> */
>>>> if (!node_memory_types[node].map_count) {
>>>> node_memory_types[node].memtype = NULL;
>>>> - kref_put(&memtype->kref, release_memtype);
>>>> + destroy_memory_type(memtype);
>>>
>>> Not need to be changed in this patch. It appears that
>>> destroy_memory_type() isn't a very good name, because we usually will
>>> not free the memory_type here. Rename it to "put_memory_type()"?
>>
>> Do you mean rename destroy_memory_type to put_memory_type in a
>> separate patch?
>
> Yes.
>
>> This sounds reasonable to me. But destroy_memory_type is a
>> EXPORT_SYMBOL_GPL symbol, is it fine to do the rename work?
>
> I think so. This isn't a kernel ABI. And not many people use it now.
Will do it. Thanks for your advice.
>
> Best Regards,
> Huang, Ying
>
>
> .
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-03 3:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-26 12:10 [PATCH] memory tier: Use helper function destroy_memory_type() Miaohe Lin
2023-07-03 2:28 ` Huang, Ying
2023-07-03 2:53 ` Miaohe Lin
2023-07-03 3:07 ` Huang, Ying
2023-07-03 3:25 ` Miaohe Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox