From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D20FEB64D9 for ; Mon, 3 Jul 2023 02:54:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B270B6B00F6; Sun, 2 Jul 2023 22:54:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD6956B00F7; Sun, 2 Jul 2023 22:54:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C6338E007C; Sun, 2 Jul 2023 22:54:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8CC7D6B00F6 for ; Sun, 2 Jul 2023 22:54:04 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5A68A1C7DA6 for ; Mon, 3 Jul 2023 02:54:04 +0000 (UTC) X-FDA: 80968781208.08.8660177 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf15.hostedemail.com (Postfix) with ESMTP id D4B59A0007 for ; Mon, 3 Jul 2023 02:53:59 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688352840; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iiCzkkiO+NUJl4aMovNLtk+ujXfaZh8kYfyD9zvHtuo=; b=lO4axk5CwFfTrw1gAVHlPM2I7pYSlt2wOujTLV3MlSgaDMT0a+kwO/KLltaaVznDKs6ajD /5l+x2909du70d7iwEBtHBrhOpiCOeWqmClYDo/L/3GeRM5GkwkJP7/LSFnrZXHVG12sqq FqOQSjcOqfIG+J+GDvZuNdFW8vvlvwo= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688352840; a=rsa-sha256; cv=none; b=kQjhROchYJc3F5giBSswGZXu/LpEncarPoR3+jLQkktuyyMpV82A0s1XsjSFDvLXZhZvFi RYOkFerESWaGxDtcdtGiYOvtJPMJoewz5MKA/cD6pLJx1YPCeo1lgSUrmbOR8JFx2c/bSk QRab2G8mziiOHCjN2oUh0OVCTJCv53U= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QvVpV12yDzTm1D; Mon, 3 Jul 2023 10:52:50 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 3 Jul 2023 10:53:48 +0800 Subject: Re: [PATCH] memory tier: Use helper function destroy_memory_type() To: "Huang, Ying" CC: , , , Aneesh Kumar K.V References: <20230626121053.1916447-1-linmiaohe@huawei.com> <873525k9tt.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Miaohe Lin Message-ID: Date: Mon, 3 Jul 2023 10:53:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <873525k9tt.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: jemddfnfda657q6ugccdnc5b4teeuhg9 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D4B59A0007 X-HE-Tag: 1688352839-543123 X-HE-Meta: U2FsdGVkX1+FLnj58u+7deKHuHjIuOz1f2z59a367waHaKXpDWmxmws8AhEKUiiMd9seY5bgLLjexJcr/PEpkbCz48acEwt1S/dW0WbESfn5n+SQ0Q5pLS/x2a7U2VU9j2YiaB1x7harmk8wr+s2CN2DJdG5RJF7QSsxJKJtM6XWrpukxW9viagL6idgq8B2uNuP/g4GTqqCZ1PYGs24rmmqbBtPsg2U6FVKyINu4meRDYEpMdfPdQ/QQaWfBRXK3xV5UvNzh89pkjWLKqbJhx7ot+E/aqXArJTWEkoSuuWiEaXxV4KOqueYoWIZeMakHM7wdO+zDdNG9ErAph5OTot7+nGMg05HljPjee6R73RrhujaZyLKm9KAUqY+D2dtS12+R3LCy4b91/xY/jkYu4VMG3Xecv8fs4FhYy9/zhqscrcYOKnsBoCTQ3arv06CNFb/8w5rFAacVp8yfnmbgOr0GjyuqrQwL8Yiq09dkV44JTo7RnGH7jMKsNM+O60hSlWuQ0O+LD68To+2wuv5KNOkLkUjc0OpuuGNEfNC61q08ioKOEy10YMnndthZy4LFvwxe+AzekK9iI+tNgtpKMenYSDQNi0JoaT48Mgldwm14HSjqxoAl7mhTfIEYtSZOUC7YHfSbQOmMCtKmHp2bxpDR8+eiS3LrYatncM+Pf5tCVF9Oaz7KT9TunjNvR+2uuHzvd+ro2nLPlJYc73g57uKZkmUE5USlIXrLXwZXVG8XV3FHNZkR/j8A+G1Ym5LXN/QOmHjx4k2p2o1u5GJlD778pkUFEZivP1/sG59Cwhb3GDd6G876lgpdsJgF2zpiUtNj6pMV2Kmiwf5SNARu0iEIv7iasBSZzi/KBBd2gH7ZTwj6wcEJfOwWaHGCkODo4YPqX78Ulnn2SJKtdwAV+djFmD300l83qhSqwLgy1ChO/kE/jj+qh1L6d4r7Qw7HIN+ECHWx5Hirtz1dKV fiC0TxuX ztCQkmik/iX2rUKjlMn12yE918ZGJc/4ojdV21tRjdsw3geABm8cn567DXLfrqFbJGjO0ClBEcPsL1cgZmPTUb41v4UPxagksuS+bS8ozbRW0AMy4Aorzo7YwzXfuVfzEsiuNXDcqGm+oe4l7M2Hn437/X5JNIeH24CV4xb3THeLb1bGEner+csLrzhsR1RNDsTHFmpQMFzEUyW4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/3 10:28, Huang, Ying wrote: > Miaohe Lin writes: > >> Use helper function destroy_memory_type() to release memtype instead >> of open code it to help improve code readability a bit. No functional >> change intended. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/memory-tiers.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c >> index e593e56e530b..0b8b76078c12 100644 >> --- a/mm/memory-tiers.c >> +++ b/mm/memory-tiers.c >> @@ -587,7 +587,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) >> */ >> if (!node_memory_types[node].map_count) { >> node_memory_types[node].memtype = NULL; >> - kref_put(&memtype->kref, release_memtype); >> + destroy_memory_type(memtype); > > Not need to be changed in this patch. It appears that > destroy_memory_type() isn't a very good name, because we usually will > not free the memory_type here. Rename it to "put_memory_type()"? Do you mean rename destroy_memory_type to put_memory_type in a separate patch? This sounds reasonable to me. But destroy_memory_type is a EXPORT_SYMBOL_GPL symbol, is it fine to do the rename work? Thanks.