From: Cui Chao <cuichao1753@phytium.com.cn>
To: Gregory Price <gourry@gourry.net>
Cc: dan.j.williams@intel.com,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Mike Rapoport <rppt@kernel.org>,
Wang Yinfeng <wangyinfeng@phytium.com.cn>,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 1/1] mm: numa_memblks: Identify the accurate NUMA ID of CFMW
Date: Mon, 26 Jan 2026 17:06:52 +0800 [thread overview]
Message-ID: <a90bc6f2-105c-4ffc-99d9-4fa5eaa79c45@phytium.com.cn> (raw)
In-Reply-To: <aXOl9CN_66HywIjZ@gourry-fedora-PF4VCD3F>
On 1/24/2026 12:46 AM, Gregory Price wrote:
> On Thu, Jan 22, 2026 at 04:03:49PM +0800, Cui Chao wrote:
>> 2.Why a Kernel Update is Recommended Over a Firmware Update:
>>
>> In the scenario of dynamic CXL region creation, the association between the
>> memory's HPA range and its corresponding NUMA node is established when the
>> kernel driver performs the commit operation. This is a runtime, OS-managed
>> operation where the platform firmware cannot intervene to provide a fix.
>>
> This is not accurate
>
> The memory-to-node association for CXL memory is built by acpi logic:
>
> linux/drivers/acpi/numa/srat.c
>
> Specifically:
>
> acpi_parse_memory_affinity() /* if SRAT entry exists */
> -> numa_add_memblk(node, start, end)
>
> acpi_parse_cfmws() /* if no SRAT entry exists */
> -> numa_add_reserved_memblk(node, start, end)
>
>
> This patch implies the latter is occurring - as it queries the reserved
> block associations - meaning your platform is not shipping SRAT tables
> for CXL memory regions.
Sorry,my previous statement was ambiguous. What I intended to convey is
that the moment when CXL memory is actually assigned to a dedicated NUMA
node and becomes ready for use by applications is precisely during the
creation of the region.
> We have only seen this in QEMU - and this is correctable in firmware.
>
> But if this is shipped hardware, letting us know the platform lets us
> know whether we should backport it.
>
> ---
>
> All that said, this does look harmless, and seems reasonable - but the
> changelog should reflect what the hardware is doing above.
This issue was discovered on the QEMU platform. I need to apologize for
my earlier imprecise statement (claiming it was hardware instead of
QEMU). My core point at the time was to emphasize that this is a problem
in the general code path when facing this scenario, not a QEMU-specific
emulation issue, and therefore it could theoretically affect real
hardware as well. I apologize for any confusion this may have caused.
>
> ~Gregory
--
Best regards,
Cui Chao.
next prev parent reply other threads:[~2026-01-26 9:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 3:10 [PATCH v2 0/1] " Cui Chao
2026-01-06 3:10 ` [PATCH v2 1/1] mm: numa_memblks: " Cui Chao
2026-01-08 16:19 ` Jonathan Cameron
2026-01-08 17:48 ` Andrew Morton
2026-01-15 9:43 ` Cui Chao
2026-01-15 18:18 ` Andrew Morton
2026-01-15 19:50 ` dan.j.williams
2026-01-22 8:03 ` Cui Chao
2026-01-22 21:28 ` Andrew Morton
2026-01-23 8:59 ` Cui Chao
2026-01-23 16:46 ` Gregory Price
2026-01-26 9:06 ` Cui Chao [this message]
2026-02-05 22:58 ` Andrew Morton
2026-02-05 23:10 ` Gregory Price
2026-02-06 11:03 ` Jonathan Cameron
2026-02-06 13:31 ` Gregory Price
2026-02-06 15:09 ` Jonathan Cameron
2026-02-06 15:53 ` Gregory Price
2026-02-06 16:26 ` Jonathan Cameron
2026-02-06 16:32 ` Gregory Price
2026-02-19 14:19 ` Jonathan Cameron
2026-02-06 15:57 ` Andrew Morton
2026-02-06 16:23 ` Jonathan Cameron
2026-01-09 9:35 ` Pratyush Brahma
2026-01-15 10:06 ` Cui Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a90bc6f2-105c-4ffc-99d9-4fa5eaa79c45@phytium.com.cn \
--to=cuichao1753@phytium.com.cn \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=gourry@gourry.net \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=wangyinfeng@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox