From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0989C6FD1F for ; Tue, 14 Mar 2023 22:16:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EF526B0072; Tue, 14 Mar 2023 18:16:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F536B0074; Tue, 14 Mar 2023 18:16:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 467CF6B0075; Tue, 14 Mar 2023 18:16:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 31DAE6B0072 for ; Tue, 14 Mar 2023 18:16:32 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 08DDC40134 for ; Tue, 14 Mar 2023 22:16:32 +0000 (UTC) X-FDA: 80568913824.16.B6FED24 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf01.hostedemail.com (Postfix) with ESMTP id 275B540014 for ; Tue, 14 Mar 2023 22:16:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WiWabfds; spf=pass (imf01.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678832190; a=rsa-sha256; cv=none; b=NCNIo/FjErEJs47mxheFO/W1tNF7qPGx158jTGyXTAmo8CiVMFBIKgFnwEyInQl3Qs4oPw gJQqgk8SGG/3HpteLEwo9Lvx7HrkuuDDWVtm696Fr/bO7z1mMukO9R3UZUVBzF6U/Ys/wR VSpwiYb37Fg4hwbHrGNITlt7KWI+a/I= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WiWabfds; spf=pass (imf01.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678832190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0cgXw1zWR3UzIeNQHSkd/Pe/JYZucLUkg0+siqDji1Q=; b=BgvK5x8lz2DEh20CHuKP/C/xZ0ebXVXKEwh8+xsupOs8MkBhUP3YyS/86OMIeZ03fs8+xB xW2oZVP11d4qPN2KiDZHfE5TWMcg0aIl+z5slDpz3B4qucSJgixG61B4llz8SJOZdzrLsf o1I84YkEQEul0xHkwrTSAHDI/EmMsgc= Received: by mail-wm1-f42.google.com with SMTP id o38-20020a05600c512600b003e8320d1c11so1265048wms.1 for ; Tue, 14 Mar 2023 15:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678832188; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0cgXw1zWR3UzIeNQHSkd/Pe/JYZucLUkg0+siqDji1Q=; b=WiWabfdsc40Hw03sHacABR/DpeHPE1ytk52ltiIHJyYU96rC0iS1lraEKpFNPMr7fC t88zt7gAQUBBIRqrgzPkQWQDI8IBIwbBSQ44S9GXEjINbumyhcaty1H8Wl8mk8TP7vah R+sSYxV3pSFKpraUvvKNT26Tl4bm9IX1cxQTO0YuTtRAf1JyKECbjwfkxjSm3C79t2zu WimroFz4zBdQaqQbKrHUb+k9u1UDe/t+bGf+sTOFdiO/SY1n3N2Yrx3e1ZAduqS48kT2 rVHJ3JqaH5emYPmU4Xh0N/DVVXcX1nJMZW+nmKAVSR8mX825oNgoQNZkzjKn0xyWZeQC H2Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678832188; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0cgXw1zWR3UzIeNQHSkd/Pe/JYZucLUkg0+siqDji1Q=; b=WZKr1WDt2feKvG9VU9QBoPbmZ9e8qLwxHXtWWrVk3VqkC8KO76l91O6/EXlkObJfiU YKPGcWpyXO6Rqd5LmYJ0SRcA5qPU82ffoHbH6LNVOnEXfvpt3FJAoJttZ8bn9KPCMbfo DoeiMhFv/57ZdRBQMLlIF0LT5PNLtL+5G++hSWVtWJRIkcFdwUWEi/uU8m3wJe4MCZ6M CpHAUEvvy7Gk+MNmuBxwRRwwcZ+pgWkcrW1X73DD/b2NXqQIkvlhV1I0sm0jOxMp/uNn rUbDP9RF50PWlTjO+pKirLshmyJF7ZVCFnTDQQlZ+bgTU8FL4TcblpErhGsEYhBEDOGk JVCw== X-Gm-Message-State: AO0yUKXOj/1RPDNF8W4/zPeR0XbCIdZq06XQyY8jxA/v2INWLG3xkvdi 9hPENes9+2kkfW8UZQiEWjs= X-Google-Smtp-Source: AK7set/LqyA4KOXjYW3gB61Tg1NOLoBdeKaWngQqOyAVUSHmnZgHB0VC+IljqkqXyulD+UybQrzJww== X-Received: by 2002:a05:600c:1546:b0:3ed:22f2:554c with SMTP id f6-20020a05600c154600b003ed22f2554cmr8549449wmg.29.1678832188560; Tue, 14 Mar 2023 15:16:28 -0700 (PDT) Received: from localhost (host86-146-209-214.range86-146.btcentralplus.com. [86.146.209.214]) by smtp.gmail.com with ESMTPSA id 4-20020a05600c22c400b003e00c453447sm3977442wmg.48.2023.03.14.15.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Mar 2023 15:16:27 -0700 (PDT) Date: Tue, 14 Mar 2023 22:16:26 +0000 From: Lorenzo Stoakes To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , Andrew Morton , linux-mm@kvack.org, rcu@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, netdev@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 4/7] mm, pagemap: remove SLOB and SLQB from comments and documentation Message-ID: References: <20230310103210.22372-1-vbabka@suse.cz> <20230310103210.22372-5-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230310103210.22372-5-vbabka@suse.cz> X-Rspam-User: X-Rspamd-Queue-Id: 275B540014 X-Rspamd-Server: rspam01 X-Stat-Signature: wa516su91ion6zu4auyyz13ktjtsrdpo X-HE-Tag: 1678832189-548769 X-HE-Meta: U2FsdGVkX19bKZ+5XSuhSNeei5wT4f7pwBGX0tr85Q2/f8HJRvbS17I3WTOtNDGLZ2KoJTbGJfCcU1m9Cm2nSOEX1JLrpWi6tOtgTX1gHwfsYgjPuqKBnKLVoVQHl1qRJ0DsB1uY75+U3tuAja1ZpGzuIOp5IHAMLds+LHDBonFEhyihwSN6YE7xzF99N2gt1KrH4TpCEhizLMs4wjUCADerW36krpLpozm35rfE+uIaYv4GB3kAEv4kONQvK2ty1cbd9rk8lD5DtFKzlu7ZQxpVbW4pQ8poHEFqEqUaY//TTl2EId4WVKW2C0Jwmq7bckTQsg5xp9XAdCSV8msjAqm6PTIHDUwoZ/t4n+OCdHMVa5u2WtuE1GKEuvyITNv3cmwQr1uvwHhwfs1TWP2bE+eK49hTinAo3r1nO4E8hXCCKISr5+HIHlKT4oZXpCKmP6q8HavIRgG2C2GD1UqTdYjUwSzr34uNwR02ASsaEYaIBcT53+i5AGP8HcvlVhGUCPgGqeIm0Yt8hoYbWd2o99h5uU18qiTzWbY3/9x8iLifqmTmOAKngl+Lx7y/RIvy6i3oZ6tCX2U/VcrzZDH0MIlqCUyw7pFOA5IpsRpXcEncDkTfE0fCVJGOra/uw1xPnU62RZXeVdgqXKF1JUtv4ujt3hgmstvt6k9nUmsBojEn8UrN1q1kZuh4rxbIQsGuoKooICDVtE93NtIbLA/OvJ0uJcbqEscqc/qvJWlOQR2oMQXSGwZRY32UhfYAQXBXy8nLCMkdcvjQ68xJ3Al/EAN5+Gv9xEtQ64KwWnYjKVRkVcJAHeZIVsWk9bbwVRkS6D/13Cu3DUl5YGzZ5jnGp6Bxxip17UOkcdMvgyK4WVuFA9MCeMeY12yan+YeX8clsoX0oAgNlBKs0ndd6bjyQyXoO3Ij0PNI9S9QsUOWCk7JEeQXqA4CJq5NTkbiVkNHkg+rOonOhuPUP5oNFTT PbruOdc1 fenTQxd7XSjp80T9ROzHaHqFS/0K7fNUgT9KeL6l172Pb4uVg9CqlmPmKklGD0wh92/SbllBkQ2C7wr++X4/BDHrtyAt6XO9Qs6Vezo4Wukf+InE1jtD6PWJccgxhlmJicc4mu4woceLdrOyQN1xIWa68j1pvjbZwi4DW1tgrtDKd1w3hErWawKOyf6/BETxAbx4cLaN6gup7pLlVTfSktD1XSupZbmhpK1xcmVxNCHMEtVprKEgRFsTvOC5zl13aaAIPA7U5KIRM1d/XlmFGpJQP6o3w+jc9f7YEMnsNakPMm29rGOr0HwwJPOjLT+hCyOtUbQwGsAdMdifk8UHsRkoL7OhijCSHqM1zQt0+ZR3VNLUXHJyklR2Mri5HWdS5eqd/tebnP7kDW9nrFGZldfu8ksKFBv6j9oOUIMyxiA9JbuuBH9f82DmEFxud0SfraiqXR3GzRS7GVJ2GHWsBtKFb3sErbtp60anMp+WKsueVW2nE3kit1UYg54ov9obUL9Gg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 10, 2023 at 11:32:06AM +0100, Vlastimil Babka wrote: > SLOB has been removed and SLQB never merged, so remove their mentions > from comments and documentation of pagemap. > > Signed-off-by: Vlastimil Babka > --- > Documentation/admin-guide/mm/pagemap.rst | 6 +++--- > fs/proc/page.c | 5 ++--- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/Documentation/admin-guide/mm/pagemap.rst b/Documentation/admin-guide/mm/pagemap.rst > index b5f970dc91e7..bb4aa897a773 100644 > --- a/Documentation/admin-guide/mm/pagemap.rst > +++ b/Documentation/admin-guide/mm/pagemap.rst > @@ -91,9 +91,9 @@ Short descriptions to the page flags > The page is being locked for exclusive access, e.g. by undergoing read/write > IO. > 7 - SLAB > - The page is managed by the SLAB/SLOB/SLUB/SLQB kernel memory allocator. > - When compound page is used, SLUB/SLQB will only set this flag on the head > - page; SLOB will not flag it at all. > + The page is managed by the SLAB/SLUB kernel memory allocator. > + When compound page is used, either will only set this flag on the head > + page.. I mean, perhaps the nittiest of nits but probably that '..' is unintended. > 10 - BUDDY > A free memory block managed by the buddy system allocator. > The buddy system organizes free memory in blocks of various orders. > diff --git a/fs/proc/page.c b/fs/proc/page.c > index 6249c347809a..1356aeffd8dc 100644 > --- a/fs/proc/page.c > +++ b/fs/proc/page.c > @@ -125,7 +125,7 @@ u64 stable_page_flags(struct page *page) > /* > * pseudo flags for the well known (anonymous) memory mapped pages > * > - * Note that page->_mapcount is overloaded in SLOB/SLUB/SLQB, so the > + * Note that page->_mapcount is overloaded in SLAB/SLUB, so the > * simple test in page_mapped() is not enough. > */ > if (!PageSlab(page) && page_mapped(page)) > @@ -166,8 +166,7 @@ u64 stable_page_flags(struct page *page) > > /* > * Caveats on high order pages: page->_refcount will only be set > - * -1 on the head page; SLUB/SLQB do the same for PG_slab; > - * SLOB won't set PG_slab at all on compound pages. > + * -1 on the head page; SLAB/SLUB do the same for PG_slab; Nice catch on the redundant reference to the mysterous SLQB (+ above) :) > */ > if (PageBuddy(page)) > u |= 1 << KPF_BUDDY; > -- > 2.39.2 > Otherwise looks good to me, Acked-by: Lorenzo Stoakes