From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0601CC83F09 for ; Tue, 8 Jul 2025 15:42:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1C6A6B009F; Tue, 8 Jul 2025 11:42:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F2C36B00A0; Tue, 8 Jul 2025 11:42:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E1E26B00A1; Tue, 8 Jul 2025 11:42:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7A83B6B009F for ; Tue, 8 Jul 2025 11:42:24 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D9AD25A89A for ; Tue, 8 Jul 2025 15:42:23 +0000 (UTC) X-FDA: 83641514166.03.B8938A4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 5C6591A0003 for ; Tue, 8 Jul 2025 15:42:21 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UL+jT6t0; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751989341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O1MbuMS/xAVXqVQl4KdN8hBfeBeFym/jGvqVlzXbTwQ=; b=mVLQgFLm8GnyjLBo7iMmnS1bNzjz/V2kCi1SmmT/Yjn7hps7ITNRv8rx9i5ldYF4VjZJ+M K1rstPQGw1wYnY4CMB/XnA+sGsEVXP+ZUwA3M2q6iWZVjZtQ46JXtYR+Rh03lMJuDTy850 PRWytUquh06D9xgbfM+yXOC5ZJLqAVY= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UL+jT6t0; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751989341; a=rsa-sha256; cv=none; b=AmnR6+vu4JPM4rDi3Lkb//5LFYgwA3p09YgZxSzA1ALyfC5XZrr+f8u52abd5R38TiZI3l P+tKc2hjOXQLdXFOqtDRhbmPSEYqzbmX2gf7MLOYVThd2QGSNa10+esqibJVk2N0fjs2T0 20f4+YzUq8ZD/TO2TF8s9a1K0IT4LL4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751989340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O1MbuMS/xAVXqVQl4KdN8hBfeBeFym/jGvqVlzXbTwQ=; b=UL+jT6t0+WgFzdzSVGg1N9RPvIIgc2B49rvK3Ww+JOxh10a8o1zYMAusU/OVviYBEIHnlo VoSG5ydNyZCoLO95it6nd1cX5oMo91tVd92jVbqUZ+FWnUxTc3kAPIsSbv0WovzAxPvkH6 A7TODHEkR1i6e+Qr+QlO9vUgJKPH0pI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-BWO-WId0NT-JNDqRJF6sfA-1; Tue, 08 Jul 2025 11:42:19 -0400 X-MC-Unique: BWO-WId0NT-JNDqRJF6sfA-1 X-Mimecast-MFC-AGG-ID: BWO-WId0NT-JNDqRJF6sfA_1751989338 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450db029f2aso21613245e9.3 for ; Tue, 08 Jul 2025 08:42:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751989338; x=1752594138; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=O1MbuMS/xAVXqVQl4KdN8hBfeBeFym/jGvqVlzXbTwQ=; b=jJhiwL3FA8AkqvbfMoWG1Ff6h5b+CFOC94E0Y8T+fZfebDPtEdzMkfSnPLGZpT7Rqd xnvXun0XJtWraZib6ercGdV5E3Q92l8nTDlGPCx2lzqxbyx2w3ujuLFSIur0NVI29pAs izVr8aqwiWOBcSgeZpgXQ8Q1s65qi4Tko/7wNxv0VEVnXYt4iK9JYXgfvN6POh1KZrDS 65UjOxi0S683MXj7vo+A2UsgcKU9mJsPMqNJ1ftAvOYWHx3KRkrilMTmh6WeEbnmMc3h XpiWZbDCkYV0+FI9owaavImR20BHn1vWMsokeK95aP79qAxObxjtOuGy70703YMwTlRl kIGw== X-Forwarded-Encrypted: i=1; AJvYcCWs6AipB2eAEAC298jXiHdM0NYPEgN+0b2ArB72GM8+2zSb7hZJ5+jfFhY+8spnKjvFueCFI1Tivw==@kvack.org X-Gm-Message-State: AOJu0Yw55qe+NoF3j/tOwp/tv9Wh/pUfgIOILJhZKkxaXx7EikhKiRHN 7GEJO/gn2cNj8q7x1+TlWUKum0BqR2RhJJt306kaa63yKbqLqOEBl8O1CgY6PEUKrXyeRqOXbQp xbgusFS7D4xlEDCkgs0PBS2/iLuQKBlS626ewhWh2r9Rb/mm9YZcm X-Gm-Gg: ASbGncsDIwJq3NjQUyWrK4/l+FUxZ6el1bZVOesCfsOquq25BDLa31sOiieC/fi7Dr4 DE1ivwlLmiQEHRASlrHvyIciQYram6BlWguJcrI9uXozceynLkIPpVYHd63B6ljvc/0o4gxvEjs m0joovoplIMjk2Y8a+Lft1jHlucFZ27c9r7BtxZ0pJ1QR8jefqKUYI+c2GLYyw77Wiyh8Rez2hD jPBM8rifmwPkrCSe7Aw1cAzQC7PEmV8DEYs5+5a6an+T0rhlsTgStya8PR1gFWQjerxN3wJnCde MPfVB+bWQpD6nBb6XoHjv3LFH1P5qw6QkpJg2KAC+ta6Gi6CmgbDgHdm+enr9dpLVdcnE3JA2wC Mo1+snt7foDYEKmahUedQwSWGyFucuWrBDD/yABNveAwhB/rYjg== X-Received: by 2002:a05:600c:4f16:b0:450:d37d:7c with SMTP id 5b1f17b1804b1-454d31e6959mr2742995e9.21.1751989338075; Tue, 08 Jul 2025 08:42:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8HZ/ySqJpRlxvKJLl+IGmRqojZ/l2Gp1cwjot7XvUeM+y9qFyp52qh/IPBupG3LXayXcx5Q== X-Received: by 2002:a05:600c:4f16:b0:450:d37d:7c with SMTP id 5b1f17b1804b1-454d31e6959mr2742615e9.21.1751989337562; Tue, 08 Jul 2025 08:42:17 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:f500:4346:f17c:2bde:808c? (p200300d82f1af5004346f17c2bde808c.dip0.t-ipconnect.de. [2003:d8:2f1a:f500:4346:f17c:2bde:808c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454cd3d2754sm25689455e9.24.2025.07.08.08.42.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jul 2025 08:42:17 -0700 (PDT) Message-ID: Date: Tue, 8 Jul 2025 17:42:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/userfaultfd: fix missing PTE unmap for non-migration entries To: Sasha Levin Cc: Andrew Morton , peterx@redhat.com, aarcange@redhat.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20250630031958.1225651-1-sashal@kernel.org> <20250630175746.e52af129fd2d88deecc25169@linux-foundation.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: i2pAHYFj9sma-BMcb0bRj-quvfnD6I1EiXPxm_CzOoQ_1751989338 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5C6591A0003 X-Stat-Signature: 7g9znxqa1tna9ru5htntotbqd91jkphh X-Rspam-User: X-HE-Tag: 1751989341-173590 X-HE-Meta: U2FsdGVkX1+4Vy/c6bSw6pThsmGGIYwZBGbtBUDwlY1jcXYfiZVPzFVmaI1iXALl6TG1DC08qYnMbR+F9U9nVFUfYg9G0oIyQMGpzT1tBINAiqWy3E/uujptZEpIfgsKePzaD7MDGALch9YO0zr/JDEENQmrKEAGYYJS/xCjmB4W06+YyrbOrnzsmMHCwjynOp3pXitRIQE6WUJFoJsaKU6IgrSkbVxqp58AOs0hpNpckASt0YcrErbyHJUO4Cyown1aXgXnOd+1gL6DH9bQtC1dtjIY0GCmOr9QS0MfrmvjAOzEB6n+eHQRlEN8QJZwLrb6BKBSGLpHz3We84cWlr5HhmLjaO9uVV0cEVjP2MKsRHo7BIHIe+IBoWxQKkv4AE1Hm0itH46/4bU80wDDaPgyo6siv90UqynGa94IaB3bH0p6bVxutT4d028GE0+VNhHGAuIRgijPOb11NAF9Y9ggW3lc8X5mOxwpm5d4+mat2xoMklLqiS0uOHF3LXs5QNQh/BHeF9hVsDo1IYyWwHoqBfsfA7PXlCgEhOtme0EEzekNL8THRfQiyzZ/cGtA3Z9hGTDDTUeC/pijoiHC8Y4Icir+3aYGM5ysS+71+ScUyRWGc5/6AaZyJhZzflxE30xAs4M7N5nY74yAyS5hxdVr9xmaB9eYzNxw3NNIzHp/fIheg1bPgD5OIGenib4yDbtbjn7gWhEQBVZ9qgc6/JgrTRK4TrHTXzA5//nUXNWNeUM1IkymnEzNqxJPafDxTs3NrGsPf4C67vxj0EmkgfstK8xknTjEknVXZioFwV08X0+cWKzcXITlaN/riEE+P73/Y4y/VJUN4C1ZTA20QWfumioyzBTLbNLjCJlUJDn4YYn+xWpnwhndzxf0i14qViHJGrLOMQzBQLZR42qDVOI4fX6LYRZ2igIEDwtbbPnsfj1Ztw9a03hwVUiUPM7aj9UXeOg5sWLRoidt1Fi sr1qVd6F Fvg1/4spanTLVSwngRS7LhAQ85FkBeasTJnQxVT2K12v3PHwOVcJThvr8y5X/9KWSawnEewpSNaMsNuCmnVOpKilJGR1W1J+/XrnJhEO2Z26NlyrDnnyKDaFa2OhL39aaO4C3mApdMhPJLzkVDwjriSpBYRx0y+DCYJu6b1dEWENkBx9AEF0i4Ul0vfCKn38Fp8XYZsPSp1BaIFrgA28mpeL/V8Wqgf5DdJMlEFs38lxL+0XPZNaSehEsfrS9vZLWckqHkkNPj3zx0iMXa0dJ8L5O5CS9cm53i9HeCHXFf82SfWesq8Hhbf3kC/xxZkCO6qvPLeyh+vemTKW9/pBHKaM+q4/5BjqKHIS3TLbRZNJet6VAl735IakiwjIMkSM148CbBDm56yVUTmWL0WfTQi/DoIsGuoWaFAcGj7TaC/DtwUzbwXqs3z2m1ZvlT2GcgnBmdQEyGWbHfwY1yPMf080ePBiuM3nr830ff99mvritnsI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.07.25 17:33, Sasha Levin wrote: > On Tue, Jul 08, 2025 at 05:10:44PM +0200, David Hildenbrand wrote: >> On 01.07.25 02:57, Andrew Morton wrote: >>> On Sun, 29 Jun 2025 23:19:58 -0400 Sasha Levin wrote: >>> >>>> When handling non-swap entries in move_pages_pte(), the error handling >>>> for entries that are NOT migration entries fails to unmap the page table >>>> entries before jumping to the error handling label. >>>> >>>> This results in a kmap/kunmap imbalance which on CONFIG_HIGHPTE systems >>>> triggers a WARNING in kunmap_local_indexed() because the kmap stack is >>>> corrupted. >>>> >>>> Example call trace on ARM32 (CONFIG_HIGHPTE enabled): >>>> WARNING: CPU: 1 PID: 633 at mm/highmem.c:622 kunmap_local_indexed+0x178/0x17c >>>> Call trace: >>>> kunmap_local_indexed from move_pages+0x964/0x19f4 >>>> move_pages from userfaultfd_ioctl+0x129c/0x2144 >>>> userfaultfd_ioctl from sys_ioctl+0x558/0xd24 >>>> >>>> The issue was introduced with the UFFDIO_MOVE feature but became more >>>> frequent with the addition of guard pages (commit 7c53dfbdb024 ("mm: add >>>> PTE_MARKER_GUARD PTE marker")) which made the non-migration entry code >>>> path more commonly executed during userfaultfd operations. >>>> >>>> Fix this by ensuring PTEs are properly unmapped in all non-swap entry >>>> paths before jumping to the error handling label, not just for migration >>>> entries. >>> >>> I don't get it. >>> >>>> --- a/mm/userfaultfd.c >>>> +++ b/mm/userfaultfd.c >>>> @@ -1384,14 +1384,15 @@ static int move_pages_pte(struct mm_struct *mm, pmd_t *dst_pmd, pmd_t *src_pmd, >>>> entry = pte_to_swp_entry(orig_src_pte); >>>> if (non_swap_entry(entry)) { >>>> + pte_unmap(src_pte); >>>> + pte_unmap(dst_pte); >>>> + src_pte = dst_pte = NULL; >>>> if (is_migration_entry(entry)) { >>>> - pte_unmap(src_pte); >>>> - pte_unmap(dst_pte); >>>> - src_pte = dst_pte = NULL; >>>> migration_entry_wait(mm, src_pmd, src_addr); >>>> err = -EAGAIN; >>>> - } else >>>> + } else { >>>> err = -EFAULT; >>>> + } >>>> goto out; >>> >>> where we have >>> >>> out: >>> ... >>> if (dst_pte) >>> pte_unmap(dst_pte); >>> if (src_pte) >>> pte_unmap(src_pte); >> >> AI slop? > > Nah, this one is sadly all me :( Haha, sorry :P -- Cheers, David / dhildenb