From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A28C3ABAA for ; Mon, 5 May 2025 13:02:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0F976B0092; Mon, 5 May 2025 09:02:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E94B16B0093; Mon, 5 May 2025 09:02:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE7CD6B0095; Mon, 5 May 2025 09:02:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A8EF16B0092 for ; Mon, 5 May 2025 09:02:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5DF1459105 for ; Mon, 5 May 2025 13:02:10 +0000 (UTC) X-FDA: 83408867220.05.DB99663 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id BC1071C000F for ; Mon, 5 May 2025 13:02:07 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="at/koz1m"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746450128; a=rsa-sha256; cv=none; b=cdIwisGDZ33knsRzjE+pnk/IU1zktluRL1s8yU9h/Xik/Nc8u8McyOfKBwF8CeCeIESF/H YvnIMTAyrJNbtpzJGKDECjjg95GrBZlMiUKkiULH04rV9w/+ayV47uUNQxerCyV/o4TGj8 MkwXqZhD/lDu8G1hxe5VpWQHf/eYq5Y= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="at/koz1m"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746450128; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lcq9nBP3ZRCfusgIDw58LKjlT4CGzBWjkt+QgAcwfS8=; b=aGlW28nvnW3MwpOa12AlaCSUMB7Eq6Gn+5E3G55m/btV9Y7QMwDZ2OAAIFmEqmTgZTZ93u Xa7DQ55iEEmszmLKDjtwuwuPC99r6KQMZueAs/z9tfE3/xXs0uTHgaVfYq6lIMVrtuCq8Y azLG35ckBhuk/uFfaz80tzZ+ghqW9xc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746450127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=lcq9nBP3ZRCfusgIDw58LKjlT4CGzBWjkt+QgAcwfS8=; b=at/koz1mNgyj3q16STE+f+8ttNpgTxS+xg8eeWolSGOgHozSul3AfBa2TQsQhAG8pt+i/Q o7O91/PEw0ekbZX5XjTOWisz2sGnouJiglU8Dcz2zBwl81nCAQb983lIT5v8vYVxpyQtSI Xj7A4WBctRkjbs7qC6JOQL28koEBWrI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-OnqaplWYOMWUUrVXrXJX-w-1; Mon, 05 May 2025 09:02:05 -0400 X-MC-Unique: OnqaplWYOMWUUrVXrXJX-w-1 X-Mimecast-MFC-AGG-ID: OnqaplWYOMWUUrVXrXJX-w_1746450124 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-39c184b20a2so1246689f8f.1 for ; Mon, 05 May 2025 06:02:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746450124; x=1747054924; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=lcq9nBP3ZRCfusgIDw58LKjlT4CGzBWjkt+QgAcwfS8=; b=tgshK42b7dPxDv14PRKa69ykxXQYgkLGCNRErg8Y6252iu7SYXVDuwmwmLzHtTbt2X vTH1tyFQNWtFxLe8bWGwci9I3E5fd2lELQEKUbrOXaYnjgwzqgMw5HZ3qR9oJeCuKfNk Pl3C5XLq9Uq2LWly5aBN09cxSbgMf1rAfuoV0adtFNPmmJlAsFqAt438pjwomiNovAL0 Xf7qGpDm2VpM4hlsOh5fWawTJ9VObl7qdZxjYOiDgVTOHaME4Be/EEXcx/RWaNAifew6 hNblHEqXqKtS1OlWAV+JitemTYXVTz6zL2/j6hgPtFnFuSWmLY2LbAONwBvLbyhlUI1b OpIA== X-Forwarded-Encrypted: i=1; AJvYcCU/PWhnS+ER1ty+VT07qH7V5aacXuoXcog+S3GLROvB63JAfXg38Z95KY1DLvAwhQ41t3lM5vVWiw==@kvack.org X-Gm-Message-State: AOJu0YxP9k/3Ua7Iv+bezBe+JL9YhOBhrC59TGmOQ7TIF31pLPFmGz1U QcthV5fDjOzV4Fd1Mf+CRH7Xjdt7Y9pV2l7WFy1L5EaBx9TiRZWBNQtJvSH3BDH8n08K41MYy98 FqTPXeYBn8ipdFPP5ud2LuE/+VR5IyjNTDII+QuNHqiqFQkDZ X-Gm-Gg: ASbGnctgZqxovJUn3dGx5iOhGJMMbWPaDDDDActXZsreHCZjFze3oaP0usAwmVfxlJr Lq2UZN1eWQYZrQYqZYpkfsccst6UMoLnnOVDL7NrlR08CKmHKGn2C60mqztzwVt2m+K0IK/sXIv 6uINy0gxl0cWRxIB2dCNaQHP8WRboPcBYF275e82mwLoo2iESJcju7hnamRBopM/0tktcgCMJ4v 0HaXT6vE/bG5/ae5DKuGjGruCQuBtFprxcJurHC9HGD78Pbd4Z7H1CZODA0nlcm4jonS1j2LnJp 02qWtS+3IsKZjPv5lxWm/kWdpj3h2C2WS3pNRId51/fhwSejcsl3A3RWZODv7kVf4aFMcWl8Ll6 EOHK5QbdCzuaAEVnCBmgkvF0/+Xr4QmYPLvVBDiA= X-Received: by 2002:adf:cf04:0:b0:3a0:a09d:b2f7 with SMTP id ffacd0b85a97d-3a0a09db5c7mr4342545f8f.57.1746450124412; Mon, 05 May 2025 06:02:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdvC1DTXrZIPIxmt4B4oCiYR+taOCdOzskFrRBkszS9uF++wO0dkgaJMa9iabo+Xj8Z6FgYQ== X-Received: by 2002:adf:cf04:0:b0:3a0:a09d:b2f7 with SMTP id ffacd0b85a97d-3a0a09db5c7mr4342508f8f.57.1746450123831; Mon, 05 May 2025 06:02:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a099ae7bbesm10162069f8f.49.2025.05.05.06.02.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 06:02:03 -0700 (PDT) Message-ID: Date: Mon, 5 May 2025 15:02:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time To: Donet Tom , Oscar Salvador Cc: Mike Rapoport , Zi Yan , Greg Kroah-Hartman , Andrew Morton , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <188fbfba-afb4-4db7-bbba-7689a96be931@redhat.com> <74c500dd-8d1c-4177-96c7-ddd51ca77306@redhat.com> <0e568e33-34fa-40f6-a20d-ebf653de123d@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6KVUV1NAFG0LOk_ozvEFCARmYAYw-DlSv1H5pHP7RHs_1746450124 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BC1071C000F X-Stat-Signature: 5cewu3dmijmzz3an86yqttu5qctx4yme X-Rspam-User: X-HE-Tag: 1746450127-534439 X-HE-Meta: U2FsdGVkX1+pn3A27DfoonOWitV+SaHrbYekKk7yJtacpG43XBI29Xp0Q7p8wvWjLtuIVBW94MBFhwr5b9IS8mQNcp8bBLZFHGOlgP51+vUFvA6c9W8AOh02xTe311L5TgV4D5yv3klLiRmYsMh6z+4KuqJcco84ZhEzUBHG4onC5NuEVypTF1VDbBjHrd/rw5xtxh6pv6x/c0IFX3Gf1zyqK4krJUGEYFXZXCBwsnZ8wYXjyH/ytwQhf/6xOkvPLecCYFJIlXCQaw8bxHpRD6pLngndZPQguKY+Xrla6REtSueD3tTUiGBCTzUgqn2DHg350LSEQMTM0gFkjziqyn7I+bguXmvBPmjMsdKPi3WtuUxS2cuhAfsfOrk5L1ZnpzWvYIyZYyLuQfrVfulbD9F1D9/DdrKXm2oCFHkKGnXpfm2+v6lP5+4W1MrGQl+f1FSH3XaqcKrHqcWcLJ/dV4mpwtr/Y0eMauzJWJH/DM5ntxWaT8zUFVzjLpIqMB9y5Q3HZAmCtyYPq2XM49o8qjF11PhCw/PHMf79yU/XM4SIh0Atc2T+MQJX8CO9YjonBGDS3mJlRwfvVg2uBIVzZpR4q3x/uEgAGyPPSfh+qKsLcMy7AFEzgcZkLX8ZIkjNrdBxaB4M3G5+avDkTUkOfVhqc0/caP5jV2aH2aLrHM56xYyfSlR6CSnta3zZOdMOd/dX81dpqwaH/Z2hVQ93NaXhLwugchbstpCGM0k3qb4xBJslHJoPclfnD6X857ri3d+mLdDLZyFfNufx7v3GLxV6Nu9j9kidd5gs7onpMr87t9NH8Z9fHIdpfTZIAL7cksgJDfvNasLoheVhMC402yXnk42N5SFLn/enzpNZyeYLpukWKcCndi1TILvEmVTGzVE4skcw4QNtIhU4EVtWBq6plYlaz9mgob/YW0++oqstunp3jNAMbsVSbe792J0gJXZ7xY/YXtUlHiZ91V7 90h7KR4q aE/Zr6Nr5TueJFg564wmsfEEHC7erTJv9SDX3lQFRUY9MwqI5ZbB0eEilSRlx3ebAAV8zoBudwJW4FrljVc1SjnV++NcgzY1hoBgaU9IH7ANIV9u8w4Eg5OeqS59BqQ1rkmyNmY/96gJSC0KT5RIbyWSsuQBiVOwGOJISlP9bvq6pJd22SABC0S4ZPW0trxVrxjDHdlWDo9AvczrkfcCU4W2eLTud6YiTnqueInfFrUO9tZkMSsviR7eONVpKpr23U0kfMUAWWDMc02H6ZKKleI6RY9RjmTvl16UOTLSnJ+SgdiLzFssz5juSNyHIC3TRdb+NHRhOcHj6Zi0mRP58nQVanVTAGZtiEFBCA5lbi4hMD5Agm+q5YJTa5g+J3SyROJM80tz5MbBVsPJf+y4e7t1W2oQM+esib4323SwYltsFgTeKL3dHAcIGLDQLvBJlAT3Rq1QHngpNQCcJDMGYX/ucdlIg+5++bDH9sp1H/y+JOg0eUd/1JcLKSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.05.25 14:51, Donet Tom wrote: > > On 5/5/25 4:06 PM, David Hildenbrand wrote: >> On 05.05.25 11:36, Oscar Salvador wrote: >>> On Mon, May 05, 2025 at 10:12:48AM +0200, David Hildenbrand wrote: >>>> Assume you hotplug the second CPU. The node is already >>>> registered/online, so >>>> who does the register_cpu_under_node() call? >>>> >>>> It's register_cpu() I guess? But no idea in which order that is >>>> called with >>>> node onlining. >>>> >>>> The code has to be cleaned up such that onlining a node does not >>>> traverse >>>> any cpus / memory. >>>> >>>> Whoever adds a CPU / memory *after onlining the node* must register the >>>> device manually under the *now online* node. >>> >>> So, I think this is the sequence of events: >>> >>> - hotplug cpu: >>>    acpi_processor_hotadd_init >>>     register_cpu >>>      register_cpu_under_node >>> >>>    online_store >>>     device_online()->dev_bus_online() >>>      cpu_subsys->online() >>>       cpu_subsys_online >>>        cpu_device_up >>>         cpu_up >>>          try_online_node  <- brings node online >>>           ... >>>           register_one_node <- registers cpu under node >>>          _cpu_up >> >> My thinking was, whether we can simply move the >> register_cpu_under_node() after the try_online_node(). See below >> regarding early. >> >> And then, remove the !node_online check from register_cpu_under_node(). >> >> But it's all complicated, because for memory, we link a memory block >> to the node (+set the node online) when it gets added, not when it >> gets onlined. >> >> For CPUs, we seem to be creating the link + set the node online when >> the CPU gets onlined. >> >>> >>> The first time we hotplug a cpu to the node, note that >>> register_cpu()->register_cpu_under_node() will bail out as node is still >>> offline, so only cpu's sysfs will be created but they will not be linked >>> to the node. >>> Later, online_store()->...->cpu_subsys_online()->..->cpu_up() will >> take> care of 1) onlining the node and 2) register the cpu to the node >> (so, >>> link the sysfs). >> >> >> And only if it actually gets onlined I assume. >> >>> >>> The second time we hotplug a cpu, >>> register_cpu()->register_cpu_under_node() will do its job as the node is >>> already onlined. >>> And we will not be calling register_one_node() from __try_online_node() >>> because of the same reason. >>> >>> The thing that bothers me is having register_cpu_under_node() spread >>> around. >> >> Right. >> >>> I think that ideally, we should only be calling >>> register_cpu_under_node() >>> from register_cpu(), but we have this kinda of (sort of weird?) relation >>> that even if we hotplug the cpu, but we do not online it, the numa node >>> will remain online, and so we cannot do the linking part (cpu <-> node), >>> so we could not really only have register_cpu_under_node() in >>> register_cpu(), which is the hot-add part, but we also need it in the >>> cpu_up()->try_online_node() which is the online part. >> >> Maybe one could handle CPUs similar to how we handle it with memory: >> node gets onlined + link created as soon as we add the CPU, not when >> we online it. >> >> But likely there is a reason why we do it like that today ... >> >>> >>> And we cannot also remove the register_cpu_under_node() from >>> register_cpu() because it is used in other paths (e.g: at boot time ). >> >> Ah, so in that case we don't call cpu_up ... hm. >> >> Of course, we can always detect the context (early vs. hotplug). >> Maybe, we should split the early vs. hotplug case up much earlier. >> >> register_cpu_early() / register_cpu_hotplug() ... maybe > > Hi David and Oscar, > > I was thinking that __try_online_node(nid, true) being called from > try_online_node() might cause issues with this patch. From the > discussion above, what I understand is: > > When try_online_node() is called, there are no memory resources > available for the node, so register_memory_blocks_under_node() > has no effect. Therefore, our patch should work in all cases. Right, it's simply unnecessary to perform the lookup ... and confusing. > > Do you think we need to make any changes to this patch? Probably not to this patch (if it's all working as expected), but we should certainly look into cleaning that all up. -- Cheers, David / dhildenb