From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78741C19776 for ; Fri, 28 Feb 2025 09:09:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1E1F6B007B; Fri, 28 Feb 2025 04:09:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ECD2D6B0082; Fri, 28 Feb 2025 04:09:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6DB46B0088; Fri, 28 Feb 2025 04:09:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B95536B007B for ; Fri, 28 Feb 2025 04:09:43 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 722131405CA for ; Fri, 28 Feb 2025 09:09:43 +0000 (UTC) X-FDA: 83168780646.18.8D0C052 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 0A73D140006 for ; Fri, 28 Feb 2025 09:09:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dn6mFbnI; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740733781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bNBOfaUsEVE1WE4tuVeIJP7JgkCRJme1Trp+BqRgXwE=; b=0rWd5XJNWuNtBSDVmS9pwfJjmpSlkEmDxTBEjSZgIW40MjKBZ7v/O/KPjOiPjpI8te7F8C Qyb+G+dpLis7qET8dOPDOMLktquJ1eryuOCQ9HdXGoCoBK5KXsyHiXhbXcVxB0tN6a+Yc4 Uq7N2CDY4GllNX3J/BDDdPMw+EurVGM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dn6mFbnI; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740733781; a=rsa-sha256; cv=none; b=JjBflxRbrFyHhZ0ZqUBkzf/chkfEhYxFPE+dm+UDpwXbh7IAIhoh+Ua1pp2CcV9eR9DE2E HhMmElc4iiRwrKMK66O63p64fHtNXMpUUxu9yGl5HANb2Ie4Wk3vPS/w4A6/bLe2Vpuh/5 WsXjAxTV2pxdfyC6Wc/g0GkBUH2ppOs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740733780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bNBOfaUsEVE1WE4tuVeIJP7JgkCRJme1Trp+BqRgXwE=; b=Dn6mFbnIZ5GFQ2PrP58zf4puyhMOiLS5MxjuzzBMUJx5662FoJjKgzBZDi395ZSlXaz3hp o0fgL29FOvEtraQvX+PTVaCuQQzH4BBni6pDurjkUHMKqEl7Fi70t8JUlalZvpgE3FIqCZ cS9Ygz/ZzdfuM07+5RBPVPbminjdTgY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-35B-eX0-Pb2DtolzwRdBmQ-1; Fri, 28 Feb 2025 04:09:39 -0500 X-MC-Unique: 35B-eX0-Pb2DtolzwRdBmQ-1 X-Mimecast-MFC-AGG-ID: 35B-eX0-Pb2DtolzwRdBmQ_1740733778 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4398ed35b10so9869995e9.1 for ; Fri, 28 Feb 2025 01:09:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740733778; x=1741338578; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bNBOfaUsEVE1WE4tuVeIJP7JgkCRJme1Trp+BqRgXwE=; b=jBosAfm57if1CbrW0ZaP4iMZgZTkeyJLeLmSlBlauL1BOviZcnN3C9bA8IBRLv0L5v rax2RgIRoVqFtDTkCfOKWo3JVkyrgEwjzXG6rOPzn8OCpWP41kOFZBXopgFt1ifLp/0L tPTgw5BBD6AhQihEbRBdLqjeS5SsopK1Ym0v2nBp0iuYYBq9/f3Y8KYyjgNiGW1oCpKO 4NiU5+TfaotQA/Bgjy5rqLYnr/dYWMepHNhTxiHsvnS8BYEK2ONann5ZeF3d1YYNWwfs w3eTzrEugwiJULCaIrd6eIuLQQ6ptLbBR4jQgTA6pGYMbqOncy25OybSvu8+eilpTvqn Bj5Q== X-Forwarded-Encrypted: i=1; AJvYcCX9/LLiT3/8a4ztdiIez32gJG0hU3K1HE4eAJvSDafgI6fmRp5NO67BDdnSbull1C1w0UyWifeVVg==@kvack.org X-Gm-Message-State: AOJu0YyjIMaXDQJyTgdkuNDmwMoVzrrmji/a5Zoi1IJk17nYnykUMZKV J3pYPVSAM5AG6eQWOfKRnlKZDNBgwDxPfcmiKZI2p8VGwH4G2xNRLBxKX93JXXh8dXIgcNflqsJ TJ5qmYnToByXz8vPGVoNUbZ2ELU4FvA29wa+MbW/OANgiYKer X-Gm-Gg: ASbGnctkAACPx49VM60j6ca+/7LNqKUKf4D97m9XI7QirH2Mg1xwjgjyHuKmOAvrkwQ cuHSDSZIfP0lyfOJUlxzIcIalPY0sO0TSdQwdTxtcK+SQJHZUlULPNR2Ok2a4K5oLYbolNQvGiB IWrsgXM3Bh6qrYvVYUfPzZZF2XccVyq8FtBJH2b1mqD5qEPspsP+2OB9LiHD+p8shl/lIVKiz4a 64a4lGqdhxu0bXv4J6UGqPioHU/2iUAPY1Eh4ky1a1wwvsuCrr6aae/LJdbSteuEneg/9auFaCn FgK+IWTKIEuzrrMJKH/AIuwLGyoJ+Mnhl11MMzEaoSilyBmJhLXcCgH6LSW9ZgYobM5lGb+XUe2 qhHd9B1hqPESXBbHYiwfvPMQxODM2ZSAqHiFtYms+qjI= X-Received: by 2002:a05:600c:3ca8:b0:439:94ef:3766 with SMTP id 5b1f17b1804b1-43ba67606b8mr17960295e9.19.1740733777658; Fri, 28 Feb 2025 01:09:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXr6Wi01aqBedbj7Dem90wxj+u2b2qPAW38UYsPBSAAjWWcn4dy/B1BZzcdMvyHyWYteAbpQ== X-Received: by 2002:a05:600c:3ca8:b0:439:94ef:3766 with SMTP id 5b1f17b1804b1-43ba67606b8mr17960025e9.19.1740733777311; Fri, 28 Feb 2025 01:09:37 -0800 (PST) Received: from ?IPV6:2003:cb:c701:e300:af53:3949:eced:246d? (p200300cbc701e300af533949eced246d.dip0.t-ipconnect.de. [2003:cb:c701:e300:af53:3949:eced:246d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba587163sm80791205e9.36.2025.02.28.01.09.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2025 01:09:36 -0800 (PST) Message-ID: Date: Fri, 28 Feb 2025 10:09:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] mm: page_owner: use new iteration API To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com, pasha.tatashin@soleen.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, muchun.song@linux.dev References: <68e82e87-606e-4443-99d3-7de6f665ce05@redhat.com> <5bb20271-a92a-454e-90e7-8812fd01d31d@redhat.com> <7ca09134-271e-48aa-b965-14fddd0504d9@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <7ca09134-271e-48aa-b965-14fddd0504d9@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VZ5M3U6et0PrVOaDQOke41I31yNig3D_BgSREozVWDE_1740733778 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4ct5epxk7ay1qgp6j3pimf81ze1t6b3p X-Rspamd-Queue-Id: 0A73D140006 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740733780-762366 X-HE-Meta: U2FsdGVkX18/JJFnaiTev0ALqmGjMnGvzJj4Z200lkSRCUT+6tdUXhbbtCQbN/MnfkVRTTpREdoHcAd+AP1ospn8atIMPgs/47OJ/M90B6cpYvPPwRb2lEZ43CVmVZun+gP/YOjzHkZB+RAgoRJqBbto6y5gRF8Q3rHDobdCb2hHSrmRqaQR7lx8UDqsqigjvy6B7dK/1FgSYUNxoYd9FrZvCq8HjEBW/38ijjxwxdcQ+HD0PE4B55mtRTaaMduq0e/mH1dsrG/M5tfAR88pxk0j/rhidXdXvmz8R4qH76MatM6R8VaO+PPvizna3rlO7wFxfvyaZjiCvELs22hRba+mLpkMWP2RvPtSh46nAuZmc6Mvf47QM+0qTuRuQfqHkEwi0WXRTYa5b7m/BMrnMbfWKaeG1I9OzUSm/G9dsXqi/qkBeXFTn2ujd+71cE0+707EEjL+q4MfMpSVbUVe9dSMTEl8gd2BIJP7JufGuOsa71qBBpydFAjYVWZgb2U3pkoJKc50eFX3pkl2L+X2qZIdnPaNFKnf1Nf1lWmFmH1Ka9a4X5TnpXgS8QsI3fmXvNv1cqVHZ+2FA/lBQVQwSuaCKQ7HcT3eRKm9gAMZXHbSPTlMqmgDMg5TWNcT9IcDRxqLycs4uq76hVcmiTgXAq+jRM/pv1LXhXciW/r0enLhhXltAt61UyP0sHFSCgd05v3yL15FNUy7FM/gVeDufXzVNJQ3tU4/57ijd0JgmOgVr7cXgFH7A6qU21SGeaeBbEu/BPy+vhS3FcrTv6MXINdOjRz4nveV+0hbbEsdW3JD3CGDIcsIkmPHI5+w8sMw/YuZYyUPiH87PE8U0u3hwM14jB95PkhJwfEEWtopaZcmb7R4R1yyhG5ZZYGJ1N6i+0BaxMsWmwF65kAerWdMQGF7PH4v6EzWXbRHfMty0lCvZpkk1+79bM9DcUe090e+fLQ6mEVXTQqViuKqEKc XbP8ef1Y TMq+Jyjgt/ubarSykQC/UbUG+ENNEZbgY+HsJJnFBDwnGNdb10+HDpwbxRwAIcXAQIYQ5UPmacK3xL+Dq3qYrHrd6HM5E4b/SdgmBsnW/pzjdl7mhR5bG0KgRVN8P/J8Yv7tftWI513OEol7vHA+w62b58GsS51qEUk9U2ciHgaRX4qeMXRx2MSgghtRtgB9onfEdZrk4Hh39AnYYlbAdRN728wJ6Unqv4+u6hnm+aX/iUgecYq1vNEL4w0NGZmY7f/jjxo6HRIR2Ehv9H3uPnl3AcyBpR3Oiq2xyuh/F5YfIUnUk11TtMfSpQQre7T4Q51ociG6Y5ZjpydRrjHjA+WVSehXI757e3E7bEQpU8u52RLe1pmpPzlXMqV5PwxFKvWCkk7uBsVjffBoNjOhEGQRylVIaZ9wBUrGUg7xYghMjp9wqiwBtAkR0DHMpQ7zs00mr9dSwA+TQv99ol+9JoPCJ6B9BIkEunLae7KVK5s7mwm6DGeTI2GcUnzg88Ssd2ilNi2b7O80w30qbihN2O9sMeTSwGFjQg3jeQOAqveXmuPcMY0ywyc4Eqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000040, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> To be precise, can't we simply do the following on top? > > Yes, that looks good and I like how the new API allows for simpler code. > > My only concern is that if the user is not familiar with the page_ext > internals, it might not be clear what page_ext_put() is actually > protecting in which case it looks wrong that we're using a reference > returned by get_page_owner() after releasing the lock. If you think > that that's not an issue then I can apply this change on top. The page_ext stuff only protects the page_ext itself, not any data stored in there. So I assume this should be just fine. (most of these cases shouldn't need any protection, because the page_ext should not actually ever vanish here for memory that we are holding in our hands; but we decided to just add it everywhere for consistency) -- Cheers, David / dhildenb