From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3FA2D49206 for ; Mon, 18 Nov 2024 10:05:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F0A16B00AD; Mon, 18 Nov 2024 05:05:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A0076B00AE; Mon, 18 Nov 2024 05:05:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F2656B00C3; Mon, 18 Nov 2024 05:05:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E31E6B00AD for ; Mon, 18 Nov 2024 05:05:01 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AB95980153 for ; Mon, 18 Nov 2024 10:05:00 +0000 (UTC) X-FDA: 82798780932.24.8275BC0 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf29.hostedemail.com (Postfix) with ESMTP id 31929120019 for ; Mon, 18 Nov 2024 10:03:50 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ViJ+mjcv; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=H72bCCP5; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1731924163; a=rsa-sha256; cv=pass; b=r8pBp9dRXMo3u6Zv8F6dMq6aveZs1s5ZbuiaicMcuHKE7yiLhu2fQNUuFt55A3KSusPF/a LP9s7C3oaK7SBp3NohcGREz6pQGcv5JEyO/z/HCL7z6MrxkEJKyk2QLSg5/K91sZrlcgQp roy9TdEynqQV6NkJshovEAQuv5owAHc= ARC-Authentication-Results: i=2; imf29.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ViJ+mjcv; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=H72bCCP5; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf29.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731924163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MHt6onxae03sTkLuKFidHcuDEYCMOm2Pak3Oh/4a/rc=; b=5i18IeMBgcOIBbyV4KXJK4uVoGp9UZeJSTYuzA2xSpuca68S36q7/j5WmC6IQPFuX5D0ev wU/CTmgap8gScrauuEyz7N9yOzcldHOwFCTUaAMn0ArAqiZ5irBNmdRv2pfA8KmmTmFQFV 0ET9Y57VCQSv8Ii34uFr4N5KR3Lq2uY= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI8R28P011100; Mon, 18 Nov 2024 10:04:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=MHt6onxae03sTkLuKF idHcuDEYCMOm2Pak3Oh/4a/rc=; b=ViJ+mjcvp23En1qoUw3S8aufEQvs1wPe/C mMvShAsmMp/YRAvlWY9xtMS6tnkhnRLN1dTvju03lS1Igk39yu9NOI0M6SXtLAbk Whc6kqBWzoeniOng2IwYeO+RLidx2dyu5b4wGA2xOfZAgTj/VD2Xs8vdMqS5MXxu zbDpT+sPwopgg2Zsl7E2o3JBpr8jX0FhsBnb279rMXiMt/f8giy0KdcC8WxOHRYQ mphZonxBprMiFHXK2q4HlQhx5ksXRDfxi8tZH3LpY4WFqMZeYXWk2CPolvyVZBh/ WGi/Hm0AAJEjrzsC0biT/78IiIi9V4M8WdDaBSBKkYazDjD9ZQeg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42xhtc2bs6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2024 10:04:54 +0000 (GMT) Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI8Vgxn023125; Mon, 18 Nov 2024 10:04:54 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42xhu787b4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2024 10:04:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qJWByinByUDK5sGnF+JNHSXwGKqmyx9e5cQbST1AzQa4Lk5TKBk+AlzILopG3zBEX6P5jng5X6GlxFpOkhgQ0PgHjmGBr71tqekIqresKYLS4zaeDfTZ3hAfNAQqBlojpMdAM6ojWmdFbokUEc0rcqiCq5KOYnzlyMaSkt90AaVHPk3r2l+WlBMPV7U4DglCWrOhRQE7qATw7F9fKGt9AsoVL4zfD6nrdv15ytAJRDpAySqsOyqyqZ3518pNYlQT1Y9s2fkeW1izAilIGkallfLeKOir0FxYX/TrtB30HoWRH98OU15o89x8oy9usH9wlpk8R51T5awUHr33M1/Y1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MHt6onxae03sTkLuKFidHcuDEYCMOm2Pak3Oh/4a/rc=; b=wm8K0zsTFO7ZWIoApSLrJ75r5bEClWAaoSWzUMHTVEmY+V+s1spHxcMTgHoDzZ4CpeTaNEQwhhAMklyrg1NgJtQeyFyG/R836w0DzSXpPgtqaaLisCM5x9aXdeVE3Mo0zfjwaUcXF6AMfs46D8vx7BQPh7Eee4TgMcJ/Jsb/8i5/CLsC/aqnUue2vIjE87AcYk88wh3j2pjgqSOvVcrKp3YAj4gzLbKdOxY/jxo520eRmVBHHzklGeWD8r1Un7FH+ZfeI6bVXXvmFdC6q7Yd9O9zjUjnhHRwCBfpOBdKtfSxb8rsTBhC8hGbUhVIyWrSW+/LfywV6BfjqtkVcMpQ6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MHt6onxae03sTkLuKFidHcuDEYCMOm2Pak3Oh/4a/rc=; b=H72bCCP5bO74cmyU+pepsKFq/5oFXtPMMZnrRXr8DQ9vwWnKUG8/jccOERF9ymjGvAMedQJdYTPk9WkHLvxMhk7c2JyZmdnBadogmK717VMyTTsSF1p9xVPU8SYFABTXU5ldAMP2ZcPKkg6x3Bq1tEfXPkg+R4Bnoo++iqydPKM= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH7PR10MB5748.namprd10.prod.outlook.com (2603:10b6:510:131::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.22; Mon, 18 Nov 2024 10:04:50 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%7]) with mapi id 15.20.8158.021; Mon, 18 Nov 2024 10:04:50 +0000 Date: Mon, 18 Nov 2024 10:04:44 +0000 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/vma: check retry_merge only for new vma case Message-ID: References: <20241118021823.17386-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241118021823.17386-1-richard.weiyang@gmail.com> X-ClientProxiedBy: LO4P123CA0653.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::23) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH7PR10MB5748:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a747d44-a0f9-49bd-d7dc-08dd07b870ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YrWZLmG7HpVWyUnD/TFZcb6o19Fbk2hOCTEPdHUKDOSelOe1VgacgQt1saBc?= =?us-ascii?Q?ta4nOa/wueVQ4hhgW4fjtDvbbfANTqUZSKoAkwb8tJjVNzfX9Qwotv2ihU0m?= =?us-ascii?Q?az6gwPc9Ki3n9nzQ25060yzfkw12Y6hKzrrmZbSMKatKFvQeQe1/w2k5prV1?= =?us-ascii?Q?ylkppA1htnRzVCtQHgevwh1FHvsxu5PY2Mh5pdIuZP+hpSI4qjad7GUY2wvz?= =?us-ascii?Q?GtlJ5OPO2yYLGsl2THa7ykZNEoBkWPZPvXlyt/D/rvL4WGlTzXS5CmAlwBvy?= =?us-ascii?Q?3vSw4MeOoHAvsI4UXx3O/PDnk1fS6Iw/gOgrbM2TnmiOsQflscahNvVOwNXP?= =?us-ascii?Q?v0rKN1ansneiJPAb+rOWoc81f0sDDPcKFweYFUb3vP1GCizHy/BVlquCKF/w?= =?us-ascii?Q?GH8jXHm57wt2xjydm6ezpOaUkdpTMg8QZHQFJfrR9QZrWC4qdWC2riuqscr0?= =?us-ascii?Q?nveA8lczYNVKc3vlXGnzTY8kcbpIINFiWBJLtIEaRjNMPk9QkL3nn2C8rrDp?= =?us-ascii?Q?xKnYrtjYbfj0E9+3l/s2qEkQWXk2IMJJ7sPT1S4lXmEFv8G75mJvHNJkulet?= =?us-ascii?Q?k/BTCaHP72BQicGRkvJaYuaKIQHRFeremvWDe4cy8xJQtzhKU8kq6UHXWKZr?= =?us-ascii?Q?fIgihult5ZCTI9KgEdgOhwPmiuafxUOTG/mFojLRNY+dAYBEsHd7RdR7gMiL?= =?us-ascii?Q?b77fw/qyWCsXT673didpsIwgyFWymP34e7rOKx/0KbobXnZQyglJSQQBiw2V?= =?us-ascii?Q?hHyBajAHihxeB8nuzYxTusCs/KuCe3MmniGqYHPgEgmgUF7HfpHXYwsYbTQX?= =?us-ascii?Q?JBVK3Ef873YeuCfkcIsB8lBLQcozn2Zwp32YqP9AnMq4JbgP4yphXEWK/Jp9?= =?us-ascii?Q?XEZUlywS5XM0IMFbmEnbxg4UV01byngKYVpyX2IeyVTZnCF5DyoamIzJeVu5?= =?us-ascii?Q?k3pXBrg6mvTf6WzH0hXefNCffG5u48HQj9jLLcsrldtGN3YaB7ZqyILyPWe1?= =?us-ascii?Q?qYlebLxxostgrhPVTwnqUSBBvHpeSMQu/7xmgsMntV/iio6V57sYJIcYc5TQ?= =?us-ascii?Q?aT9u1IMTgKFPtw963jX0hhuen6TBhmRz1OmbTcM7BGsVOVa1P4HM6KEFLdbD?= =?us-ascii?Q?Go35nB4eGG6cBwWg8jSkKZArahoFW1FlLInZWC1MsC1rwEzr3F0PcwnClZrk?= =?us-ascii?Q?Mocpn093tsAanQAh8/rApqnGKS3U4S2Lf34ccMkPN8fgIhkc4Ptoz7CR74iT?= =?us-ascii?Q?cBXfExQPpNu6eNh0b+aLUGAQFJb4gy/3qVK/0SEAWhYOqgSeLQ9EgR6jNCjQ?= =?us-ascii?Q?nWN/+v5TKzzPM3GXYFWCRj0Y?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RJgdjFsQJQrzmLUbDId1ihOTYVChFze0/YLvE702RpryxM+A2OkHZOIzmjns?= =?us-ascii?Q?B/aJiEl6y2tlm31NTOKjjvcdnDdjk0BkE8YxI9yJ5lifO+r67Rz1QYqPOg3S?= =?us-ascii?Q?7ccwHeXl6GgctdD0P0DbaMXWt7t8mCZ3ETc4EyFAE4F9CNdCTDUYBhsiVlUC?= =?us-ascii?Q?dSTg4sdr+NnE+VsWGr/MMPKOxX4o3BtYXelgQaLehbTqRkvktvRGIWqtnXrl?= =?us-ascii?Q?EKkeNQbZzOCjhtP2Y14jW5aZArfNQEQNB/TjJ3yB/nPyGMfyJw1M1R9DwThK?= =?us-ascii?Q?7cPgotCouSyq8tz2bkJm+7szmNPdKKUvu8t6r2ef/6Wr2XacXpia+qO1+LnJ?= =?us-ascii?Q?2GthM0l1qV03rvb6Hg3zP3/9QOi+C8hb7kJktki2SHmWoSNparphMnFmG1lt?= =?us-ascii?Q?OYj5ikClK925OZu6O0TXm2joFalMJP6UKIJJzKW4oOodUyrJX8XOl3B7VD5z?= =?us-ascii?Q?bDNWpY8po4Yw9pP4e4CQRl4niIWfkomvh1b3pgMoXmsa9RVG2TCENmhHq8aV?= =?us-ascii?Q?57WH3Dwnpoo0DuAgJ6YSdOJ0msEFd027VL2SLoPS7smXroO013MGsSzjm27t?= =?us-ascii?Q?PixefLe4AiA1y85HImZEbAcfdWbdvfLr32+3CU8RY1892Lz+8eg3FPl46v2j?= =?us-ascii?Q?m+4TZIwXsRu0ASY86vdSJ9OY4+0AWp91Z0DLeVLdE1ILy0yrM1Tmg7XMG6np?= =?us-ascii?Q?5LX4Hekzr80SJWLFBKj0au57ETz8LciGxI1Req79Dqt8JeA1iw71DFq/GGvS?= =?us-ascii?Q?6eEtDU7A3NpJWhseuZz5wDYDRKPr7Z1QIrGOCpVMDFLkI6cRMwax1FXOEWxy?= =?us-ascii?Q?njzxNzUPNOu1S5N8yGJKWp3LxWZp8fEoi8EHFUkCkLSU94NRYdvNi2QpFJ8y?= =?us-ascii?Q?3gQcwcoBu0tbKYgXsUYYB5tr0C/MdIwjgbsvGpFww9xuXg9fIAgPw3VqU980?= =?us-ascii?Q?rBl53KrAKcUOtv2rAvP2sINyLpMpSQnSRby3WsUK5D0oSLNqeFP7eWTd6igd?= =?us-ascii?Q?wcPM/MJbWn9k2GeI8HFPABD5We0jN+WsnsDdGuoHaU53wR5QwZm42l7YCynr?= =?us-ascii?Q?RouTJNB6NMjWUGBPPaiWCmngTDWn7Dk3pXhq55O6WHkpgn18Rvd6KsJHhTGh?= =?us-ascii?Q?j5MrRlodFfEN+uap/kgs+h+UQlX6MpjFdcK8veF5OVoyZxyRCLVGoUs+HcrO?= =?us-ascii?Q?jCTnI0AR/IPGGi8BCE2ddnjpcOV30AVOYgwvkN2dR9pgMzz7l34YPaXwW6Kf?= =?us-ascii?Q?NfqrlKORFsa1XnScMSbBQQzNN5MeReJoCTj2JxGmvffOCWXywK7eh+eS17HQ?= =?us-ascii?Q?cLLbH0nYVfckCpdRkmXByjmb7sDebpye9ub2PUnM5WhIDgqUwkEiulMblAUF?= =?us-ascii?Q?ftaTVB9XM0tPe5bO4OQHW86SS71rl2NuZYd5uPldkR8aRKWcp+0mZr/j0AGq?= =?us-ascii?Q?vzsvE4qwCg2c2h5xS2QjdIZs2ndwiJed6+S4MlozXYcZEUWSHad32N6RmUjW?= =?us-ascii?Q?CQ4p6i88QZSSLHtSKcKIMsHIvwzA2ASpkEThW4X6T7EeA1QQZMxh244/siTv?= =?us-ascii?Q?9f2iaIoeBqGWHxr2OHy/IW5gz6SXrgAwCvy8Yq992+JioPDw933h4hWs7jQ0?= =?us-ascii?Q?Dg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: IklB2rS3llvMWvfLWA+eaZCDfJpl3RBGywQR5rP1JC/qg2Kd8LhDreJJCZs+8cKHagQvMX/L8DTjjoDAM3iNA/i9aUbblTfaxOeG/g7XiYgPoL5HDAhmzhKAxHkkrfGEnNNtoVE0eHpUvB2ARHIjM3lE+Qx6fMfx7yxr4GA6vKdRXfcSnID9U5ab6ewbRYZKOGfdYHV/FvrwWpNwe6BEj14ncjk08X+gBzh+hgU+wZpWIkkmTCT6PTgfNTmgLLeKF5nXMuOsbSdyI4lwJddq0tP1H0JHxkFvrhL+OFuK0AJqXX/R3liU9UOjNPBV39a1a/AVSmVBmoQRGNczysl8TO2cNKAZ9Asn5zhgCAVmKkya8BJRc9rqZFdZhJ+qE/ymhfRiplzROzyEHq6ZypTl4m9gs+SfY8t3gtBjW+Kv9+gj+wQtmX8Q/1fqFddEeqDka/aJJ1wctgi2Z9MTHrkT7fod9J6H+KyL8KSkLGWCUOAAeW2Jos3bXRKeKDmfG3kbBlLTWjr06adr0L56wnMOf6zN80Lcjh5YFi39DkqVNE3p2V+6Sds6yIb3HlmSSWJY0sLa+U38WrBRWWM/YQi3eloBrjPdY2j6vOWj+SO3qF8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a747d44-a0f9-49bd-d7dc-08dd07b870ac X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2024 10:04:50.3307 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eGByGYShe7eAX/Ve25nYPIPiyb8Lz1GokdrsIT54jusyqKpwNFNFEyUPSu8kRA6e445SRDaKoEul1eQnH3dn7nsox/NtQLJ2Abf6KTKQi5c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5748 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-18_06,2024-11-14_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411180083 X-Proofpoint-GUID: MIQ3xi7ez0goIpvrkqtv0__NNpteoVz4 X-Proofpoint-ORIG-GUID: MIQ3xi7ez0goIpvrkqtv0__NNpteoVz4 X-Rspamd-Queue-Id: 31929120019 X-Stat-Signature: 9kdt3jgq9yophaskh35fcwcg73n8er5h X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1731924230-868509 X-HE-Meta: U2FsdGVkX18W8rtLJhN0ISRsHy1uSsZpBnjkQWfv4kxMRUB4rABz6sEaxry6wIAmk/IqGEsptqEjI9hVXWxH8GJ/QaqArPfKbVJXTfytbeDYaYBeCare3WqPH4Q0RxXMbbPEQTNamr+sTMfOG9migkdFRSpK63p8rdTz9SU6+Oz6G9sQU5nUuYEYhO7A95el4+fCSU5uOurJVjM6Fiozg7BkYAZW4U9/MRA67qvvt97bVbG+Ceq9Taci7hyP4b415X7YDJ5RZ2Ic7kzfPQVUq2ZKsBxS08rBmZIVKfjRn0F23eXkhs0u+R8a5reRxbzEjnp4HcnlE0nDREj+7cKtHtM4TVcyw0RyNyTjJeeklrVvBrKpnxwQ5voO6P7qs/vi5Csxvp0vSc3VhgVgySslNpqt39ewJ7ebsgJMBw3aOMaodb4XTWidcJ7Bj3shRkxGaocBhDprgcGpTmArciqGP7qiyrBxdUPVxihLXkdumzUmLiqt92hjsOaQeorqudUfT6VhRULMYEqTxqMWa0NfSoseOIMohONPO4k7QYxiUOI1SfgVLyuvQwamgnjZE8IzpUbNFTHLodCPgN4L5sAkN0YltxNJhNQQk2vfV0YhslLJ8CYSmYeK5hh7IdrectGsHiN5S6SqBN0oQDtY3drhK3KnCXNypEpJS8iG/BKdd3hySI9AN4sWZGdKLz00383WhtiqVGnMjEY+O9RUsXS/Bd/SHiHTog+A6t3E6dR/ZrBCh0VBlONuWlzXoncxPM+lnSH+7ctgwjPJRtZ0lEMOkURBiEUhq8eSoQSRhJ0eIrI0UjeRvjPCjKAYtGkcr5rPDdDLJK3T5acDlqvacbfN79KFjFchCdTfaa1wSObxMFHO/T4muWNPIKiQK3UnQ0Y3K8OJlCstdrrecw9C0a/+3GNhoS9nDftf4orYVyGvmdYPV2j3pOLuVlCMHi2SNKefUDhnq9SFw2Kz1T+3eSk gpAthLCq zhKd8lT78MWykd+oWOUZrrketJKGdohvt6wgYGrovAflX5YTe6MS55p38y/4sj8G+S+RwZ5AXzD3aMwQJpl52t3oGFTTsdR6LzJr33kvBGqrA1uE6wlN42F+uKoWp33XWXVu7Gy+8/TiMwaFUNuI/kN0Zqs7Oj4g3lTtfYwTvU7ttgHmsnf/TTQk0uEMSs7KyNYsZDpkguEZdATaB63GMhdAryartHS/l6MF7P/47ICs8BW4XxznNsk2JmYJ8UpaVSL9k14bKXxi1SgRB4xQyljMvFf89BsZDMyGVfgPgKwUrv/7TrBg9VE++EkMHIfbjnNnGrckfvQgo4r4zyHZQ5nCt+cJ98SE/FMu7T8IKGb73c2zEUDXifkxxgde6dHwqW3IAcDy6gRB6COAoN8yxM6xKvLn1yCay0acoOl6yBETE+VKS5WRxezxvPZcnz3l2/f62R0dt5lTDBcX+Meqi1v0QS2B0cipTtMT3lUiBKnnQKgDJ+13hrRON62OIzEIDearp/OLKs3dvnIc0cWxC3g27Gz0ap4TZJG7i33TeRRXSokfA0QdeYLwPnBxZVLCoS7quXYDCGgysvi4bUXUtA8gjFLO0/NA/OAoC55aeJA2EPjjenTUx3rCM//FNGyJFBvccQKTF1+oLnHmewopfZZY+/EyS7nKsq1uMs5/YuAhD1kNG2swyHCqBFhKJoKa+sG8sptKsFboQCOCtBWyAjLZz+VFW3c+BCLcyYD+OyJJmE7euZAMo8/F5/wiMw26bU98XvkTX34n1I4SISilGdl3lDeRUeNeAyxe+yyBgCIdI1mE5VdEqPkoeBlGUKB1/H1/gmjPXeTSR8rf1F8XcoTDo9WU21SsBAaGm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 18, 2024 at 02:18:23AM +0000, Wei Yang wrote: > Current code logic looks like this: > > __mmap_region() > vma = vma_merge_new_range(&vmg) > if (!vma) > __mmap_new_vma(&map, &vma) > __mmap_new_file_vma(map, vma) > map->retry_merge = xxx --- (1) > if (map.retry_merge) > vma_merge_existing_range(vmg, &map, vma) > > Location (1) is the only place where map.retry_merge is set, this means > it is not necessary to check it if already merged with adjacent vma. > > Let's move the check and following operation into new vma case. > > Signed-off-by: Wei Yang Nack. As I said to you in another patch, the aim isn't to find the mathematically smallest size of patch. The aim is to keep things readable and nesting things like this works against that aim. Unless you can demonstrate a _significant_ perf improvement for not checking a boolean here, then you're making the code more complicated than it needs to be for no gain. Right now it's (intentionally!) simple - try to merge, ok we can't, try to map a new VMA. Finally, if the state says retry a merge, do it. It's easy to read and easy to understand. Nesting as you say takes away from that. I also could have gone through this mmap() code and tried to reach some mathematically perfect level of avoiding unnecessary things, but as this wasn't the aim, I didn't. Please try to focus on finding bugs, or _demonstrable_ perf issues rather than stuff like this. Thanks! > CC: Liam R. Howlett > CC: Lorenzo Stoakes > CC: Vlastimil Babka > CC: Jann Horn > --- > mm/vma.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/vma.c b/mm/vma.c > index 8a454a7bbc80..80b1bd404f23 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -2456,14 +2456,14 @@ unsigned long __mmap_region(struct file *file, unsigned long addr, > error = __mmap_new_vma(&map, &vma); > if (error) > goto unacct_error; > - } > > - /* If flags changed, we might be able to merge, so try again. */ > - if (map.retry_merge) { > - VMG_MMAP_STATE(vmg, &map, vma); > + /* If flags changed, we might be able to merge, so try again. */ > + if (map.retry_merge) { > + VMG_MMAP_STATE(vmg, &map, vma); > > - vma_iter_config(map.vmi, map.addr, map.end); > - vma_merge_existing_range(&vmg); > + vma_iter_config(map.vmi, map.addr, map.end); > + vma_merge_existing_range(&vmg); > + } > } > > __mmap_complete(&map, vma); > -- > 2.34.1 > >