From: David Hildenbrand <david@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Dan Williams <dan.j.williams@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Karel Zak <kzak@redhat.com>, Linux-MM <linux-mm@kvack.org>,
Michal Hocko <mhocko@kernel.org>, Michal Hocko <mhocko@suse.com>,
mm-commits@vger.kernel.org, ndfont@gmail.com, pbadari@us.ibm.com,
Rafael Wysocki <rafael@kernel.org>,
rcj@linux.vnet.ibm.com, stable <stable@vger.kernel.org>,
steve.scargall@intel.com
Subject: Re: [patch 2/5] drivers/base/memory.c: indicate all memory blocks as removable
Date: Sun, 29 Mar 2020 21:11:04 +0200 [thread overview]
Message-ID: <a8b2f031-05d3-d0cb-be12-7eb4ef316289@redhat.com> (raw)
In-Reply-To: <CAHk-=wg+UUK7hj9xKhoDfqXG4bCrOtTA-_WPoFemU_=1G_NHGQ@mail.gmail.com>
> Well, that may still be a perfectly fine email.
>
> Yes, it has the MIME crap, but it also has that
>
> Content-Transfer-Encoding: quoted-printable
>
> which should tell all users how to _handle_ that MIME crap.
>
> It's sad that people in this day and age still don't just handle
>
> Content-Transfer-Encoding: 8bit
>
> and just send it on untouched, but SMTP certainly encourages that bad
> behavior of "convert to 7-bit MIME crap", because in theory there
> could be SMTP servers out there that can't handle anything 8-bit or
> with longer lines.
>
> Those SMTP servers should just be scrapped and people told not to use
> them, but sadly that's not the approach email people have taken.
> They've taken the approach that old garbage SMTP servers should be
> allowed to exist and destroy email for the rest of us.
Yeah, would save us trouble :)
>
>> I have no idea if such a conversion is expected to be done.
>
> It is (sadly) expected to be done by a lot of mail software.
>
> But the problem is that some part of your email handling code then
> doesn't _undo_ the MIME conversion, and leaves the MIME turds alone,
> while then that "Content-Transfer-Encoding: quoted-printable" got
> lost.
>
> Do you at any point end up using a raw mbox and cut-and-pasting stuff?
Just Thunderbolt for reading, and vim for editing. Really nothing
special. In this specific case, I don't think I copied anything back and
forth. Just a simple git commit and editing the message in vim.
The mail was sent around the same time the other two (?) broken mails
showed up (end of January/beginning of February) and ended up in your
mail box.
I checked my other patches that are in -next. All (especially the stuff
I sent recently) seem to be fine except one remaining patch, sent end of
February IIRC:
https://lkml.kernel.org/r/20200228095819.10750-2-david@redhat.com
It also has this issue with long lines in one instance. And for that
patch, I still have the original commit lying around here. Did a fresh
format-patch+send-mail to another mail address (via RH mailing
infrastructure). Again, converted to
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
But the MIME crap (for the newline) is gone. So the issue seems to be fixed.
> Reading email in a broken mail-reader that doesn't undo MIME? Because
> that's the usual way that these kinds of turds get copied.. Using raw
> emails without honoring or taking that "Content-Transfer-Encoding"
> into account.
Again, sorry for the trouble, I suspect bad mailing infrastructure that
has been fixed. Will pay attention if this starts happening again, and
then switch to another mail server/mail address, because something
within RH mailing infrastructure is making our life more difficult than
it should be.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-03-29 19:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 2:14 incoming Andrew Morton
2020-03-29 2:17 ` [patch 1/5] mm/swapfile.c: move inode_lock out of claim_swapfile Andrew Morton
2020-03-29 2:17 ` [patch 2/5] drivers/base/memory.c: indicate all memory blocks as removable Andrew Morton
2020-03-29 16:46 ` Linus Torvalds
2020-03-29 18:03 ` David Hildenbrand
2020-03-29 18:28 ` Linus Torvalds
2020-03-29 19:11 ` David Hildenbrand [this message]
2020-03-29 19:15 ` Linus Torvalds
2020-03-29 19:43 ` Konstantin Ryabitsev
2020-03-29 19:55 ` Linus Torvalds
2020-03-29 19:56 ` Linus Torvalds
2020-03-30 14:46 ` Konstantin Ryabitsev
2020-03-30 14:54 ` David Hildenbrand
2020-04-01 13:35 ` David Hildenbrand
2020-04-01 15:33 ` Konstantin Ryabitsev
2020-04-01 15:40 ` David Hildenbrand
2020-03-29 2:17 ` [patch 3/5] hugetlb_cgroup: fix illegal access to memory Andrew Morton
2020-03-29 2:17 ` [patch 4/5] mm: fork: fix kernel_stack memcg stats for various stack implementations Andrew Morton
2020-03-29 16:41 ` Linus Torvalds
2020-03-29 2:17 ` [patch 5/5] mm/sparse: fix kernel crash with pfn_section_valid check Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8b2f031-05d3-d0cb-be12-7eb4ef316289@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=kzak@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=ndfont@gmail.com \
--cc=pbadari@us.ibm.com \
--cc=rafael@kernel.org \
--cc=rcj@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=steve.scargall@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox