From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C3E1C3F6B0 for ; Wed, 27 Jul 2022 01:53:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 012128E0001; Tue, 26 Jul 2022 21:53:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F03B36B0072; Tue, 26 Jul 2022 21:53:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCAC68E0001; Tue, 26 Jul 2022 21:53:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CAFDA6B0071 for ; Tue, 26 Jul 2022 21:53:11 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9EE83140A74 for ; Wed, 27 Jul 2022 01:53:10 +0000 (UTC) X-FDA: 79731206940.05.959BC21 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf27.hostedemail.com (Postfix) with ESMTP id D121F40031 for ; Wed, 27 Jul 2022 01:53:09 +0000 (UTC) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Lsxbc1GDwz9sy2; Wed, 27 Jul 2022 09:51:56 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 09:53:06 +0800 Received: from [10.174.178.120] (10.174.178.120) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 09:53:05 +0800 Message-ID: Date: Wed, 27 Jul 2022 09:53:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 CC: , , , , Subject: Re: [PATCH] memblock tests: compiling error Content-Language: en-US To: , References: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn> From: mawupeng In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.120] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658886790; a=rsa-sha256; cv=none; b=78Bg+WbJvJjVCOuI8B6zmV1M8ykQdqKuv1s/HQ3Ueh9e71kT0esZQZtp0CEnj6kyD++j4v hlZa+XLem3iDX1/au4NurEG6nDKn+NZgJdX2lCnXvwLMQ9jMhez/9zmtj7+3GQ9K85j4EK vU4+fjKH1DYHrAJaoYC0YkfAcsnJsJQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658886790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+XjGr268OIeJICBSmKDREa+wJXrYy8H4GEQi91sppFc=; b=SYOTyMqBqAMqve9JAOvJsG0o6tLSTEX917wkLUuAWB0PII96MDx1VplxyebADmtTBbUWcE ECXlg5aFm+4CBTgxUIV6xRYUFPo+wQYfBp0gcyPQs0M+43S9WDozyJqGM4HlnHFklElCVw q37RMzVbA1ZzuKD39s4dcdTWnhrZIr4= X-Rspamd-Queue-Id: D121F40031 X-Rspam-User: X-Stat-Signature: mdsdcsffxnec79bb785a4mj1sercpmjg Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com X-Rspamd-Server: rspam08 X-HE-Tag: 1658886789-62486 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/27 9:01, Souptick Joarder wrote: > On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng wrote: >> >> memblock.o: In function `memblock_find_in_range.constprop.9': >> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' >> memblock.o: In function `memblock_mark_mirror': >> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' >> > > what is the steps to hit this compile error ? Do make -C tools/testing/memblock can hit this compile error. > >> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not >> specified") >> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") >> >> Signed-off-by: Liu Xinpeng >> --- >> tools/testing/memblock/internal.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h >> index c2a492c..cf67e6e 100644 >> --- a/tools/testing/memblock/internal.h >> +++ b/tools/testing/memblock/internal.h >> @@ -9,6 +9,9 @@ >> static int memblock_debug = 1; >> #endif >> >> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); >> + >> +bool mirrored_kernelcore = false; >> struct page {}; >> >> void memblock_free_pages(struct page *page, unsigned long pfn, >> -- >> 1.8.3.1 >> >>