From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28BE1C54E58 for ; Thu, 14 Mar 2024 02:47:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EFF780079; Wed, 13 Mar 2024 22:47:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99F7580073; Wed, 13 Mar 2024 22:47:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8407180079; Wed, 13 Mar 2024 22:47:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7506680073 for ; Wed, 13 Mar 2024 22:47:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0EABB403D0 for ; Thu, 14 Mar 2024 02:47:18 +0000 (UTC) X-FDA: 81894108156.15.60D307C Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2073.outbound.protection.outlook.com [40.107.101.73]) by imf28.hostedemail.com (Postfix) with ESMTP id C35C9C0003 for ; Thu, 14 Mar 2024 02:47:14 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="Np378GJ/"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf28.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.101.73 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710384435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GYSGtIeIx6IltXhQYyd24r9ovQSxD9jZ3UFOoMFdf2E=; b=pRgpXW/sFHtwmHMJUVAjT5a2NqD9mUpeSGMSISGRh12n1Rs990lSFZhNILFpdmo9C7kP6c FfwuiUsqqPgK0gQJjHgGStVi8qFwth9SiP0aEoYmEWPL0qCP4JPNxEDtJoR8drDOaqwdV6 n2uulGQvs2dRjBvhTQQ9lb0t7G5eUJM= ARC-Authentication-Results: i=2; imf28.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="Np378GJ/"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf28.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.101.73 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1710384435; a=rsa-sha256; cv=pass; b=AZ5BpDzjdAHcy4lbu5bvU4rSrsPbY8KpetqcmRj3i0+nXCu6Ut1EiGPGop9vohCcTDod+M G32CJpZMpsl56Edu7+Q9bUpAEyN8o14OuingReofWPrI9H4lVhdnCAYoHuCdzN0+h1/swP snt/uiYIL7m/at7lnrJQR5TWRAyhF9o= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SSGRGkeoBwAO3lc/kBfwYxseztCisP5iHD7oao7PrS+4Ut+7YGPa6z8ThC6RjB2+XyyMs4VrB4aUfxRic5prJLmTP8asiMDGPJomtXIQwZOxmwkyvOpENVYURSDFC4lhnKosI1Qx+/9478mDBedxe4pSvNyz6Cuyrz7CPumJGaH5BdZSrlZJrK+qfIY2vubi7pG5RQAe9jQxi9EHRfSEF6cU6Pu+v3TAv/rx0BiPvoMxDWRUdH71jpJvVJFpUpnD/Iu4hcbuece1jShqSLdgq3+LRuHfWTDz6lfrLnL/W15qA6TEO9qFjbdgfKfpR2b6kav3O51TEpLp7T/lYgQO7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GYSGtIeIx6IltXhQYyd24r9ovQSxD9jZ3UFOoMFdf2E=; b=FF3+NXjHZ2Vl9UZcrbn1o93nYTTYvsUJfWhG++h3pWeq3Nu73KvsjefvUbjOgCWZPhlGha2R/w0K5HQ+OUN9xmUbHcgDlPciFCdCqmequ6pOit4WCmzr+oBjn1T3dz4IQDQaPjquYwQhXBsioGRiOtlrLUyDNR2T+jSbnZ/cke4pW2yjLrst8k/DznfJui1asNa83XvI85Vu3o0DgGom0Ko8/V0l96o6cK08ha51XQqtmmkTJ5M4GyYpibCpdmdaYCKT9gsawLZyXrfdicRucepD5F6Fx7FLpq67+VeRawqqTVd2RKKqfHYkdcAd4DkqFxyj2p972IPD5NAEoQolHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GYSGtIeIx6IltXhQYyd24r9ovQSxD9jZ3UFOoMFdf2E=; b=Np378GJ/qquaFV9+VuotEKTI9qkt4JagXBpBx4CcFaxKNVBLGnRlvG48B2/r4LK4Qpf7sQ1B8+6c5OuoTUH03QPRwigZ+r6JfAB0LYKL5cowuOwkXmqKXwVmQPyCTVV+rDFuFHFPRaI3YNVHyogSr0YlAA+vK6L6EN0dYmfep1uKIz40ysgSYfvV7bYj1uroKM2AscXwD1xLWyaqvTtFrcZu5/KjqlORgKMpmQ706Y2nT0AzGtJ1Xh5dfFQfdIl9QFjFhYB9jZGbidEeSd4J/TVLyTXBpVLXgkrOgfsOSULaxQgx4JWPQA8gXrZlNcdoD/EGoSx8I1lNoOTUjAwpvg== Received: from BLAPR03CA0068.namprd03.prod.outlook.com (2603:10b6:208:329::13) by PH7PR12MB5878.namprd12.prod.outlook.com (2603:10b6:510:1d6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.20; Thu, 14 Mar 2024 02:47:10 +0000 Received: from MN1PEPF0000ECD6.namprd02.prod.outlook.com (2603:10b6:208:329:cafe::55) by BLAPR03CA0068.outlook.office365.com (2603:10b6:208:329::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36 via Frontend Transport; Thu, 14 Mar 2024 02:47:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MN1PEPF0000ECD6.mail.protection.outlook.com (10.167.242.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Thu, 14 Mar 2024 02:47:09 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 13 Mar 2024 19:46:55 -0700 Received: from [10.110.48.28] (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Wed, 13 Mar 2024 19:46:54 -0700 Message-ID: Date: Wed, 13 Mar 2024 19:46:54 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: updated documentation: Splitting pinned folios Content-Language: en-US To: David Hildenbrand , Matthew Wilcox , Jane Chu CC: References: <57c9e228-9aca-4da6-a714-f175f053ff50@redhat.com> From: John Hubbard In-Reply-To: <57c9e228-9aca-4da6-a714-f175f053ff50@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECD6:EE_|PH7PR12MB5878:EE_ X-MS-Office365-Filtering-Correlation-Id: 50b76ec3-b073-40b3-8239-08dc43d10b58 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q7x8AL+OibHstJHuz2Mtf2Y5NMRY2JtX9n4aE2Ar9XXof8U8cgZ2iPXwU3nI7DE3MSiAgmRK+YrOWBfKAi7254loJ0goIb3aQjlrSTK6LuUVCAPUkeC4B6cCy/qnHyYBhXNQWbJrafZDxpGL7lHzo8ILPn677Nc9TmTdKSVICpSDT95woFLYzO649Nq+58I98aGMzFrxQzkXNImaZqyKNmCqtu7hEkAycgXi2OALlxjq7F/k3lh/LSJSq16DVBKI91omH5VLfzYlYxFmtjY0fJs2Gr7OfabKeOmIzKsY9391WBvmR2w/gGLQsKjrIA6wtjWgcIoRL3WLmpWI5m8Srg5ia3qLN72lxEcP/S8w3GLVE9oUtWwkXAVtPpK4w0XPppv+bYtzR6HmFu3QAPcaDkUIzXS5QjTWEAsgMbw2wXIQryvKpnQAHGJRkIU4Q8QGWcKvXKT25DiRv1NfxstgCJhdePKrD53PqM4aXx9V8Y46wanfHzz5j4VtCTxvBfqCModnEESUrvzGNozQcOlgGirB2xLW01sXczcqZpHGy7JiBrW1dvqxmv8NmP8Z8/LGHG9ZHA7u4/NEi57KW60MjH6T68bFIuWdxaFuwq4mnfHIYryIjLOPhEkL1rbKyBpOKXMxz5/jeVNXfOokQx9GtapN+QYjr0cTSNSRQL/r2lafMvt5704+Jlh0Kn1/MUVSzmfrsIDfA6OhWb4HzXhWWAAEEYIOqjsoJboBaCcBEgj+P/rR3ATNVH9jGao53HJt X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 02:47:09.5468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50b76ec3-b073-40b3-8239-08dc43d10b58 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECD6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5878 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C35C9C0003 X-Stat-Signature: y5bm1kycjoj9pu8jub3z9o79dfdng367 X-HE-Tag: 1710384434-649207 X-HE-Meta: U2FsdGVkX18YEWcPH8WHD6ivENnl5t7Y5VGE6UyFUvmMOeSgDQC5yK6F5dGlFX/O18F4Fs4S2NpRD5+MxupLCqXzNUPJyRNTlJB68tB+I9sUrxK8EjqUaz64HwzS8+CvUFQB5kfV1brHVObiIu8F2pLyjgmV8/UVTqxvVE+yK6sVYHqj47yzd04sP/Rx1jsCsqwL9N19wA9lzgxzPZNJyPy+V9RBJriYCtO9XV7nKwdBlSpoZHrqVzqxZArGiSWxzOZlwP12qfPVp14t39Jw8nK7CmlM3zscOqvJfIK7RyvLyaZGFI0kdaY9mMDdeIBKFcI+B+B6UP4vrE6hon9WltjZ0FpviqnwQz+6l8EirfQ310Xx0KvBybdn9J9VvhVCqJzg/4uugUS6sXVlsL5AVrQDwXuIC0B38/I0jlnsvmSRwsMDbKW5PPdOdvkFko0nMK0KjuliDqwx5nrt+8jJS5dLSAUcWWsR2xIzYlsq4PyUGPIaxX63Bu1J6VUP6GXcB0GWug1RB1THvCNaTBnfDHDWZ7xDj4kcSLBRD0+KWqBHH6SEc68e9ibjkRl5+rBi01r5VfIA/620YvLS1lrYePM+yprgVTSya9HHG6JyUS8HD/KZdF9O9SbJNfmMm0Geuu3mc2JU8wsL6Ly8ZY4dt4iwvTIgknHt2u82ZekJiEoG0ADKYO9nwwGUkc0Rkje4VcjVnTD7HvC4CFXgfgqdnBSG+jIrHVGwM+EsUr1Lt43/ZegntYuHVlkpCeZP8vO+xCELnDBwZKzcNbBzChddnyRYZnriaBwBGiZWwlnCTgQnOpU92JmK55WdH9wtkBFuQPZH56kLSo1krPAqOc8ELQO7LH/J9UBI4aIUW3U+pgo44k8ORNk+GLZFYBh9rRwyYq9loUe3R/RC0HrOMr64hPIeBgXlvL2QgNtdv2599tQfFn6o9jE8cb+IxUkgUM04F6rmkJPYy9YknRQeXCD 9LkLr0Hy 8j2WmmyFKV4K6cpSSQE5r54eQbvGNEWLIqVk9O6UqJLY5rkUA99c/BCCDqwQbRO5o97qiJYQCKOai8pRWKkbFZLZRrS//L6MyNx7LfbCb7zLmr5ndU8feOQnfISOJUtyyGstUYpuvOqGRyho4wIPCqeSN2dXExFs5xJOTy9PQlVs8O2vDYvvmScgAA9X5y9wOotmr3J/1GzSkhagjnGeryWpos4n1jM9sXXv4HmT/5a8wjErK6V/k7NJO11b34r5Cs40a+9K8TLo7Hp8hqsmscgsaFrGkKNhpc+tCPz7oAnkD3VQELPyFphY+cU1bc5OBs5y19Xf8ZF83KDyTuqC5jQ6ZosY3NIMzQc8VUAzdKoa1rumNeyDabV42wA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/13/24 2:20 AM, David Hildenbrand wrote: ... > The description is wrong. Whoever calls split_huge_page_to_list() must hold a folio reference. > > That folio reference will be transferred to @page (not the head page) once split. So @page can be used by the caller after the split succeeded. > David and all, does this updated draft comment look accurate? /* * This function splits a huge page into normal pages. @page can point to any * subpage of the huge page to split. The split operation does not change the * position of @page. * * Prerequisites: * * 1) The caller must hold a reference on the @page's owning folio, also known as * the huge page. * * 2) The huge page must be locked. * * 3) The folio must not be pinned. Pinned folios will not be split; instead, * the caller will receive an -EBUSY. * * After splitting, the folio's refcount is transfered to @page (not the head * page, unless @page is actually the head page). The other subpages may be * freed if they are not mapped. * * If @list is null, tail pages will be added to LRU list, otherwise, to @list. * * Both head page and tail pages will inherit mapping, flags, and so on from the * hugepage. * * Returns 0 if the hugepage was split successfully. * * Returns -EBUSY if @page's folio is pinned, or if the anon_vma disappeared * from under us. */ int split_huge_page_to_list(struct page *page, struct list_head *list) thanks, -- John Hubbard NVIDIA