From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2AD3C32771 for ; Mon, 26 Sep 2022 13:27:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7152E8E004C; Mon, 26 Sep 2022 09:27:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ED128E0047; Mon, 26 Sep 2022 09:27:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58C6B8E004C; Mon, 26 Sep 2022 09:27:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 488C98E0047 for ; Mon, 26 Sep 2022 09:27:13 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1450FC0A60 for ; Mon, 26 Sep 2022 13:27:13 +0000 (UTC) X-FDA: 79954312746.04.0F97D97 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 3A44280012 for ; Mon, 26 Sep 2022 13:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664198831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CC6e2wRFrDDsU2r0lOBUFQLcJ+ak6awLWbpV9xxP0pE=; b=ZlwzXn7oOSdx7bOkuOpEntRvHL0GHzBbJYTU8SuHO6dCcFz29XoIK55DOPKdPOI6zyxST/ MYESRR14L0GiP81cpoyip2NOYWmZM8aVrp+cWuY9zbZnJroBl+rVHKhZJix07rsYDpD1A2 JBzMQTNR7ac3N3LcMoadXipdQqNPedg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-421-l1JDs4QVNRSx3otM6mqWPw-1; Mon, 26 Sep 2022 09:27:10 -0400 X-MC-Unique: l1JDs4QVNRSx3otM6mqWPw-1 Received: by mail-wm1-f72.google.com with SMTP id k21-20020a7bc415000000b003b4fac53006so1871500wmi.3 for ; Mon, 26 Sep 2022 06:27:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=CC6e2wRFrDDsU2r0lOBUFQLcJ+ak6awLWbpV9xxP0pE=; b=J8OAA+5DDmk1X8d+Q55l5lwYIMkZAB/iqB5gNHI2zsP1RyUAMxkY2ePc1LF4VeLl37 L2m0YC9suSYfIiLfLg/1t+gHkEDTJ5Z7trnovGuYbA16O8j6a719VspGRU5uclj8WSla rTRjL8SePMWXALuUSV+wreV1TAMynoNxzsjWYwibGFvH2Bq9vTNYU1leRujXlCGUMB8y Y6iHMANULukKctYxnXAEPnalQ5V1MzQFiPZUwcyREOSxDrINwTsAhd5hOZtCQDBezOGc h+XTw3EvJf8OYZCFk8tsnbTBX0flugIpZuGCG/f71QFa0d70izSd+Eyhtd/3Zt0ciWlT D1/A== X-Gm-Message-State: ACrzQf2eriYdO8WqRt15P6tjpVZ+2UCWujI5qeEVmqbvJqs52ylZK3v6 5DJWmURx87s23zi/VKlL/r6vmALNoa99HqLw/4NezVzYIQegLG5n5iEFHlIB11Ina8CO9Gmsm5b sej9X/UF9tV4= X-Received: by 2002:a5d:5850:0:b0:22b:1ada:a0d1 with SMTP id i16-20020a5d5850000000b0022b1adaa0d1mr13313638wrf.313.1664198829377; Mon, 26 Sep 2022 06:27:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6i/D23ji2hKO4DfDWW0T+a1gSVZfr/kKtjKf8L/kZXxs1GT++Yct2ALmt57EuGwcrSrkBlOA== X-Received: by 2002:a5d:5850:0:b0:22b:1ada:a0d1 with SMTP id i16-20020a5d5850000000b0022b1adaa0d1mr13313605wrf.313.1664198829067; Mon, 26 Sep 2022 06:27:09 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:4b00:e090:7fa6:b7d6:d4a7? (p200300cbc7034b00e0907fa6b7d6d4a7.dip0.t-ipconnect.de. [2003:cb:c703:4b00:e090:7fa6:b7d6:d4a7]) by smtp.gmail.com with ESMTPSA id bg34-20020a05600c3ca200b003b4ff30e566sm23814053wmb.3.2022.09.26.06.27.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 06:27:08 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 15:27:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH -next v3 1/3] selftests/memory-hotplug: Add checking after online or offline To: Zhao Gongyi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Cc: akinobu.mita@gmail.com, corbet@lwn.net, osalvador@suse.de, shuah@kernel.org References: <20220926130341.253039-1-zhaogongyi@huawei.com> <20220926130341.253039-2-zhaogongyi@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220926130341.253039-2-zhaogongyi@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664198832; a=rsa-sha256; cv=none; b=Uz/Ikh+M1QkQgNpLivFJrXH0v/QdoTjR+D73URsEBBb/phi4p0fcKW+DnSIyljAWLnGVKb VbSJT3wkWtkIVwdURHOJqMMX01Ivezqxs7pNilEkL0rq5gEy5C0LyITQSHuMT+0I+R0EPP AM+53PppR5dXohDYVVCK9axKe2asOYI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZlwzXn7o; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664198832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CC6e2wRFrDDsU2r0lOBUFQLcJ+ak6awLWbpV9xxP0pE=; b=QsvBmrSo3LiUYWPF/Znp7AB3Hy6nKmwtXgIBPSpQZP80kx6uNbFbNNcDABKisEn3hoiU1g Jvdzoj9BhuVc+QnhJ4iNmI+ykz8zprOIJhrvfzEhrryABXhxfD9al4dJMaY1ANVpg6a4I7 Ms2+QLXSfgtqGYqsZGp54GbzvmyZog4= X-Rspam-User: X-Rspamd-Queue-Id: 3A44280012 X-Rspamd-Server: rspam08 X-Stat-Signature: gjrxo8tt8apsb691u58tjau1iajtjxqr Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZlwzXn7o; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-HE-Tag: 1664198832-991903 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.09.22 15:03, Zhao Gongyi wrote: > Add checking for online_memory_expect_success()/ > offline_memory_expect_success()/offline_memory_expect_fail(), or > the test would exit 0 although the functions return 1. > > Signed-off-by: Zhao Gongyi > --- > .../selftests/memory-hotplug/mem-on-off-test.sh | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > index 46a97f318f58..3edda1f13f7b 100755 > --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh > @@ -266,7 +266,10 @@ done > # > echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error > for memory in `hotpluggable_offline_memory`; do > - online_memory_expect_fail $memory > + online_memory_expect_fail $memory || { > + echo "online memory $memory: unexpected success" The functions themself already print an error, isn't it sufficient to set retval=1? > + retval=1 > + } > done > > # > @@ -274,7 +277,10 @@ done > # > echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_ONLINE/error > for memory in `hotpluggable_offline_memory`; do > - online_memory_expect_success $memory > + online_memory_expect_success $memory || { > + echo "online memory $memory: unexpected fail" > + retval=1 > + } > done > > # > @@ -283,7 +289,10 @@ done > echo $error > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error > for memory in `hotpluggable_online_memory`; do > if [ $((RANDOM % 100)) -lt $ratio ]; then > - offline_memory_expect_fail $memory > + offline_memory_expect_fail $memory || { > + echo "offline memory $memory: unexpected success" > + retval=1 > + } These functions return 0 if the result is as expected and 1 if the result is unexpected. ... but wouldn't we evaluate the right hand side only if the result is "0" -- expected? I might be wrong. Wouldn't it be simpler do it as in "Online all hot-pluggable memory again" if ! online_memory_expect_success $memory; then retval=1 fi (similarly adjusting the function name) -- Thanks, David / dhildenb