From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECCEC433F5 for ; Tue, 5 Apr 2022 21:41:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FC0D6B0075; Tue, 5 Apr 2022 17:40:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AAF66B0078; Tue, 5 Apr 2022 17:40:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14CB86B007B; Tue, 5 Apr 2022 17:40:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 079B76B0075 for ; Tue, 5 Apr 2022 17:40:30 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BDE51AD6F9 for ; Tue, 5 Apr 2022 21:40:19 +0000 (UTC) X-FDA: 79324144158.31.EFA23FE Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf16.hostedemail.com (Postfix) with ESMTP id EC655180026 for ; Tue, 5 Apr 2022 21:40:18 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id t4so527705pgc.1 for ; Tue, 05 Apr 2022 14:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=4qdFCpqXJlibMLMmOh+khRtYiv84b92yeP1UHSU4/XM=; b=qdb9FXkcJDsuO06gq+eT+kXK0a+6EAevKNYutHs1sHo02PgFcBzm4NidfGlv0TeZsk lAye9LJRnRUsM5PPn8JATtm9hvlOa0GVJ+6X0B3a4M1SQ+KhgtmV+NPD8o5BiU0Orf3j 4x8lnnEDrhHCxeZLy8J8nnqdwGAZ1Gkpc0hmy4N0mYsU4HLnwMA1ZKyqDPJfYwIcElbM 7jroAQC1AOR23AO9iP5KKLawgM9QJu+OXGHVrm9JPAawThONQEos0sZ/bSgJyD3kNm2+ JAN8hpJfKhrgAT5E0JbW0/hLVcIaB2Mu3QKE/gd62QVsfLvdVtNS4rOMAv/4BGuwjsGH CiGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=4qdFCpqXJlibMLMmOh+khRtYiv84b92yeP1UHSU4/XM=; b=zPg859Z7j6DP9ST+N4NzthW0kO3paL6oJc2A8wUObar5pgMnvmN5AlyFKey9+og2N0 6f84y0FJozicIYLZncWt8MtnXdYQklsKIhb2Fsp9Uo5oj5vJEghvQW3rO8H1823CxBWy SGNOy2Dt0MH3Yqi9QnZ9hHwuYWiO0vjM0bhT2wKcZFSGrEcJaRloXJDhFESePTapFWlh 7sTNw5ym6Xe92i3JC/H9BBZGLy0S5JOQ6jDlOn8maiM4vwpcK382Pqt9fNeuqNkQsT1i 8OhuAluAei2A2bjDEm5D8WD5WxDcrt8zGlHliTyABLaBvcr9k9ppDfxrk6mSbQCDFXST UE0A== X-Gm-Message-State: AOAM533iltvSM+U1fLHhCUJndr0OCPfKCuMLWZTw4CvRvWYVaWsRVBzI pZXG62LpHVHnu4wrzyL3Itg7eg== X-Google-Smtp-Source: ABdhPJwPwjfefI2JSh8SzZZVYV7Z0sOVeowJ14ZyTTisOzE7+UVYFaPwlmA1EkEbrCCUemK24q4jjg== X-Received: by 2002:a05:6a00:810:b0:4fa:e71f:7e40 with SMTP id m16-20020a056a00081000b004fae71f7e40mr5528326pfk.15.1649194817775; Tue, 05 Apr 2022 14:40:17 -0700 (PDT) Received: from [2620:15c:29:204:be3e:5e1c:99cc:513f] ([2620:15c:29:204:be3e:5e1c:99cc:513f]) by smtp.gmail.com with ESMTPSA id m7-20020a625807000000b004fe0a89f24fsm8117856pfb.112.2022.04.05.14.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 14:40:17 -0700 (PDT) Date: Tue, 5 Apr 2022 14:40:16 -0700 (PDT) From: David Rientjes To: Vlastimil Babka cc: Christoph Lameter , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Glitta , Marco Elver , Mike Rapoport , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Imran Khan Subject: Re: [PATCH v3 4/6] mm/slub: distinguish and print stack traces in debugfs files In-Reply-To: <20220404164112.18372-5-vbabka@suse.cz> Message-ID: References: <20220404164112.18372-1-vbabka@suse.cz> <20220404164112.18372-5-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Stat-Signature: g9scnp7yz1wcy6gu5o6hrgxq4p38nspq Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=qdb9FXkc; spf=pass (imf16.hostedemail.com: domain of rientjes@google.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: EC655180026 X-HE-Tag: 1649194818-633743 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 4 Apr 2022, Vlastimil Babka wrote: > From: Oliver Glitta > > Aggregate objects in slub cache by unique stack trace in addition to > caller address when producing contents of debugfs files alloc_traces and > free_traces in debugfs. Also add the stack traces to the debugfs output. > This makes it much more useful to e.g. debug memory leaks. > > Signed-off-by: Oliver Glitta > Signed-off-by: Vlastimil Babka > Reviewed-and-tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > --- > mm/slub.c | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 98c1450c23f0..f2e550e1adf0 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -5064,6 +5064,7 @@ EXPORT_SYMBOL(validate_slab_cache); > */ > > struct location { > + depot_stack_handle_t handle; > unsigned long count; > unsigned long addr; > long long sum_time; > @@ -5116,9 +5117,13 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > { > long start, end, pos; > struct location *l; > - unsigned long caddr; > + unsigned long caddr, chandle; > unsigned long age = jiffies - track->when; > + depot_stack_handle_t handle = 0; > > +#ifdef CONFIG_STACKDEPOT > + handle = READ_ONCE(track->handle); > +#endif > start = -1; > end = t->count; > > @@ -5133,7 +5138,8 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > break; > > caddr = t->loc[pos].addr; > - if (track->addr == caddr) { > + chandle = t->loc[pos].handle; > + if ((track->addr == caddr) && (handle == chandle)) { > > l = &t->loc[pos]; > l->count++; > @@ -5158,6 +5164,8 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > > if (track->addr < caddr) > end = pos; > + else if (track->addr == caddr && handle < chandle) > + end = pos; > else > start = pos; > } Does this need to properly handle the case where handle == NULL? > @@ -5180,6 +5188,7 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > l->max_time = age; > l->min_pid = track->pid; > l->max_pid = track->pid; > + l->handle = handle; > cpumask_clear(to_cpumask(l->cpus)); > cpumask_set_cpu(track->cpu, to_cpumask(l->cpus)); > nodes_clear(l->nodes); > @@ -6089,6 +6098,21 @@ static int slab_debugfs_show(struct seq_file *seq, void *v) > seq_printf(seq, " nodes=%*pbl", > nodemask_pr_args(&l->nodes)); > > +#ifdef CONFIG_STACKDEPOT > + { > + depot_stack_handle_t handle; > + unsigned long *entries; > + unsigned int nr_entries, j; > + > + handle = READ_ONCE(l->handle); > + if (handle) { > + nr_entries = stack_depot_fetch(handle, &entries); > + seq_puts(seq, "\n"); > + for (j = 0; j < nr_entries; j++) > + seq_printf(seq, " %pS\n", (void *)entries[j]); > + } > + } > +#endif > seq_puts(seq, "\n"); > } > > -- > 2.35.1 > >