From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50708C25B74 for ; Thu, 16 May 2024 18:05:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B94EF6B0082; Thu, 16 May 2024 14:05:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B44D36B0085; Thu, 16 May 2024 14:05:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E5756B0089; Thu, 16 May 2024 14:05:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 801A66B0082 for ; Thu, 16 May 2024 14:05:55 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D663340E80 for ; Thu, 16 May 2024 18:05:54 +0000 (UTC) X-FDA: 82125037428.19.74D3BE8 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf12.hostedemail.com (Postfix) with ESMTP id C1C0440021 for ; Thu, 16 May 2024 18:05:52 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="Rk3zzz6/"; spf=pass (imf12.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.43 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715882752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4kOPvncac5GEXKOWcgYcErTg+ZSoHGXXhbSEbOdfWFY=; b=sEEfBhlSE27Pe5RX/xiB+jKk7rW65TAgYVRoW+S6NcLINGNlPethYpl5E+rssEmCof2a2i Lnq04z1Ft3gZ0XS4P4wIltbWFMJ7lMsFaTW6wkrJOy6b6kKC5TOAGroisM2zYOYYxyz3Kh EKfGtN9Ux2uI8+P4WTgQ9vSAD4zit1w= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b="Rk3zzz6/"; spf=pass (imf12.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.43 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715882752; a=rsa-sha256; cv=none; b=IFypNqw94V2bobikW4UlJXpK7nZFXl487amX6iSFcZJJFbncmFXKEc4ORun8m4p52+h4T2 ITukqT9GXa/1fd4VvGweZRj4Jn5X4kgRG8mOPqg/hM0rohtmpaCZMm28/uUxNDcoTuC3Nb JHH8IEA9GwaiR1j7bkM221HFF3N8pP8= Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-7dec804bd19so3467439f.1 for ; Thu, 16 May 2024 11:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1715882752; x=1716487552; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4kOPvncac5GEXKOWcgYcErTg+ZSoHGXXhbSEbOdfWFY=; b=Rk3zzz6/BbCP2/5bR6zYIL4+H7VDdIfEwVV5OcXm6SbY8mL2Wjd/06SWbBOuSxe+dJ w2BoNhdPNdOEn0DZ/iwgtzT1U0OzhXYg1CV8jP8TXJNPtCpLmLyxlJ4qZTQQQQ+KmxTQ /CS86nivhSaVm5zpBnYmxF4eLPivHK1G8XXMc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715882752; x=1716487552; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4kOPvncac5GEXKOWcgYcErTg+ZSoHGXXhbSEbOdfWFY=; b=cPNhu4CnHeiuc2vDeUVkE11anzCmbIXpGmwqKfNl3OXyuVzCVc+GUGFzg/3GoVUyNg 5+qNHCaidJnOSe+VpgZopePRC5p8cjxhaEoZKFZWvu1qJHyK1CYIR4fBwef9cuHQ0ygh lgoTCmKZoQD6qQuGiV/3oc/Kh7fEQe58rZ6nOGz+jM8D+t3B7fpvMdprcWtPeznWmtDU ccOrC7qKrzmsm+dWq2W2ZeQbZFlq3HyKoO5biyfiKKsXakVMeljR9cn0ofWct4gURvhd ClHzctVazTjH2sy6R7YOyBFnMBtNo1TadbMqDoXyhpg4hX6b5azEPLOGFp7RY6Y2Wsh2 NFHQ== X-Forwarded-Encrypted: i=1; AJvYcCW6g+N5p7TRjDzX+mLd3HlaY4QxEWBP8poe9cdXhbC5uTgU2T8MN8p6gINpWsNwnuLwrBoC8lGLZVx5lySCo8jW/Nc= X-Gm-Message-State: AOJu0YyNn9ADZXzhSNwJiESp/h5KJwOhtyfmSbGtddz/Khe+5G2klNe4 ya5OgUtV+Y2pr0s947F4DkIdT8zelMBxB/ZTUe8WR6KbK2l5nWoggjEYaIm27qA= X-Google-Smtp-Source: AGHT+IG9thpIuxuOJl/ateMI7c9MGpJjRHArmdLOc92/CkQSwD6jAwuSSMxSGmhDOz36YwjGKp1fTQ== X-Received: by 2002:a6b:d203:0:b0:7de:e04b:42c3 with SMTP id ca18e2360f4ac-7e1b5022577mr2055903739f.0.1715882751618; Thu, 16 May 2024 11:05:51 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-7e2031b57bcsm134683339f.8.2024.05.16.11.05.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 May 2024 11:05:51 -0700 (PDT) Message-ID: Date: Thu, 16 May 2024 12:05:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE To: Tejun Heo Cc: Edward Liaw , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Zefan Li , Johannes Weiner , Muchun Song , Michal Hocko , Roman Gushchin , Shakeel Butt , Yosry Ahmed , Nhat Pham , Chengming Zhou , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Shuah Khan References: <20240510000842.410729-1-edliaw@google.com> <20240510000842.410729-9-edliaw@google.com> <9e72d97a-9a04-4423-a711-0c21c1c8b161@linuxfoundation.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C1C0440021 X-Stat-Signature: z1m6wydo5bjjpyrrkw6djds9b34znobi X-Rspam-User: X-HE-Tag: 1715882752-322611 X-HE-Meta: U2FsdGVkX18xbvptdquru0F5+xOxQXzLh5w9N/Xvzvwf46Fr93Y6WKBxH/3t2uxDTOjDI3hRNIpFh2+HJr7K/IdUe7bpWnBUs0YHK7AtMCHw7XTSy0ZaHM5GLrNmSnR45PhDiFNj1R6WKAM7l6IHFuFuNF6l3AhsurFpBKJoWYZdpOfF6V88pR/2ZU5Eb/f4VG2uUh2KvxH+7Ydu3w3Bho6vn4safTcUPtr4jWs6PNyTZeBdb0OgMnPgs4/4ZfMx0TqsYCXCxniYVZNvG3QGYiTHtaEuX+AHlAqWmqAhb5FRHZWm07arHsLn1X0vHqGJCiR8F3MkSPZuJM2SPlITIiH+V6RQh9WuMe/pwQBO/GZ3zEXw4+E3aGAXTUc8z5VRKwvj3q4R9N350mL71R4xKsZmtVKNEOoHnoa5v66oQwX+AoD5vMOhay91/tZXWH2YF/9UZVQ22KVFuQoi1CC7J8crcHVN25LSwgS82pLoJcYe9YvPZCq9JGwB093bQbIx3NIfc+Sx0lQdpWAl/vAvjBub07wkmUYIltqe1Y54DqWM3a6uxbwk+P1rrzBXZkTvB878MMgZqxTdSXK+VWgQIwWpLX9alXW1iFIeXZk9Jd+TE9R/Pq+xAPjFjxGptx/HAklm3ICNwi/671W2ZNaHAp3KiAZZP/4nNkduDLS5mS/XY/G2e3CvBSb5YgrWyxbFarZMfNmNP3s9n2MBrzfhZ+Uxk0+qr5JzQUC8o6MTN9Giz1OWOpQUdwJJ4zkeRib8Q2755ZqaDi/E1Qv8Z+t++JPTuvZyYjngl7J4tHij82VL+rW9rF4Ly7WYhrN0KVUo06xTQlZA8G7QBI1yGLJvcgu+u6vLe2UQoY+3Z1O/wsGcOAd/sLWpI3cMU14MXQw7StKjTA1GyYk85sIMkwiRqsSMsa4naCEQYwewVp6/Jt2b/TwKnwwr/9tMEKmJsyacUOkGvaw/PcpEfhhLIXP 9RGMQ9zM oGCq5xyURNDGWKV9bWYl0I8YULY85AvzUkVMYTPyElCoqM7eOyNuZ0Wz5nEkGxbdsC7Qogq6ZgABh0eNN7FvXqdqDElqWB9c+ErzAw0MdFon2cF9fux1JFkIfDufadaXvz2Sl8lC2KpiqBn0zBxZVAR+Keznydqc6bMCTAQkSk9vsk8mVlmbsWQjBNrziE0e/haplywoCXLO5s91lBHRg0Ihex+Yjeu9+nAqXWPYUkmtzum1J2tVaZTfnj2sDhSQT7fUjhIKYkVOLBpFHBk4KtOo4XLZEWOBBCPn4ofQl3EyvKk/m6ykNO1thIBj3MXPIHJ7HE+aiZNsPUQI3oq2EuUCSuYJ+6Fd9RhriSdkTQ6fo1vSBWK1Lf4R8Gy1vjjGpSdlQqJjPFJ0XvuGR8hstvJaTDrj8m/LsWyMc0u0pC9Y8F1TgRQGLXClOZjpJn2lizyqHfbDveXZhj3aaF2Sc66b6LxdPFc1JHQrMmNLCjWwvGfJpMzauIIVCn1qtDmL3PwE5jGpEbKaUYgJj9g2nk71jCxNC3AhXDKvu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/16/24 11:45, Tejun Heo wrote: > Hello, > > On Thu, May 16, 2024 at 10:31:13AM -0600, Shuah Khan wrote: >> I am exploring options and leaning towards reverting the patch >> >> daef47b89efd ("selftests: Compile kselftest headers with -D_GNU_SOURCE") >> >> Your amending the PR helps me if I have to send revert. I am sorry >> for the trouble. >> >> I can all of them together in a second update or after the merge window >> closes. > > The cgroup commit is already pulled in unfortunately. Can you please handle > the revert and whatever's necessary to fix up the situation? I'll ask you > what to do with selftest patches from now on. > Thanks for the update. Yes I am working on fixing the situation and will send revert for cgroup test patch as well if necessary. No worries. It is not a problem for you to handle cgroup test patches in general. I will need your review anyway and letting you handle them reduces the overhead. This kind of framework change causes needs to be coordinated. I should have held back on the framework change on my part. thanks, -- Shuah