From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB38CE79CF for ; Wed, 20 Sep 2023 13:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB2986B016B; Wed, 20 Sep 2023 09:11:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A62A76B016C; Wed, 20 Sep 2023 09:11:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 951726B016D; Wed, 20 Sep 2023 09:11:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 870FA6B016B for ; Wed, 20 Sep 2023 09:11:32 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1CB6A803DA for ; Wed, 20 Sep 2023 13:11:32 +0000 (UTC) X-FDA: 81257012424.23.7AF89BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id ECFE9A002A for ; Wed, 20 Sep 2023 13:11:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UbhpxBHT; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695215488; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oYm/Hehcaf9clr/3Nqxb6FNHPYKywPyNIBP16nLDItw=; b=TW7dfv5pqxmgzOYWyDBF5GSyxRm/YlnlIKz8AXqESngJz8cCtzZVJg3LtqLAbgS5kstFxa kVO8DSv/ZuIUKx2Qj9hZzTqjD6lQxLHqS+2KG75tIJBHFQSRXapJwoEwXAnbDVldnjBMXs Mbv9vufL1qFmi3pk2gzvTyF3DR4YUUs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UbhpxBHT; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695215488; a=rsa-sha256; cv=none; b=I7yWz6ryiYIXjebLj+oOASQMRvZr05l24CkGmY/tSZn3JDqIE9w9ekIvBeySxA921ix82g kNXba/PpFR4E8hOnfYsPJMZfiwS5BxAsnKkaTKlLpH/9s8hTdlgXL1VUBj9pQwO3pqUqiX V1MYsT+ihC/kQZs03hMfK87bLss63BQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695215487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oYm/Hehcaf9clr/3Nqxb6FNHPYKywPyNIBP16nLDItw=; b=UbhpxBHTw2QV7fCR3Vwb1giUU8b4nszGZrQ6P44iCqxoVvy/cb8xFDQWxqWf96KVHkDT3K vODDdBTq8Incp/HqXDF9XLKV7I2SRGp2hESREIyzTwhCr5JzD+fuDU2gEOF/HJXyScixSM jdMXRD+PE6/IDMEjuLzIK0+qNWreapE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-Jj2Kw4snM0WQVl_l2wF1Ng-1; Wed, 20 Sep 2023 09:11:25 -0400 X-MC-Unique: Jj2Kw4snM0WQVl_l2wF1Ng-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40478e6abd0so43279685e9.1 for ; Wed, 20 Sep 2023 06:11:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695215485; x=1695820285; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oYm/Hehcaf9clr/3Nqxb6FNHPYKywPyNIBP16nLDItw=; b=v4Gyr+8oknXwlRgf2H0+yHd6/MPPafmATCDccT8qZ5gFhA5nORg4uyRqoGlGgTzoDr qiKF+G4sfNg3JNHgt5w0KiuBUnZQhgSE5J3uCz/1CxeP9/htdOHr8+LSUDx/9cZtU+Pc 4uKUfJ2VXslO7bM/2IFqvP7y0a41+C07GnH/y0hIvyKMFyDGsTfTDKPO1y/rBEwv+fAP WLmaqCOafxDPdXk8XWEjNYngJbB4RWn7LNP7uD5CJQP24DnPnuMwKuu9H41KVq/jT9eI XGQ7WJpKEGukzo1f20qPDZg/BqyzJQ2RmrXXqyjNEYVA1rwaddJmdS5JVlsKjlET29RI nI7w== X-Gm-Message-State: AOJu0YzEjl4UpyWmANxj1uRb/dzM/KO3ad3Wbqu+35dBiCUdvXaHJAXw 6iCyMljVAiVEqnVuw+WQpGfbhnSzgQlz5VeObQroYtAyoC5JRR7nWONbi6s35/8Ou6DxRZVV7Np 2KLXQdOOKGp0= X-Received: by 2002:a5d:4f08:0:b0:31f:fa66:5852 with SMTP id c8-20020a5d4f08000000b0031ffa665852mr2078290wru.21.1695215484731; Wed, 20 Sep 2023 06:11:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsv7A65TZLETNJZ+kTvocUFDInz23b+iTJRlDZvBeoOAeqZKOgQpelJIjt2J7/WlLrTP9wYw== X-Received: by 2002:a5d:4f08:0:b0:31f:fa66:5852 with SMTP id c8-20020a5d4f08000000b0031ffa665852mr2078270wru.21.1695215484279; Wed, 20 Sep 2023 06:11:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:8600:dad5:13bb:38a9:3010? (p200300cbc70b8600dad513bb38a93010.dip0.t-ipconnect.de. [2003:cb:c70b:8600:dad5:13bb:38a9:3010]) by smtp.gmail.com with ESMTPSA id e11-20020a056000120b00b003196b1bb528sm18589753wrx.64.2023.09.20.06.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 06:11:23 -0700 (PDT) Message-ID: Date: Wed, 20 Sep 2023 15:11:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 1/2] mm/ksm: support fork/exec for prctl To: Stefan Roesch , kernel-team@fb.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Carl Klemm References: <20230919205158.1897353-1-shr@devkernel.io> <20230919205158.1897353-2-shr@devkernel.io> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230919205158.1897353-2-shr@devkernel.io> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: ECFE9A002A X-Rspam-User: X-Stat-Signature: q7xsm6jg131u3qijni3ye1wfyuwytw3c X-Rspamd-Server: rspam01 X-HE-Tag: 1695215487-580874 X-HE-Meta: U2FsdGVkX1/Qx1jg6CuFCNZuEc22xDg4ct0FDxSBSwBhX0zQI/TRFCB4VvZf/OGe1m5jODAvc5yS6X2kKwm8Yam8FjuqcgkIrdbeDOJhRxeirCOADUFXGTCB48VhusYGs9IiGNqmuRuBWmmJ2zqxbbNbEQEqXcipByZS8vfLB+FlQwYS92t15SXeMpTUO4iCiUf0vRgldqkqx7uQHHNPB+gynQSMdc0oHjGi9XfIdN/EHKss6VcGYnisLeROvdWXkgvyfs7QJAHm64udmbn8x/ETRSwoPIvP3vStI+Yz3My7GkZ5+HISGaYnG8lrOwQxiqz++iKo3Z0060pXgbgg8OgsrVC/qjDRQjrgjDjPWK50jiMFFNvUrOoHtQFLHXzzjl2coqYs49fJueS7kcXlAD56Q6OWS46Wx77OLMBAJYWHFs0/Gfmq56ypEsy//FG77EWY19eoh4xYppk28M8/FCtgvSH7U1S4Lqn7BoUosF9MCmdNvTp90b7Mhfr+DwU98Sv+FE9Kz51XQDK3gdjPZa/X1tmpZzvJRGXBAjyJCeKxNU+lsQm3hdlr19C7JcvWeGHpmPMIvvVWSRWLRsQTeNrhhyV5050CrWTcCWrkcfpELcuNTg7LG5FuGEX+PU6D4B2NgYC7IbMH0wTHXaRxQ6IXmcJZOCkVFx1G2XQ9tBIferdrxh9tllgrvuDApyawUryK9QTv//2WsKrC7Zms82aA+m46/JER2+O6gDDXb7r24Djofiy1oPTPUrXscw6sbgKDo7mcxOJ8Y/AaAUqswgOtXOYfitMpacIZY2gmkF7yLLVnyjhPucjQzKaBCadI6YTA623OCjFR+l/eCr6VLsAi41nlTqVbEdEJEexAtCWw107BvTlsYfqePpQ9l+C2IpZk2CXBOBPJ5YQ4kHWg8ieg3zCbii4jhpF70Q5hbhVB/vyNGDfY7GnIX1kHTA7GVSRMHymQ7tWQR9r1bEa nFRQpMYu ZfUkhuXPxU/kI0bjyfL7qHDA5F+92aWBnnCNUdhoW2VwueIiiurMNJMFzjClg8GjrQ3zXua9YwwWTg6imAbMW3NF1Z/VHKrES3lJzKP7kbdFjZuMgaoT/+HiTAxx6AoFiniUt80OSIZJ+16Z+S9eq1VqtRx18P4UuVa2wAg13LYK6rwebpyATiE/Sx5UfFJ/CaLQOgWBXXdT9oodSUmVN+MsPAvjnLBZtbqj3G6KnOKUYR6YtPqzyABIMXmni+CrksZiN+/QP3ChwSXQ6DisB4JTee/xniAGMgqe3JRmk4Iw6TmifGtVstgXjy+5XT2ouIRnryzm7CnUTTo+msH1/fGTmizXgF8aYM3rUlwTgwzDonkVra63bSdNfN9fW4Zl4hWd+D7QDIVdw71s3Eukrs8XOuK988r/fhnS1HpmbNP8zJyZqMODlK8LrS/NaCGx8kn//bVhXTwFnFvgR3cpATPna2PbVb44nbc81ZTH2gGqTyivuxPQWFcIaykmx7qrfXye9SoevDGU4WyLjP4IYJIrCttsXWn8kbsUX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.09.23 22:51, Stefan Roesch wrote: > A process can enable KSM with the prctl system call. When the process is > forked the KSM flag is inherited by the child process. However if the > process is executing an exec system call directly after the fork, the > KSM setting is cleared. This patch addresses this problem. > > Signed-off-by: Stefan Roesch > Reported-by: Carl Klemm > --- > include/linux/sched/coredump.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h > index 0ee96ea7a0e9..205aa9917394 100644 > --- a/include/linux/sched/coredump.h > +++ b/include/linux/sched/coredump.h > @@ -87,8 +87,11 @@ static inline int get_dumpable(struct mm_struct *mm) > > #define MMF_DISABLE_THP_MASK (1 << MMF_DISABLE_THP) > > +#define MMF_VM_MERGE_ANY 29 > +#define MMF_VM_MERGE_ANY_MASK (1 << MMF_VM_MERGE_ANY) > + > #define MMF_INIT_MASK (MMF_DUMPABLE_MASK | MMF_DUMP_FILTER_MASK |\ > - MMF_DISABLE_THP_MASK | MMF_HAS_MDWE_MASK) > + MMF_DISABLE_THP_MASK | MMF_HAS_MDWE_MASK |\ > + MMF_VM_MERGE_ANY_MASK) > > -#define MMF_VM_MERGE_ANY 29 > #endif /* _LINUX_SCHED_COREDUMP_H */ Fixes: tag? Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb